mirror of
https://github.com/gui-cs/Terminal.Gui.git
synced 2025-12-26 15:57:56 +01:00
* Initial plan * Fix Wizard v2 architecture issues - ScrollBar API, event handlers, key bindings Co-authored-by: tig <585482+tig@users.noreply.github.com> * Implement issue #4155 - Put nav buttons in bottom Padding, Help in right Padding Co-authored-by: tig <585482+tig@users.noreply.github.com> * Address code review feedback - Extract helper method, improve null checks Co-authored-by: tig <585482+tig@users.noreply.github.com> * Fix disposal issue - Ensure _helpTextView is always disposed Co-authored-by: tig <585482+tig@users.noreply.github.com> * Refactor & improvements. WIP * Tweaking layout * Wizard tweaks * Added View.GetSubViews that optinoally gets subviews of adornments * Refactor Wizard API: modern events, layout, and design - Replaced custom event args with standard .NET event args (CancelEventArgs, ValueChangingEventArgs, etc.) - Removed Finished event; use Accepting for wizard completion - Updated Cancelled, MovingBack, MovingNext to use CancelEventArgs - Refactored UICatalog scenarios and tests to new event model - Improved WizardStep sizing and wizard auto-resizing to content - Enhanced IDesignable for Wizard and WizardStep with richer design-time UI - Simplified help text padding logic in WizardStep - Removed obsolete code and modernized code style throughout - Improves API consistency, usability, and .NET idiomatic usage * Fixes #4515 - Navigating into and out of Adornments does not work * WIP. QUite broken. * All fixed? * Tweaks. * Exclude Margin subviews from drawing; add shadow tests Update Margin adornment to skip drawing subviews that are themselves Margin views, preventing unsupported nested Margin rendering. Add unit tests to verify that opaque-shadowed buttons in Margin are not drawn, while Border and Padding still support shadow rendering. Update test class to use output helper and assert driver output. * Final code cleanup and test improvements. * Update Margin.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update View.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update View.Hierarchy.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update View.Hierarchy.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Refactor: code style, formatting, and minor logic cleanup - Standardized spacing and formatting for method signatures and object initializations. - Converted simple methods and properties to expression-bodied members for conciseness. - Replaced named arguments with positional arguments for consistency. - Improved XML documentation formatting for readability. - Simplified logic in event handlers (e.g., Wizard Back button). - Removed redundant checks where properties are guaranteed to exist. - Fixed minor bugs related to padding, height calculation, and event handling. - Adopted consistent use of `var` for local variables. - Corrected namespace declarations. - Refactored methods returning constants to use expression-bodied syntax. - General code cleanup for clarity and maintainability; no breaking changes. * api docs --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: tig <585482+tig@users.noreply.github.com> Co-authored-by: Tig <tig@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This commit is contained in:
@@ -22,7 +22,7 @@ public class WizardTests
|
||||
wizard.AddStep (step1);
|
||||
|
||||
var finishedFired = false;
|
||||
wizard.Finished += (s, args) => { finishedFired = true; };
|
||||
wizard.Accepting += (s, args) => { finishedFired = true; };
|
||||
|
||||
var isRunningChangedFired = false;
|
||||
wizard.IsRunningChanged += (s, e) => { isRunningChangedFired = true; };
|
||||
@@ -46,7 +46,7 @@ public class WizardTests
|
||||
wizard.AddStep (step2);
|
||||
|
||||
finishedFired = false;
|
||||
wizard.Finished += (s, args) => { finishedFired = true; };
|
||||
wizard.Accepting += (s, args) => { finishedFired = true; };
|
||||
|
||||
isRunningChangedFired = false;
|
||||
wizard.IsRunningChanged += (s, e) => { isRunningChangedFired = true; };
|
||||
@@ -79,7 +79,7 @@ public class WizardTests
|
||||
step1.Enabled = false;
|
||||
|
||||
finishedFired = false;
|
||||
wizard.Finished += (s, args) => { finishedFired = true; };
|
||||
wizard.Accepting += (s, args) => { finishedFired = true; };
|
||||
|
||||
isRunningChangedFired = false;
|
||||
wizard.IsRunningChanged += (s, e) => { isRunningChangedFired = true; };
|
||||
@@ -437,7 +437,7 @@ public class WizardTests
|
||||
// this test is needed because Wizard overrides Dialog's title behavior ("Title - StepTitle")
|
||||
public void Setting_Title_Works ()
|
||||
{
|
||||
var d = Application.Driver;
|
||||
IDriver d = Application.Driver;
|
||||
|
||||
var title = "1234";
|
||||
var stepTitle = " - ABCD";
|
||||
|
||||
Reference in New Issue
Block a user