From 43142dedc37ec46cd2ffe0da22309eac75be3275 Mon Sep 17 00:00:00 2001
From: Daniel Marbach <daniel.marbach@openplace.net>
Date: Fri, 27 Jun 2025 18:11:59 +0200
Subject: [PATCH] Cleanup Dependencies slighty (#4178)

* Source link should be private

* Remove unnecessary System.Text.Json reference

* Use logging abstractions

* Use fixed logging version

* Remove unnecessary analysis references

---------

Co-authored-by: Daniel Marbach <danielmarbach@users.noreply.github.com>
---
 Directory.Packages.props                            |  4 ++--
 Examples/UICatalog/Scenarios/Scrolling.cs           |  5 +----
 Terminal.Gui/Terminal.Gui.csproj                    | 13 ++++++-------
 .../TerminalGuiFluentTesting.csproj                 |  4 ++++
 4 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/Directory.Packages.props b/Directory.Packages.props
index 974bb98f4..70480f111 100644
--- a/Directory.Packages.props
+++ b/Directory.Packages.props
@@ -11,9 +11,9 @@
     <PackageVersion Include="Microsoft.CodeAnalysis" Version="[4.11,4.12)" />
     <PackageVersion Include="Microsoft.CodeAnalysis.Common" Version="[4.11,4.12)" />
     <PackageVersion Include="Microsoft.CodeAnalysis.CSharp" Version="4.11.0" />
-    <PackageVersion Include="Microsoft.Extensions.Logging" Version="[9.0.2,10)" />
+    <PackageVersion Include="Microsoft.Extensions.Logging.Abstractions" Version="[9.0.2,10)" />
+    <PackageVersion Include="Microsoft.Extensions.Logging" Version="9.0.6" />
     <PackageVersion Include="System.IO.Abstractions" Version="[22.0.11,23)" />
-    <PackageVersion Include="System.Text.Json" Version="[8.0.5,9)" />
     <PackageVersion Include="Wcwidth" Version="[2,3)" />
     <PackageVersion Include="Microsoft.VisualStudio.Azure.Containers.Tools.Targets" Version="[1.21.2,2)" />
     <PackageVersion Include="Serilog" Version="4.2.0" />
diff --git a/Examples/UICatalog/Scenarios/Scrolling.cs b/Examples/UICatalog/Scenarios/Scrolling.cs
index 14fa5b193..6b14d755b 100644
--- a/Examples/UICatalog/Scenarios/Scrolling.cs
+++ b/Examples/UICatalog/Scenarios/Scrolling.cs
@@ -1,7 +1,4 @@
-using System;
-using Microsoft.CodeAnalysis.CSharp.Syntax;
-
-namespace UICatalog.Scenarios;
+namespace UICatalog.Scenarios;
 
 [ScenarioMetadata ("Scrolling", "Content scrolling, IScrollBars, etc...")]
 [ScenarioCategory ("Controls")]
diff --git a/Terminal.Gui/Terminal.Gui.csproj b/Terminal.Gui/Terminal.Gui.csproj
index 0646dce05..300e5a972 100644
--- a/Terminal.Gui/Terminal.Gui.csproj
+++ b/Terminal.Gui/Terminal.Gui.csproj
@@ -57,15 +57,14 @@
     <ItemGroup>
         <PackageReference Include="ColorHelper" />
         <PackageReference Include="JetBrains.Annotations" />
-        <PackageReference Include="Microsoft.CodeAnalysis" />
-        <PackageReference Include="Microsoft.CodeAnalysis.Common" />
-        <PackageReference Include="Microsoft.CodeAnalysis.CSharp" />
-        <PackageReference Include="Microsoft.Extensions.Logging" />
+        <PackageReference Include="Microsoft.Extensions.Logging.Abstractions " />
         <PackageReference Include="System.IO.Abstractions" />
-        <PackageReference Include="System.Text.Json" />
         <PackageReference Include="Wcwidth" />
-        <!-- Enable Nuget Source Link for github -->
-        <PackageReference Include="Microsoft.SourceLink.GitHub" />
+    </ItemGroup>
+
+    <ItemGroup>
+      <!-- Enable Nuget Source Link for github -->
+      <PackageReference Include="Microsoft.SourceLink.GitHub" PrivateAssets="All" />
     </ItemGroup>
     <!-- =================================================================== -->
     <!-- Global Usings and Type Aliases -->
diff --git a/Tests/TerminalGuiFluentTesting/TerminalGuiFluentTesting.csproj b/Tests/TerminalGuiFluentTesting/TerminalGuiFluentTesting.csproj
index bf250a284..8b0676524 100644
--- a/Tests/TerminalGuiFluentTesting/TerminalGuiFluentTesting.csproj
+++ b/Tests/TerminalGuiFluentTesting/TerminalGuiFluentTesting.csproj
@@ -11,4 +11,8 @@
 		<ProjectReference Include="..\..\Terminal.Gui\Terminal.Gui.csproj" />
 	</ItemGroup>
 
+	<ItemGroup>
+		<PackageReference Include="Microsoft.Extensions.Logging" />
+	</ItemGroup>
+
 </Project>
\ No newline at end of file