From 5f448a6f9a13f400bce45dd27fd24b9eb02aaa77 Mon Sep 17 00:00:00 2001
From: Tig <tig@users.noreply.github.com>
Date: Thu, 20 Jun 2024 16:04:06 -0700
Subject: [PATCH] Fixed warnings

---
 Terminal.Gui/View/ViewKeyboard.cs |  3 +++
 Terminal.Gui/Views/Line.cs        |  5 -----
 Terminal.Gui/Views/Shortcut.cs    |  2 +-
 Terminal.Gui/Views/Slider.cs      |  2 +-
 UICatalog/Scenario.cs             | 10 +++++-----
 5 files changed, 10 insertions(+), 12 deletions(-)

diff --git a/Terminal.Gui/View/ViewKeyboard.cs b/Terminal.Gui/View/ViewKeyboard.cs
index d1f04c654..080f5380d 100644
--- a/Terminal.Gui/View/ViewKeyboard.cs
+++ b/Terminal.Gui/View/ViewKeyboard.cs
@@ -633,6 +633,7 @@ public partial class View
     ///     <para>See <see href="../docs/keyboard.md">for an overview of Terminal.Gui keyboard APIs.</see></para>
     /// </remarks>
     /// <param name="keyEvent">Contains the details about the key that produced the event.</param>
+    /// <param name="scope">The scope.</param>
     /// <returns>
     ///     <see langword="false"/> if the key press was not handled. <see langword="true"/> if the keypress was handled
     ///     and no other view should see it.
@@ -745,6 +746,7 @@ public partial class View
     /// Returns true if Key is bound in this view heirarchy. For debugging
     /// </summary>
     /// <param name="key"></param>
+    /// <param name="boundView"></param>
     /// <returns></returns>
     public bool IsHotKeyKeyBound (Key key, out View boundView)
     {
@@ -779,6 +781,7 @@ public partial class View
     ///     <para>See <see href="../docs/keyboard.md">for an overview of Terminal.Gui keyboard APIs.</see></para>
     /// </summary>
     /// <param name="key">The key event passed.</param>
+    /// <param name="scope">The scope.</param>
     /// <returns>
     ///     <see langword="null"/> if no command was bound the <paramref name="key"/>. <see langword="true"/> if
     ///     commands were invoked and at least one handled the command. <see langword="false"/> if commands were invoked and at
diff --git a/Terminal.Gui/Views/Line.cs b/Terminal.Gui/Views/Line.cs
index 95a8287c8..6a25fa55b 100644
--- a/Terminal.Gui/Views/Line.cs
+++ b/Terminal.Gui/Views/Line.cs
@@ -11,8 +11,6 @@ public class Line : View
         SuperViewRendersLineCanvas = true;
     }
 
-    public Dim Length { get; set; } = Dim.Fill ();
-
     private Orientation _orientation;
 
     /// <summary>
@@ -30,12 +28,9 @@ public class Line : View
             {
                 case Orientation.Horizontal:
                     Height = 1;
-                    // Width = Length;
-                    //Border.Thickness = new Thickness (1, 0, 1, 0);
 
                     break;
                 case Orientation.Vertical:
-                    Height = Length;
                     Width = 1;
 
                     break;
diff --git a/Terminal.Gui/Views/Shortcut.cs b/Terminal.Gui/Views/Shortcut.cs
index 7290537a0..08c7e0a00 100644
--- a/Terminal.Gui/Views/Shortcut.cs
+++ b/Terminal.Gui/Views/Shortcut.cs
@@ -631,7 +631,7 @@ public class Shortcut : View
     ///     - if the user presses the HotKey specified by CommandView
     ///     - if HasFocus and the user presses Space or Enter (or any other key bound to Command.Accept).
     /// </summary>
-    protected new bool? OnAccept (CommandContext ctx)
+    protected bool? OnAccept (CommandContext ctx)
     {
         var cancel = false;
 
diff --git a/Terminal.Gui/Views/Slider.cs b/Terminal.Gui/Views/Slider.cs
index 6dca6f8c4..1b96bda0d 100644
--- a/Terminal.Gui/Views/Slider.cs
+++ b/Terminal.Gui/Views/Slider.cs
@@ -1743,7 +1743,7 @@ public class Slider<T> : View
         return true;
     }
 
-    internal bool Accept ()
+    internal new bool Accept ()
     {
         SetFocusedOption ();
 
diff --git a/UICatalog/Scenario.cs b/UICatalog/Scenario.cs
index df8e510d9..c5a724ba7 100644
--- a/UICatalog/Scenario.cs
+++ b/UICatalog/Scenario.cs
@@ -271,7 +271,7 @@ public class Scenario : IDisposable
 
     /// <summary>Defines the category names used to categorize a <see cref="Scenario"/></summary>
     [AttributeUsage (AttributeTargets.Class, AllowMultiple = true)]
-    public class ScenarioCategory (string Name) : System.Attribute
+    public class ScenarioCategory (string name) : System.Attribute
     {
         /// <summary>Static helper function to get the <see cref="Scenario"/> Categories given a Type</summary>
         /// <param name="t"></param>
@@ -291,15 +291,15 @@ public class Scenario : IDisposable
         public static string GetName (Type t) { return ((ScenarioCategory)GetCustomAttributes (t) [0]).Name; }
 
         /// <summary>Category Name</summary>
-        public string Name { get; set; } = Name;
+        public string Name { get; set; } = name;
     }
 
     /// <summary>Defines the metadata (Name and Description) for a <see cref="Scenario"/></summary>
     [AttributeUsage (AttributeTargets.Class)]
-    public class ScenarioMetadata (string Name, string Description) : System.Attribute
+    public class ScenarioMetadata (string name, string description) : System.Attribute
     {
         /// <summary><see cref="Scenario"/> Description</summary>
-        public string Description { get; set; } = Description;
+        public string Description { get; set; } = description;
 
         /// <summary>Static helper function to get the <see cref="Scenario"/> Description given a Type</summary>
         /// <param name="t"></param>
@@ -312,6 +312,6 @@ public class Scenario : IDisposable
         public static string GetName (Type t) { return ((ScenarioMetadata)GetCustomAttributes (t) [0]).Name; }
 
         /// <summary><see cref="Scenario"/> Name</summary>
-        public string Name { get; set; } = Name;
+        public string Name { get; set; } = name;
     }
 }