mirror of
https://github.com/gui-cs/Terminal.Gui.git
synced 2025-12-30 01:38:01 +01:00
Address code review comments
- Changed Task.Wait() to task.GetAwaiter().GetResult() to avoid deadlocks - Added named constant for killEntireProcessTree parameter - Added clarifying comment for FakeInput creation - Added comment explaining relative path construction for Examples directory Co-authored-by: tig <585482+tig@users.noreply.github.com>
This commit is contained in:
@@ -71,7 +71,7 @@ public static class ExampleRunner
|
||||
// If entry point returns Task, wait for it
|
||||
if (result is Task task)
|
||||
{
|
||||
task.Wait ();
|
||||
task.GetAwaiter ().GetResult ();
|
||||
}
|
||||
|
||||
return new ()
|
||||
@@ -126,7 +126,8 @@ public static class ExampleRunner
|
||||
{
|
||||
try
|
||||
{
|
||||
process.Kill (true);
|
||||
const bool killEntireProcessTree = true;
|
||||
process.Kill (killEntireProcessTree);
|
||||
}
|
||||
catch
|
||||
{
|
||||
|
||||
Reference in New Issue
Block a user