Cleans up/Refactors View.Subviews (#3962)

* Subview clean up

* New Add/Remove event pattern

* Using Logging

* cleanup

* Subview -> SubView

* Test code cleanup. Killed many warnings.

* Fix tznind feedback

* Refactored AllViewTest helpers

* Moved keyboard tests to parallel

* Moved mouse tests to parallel

* Moved view tests to parallel

* Test code cleanup. Killed many warnings.

* dupe test

* Some mouse tests can't run in parallel because MouseGrabView

* Made SpinnerView more testable

* Moved more tests

* SubViews to IReadOnlyCollection<View>

* SubViews to IReadOnlyCollection<View> 2

* scrollbar tests

* shortcut tests

* Use InternalSubViews vs. _subviews

* Nuked View.IsAdded.
Added View.SuperViewChanged.

* API doc updats

* Unit Test tweak

* Unit Test tweak
This commit is contained in:
Tig
2025-03-08 15:42:17 -07:00
committed by GitHub
parent 85cf6619ed
commit acb5979e6c
226 changed files with 7235 additions and 7188 deletions

View File

@@ -1,15 +1,11 @@
using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
#nullable enable
namespace UnitTests.ConsoleDrivers;
public class AnsiKeyboardParserTests
{
private readonly AnsiKeyboardParser _parser = new ();
public static IEnumerable<object []> GetKeyboardTestData ()
public static IEnumerable<object? []> GetKeyboardTestData ()
{
// Test data for various ANSI escape sequences and their expected Key values
yield return new object [] { "\u001b[A", Key.CursorUp };
@@ -50,19 +46,18 @@ public class AnsiKeyboardParserTests
yield return new object [] { "\u001b[1;7D", Key.CursorLeft.WithCtrl.WithAlt };
yield return new object [] { "\u001b[1;8D", Key.CursorLeft.WithCtrl.WithAlt.WithShift };
// Invalid inputs
yield return new object [] { "\u001b[Z", null };
yield return new object [] { "\u001b[invalid", null };
yield return new object [] { "\u001b[1", null };
yield return new object [] { "\u001b[AB", null };
yield return new object [] { "\u001b[;A", null };
yield return new object [] { "\u001b[Z", null! };
yield return new object [] { "\u001b[invalid", null! };
yield return new object [] { "\u001b[1", null! };
yield return new object [] { "\u001b[AB", null! };
yield return new object [] { "\u001b[;A", null! };
}
// Consolidated test for all keyboard events (e.g., arrow keys)
[Theory]
[MemberData (nameof (GetKeyboardTestData))]
public void ProcessKeyboardInput_ReturnsCorrectKey (string input, Key? expectedKey)
public void ProcessKeyboardInput_ReturnsCorrectKey (string? input, Key? expectedKey)
{
// Act
Key? result = _parser.IsKeyboard (input)?.GetKey (input);