mirror of
https://github.com/gui-cs/Terminal.Gui.git
synced 2025-12-26 07:47:54 +01:00
Fixes #4332 - Refactor test infrastructure to use modern ApplicationImpl.Coordinator instead of legacy MainLoop (#4335)
* Initial plan * Refactor tests to use modern ApplicationImpl.Coordinator architecture instead of legacy Application.RunIteration Co-authored-by: tig <585482+tig@users.noreply.github.com> * Changes before error encountered Co-authored-by: tig <585482+tig@users.noreply.github.com> * Replace Application.RunIteration implementation to use modern ApplicationImpl.Coordinator architecture Co-authored-by: tig <585482+tig@users.noreply.github.com> * Simplify Application.RunIteration to directly delegate to ApplicationImpl.Coordinator without legacy infrastructure Co-authored-by: tig <585482+tig@users.noreply.github.com> * Update multitasking.md documentation to use Application.AddTimeout/RemoveTimeout instead of deprecated Application.MainLoop methods Co-authored-by: tig <585482+tig@users.noreply.github.com> * Refactor contribution guidelines and documentation - Consolidated all contribution-related instructions into `CONTRIBUTING.md` as the single source of truth. - Updated `copilot-instructions.md` and `AGENTS.md` to reference `CONTRIBUTING.md`. - Enhanced build, test, and CI/CD workflow documentation. - Updated repository structure documentation in `README.md` and `CONTRIBUTING.md`. - Reinforced coding conventions and streamlined testing requirements. - Documented GitHub Actions workflows and provided local CI replication steps. - Refined API documentation requirements and PR guidelines. - Simplified `.sln` file and removed redundant content. - Updated links to point to the latest documentation resources. * Revamp bug report template for clarity and detail Updated the bug report template to improve structure, readability, and comprehensiveness: - Specified "Terminal.Gui" in the `about` section. - Replaced bold headings with Markdown heading syntax. - Enhanced "To Reproduce" with placeholders for code and behavior details. - Added an "Environment" section to collect OS, terminal, PowerShell, .NET, and `Terminal.Gui` version details. - Expanded "Screenshots" to include GIFs and terminal output instructions. - Removed outdated "Desktop" and "Smartphone" sections, consolidating relevant details. - Improved "Additional Context" with prompts for consistency, prior behavior, and error messages. - Streamlined "For Maintainers" instructions for setting project and milestone. These changes aim to make bug reports more actionable and easier to reproduce. * Remove [Obsolete] attribute and pragma warnings from Application.RunIteration - method now uses modern architecture internally Co-authored-by: tig <585482+tig@users.noreply.github.com> * Refactor Application.Run.cs for clarity and cleanup Removed debug assertions and unused/commented-out code to simplify logic and improve maintainability. Renamed `forceDraw` to `forceRedraw` in `LayoutAndDraw` for better clarity. Removed the internal `OnNotifyStopRunState` method and its associated logic, indicating a refactor of the stop notification mechanism. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Tig <tig@users.noreply.github.com> Co-authored-by: tig <585482+tig@users.noreply.github.com>
This commit is contained in:
Copilot
GitHub
147
.github/ISSUE_TEMPLATE/bug_report.md
vendored
147
.github/ISSUE_TEMPLATE/bug_report.md
vendored
@@ -1,41 +1,140 @@
|
||||
---
|
||||
name: Bug report
|
||||
about: Create a report to help us improve
|
||||
about: Create a report to help us improve Terminal.Gui
|
||||
title: ''
|
||||
labels: bug
|
||||
assignees: ''
|
||||
|
||||
---
|
||||
|
||||
**Describe the bug**
|
||||
## Describe the bug
|
||||
|
||||
A clear and concise description of what the bug is.
|
||||
|
||||
**To Reproduce**
|
||||
## To Reproduce
|
||||
|
||||
Steps to reproduce the behavior:
|
||||
1. Go to '...'
|
||||
2. Click on '....'
|
||||
3. Scroll down to '....'
|
||||
4. See error
|
||||
|
||||
**Expected behavior**
|
||||
A clear and concise description of what you expected to happen.
|
||||
1. Run the following code:
|
||||
```csharp
|
||||
// Paste your minimal reproduction code here
|
||||
```
|
||||
|
||||
**Screenshots**
|
||||
If applicable, add screenshots to help explain your problem.
|
||||
2. Expected behavior: (describe what should happen)
|
||||
|
||||
**Desktop (please complete the following information):**
|
||||
- OS: [e.g. iOS]
|
||||
- Browser [e.g. chrome, safari]
|
||||
- Version [e.g. 22]
|
||||
3. Actual behavior: (describe what actually happens)
|
||||
|
||||
**Smartphone (please complete the following information):**
|
||||
- Device: [e.g. iPhone6]
|
||||
- OS: [e.g. iOS8.1]
|
||||
- Browser [e.g. stock browser, safari]
|
||||
- Version [e.g. 22]
|
||||
## Environment
|
||||
|
||||
**Additional context**
|
||||
Add any other context about the problem here.
|
||||
Please run the following commands in your terminal and paste the output:
|
||||
|
||||
**Set Project & Milestone**
|
||||
If you have access, please don't forget to set the right Project and Milestone.
|
||||
### OS Information
|
||||
|
||||
**Windows (PowerShell):**
|
||||
```powershell
|
||||
"OS: $(Get-CimInstance Win32_OperatingSystem | Select-Object -ExpandProperty Caption) $(Get-CimInstance Win32_OperatingSystem | Select-Object -ExpandProperty Version)"
|
||||
```
|
||||
|
||||
**macOS/Linux:**
|
||||
```bash
|
||||
echo "OS: $(uname -s) $(uname -r)"
|
||||
```
|
||||
|
||||
**Output:**
|
||||
```
|
||||
(paste output here)
|
||||
```
|
||||
|
||||
### Terminal Information
|
||||
|
||||
**Windows Terminal:**
|
||||
```powershell
|
||||
"Terminal: Windows Terminal $(Get-AppxPackage -Name Microsoft.WindowsTerminal | Select-Object -ExpandProperty Version)"
|
||||
```
|
||||
|
||||
**Other terminals:**
|
||||
```bash
|
||||
echo $TERM
|
||||
```
|
||||
|
||||
**Output:**
|
||||
```
|
||||
(paste output here)
|
||||
```
|
||||
|
||||
### PowerShell Version
|
||||
|
||||
```powershell
|
||||
$PSVersionTable.PSVersion
|
||||
```
|
||||
|
||||
**Output:**
|
||||
```
|
||||
(paste output here)
|
||||
```
|
||||
|
||||
### .NET Information
|
||||
|
||||
```bash
|
||||
dotnet --version
|
||||
dotnet --info
|
||||
```
|
||||
|
||||
**Output:**
|
||||
```
|
||||
(paste output here)
|
||||
```
|
||||
|
||||
### Terminal.Gui Version
|
||||
|
||||
**Option 1 - Run UICatalog (easiest):**
|
||||
|
||||
UICatalog displays the Terminal.Gui version in its About box and status bar.
|
||||
|
||||
```bash
|
||||
dotnet run --project Examples/UICatalog/UICatalog.csproj
|
||||
```
|
||||
|
||||
**Option 2 - NuGet Package Version:**
|
||||
```
|
||||
(e.g., 2.0.0-alpha.1, 2.0.0-develop.123, etc.)
|
||||
```
|
||||
|
||||
**Option 3 - Building from source:**
|
||||
```bash
|
||||
git rev-parse HEAD
|
||||
git describe --tags --always --dirty
|
||||
```
|
||||
|
||||
**Version:**
|
||||
```
|
||||
(paste version here)
|
||||
```
|
||||
|
||||
## Screenshots, GIFs, or Terminal Output
|
||||
|
||||
If applicable, add screenshots, animated GIFs, or copy/paste terminal output to help explain your problem.
|
||||
|
||||
**Animated GIFs are especially helpful for showing behavior!**
|
||||
|
||||
- **Windows**: [ShareX](https://getsharex.com/) (free, captures screen to GIF)
|
||||
- **macOS**: [Kap](https://getkap.co/) (free, open source)
|
||||
- **Linux**: [Peek](https://github.com/phw/peek) (free)
|
||||
|
||||
**For terminal output, use code blocks:**
|
||||
|
||||
```
|
||||
(paste terminal output here)
|
||||
```
|
||||
|
||||
## Additional context
|
||||
|
||||
Add any other context about the problem here, such as:
|
||||
- Does this happen consistently or intermittently?
|
||||
- Did this work in a previous version?
|
||||
- Are there any error messages in the console?
|
||||
- Terminal configuration or settings that might be relevant?
|
||||
|
||||
## For Maintainers
|
||||
|
||||
**Set Project & Milestone:** If you have access, please don't forget to set the right Project and Milestone.
|
||||
|
||||
Reference in New Issue
Block a user