diff --git a/Terminal.Gui/Application/Application.Initialization.cs b/Terminal.Gui/Application/Application.Initialization.cs index a6840db2a..f3901b8c9 100644 --- a/Terminal.Gui/Application/Application.Initialization.cs +++ b/Terminal.Gui/Application/Application.Initialization.cs @@ -150,6 +150,7 @@ public static partial class Application // Initialization (Init/Shutdown) try { MainLoop = Driver!.Init (); + SubscribeDriverEvents (); } catch (InvalidOperationException ex) { @@ -163,8 +164,6 @@ public static partial class Application // Initialization (Init/Shutdown) ); } - InitState (); - SynchronizationContext.SetSynchronizationContext (new MainLoopSyncContext ()); SupportedCultures = GetSupportedCultures (); @@ -173,7 +172,7 @@ public static partial class Application // Initialization (Init/Shutdown) InitializedChanged?.Invoke (null, new (init)); } - internal static void InitState () + internal static void SubscribeDriverEvents () { ArgumentNullException.ThrowIfNull (Driver); @@ -183,6 +182,14 @@ public static partial class Application // Initialization (Init/Shutdown) Driver.MouseEvent += Driver_MouseEvent; } + internal static void UnsubscribeDriverEvents () + { + Driver.SizeChanged -= Driver_SizeChanged; + Driver.KeyDown -= Driver_KeyDown; + Driver.KeyUp -= Driver_KeyUp; + Driver.MouseEvent -= Driver_MouseEvent; + } + private static void Driver_SizeChanged (object? sender, SizeChangedEventArgs e) { OnSizeChanging (e); } private static void Driver_KeyDown (object? sender, Key e) { RaiseKeyDownEvent (e); } private static void Driver_KeyUp (object? sender, Key e) { RaiseKeyUpEvent (e); } diff --git a/Terminal.Gui/Application/Application.cs b/Terminal.Gui/Application/Application.cs index 77a53de2a..7c0ff5529 100644 --- a/Terminal.Gui/Application/Application.cs +++ b/Terminal.Gui/Application/Application.cs @@ -177,10 +177,7 @@ public static partial class Application // Driver stuff if (Driver is { }) { - Driver.SizeChanged -= Driver_SizeChanged; - Driver.KeyDown -= Driver_KeyDown; - Driver.KeyUp -= Driver_KeyUp; - Driver.MouseEvent -= Driver_MouseEvent; + UnsubscribeDriverEvents (); Driver?.End (); Driver = null; } diff --git a/UnitTests/Application/ApplicationScreenTests.cs b/UnitTests/Application/ApplicationScreenTests.cs index d3866859e..f53bf8531 100644 --- a/UnitTests/Application/ApplicationScreenTests.cs +++ b/UnitTests/Application/ApplicationScreenTests.cs @@ -73,7 +73,7 @@ public class ApplicationScreenTests (ITestOutputHelper output) Application.ResetState (true); Assert.Null (Application.Driver); Application.Driver = new FakeDriver { Rows = 25, Cols = 25 }; - Application.InitState (); + Application.SubscribeDriverEvents (); Assert.Equal (new (0, 0, 25, 25), Application.Screen); // Act diff --git a/UnitTests/Application/ApplicationTests.cs b/UnitTests/Application/ApplicationTests.cs index b5d2edee1..333e4f942 100644 --- a/UnitTests/Application/ApplicationTests.cs +++ b/UnitTests/Application/ApplicationTests.cs @@ -644,7 +644,7 @@ public class ApplicationTests [Fact] public void InitState_Throws_If_Driver_Is_Null () { - Assert.Throws (static () => Application.InitState ()); + Assert.Throws (static () => Application.SubscribeDriverEvents ()); } private void Init () diff --git a/UnitTests/TestHelpers.cs b/UnitTests/TestHelpers.cs index e29825135..ed687e61b 100644 --- a/UnitTests/TestHelpers.cs +++ b/UnitTests/TestHelpers.cs @@ -212,7 +212,7 @@ public class SetupFakeDriverAttribute : BeforeAfterTestAttribute Application.Driver = new FakeDriver { Rows = 25, Cols = 25 }; Assert.Equal (new (0, 0, 25, 25), Application.Screen); // Ensures subscribing events, at least for the SizeChanged event - Application.InitState (); + Application.SubscribeDriverEvents (); base.Before (methodUnderTest); }