From c42c88ccbc99995ea675e6851b16cb6c5d282944 Mon Sep 17 00:00:00 2001 From: BDisp Date: Wed, 10 Apr 2024 18:16:51 +0100 Subject: [PATCH] Ensures the menu bar grabs the mouse when removing a menu. --- Terminal.Gui/Views/Menu/MenuBar.cs | 6 ++++++ UnitTests/Views/MenuBarTests.cs | 24 ++++-------------------- 2 files changed, 10 insertions(+), 20 deletions(-) diff --git a/Terminal.Gui/Views/Menu/MenuBar.cs b/Terminal.Gui/Views/Menu/MenuBar.cs index 07ff6912c..19f9f241a 100644 --- a/Terminal.Gui/Views/Menu/MenuBar.cs +++ b/Terminal.Gui/Views/Menu/MenuBar.cs @@ -1386,6 +1386,12 @@ public class MenuBar : View menu = _openSubMenu [i]; Application.Current.Remove (menu); _openSubMenu.Remove (menu); + + if (Application.MouseGrabView == menu) + { + Application.GrabMouse (this); + } + menu.Dispose (); } diff --git a/UnitTests/Views/MenuBarTests.cs b/UnitTests/Views/MenuBarTests.cs index 99b9dc42e..9a53bfaee 100644 --- a/UnitTests/Views/MenuBarTests.cs +++ b/UnitTests/Views/MenuBarTests.cs @@ -3262,11 +3262,7 @@ Edit Rectangle pos = TestHelpers.AssertDriverContentsWithFrameAre (expected, _output); Assert.Equal (new Rectangle (1, 0, 8, 1), pos); - Assert.True ( - menu.NewMouseEvent ( - new MouseEvent { X = 1, Y = 0, Flags = MouseFlags.Button1Pressed, View = menu } - ) - ); + Assert.True (menu.NewMouseEvent (new () { X = 1, Y = 0, Flags = MouseFlags.Button1Pressed, View = menu })); top.Draw (); expected = @" @@ -3281,11 +3277,7 @@ Edit pos = TestHelpers.AssertDriverContentsWithFrameAre (expected, _output); Assert.Equal (new Rectangle (1, 0, 10, 6), pos); - Assert.False ( - menu.NewMouseEvent ( - new MouseEvent { X = 1, Y = 2, Flags = MouseFlags.Button1Clicked, View = Application.Top.Subviews [1] } - ) - ); + Assert.False (menu.NewMouseEvent (new () { X = 1, Y = 2, Flags = MouseFlags.Button1Clicked, View = Application.Top.Subviews [1] })); top.Draw (); expected = @" @@ -3301,11 +3293,7 @@ Edit pos = TestHelpers.AssertDriverContentsWithFrameAre (expected, _output); Assert.Equal (new Rectangle (1, 0, 15, 7), pos); - Assert.False ( - menu.NewMouseEvent ( - new MouseEvent { X = 1, Y = 1, Flags = MouseFlags.Button1Clicked, View = Application.Top.Subviews [2] } - ) - ); + Assert.False (menu.NewMouseEvent (new () { X = 1, Y = 1, Flags = MouseFlags.Button1Clicked, View = Application.Top.Subviews [2] })); top.Draw (); expected = @" @@ -3320,11 +3308,7 @@ Edit pos = TestHelpers.AssertDriverContentsWithFrameAre (expected, _output); Assert.Equal (new Rectangle (1, 0, 10, 6), pos); - Assert.False ( - menu.NewMouseEvent ( - new MouseEvent { X = 70, Y = 2, Flags = MouseFlags.Button1Clicked, View = Application.Top } - ) - ); + Assert.False (menu.NewMouseEvent (new () { X = 70, Y = 2, Flags = MouseFlags.Button1Clicked, View = Application.Top })); top.Draw (); expected = @"