Git_Mirror/Terminal.Gui
1
0
Fork 0
mirror of https://github.com/gui-cs/Terminal.Gui.git synced 2025-12-26 15:57:56 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix AdvanceFocus not cycling properly through peers with nested subviews (#4267)

Browse Source 
* Initial plan

* Implement fix for AdvanceFocus nested subview navigation

Co-authored-by: tig <585482+tig@users.noreply.github.com>

* Refactor ShouldBubbleUpForWrapping to use iteration instead of recursion

Co-authored-by: tig <585482+tig@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Tig <tig@users.noreply.github.com>
Co-authored-by: tig <585482+tig@users.noreply.github.com>
This commit is contained in:
Copilot
2025-10-07 09:31:08 -06:00
committed by GitHub
parent 168d233428
commit c8147416b2
2 changed files with 84 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

44
Tests/UnitTestsParallelizable/View/Navigation/AdvanceFocusTests.cs
View File

@@ -644,4 +644,48 @@ public class AdvanceFocusTests ()
Assert.Equal (canFocus, view.CanFocus);
Assert.Equal (tabStop, view.TabStop);
}
[Fact]
public void AdvanceFocus_Cycles_Through_Peers_And_All_Nested_SubViews_When_Multiple ()
{
var top = new View { Id = "top", CanFocus = true };
View peer1 = new View
{
CanFocus = true,
Id = "peer1",
};
var peer2 = new View
{
CanFocus = true,
Id = "peer2",
};
var peer2SubView = new View
{
Id = "peer2SubView", CanFocus = true
};
var v1 = new View { Id = "v1", CanFocus = true };
var v2 = new View { Id = "v2", CanFocus = true };
peer2SubView.Add (v1, v2);
peer2.Add (peer2SubView);
top.Add (peer1, peer2);
top.SetFocus ();
Assert.Equal (peer1, top.MostFocused);
top.AdvanceFocus (NavigationDirection.Forward, TabBehavior.TabStop);
Assert.Equal (v1, top.MostFocused);
top.AdvanceFocus (NavigationDirection.Forward, TabBehavior.TabStop);
Assert.Equal (v2, top.MostFocused);
// This should cycle to peer1 - previously it incorrectly cycled to v1
top.AdvanceFocus (NavigationDirection.Forward, TabBehavior.TabStop);
Assert.Equal (peer1, top.MostFocused);
top.Dispose ();
}
}