From 9ea9a2abde9b2ce9c85445bab92452f1f1322264 Mon Sep 17 00:00:00 2001 From: Tig Date: Sun, 7 Jul 2024 15:07:12 -0600 Subject: [PATCH 1/7] re-enabled code coverage --- .github/workflows/dotnet-core.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/dotnet-core.yml b/.github/workflows/dotnet-core.yml index 58b75c74b..23e4fd542 100644 --- a/.github/workflows/dotnet-core.yml +++ b/.github/workflows/dotnet-core.yml @@ -35,7 +35,7 @@ jobs: - name: Test run: | sed -i 's/"stopOnFail": false/"stopOnFail": true/g' UnitTests/xunit.runner.json - dotnet test --verbosity normal --blame --diag:logs/logs.txt --blame-hang --blame-hang-timeout 60s + dotnet test --verbosity normal --collect:"XPlat Code Coverage" --settings UnitTests/coverlet.runsettings --blame --diag:logs/logs.txt --blame-hang --blame-hang-timeout 60s mv -v UnitTests/TestResults/*/*.* UnitTests/TestResults/ # Note: this step is currently not writing to the gist for some reason From e13d44dda109b1ce2b11907110872fa24890d8f3 Mon Sep 17 00:00:00 2001 From: Tig Date: Sun, 7 Jul 2024 15:24:46 -0600 Subject: [PATCH 2/7] upload logs after test --- .github/workflows/dotnet-core.yml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/.github/workflows/dotnet-core.yml b/.github/workflows/dotnet-core.yml index 23e4fd542..6226f4f1a 100644 --- a/.github/workflows/dotnet-core.yml +++ b/.github/workflows/dotnet-core.yml @@ -32,12 +32,19 @@ jobs: - name: Build Debug run: dotnet build --configuration Debug --no-restore + # See https://github.com/microsoft/vstest/issues/2952 for why the --blame stuff below is needed. + # Without it, the test runner crashes on ubuntu (but not Windows)/ - name: Test run: | sed -i 's/"stopOnFail": false/"stopOnFail": true/g' UnitTests/xunit.runner.json dotnet test --verbosity normal --collect:"XPlat Code Coverage" --settings UnitTests/coverlet.runsettings --blame --diag:logs/logs.txt --blame-hang --blame-hang-timeout 60s mv -v UnitTests/TestResults/*/*.* UnitTests/TestResults/ + - uses: actions/upload-artifact@v4 + with: + name: test-logs + path: logs/ + # Note: this step is currently not writing to the gist for some reason # - name: Create Test Coverage Badge # uses: simon-k/dotnet-code-coverage-badge@v1.0.0 From accaaf2cb690097518d2436bf37733e2f24917d2 Mon Sep 17 00:00:00 2001 From: Tig Date: Sun, 7 Jul 2024 15:30:04 -0600 Subject: [PATCH 3/7] upload logs after test 2 --- .github/workflows/dotnet-core.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/dotnet-core.yml b/.github/workflows/dotnet-core.yml index 6226f4f1a..7fbb0f08d 100644 --- a/.github/workflows/dotnet-core.yml +++ b/.github/workflows/dotnet-core.yml @@ -40,7 +40,9 @@ jobs: dotnet test --verbosity normal --collect:"XPlat Code Coverage" --settings UnitTests/coverlet.runsettings --blame --diag:logs/logs.txt --blame-hang --blame-hang-timeout 60s mv -v UnitTests/TestResults/*/*.* UnitTests/TestResults/ - - uses: actions/upload-artifact@v4 + - name: Upload Test Logs + if: always() + uses: actions/upload-artifact@v4 with: name: test-logs path: logs/ From 013477670ad3f469c1eeaf30d9b4f1f80c5f6fce Mon Sep 17 00:00:00 2001 From: Tig Date: Sun, 7 Jul 2024 16:21:55 -0600 Subject: [PATCH 4/7] upload logs after test 3 --- .github/workflows/dotnet-core.yml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/.github/workflows/dotnet-core.yml b/.github/workflows/dotnet-core.yml index 7fbb0f08d..fa5d6d5ef 100644 --- a/.github/workflows/dotnet-core.yml +++ b/.github/workflows/dotnet-core.yml @@ -47,6 +47,13 @@ jobs: name: test-logs path: logs/ + - name: Upload Crash Dumps + if: always() + uses: actions/upload-artifact@v4 + with: + name: crash-dumps + path: uploads/ + # Note: this step is currently not writing to the gist for some reason # - name: Create Test Coverage Badge # uses: simon-k/dotnet-code-coverage-badge@v1.0.0 From 6a5ef52755d177ed243b76e71458f372f746fa90 Mon Sep 17 00:00:00 2001 From: Tig Date: Sun, 7 Jul 2024 16:24:49 -0600 Subject: [PATCH 5/7] upload logs after test 4 --- .github/workflows/dotnet-core.yml | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/.github/workflows/dotnet-core.yml b/.github/workflows/dotnet-core.yml index fa5d6d5ef..c79c293d4 100644 --- a/.github/workflows/dotnet-core.yml +++ b/.github/workflows/dotnet-core.yml @@ -45,14 +45,10 @@ jobs: uses: actions/upload-artifact@v4 with: name: test-logs - path: logs/ - - - name: Upload Crash Dumps - if: always() - uses: actions/upload-artifact@v4 - with: - name: crash-dumps - path: uploads/ + path: | + logs/ + uploads/ + UnitTests/TestResults/ # Note: this step is currently not writing to the gist for some reason # - name: Create Test Coverage Badge From 986e389ca7667587106a38ac4873a2e833764ab8 Mon Sep 17 00:00:00 2001 From: Tig Date: Sun, 7 Jul 2024 16:41:11 -0600 Subject: [PATCH 6/7] upload logs after test 5 --- .github/workflows/dotnet-core.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/dotnet-core.yml b/.github/workflows/dotnet-core.yml index c79c293d4..8d3c3651b 100644 --- a/.github/workflows/dotnet-core.yml +++ b/.github/workflows/dotnet-core.yml @@ -37,7 +37,7 @@ jobs: - name: Test run: | sed -i 's/"stopOnFail": false/"stopOnFail": true/g' UnitTests/xunit.runner.json - dotnet test --verbosity normal --collect:"XPlat Code Coverage" --settings UnitTests/coverlet.runsettings --blame --diag:logs/logs.txt --blame-hang --blame-hang-timeout 60s + dotnet test --verbosity normal --collect:"XPlat Code Coverage" --settings UnitTests/coverlet.runsettings --blame --diag:logs/logs.txt --blame-crash --blame-hang --blame-hang-timeout 60s --blame-crash-collect-always mv -v UnitTests/TestResults/*/*.* UnitTests/TestResults/ - name: Upload Test Logs From 122744bbe71f5fdb841637413f97d51796a36d5e Mon Sep 17 00:00:00 2001 From: Tig Date: Sun, 7 Jul 2024 16:51:28 -0600 Subject: [PATCH 7/7] upload logs after test 6 --- .github/workflows/dotnet-core.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/dotnet-core.yml b/.github/workflows/dotnet-core.yml index 8d3c3651b..9b580c60f 100644 --- a/.github/workflows/dotnet-core.yml +++ b/.github/workflows/dotnet-core.yml @@ -37,8 +37,9 @@ jobs: - name: Test run: | sed -i 's/"stopOnFail": false/"stopOnFail": true/g' UnitTests/xunit.runner.json - dotnet test --verbosity normal --collect:"XPlat Code Coverage" --settings UnitTests/coverlet.runsettings --blame --diag:logs/logs.txt --blame-crash --blame-hang --blame-hang-timeout 60s --blame-crash-collect-always - mv -v UnitTests/TestResults/*/*.* UnitTests/TestResults/ + dotnet test --verbosity normal --collect:"XPlat Code Coverage" --settings UnitTests/coverlet.runsettings --diag:logs/logs.txt --blame --blame-crash --blame-hang --blame-hang-timeout 60s --blame-crash-collect-always + + # mv -v UnitTests/TestResults/*/*.* UnitTests/TestResults/ - name: Upload Test Logs if: always()