diff --git a/Terminal.Gui/ConsoleDrivers/ConsoleDriver.cs b/Terminal.Gui/ConsoleDrivers/ConsoleDriver.cs index 24e1347ea..2ba8ba601 100644 --- a/Terminal.Gui/ConsoleDrivers/ConsoleDriver.cs +++ b/Terminal.Gui/ConsoleDrivers/ConsoleDriver.cs @@ -452,7 +452,7 @@ public abstract class ConsoleDriver : IConsoleDriver /// Sets as dirty for situations where views /// don't need layout and redrawing, but just refresh the screen. /// - public void SetContentsAsDirty () + protected void SetContentsAsDirty () { lock (Contents!) { @@ -480,10 +480,6 @@ public abstract class ConsoleDriver : IConsoleDriver #region Cursor Handling - /// Determines if the terminal cursor should be visible or not and sets it accordingly. - /// upon success - public abstract bool EnsureCursorVisibility (); - /// Gets the terminal cursor visibility. /// The current /// upon success diff --git a/Terminal.Gui/ConsoleDrivers/CursesDriver/CursesDriver.cs b/Terminal.Gui/ConsoleDrivers/CursesDriver/CursesDriver.cs index 38530ff22..5ce4fd990 100644 --- a/Terminal.Gui/ConsoleDrivers/CursesDriver/CursesDriver.cs +++ b/Terminal.Gui/ConsoleDrivers/CursesDriver/CursesDriver.cs @@ -507,8 +507,8 @@ internal class CursesDriver : ConsoleDriver private CursorVisibility? _currentCursorVisibility; private CursorVisibility? _initialCursorVisibility; - /// - public override bool EnsureCursorVisibility () + + private void EnsureCursorVisibility () { if (!(Col >= 0 && Row >= 0 && Col < Cols && Row < Rows)) { @@ -516,12 +516,10 @@ internal class CursesDriver : ConsoleDriver _currentCursorVisibility = cursorVisibility; SetCursorVisibility (CursorVisibility.Invisible); - return false; + return; } SetCursorVisibility (_currentCursorVisibility ?? CursorVisibility.Default); - - return _currentCursorVisibility == CursorVisibility.Default; } /// diff --git a/Terminal.Gui/ConsoleDrivers/FakeDriver/FakeDriver.cs b/Terminal.Gui/ConsoleDrivers/FakeDriver/FakeDriver.cs index 6865aeae3..70c4ba447 100644 --- a/Terminal.Gui/ConsoleDrivers/FakeDriver/FakeDriver.cs +++ b/Terminal.Gui/ConsoleDrivers/FakeDriver/FakeDriver.cs @@ -377,7 +377,7 @@ public class FakeDriver : ConsoleDriver } /// - public override bool EnsureCursorVisibility () + private bool EnsureCursorVisibility () { if (!(Col >= 0 && Row >= 0 && Col < Cols && Row < Rows)) { diff --git a/Terminal.Gui/ConsoleDrivers/IConsoleDriver.cs b/Terminal.Gui/ConsoleDrivers/IConsoleDriver.cs index 7fbb9b837..af41abe66 100644 --- a/Terminal.Gui/ConsoleDrivers/IConsoleDriver.cs +++ b/Terminal.Gui/ConsoleDrivers/IConsoleDriver.cs @@ -200,18 +200,6 @@ public interface IConsoleDriver /// event EventHandler? ClearedContents; - // BUGBUG: This is not referenced. Can it be removed? - /// - /// Sets as dirty for situations where views - /// don't need layout and redrawing, but just refresh the screen. - /// - void SetContentsAsDirty (); - - // BUGBUG: This is not referenced. Can it be removed? - /// Determines if the terminal cursor should be visible or not and sets it accordingly. - /// upon success - bool EnsureCursorVisibility (); - /// Gets the terminal cursor visibility. /// The current /// upon success diff --git a/Terminal.Gui/ConsoleDrivers/NetDriver/NetDriver.cs b/Terminal.Gui/ConsoleDrivers/NetDriver/NetDriver.cs index d8e7e1d3e..2ede00a00 100644 --- a/Terminal.Gui/ConsoleDrivers/NetDriver/NetDriver.cs +++ b/Terminal.Gui/ConsoleDrivers/NetDriver/NetDriver.cs @@ -496,7 +496,7 @@ internal class NetDriver : ConsoleDriver return visibility == CursorVisibility.Default; } - public override bool EnsureCursorVisibility () + private void EnsureCursorVisibility () { if (!(Col >= 0 && Row >= 0 && Col < Cols && Row < Rows)) { @@ -504,12 +504,10 @@ internal class NetDriver : ConsoleDriver _cachedCursorVisibility = cursorVisibility; SetCursorVisibility (CursorVisibility.Invisible); - return false; + return; } SetCursorVisibility (_cachedCursorVisibility ?? CursorVisibility.Default); - - return _cachedCursorVisibility == CursorVisibility.Default; } #endregion diff --git a/Terminal.Gui/ConsoleDrivers/WindowsDriver/WindowsDriver.cs b/Terminal.Gui/ConsoleDrivers/WindowsDriver/WindowsDriver.cs index 4998b27c7..c67eb9129 100644 --- a/Terminal.Gui/ConsoleDrivers/WindowsDriver/WindowsDriver.cs +++ b/Terminal.Gui/ConsoleDrivers/WindowsDriver/WindowsDriver.cs @@ -293,35 +293,6 @@ internal class WindowsDriver : ConsoleDriver return WinConsole?.WriteANSI (sb.ToString ()) ?? false; } } - - /// - public override bool EnsureCursorVisibility () - { - if (Force16Colors) - { - return WinConsole is null || WinConsole.EnsureCursorVisibility (); - } - else - { - var sb = new StringBuilder (); - sb.Append (_cachedCursorVisibility != CursorVisibility.Invisible ? EscSeqUtils.CSI_ShowCursor : EscSeqUtils.CSI_HideCursor); - return WinConsole?.WriteANSI (sb.ToString ()) ?? false; - } - - //if (!(Col >= 0 && Row >= 0 && Col < Cols && Row < Rows)) - //{ - // GetCursorVisibility (out CursorVisibility cursorVisibility); - // _cachedCursorVisibility = cursorVisibility; - // SetCursorVisibility (CursorVisibility.Invisible); - - // return false; - //} - - //SetCursorVisibility (_cachedCursorVisibility ?? CursorVisibility.Default); - - //return _cachedCursorVisibility == CursorVisibility.Default; - } - #endregion Cursor Handling public override bool UpdateScreen ()