From 122744bbe71f5fdb841637413f97d51796a36d5e Mon Sep 17 00:00:00 2001 From: Tig Date: Sun, 7 Jul 2024 16:51:28 -0600 Subject: [PATCH 1/7] upload logs after test 6 --- .github/workflows/dotnet-core.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/dotnet-core.yml b/.github/workflows/dotnet-core.yml index 8d3c3651b..9b580c60f 100644 --- a/.github/workflows/dotnet-core.yml +++ b/.github/workflows/dotnet-core.yml @@ -37,8 +37,9 @@ jobs: - name: Test run: | sed -i 's/"stopOnFail": false/"stopOnFail": true/g' UnitTests/xunit.runner.json - dotnet test --verbosity normal --collect:"XPlat Code Coverage" --settings UnitTests/coverlet.runsettings --blame --diag:logs/logs.txt --blame-crash --blame-hang --blame-hang-timeout 60s --blame-crash-collect-always - mv -v UnitTests/TestResults/*/*.* UnitTests/TestResults/ + dotnet test --verbosity normal --collect:"XPlat Code Coverage" --settings UnitTests/coverlet.runsettings --diag:logs/logs.txt --blame --blame-crash --blame-hang --blame-hang-timeout 60s --blame-crash-collect-always + + # mv -v UnitTests/TestResults/*/*.* UnitTests/TestResults/ - name: Upload Test Logs if: always() From b84e7b868cf29845f9e1530452c5ea0cc75d52da Mon Sep 17 00:00:00 2001 From: Tig Date: Sun, 7 Jul 2024 16:59:44 -0600 Subject: [PATCH 2/7] matrix.os --- .github/workflows/dotnet-core.yml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/dotnet-core.yml b/.github/workflows/dotnet-core.yml index 9b580c60f..7b5cfdf96 100644 --- a/.github/workflows/dotnet-core.yml +++ b/.github/workflows/dotnet-core.yml @@ -13,7 +13,11 @@ on: jobs: build_and_test: - runs-on: ubuntu-latest + runs-on: ${{ matrix.os }} + strategy: + matrix: + os: [ ubuntu-latest, windows-latest, macos-latest ] + timeout-minutes: 10 steps: From 7c119de0e602d4db0b1327378b6539077acfa535 Mon Sep 17 00:00:00 2001 From: Tig Date: Sun, 7 Jul 2024 17:04:35 -0600 Subject: [PATCH 3/7] need to install sed on macos --- .github/workflows/dotnet-core.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/dotnet-core.yml b/.github/workflows/dotnet-core.yml index 7b5cfdf96..67959afc9 100644 --- a/.github/workflows/dotnet-core.yml +++ b/.github/workflows/dotnet-core.yml @@ -36,6 +36,10 @@ jobs: - name: Build Debug run: dotnet build --configuration Debug --no-restore + - name: Install sed on macOS + if: runner.os == 'macOS' + run: brew install gnu-sed + # See https://github.com/microsoft/vstest/issues/2952 for why the --blame stuff below is needed. # Without it, the test runner crashes on ubuntu (but not Windows)/ - name: Test From 454bfda636ee1cf6eda1df46dcefe919a5943587 Mon Sep 17 00:00:00 2001 From: Tig Date: Sun, 7 Jul 2024 17:08:17 -0600 Subject: [PATCH 4/7] fail-fast: false temporarily --- .github/workflows/dotnet-core.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/dotnet-core.yml b/.github/workflows/dotnet-core.yml index 67959afc9..c40a74ec2 100644 --- a/.github/workflows/dotnet-core.yml +++ b/.github/workflows/dotnet-core.yml @@ -15,6 +15,8 @@ jobs: runs-on: ${{ matrix.os }} strategy: + # Turn on fail-fast once we have the tests running on all platforms + fail-fast: false matrix: os: [ ubuntu-latest, windows-latest, macos-latest ] From 23ee80f03056c20037aec738714b76a1f0ce0f3a Mon Sep 17 00:00:00 2001 From: Tig Date: Sun, 7 Jul 2024 17:11:34 -0600 Subject: [PATCH 5/7] need path to sed on macos --- .github/workflows/dotnet-core.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/dotnet-core.yml b/.github/workflows/dotnet-core.yml index c40a74ec2..191907d7f 100644 --- a/.github/workflows/dotnet-core.yml +++ b/.github/workflows/dotnet-core.yml @@ -40,7 +40,9 @@ jobs: - name: Install sed on macOS if: runner.os == 'macOS' - run: brew install gnu-sed + run: | + brew install gnu-sed + PATH="/opt/homebrew/opt/gnu-sed/libexec/gnubin:$PATH" # See https://github.com/microsoft/vstest/issues/2952 for why the --blame stuff below is needed. # Without it, the test runner crashes on ubuntu (but not Windows)/ From a2e63e7700a483cb79a7d59484ebc3a5dc390398 Mon Sep 17 00:00:00 2001 From: Tig Date: Sun, 7 Jul 2024 17:13:42 -0600 Subject: [PATCH 6/7] need path to sed on macos 2 --- .github/workflows/dotnet-core.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/dotnet-core.yml b/.github/workflows/dotnet-core.yml index 191907d7f..7f9316f90 100644 --- a/.github/workflows/dotnet-core.yml +++ b/.github/workflows/dotnet-core.yml @@ -43,6 +43,7 @@ jobs: run: | brew install gnu-sed PATH="/opt/homebrew/opt/gnu-sed/libexec/gnubin:$PATH" + sed --version # See https://github.com/microsoft/vstest/issues/2952 for why the --blame stuff below is needed. # Without it, the test runner crashes on ubuntu (but not Windows)/ From 53a8f1d04a8b47b6e4b00f06b29ca09865656498 Mon Sep 17 00:00:00 2001 From: Tig Date: Sun, 7 Jul 2024 17:15:03 -0600 Subject: [PATCH 7/7] need path to sed on macos 3 --- .github/workflows/dotnet-core.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/dotnet-core.yml b/.github/workflows/dotnet-core.yml index 7f9316f90..8c49b7f78 100644 --- a/.github/workflows/dotnet-core.yml +++ b/.github/workflows/dotnet-core.yml @@ -49,6 +49,7 @@ jobs: # Without it, the test runner crashes on ubuntu (but not Windows)/ - name: Test run: | + PATH="/opt/homebrew/opt/gnu-sed/libexec/gnubin:$PATH" sed -i 's/"stopOnFail": false/"stopOnFail": true/g' UnitTests/xunit.runner.json dotnet test --verbosity normal --collect:"XPlat Code Coverage" --settings UnitTests/coverlet.runsettings --diag:logs/logs.txt --blame --blame-crash --blame-hang --blame-hang-timeout 60s --blame-crash-collect-always