mirror of
https://github.com/gui-cs/Terminal.Gui.git
synced 2026-02-10 04:03:41 +01:00
v2_develop
19 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
Tig
|
e9976da95e |
Reapply "Merge branch 'v2_develop' of tig:gui-cs/Terminal.Gui into v2_develop"
This reverts commit
|
||
|
Tig
|
845c05ff47 |
Revert "Merge branch 'v2_develop' of tig:gui-cs/Terminal.Gui into v2_develop"
This reverts commit |
||
|
Tig
|
004bfd200b | Fixed shft selection bug. | ||
|
Tig
|
07cee7174d |
Fixes #4471, #4474, #3714, #2588 - MASSIVE: Refactors Mouse, Adds ANSI driver, Enables Input Injection (#4472)
* Improve logging for debugging and error traceability
Enhanced logging across multiple classes to improve observability:
- Added debug log for `OperationCanceledException` in `MainLoopCoordinator<TInputRecord>`.
- Logged mouse event details in `MouseImpl` for better event tracking.
- Added trace log in `InputImpl<TInputRecord>` to indicate input availability.
- Replaced `LogInformation` with `Logging.Information` in `WindowsInput`.
- Logged detailed error information for console input failures in `WindowsInput`.
These changes enhance maintainability and debugging capabilities.
* Fixed warnings
* Refactored `MouseHeldDown` to support accelerating timeouts for
continuous actions like auto-scrolling. Enhanced `IMouseHeldDown`
to include richer event data and updated `Start` to accept
`MouseEventArgs`. Removed `MouseGrabHandler` and integrated its
functionality into `MouseHeldDown` and `MouseImpl`.
Streamlined mouse event handling in `View` by introducing lazy
instantiation of `MouseHeldDown` and replacing legacy methods
with `RaiseCommandsBoundToButtonClickedFlags` and
`RaiseCommandsBoundToWheelFlags`. Removed the `MouseWheel` event
and transitioned wheel handling to the command-binding system.
Improved `MouseBindings` to convert "pressed" events to "clicked"
events for better command invocation. Updated `TimedEvents` to
ensure proper handling of scheduled timeouts.
Refactored `MouseTests` to align with the new `MouseHeldDown`
implementation. Removed redundant code in `Button` and performed
general cleanup and documentation updates for better
maintainability.
* WIP: Refactor MouseFlags and improve mouse event handling
- Introduced semantic aliases for `MouseFlags` to improve readability.
- Enhanced XML documentation for `MouseFlags` and related enums.
- Refactored `MouseHeldDown` to improve type safety and add detailed logging.
- Updated `View.Mouse.cs` to handle mouse events more consistently.
- Changed default mouse bindings to use semantic aliases (e.g., `LeftButtonClicked`).
- Removed redundant and excessive logging across multiple files.
- Updated `Button` class and test cases to align with new mouse flag aliases.
- Improved handling of continuous button presses and mouse grab logic.
* WIP: Big code cleanup and reorg of Mouse processing helpers.
* WIP: Add comprehensive driver/input/output unit tests
Introduces a broad suite of new xUnit tests for Terminal.Gui's driver, input, and output subsystems under the DriverTests namespace. Tests cover keyboard mapping, mouse click detection, input processing (including Unicode/surrogate pairs), and output buffer behavior. Includes edge cases for modifiers, wide/combining characters, and mouse event quirks. Some tests document known limitations or are marked as skipped for future investigation. This significantly increases test coverage and documents both expected and legacy behaviors.
* New arch
* WIP: Implement timestamp-based multi-click detection with pending clicks
Added Timestamp property to MouseEventArgs. Refactored MouseButtonClickTracker and MouseInterpreter to use event timestamps. Updated all test constructors. MouseButtonClickTrackerTests: 17/17 passing. MouseInterpreterExtendedTests: 9/18 passing (9 need deferred-click assertion updates).
* Add implementation summary for timestamp-based multi-click detection
* WIP:
* Almost working - Geting single and double clicks but at least single works.
* Made MouseEventArgs.Position nullable to indicate it might not be set.
* MouseEventArgs -> Mouse
* API docs
* Renames.
* Code clean up and deep dive
* Docs
* tests
* More analysis
* fxied some tests
* Massive mouse nameing cleanup
* HighlightStates rename and code cleanup
* More renames
* Disabled broken tests with Skip = "Broken in #4474"
* Commented legacy
* Phase 2
* Add testable input and debug/test suite for UnixInput
Implemented ITestableInput<char> in UnixInput, enabling injection of synthetic keyboard and mouse events for robust unit testing. Overrode EnqueueKeyDownEvent and EnqueueMouseEvent in UnixInputProcessor to inject ANSI sequences for keys and mouse actions. Added comprehensive unit and debug tests for input injection, event sequencing, and ANSI code mapping. Included detailed driver input/output analysis documentation comparing all drivers and their use of native APIs and ANSI infrastructure. These changes greatly improve testability and cross-platform input simulation.
* Add AnsiKeyboardEncoder/MouseEncoder and related tests
Introduce AnsiKeyboardEncoder and AnsiMouseEncoder utility classes to convert Key and Mouse objects to ANSI escape sequences, enabling round-trip testing and input injection. Refactor UnixInputProcessor to use these encoders, removing legacy conversion methods. Add comprehensive AnsiKeyboardEncoderTests and remove obsolete MouseToAnsiDebugTests. Minor formatting improvements in AnsiKeyboardParser. These changes improve modularity and testability of ANSI input handling.
* merged
* Enabled previously skpped tests. STuff is broke
* updates transparent shadow test
* Refactor Fake driver to use pure ANSI char stream
Refactored the Fake (mock) driver to operate as a true ANSI driver using a char stream for input and output, replacing the previous ConsoleKeyInfo-based model. FakeInput now implements IInput<char> and ITestableInput<char>, reading raw bytes from Console.OpenStandardInput(), decoding as UTF-8, and parsing ANSI escape sequences for keyboard and mouse events. FakeInputProcessor is updated to process char streams and integrates with the ANSI parser infrastructure, supporting EnqueueKeyDownEvent and EnqueueMouseEvent via ANSI encoding.
FakeOutput now writes ANSI escape sequences directly to the console (if available) and maintains an internal buffer for test verification, supporting both 16-color and true-color output. All related tests and helpers are updated to use char-based input buffers and ScreenPosition for mouse events. Added a new FakeInputTestableTests.cs file for comprehensive testing of the ITestableInput<char> implementation.
Also updated launchSettings.json to add a "UICatalog --driver fake" profile. This modernizes the Fake driver for more realistic testing and compatibility with real ANSI terminals.
* Add platform raw mode support to FakeInput (Unix/Win)
Enables and restores terminal raw mode on Unix/Mac using termios
(P/Invoke), and enables Virtual Terminal Input mode on Windows
using Console API. Original terminal settings are restored on
shutdown. Updates class documentation to clarify platform-specific
behavior and limitations. Improves FakeInput for real ANSI input
on Unix-like systems and enhances Windows support, though with
noted caveats.
* Refactor FakeDriver: true ANSI/VT, platform helpers, size
- Introduce UnixRawModeHelper and WindowsVTInputHelper for robust, cross-platform raw/VT input handling.
- Refactor FakeInput and FakeOutput to use real ANSI/VT sequences, alternate buffer, and proper terminal state management.
- Add FakeSizeMonitor for ANSI-based terminal size detection using escape sequences and async response handling.
- Enhance ISizeMonitor with Initialize(driver) for post-construction setup.
- MainLoopCoordinator now initializes size monitor after driver construction.
- Update and clarify tests for ANSI/VT limitations and mouse/key round-tripping.
- OutputBase.ToAnsi emits plain text for legacy consoles.
- Add launch profiles for Fake driver on Windows and WSL.
- General code cleanup, improved comments, and platform separation.
* Unify ANSI key conversion for Unix and test drivers
Replaced UnixKeyConverter with new AnsiKeyConverter, consolidating ANSI char-to-Key mapping for both Unix and FakeInput drivers. Updated processors to use AnsiKeyConverter, removed UnixKeyConverter, and improved documentation for clarity. Reformatted WindowsVTInputHelper for consistency. This refactor ensures consistent, cross-platform ANSI input handling and reduces code duplication.
* Introduce DriverRegistry: type-safe, AOT-friendly driver system
Adds DriverRegistry for centralized, reflection-free driver discovery and selection. Refactors Application and driver factories to use registry-based logic and type-safe constants. Removes legacy string-based and reflection-based driver selection. Updates docs, tests, and schema for new pattern. Enables custom driver registration and improves AOT compatibility.
* Rename Fake driver to ANSI driver throughout codebase
Refactored all code, tests, docs, and configs to replace the "Fake" driver with the "ANSI" driver. This includes renaming all related classes, files, registry constants, and test helpers (e.g., FakeInput → ANSIInput, FakeOutput → ANSIOutput, etc.), and updating all references in documentation and configuration. No functional changes were made; this is a naming and documentation update to clarify that the ANSI driver is a real, cross-platform ANSI escape sequence driver suitable for both testing and actual use. The FakeClipboard utility remains unchanged.
* Rename ANSI* classes to Ansi* and update docs/references
Renamed ANSIInput, ANSIInputProcessor, ANSIOutput, and ANSISizeMonitor to AnsiInput, AnsiInputProcessor, AnsiOutput, and AnsiSizeMonitor for .NET naming consistency. Updated all references, type checks, and XML docs accordingly. Removed the "Extending the Driver System" section from drivers.md, including custom driver registration and implementation examples. No functional changes; this is a naming and documentation refactor.
* Merged and fixed warnings.
* Refine mouse click handling for UI controls
Standardize mouse interactions across controls: single left clicks now activate items (not accept), while double-clicks trigger accept actions. Removed or replaced default single-click bindings to prevent accidental state changes, especially in CheckBox and ColorBar. Improved movement and activation logic in ColorPicker16. These changes make mouse behavior more deliberate and consistent throughout the UI.
* deleted
* No changes detected
No code modifications were made in this commit.
* Rename Enqueue* APIs to Inject*; enhance ANSI key encoding
Renames all Enqueue* input injection APIs and test helpers to Inject* for clarity and consistency (e.g., EnqueueKeyEvent → InjectKeyEvent, AddInput → InjectInput). Updates all interfaces, implementations, and test usages accordingly. Improves AnsiKeyboardEncoder to support correct ANSI escape sequences for function/navigation keys with Shift, Ctrl, and Alt modifiers, including new helper methods and extensive new unit tests for modifier handling and round-trip parsing. Adds ApplicationKeyboardTests to verify integration of injected key events with the application and view event pipeline. Introduces InputTestHelpers for simulating input threads in tests. Updates documentation and comments to reflect new terminology. Refactors and clarifies related unit tests, and marks some as skipped due to known issues. Includes minor code cleanups and formatting improvements.
* Add comprehensive mouse event pipeline tests
Added ApplicationMouseTests.cs to thoroughly test the mouse event pipeline, including injection, ANSI encoding/decoding, input queue processing, and event routing through IApplication.Mouse and View.MouseEvent. Tests cover event propagation, flag and modifier handling, event ordering, mouse enter/leave, mouse state tracking, and disabled mouse scenarios.
Also added InjectAndProcessMouse helper methods to InputTestHelpers to streamline mouse event injection and processing in tests. These changes ensure robust automated coverage of mouse event handling throughout the application's input system.
* lame progress
* Add input injection redesign and fix click threshold bug
Introduce driver-input-injection-redesign.md, detailing a proposed overhaul of Terminal.Gui's input injection and testing architecture. The redesign includes a virtual time system, unified input injection API, refactored input/test architecture, simplified test helpers, and improved integration test support. A migration path and benefits summary are provided.
Add driver-input-injection.md to document the current input injection system, its architecture, and pain points, serving as a baseline for the redesign.
Fix a bug in MouseButtonClickTracker by changing the click threshold comparison from '>' to '>=' for correct double-click detection.
Update Button.OnMouseHoldRepeatChanged to properly manage mouse bindings when toggling hold repeat.
Apply minor formatting and #nullable directive adjustments in Button.cs.
Update ApplicationMouseTests.cs and InputTestHelpers.cs for consistent object initialization and clearer timestamp handling in mouse event injection.
These changes lay the foundation for a more robust, testable, and maintainable input system in Terminal.Gui.
* update input injection spec
Updated driver-input-injection-redesign.md with a comprehensive, implementation-ready specification: added an "AI Agent Prompt," expanded rationale and constraints, provided explicit coding standards, and included a detailed step-by-step implementation checklist. Clarified migration path, success criteria, and the status of disabled tests. The spec now fully supports the upcoming input injection redesign and test migration.
Marked mouse/keyboard input tests as skipped due to #4474, disabling them in ButtonTests, ScrollBarTests, OptionSelectorTests, and GuiTestContextMouseEventTests. Reformatted object initializations in ButtonTests for coding standards compliance.
* Revise mouse behavior specification for clarity
Updated the mouse behavior specification to clarify design principles, button types, and event handling. Added details on ClickCount, MouseHoldRepeat, and visual feedback for buttons.
* Initial plan
* Add core time abstraction and input source interfaces
- Created ITimeProvider, SystemTimeProvider, and VirtualTimeProvider
- Created IInputSource, TestInputSource, and ConsoleInputSource
- Created InputEventRecord types (keyboard, mouse, ANSI)
- All code follows Terminal.Gui coding standards
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Add Input Injector infrastructure
- Created IInputInjector interface with injection modes
- Created InputInjector implementation
- Created InputInjectionExtensions for convenience methods
- Defined InputEvent, KeyEvent, and MouseEvent for sequences
- Integrated with existing IInputProcessor interface
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Update core components to use ITimeProvider
- Updated MouseInterpreter to use ITimeProvider instead of Func<DateTime>
- Updated MouseButtonStateEx to use ITimeProvider
- Updated AnsiResponseParserBase to use ITimeProvider
- All components now support virtual time for testing
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Add validation tests for VirtualTimeProvider
- Created comprehensive tests for virtual time functionality
- Tests verify time advancement, delays, and timers
- All 7 tests passing successfully
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Fix code review feedback - capitalize Copilot comments
- Fixed capitalization of "CoPilot" to "Copilot" in test comments
- Addressing code review feedback
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Fixed bug
* Fix merge conflicts and adapt to v2_4471-Continuous refactoring
- Updated MouseInterpreter to use ITimeProvider instead of Func<DateTime>
- Updated MouseButtonClickTracker to use ITimeProvider
- Changed MouseEventArgs references to Mouse class
- Updated InputInjector to use current IInputProcessor method names (InjectKeyDownEvent, InjectMouseEvent, RaiseMouseEventParsed, RaiseSyntheticMouseEvent)
- Fixed XML documentation warnings
- Build succeeds with 0 errors
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Add FuncTimeProvider and update tests for ITimeProvider compatibility
- Created FuncTimeProvider helper class to wrap Func<DateTime> for backward compat
- Updated all mouse-related tests to use FuncTimeProvider
- Fixed 45+ test instances that were using lambda expressions
- All 7 VirtualTimeProvider tests passing
- Tests build successfully with 0 errors
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Add comprehensive tests for ANSI driver, input, and OSC 8
Introduced new xUnit test files covering the Terminal.Gui ANSI handling layer, including driver, input, parser, encoder, and OSC 8 hyperlinking. Tests verify keyboard and mouse parsing, driver resizing and buffer logic, clipboard, request/response scheduling, and robust URL hyperlink wrapping. All tests are parallelizable, cover edge cases, and improve maintainability of the ANSI infrastructure.
* Fixed namespace
* Fix: Update file name casing for ANSI driver files
* Refactor: add low-level driver tests and test base class
Adds comprehensive low-level and unit tests for Terminal.Gui's driver infrastructure, covering ANSI, Unix, .NET, and Windows backends. Tests include input/output construction, buffer handling, key/mouse event injection, and Unicode/wide character rendering. Introduces OutputBufferWideCharTests for #4466, and TestDriverBase for reusable test driver setup. All tests use xUnit and are organized for platform-specific execution, improving coverage and reliability of driver internals.
* disbled test that fails in GH runners sometimes.
* Phase 5 Part 1: Add ITimeProvider and test mode to Application layer
- Updated Application.Create() to accept optional ITimeProvider parameter
- Added Application.CreateForTesting() factory method with VirtualTimeProvider
- Updated ApplicationImpl constructor to accept ITimeProvider and testMode
- Added GetTimeProvider() method to IApplication interface
- Added GetTimeProvider() implementation in ApplicationImpl
- Build succeeds with 0 errors
Next: Pass ITimeProvider to components (MouseInterpreter, AnsiResponseParser) and wire up TestInputSource in test mode
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Phase 5 Part 2: Wire ITimeProvider through InputProcessor and AnsiResponseParser
- Updated InputProcessorImpl to accept ITimeProvider and pass to MouseInterpreter and AnsiResponseParser
- Updated all derived InputProcessors (Net, Windows, Unix, ANSI) to accept and forward ITimeProvider
- Updated AnsiResponseParserBase to accept ITimeProvider and use it instead of DateTime.Now
- Updated AnsiResponseParser<T> and AnsiResponseParser to pass ITimeProvider to base class
- Build succeeds with 0 errors
Next: Update component factories to accept and pass ITimeProvider, then wire up TestInputSource in test mode
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Fix build errors - add ITimeProvider to test instantiations
- Updated TestDriverBase to pass SystemTimeProvider to AnsiResponseParser and AnsiInputProcessor
- Fixed all test files to pass ITimeProvider (or null) to InputProcessor constructors
- Fixed AnsiResponseParser instantiations in test files to include SystemTimeProvider
- Updated AnsiResponseParserTests class fields and method instantiations
- Build succeeds with 0 errors
- All 7 VirtualTimeProvider tests pass
- All 15 MouseInterpreter tests pass
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Code cleanup.
* warnings
* Phase 5 Part 3: Wire ITimeProvider through component factories
- Updated IComponentFactory.CreateInputProcessor() to accept optional ITimeProvider parameter
- Updated ComponentFactoryImpl abstract class with new signature
- Updated all factory implementations (Ansi, Net, Unix, Windows) to pass ITimeProvider to InputProcessors
- Updated MainLoopCoordinator to accept and pass ITimeProvider to factory
- Updated ApplicationImpl.CreateSubcomponents to pass ITimeProvider to MainLoopCoordinator
- Fixed ApplicationImplTests mock setup for optional parameter in expression tree
- Build succeeds with 0 errors
- All 7 VirtualTimeProvider tests pass
Phase 5 complete: ITimeProvider now fully wired through application layer
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Phase 5 Complete + Phase 6: Input injection examples
Phase 5 completion:
- Added IApplication.GetInputInjector() method
- Added ApplicationImpl.GetInputInjector() implementation
- Added Application.CreateForTesting() factory method
- All infrastructure now complete and wired
Phase 6: Example tests demonstrating simplified API
- Created 7 comprehensive example tests showing new API benefits
- Examples cover: simple injection, virtual time, sequences, combinations, timing
- All 7 tests passing
- Tests demonstrate 60-70% code reduction vs old 3-step pattern
- Examples show deterministic, fast testing without Thread.Sleep
Build: ✅ 0 errors
Tests: ✅ 7/7 example tests passing, 7/7 VirtualTimeProvider tests passing
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Port GuiTestContext to use new input injection infrastructure
- Updated GuiTestContext to use VirtualTimeProvider for deterministic time control
- Ported InjectKeyEvent to use app.InjectKey() (new simplified API)
- Ported InjectMouseEvent to use app.InjectMouse() (new simplified API)
- Updated mouse timestamps to use virtual time instead of DateTime.Now
- Added TimeProvider property to expose VirtualTimeProvider for advanced test scenarios
- Added new ApplicationImpl constructor accepting IComponentFactory, ITimeProvider, and testMode
- All GuiTestContext tests pass (24/24 basic, 59/60 key events, 12/12 mouse events)
- Tests now benefit from virtual time control for deterministic, fast testing
Benefits:
- Tests execute with deterministic time - no more Thread.Sleep
- Virtual time allows testing time-dependent features (double-click, timeouts)
- Simplified injection API reduces test complexity
- Backward compatible - existing tests continue to work
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Fix GetTimeProvider extension method to delegate to interface
Fixed issue where InputInjectionExtensions had duplicate GetTimeProvider/GetInputInjector extension methods that conflicted with interface methods. Removed duplicates and kept only the convenience extension methods (InjectKey, InjectMouse, InjectSequence).
Note: 14 Menu/MenuBar tests are failing but these appear to be pre-existing issues not caused by the GuiTestContext porting. Tests were passing at commit
|
||
Copilot
|
e6a0ec64ca |
Fixes #4361 - Consolidate FakeDriver into library and refactor driver architecture (#4362)
* Initial plan * Add ScreenChanged event, SetScreenSize method, and fix FakeDriver buffer initialization Co-authored-by: tig <585482+tig@users.noreply.github.com> * Add comprehensive tests for ScreenChanged event and buffer integrity Co-authored-by: tig <585482+tig@users.noreply.github.com> * Replace obsolete SizeChanged usage with ScreenChanged in core and tests Co-authored-by: tig <585482+tig@users.noreply.github.com> * Refactor terminal size event handling Replaced `ScreenChanged` with `SizeChanged` across the codebase to standardize naming and improve clarity. Updated event handling logic, including subscriptions, unsubscriptions, and raising methods. Removed deprecated `ScreenChanged` event and backward compatibility code. Refactored driver initialization to handle legacy `IConsoleDriver` types separately. Updated tests and mock implementations to align with the new `SizeChanged` event. Improved documentation and comments to reflect these changes. These updates enhance maintainability, consistency, and modernize the architecture. * Refactor & Code Cleanup: Replace IWindowSizeMonitor with IConsoleSizeMonitor Renamed `IWindowSizeMonitor` to `IConsoleSizeMonitor` across the codebase, updating all references, method signatures, and event handlers. Replaced the `WindowSizeMonitor` class with the new `ConsoleSizeMonitor` implementation, which includes improved terminal size change handling via the `Poll` method. Enabled nullable reference types in several files to enhance code safety. Updated test cases to reflect the new `IConsoleSizeMonitor` interface. Removed redundant code, simplified null checks, and corrected minor typos in comments. Streamlined the codebase by removing the obsolete `WindowSizeMonitor` class and its interface. * Code cleanup - Refactor and enhance ShadowView and FakeDriverTests Updated ShadowView.cs to use null-conditional operators and added null checks for safer access to `ScreenContents`. Refined XML documentation in View.Layout.cs for clarity and consistency. Refactored FakeDriverTests.cs to leverage modern C# features, including shorthand object instantiation, inline lambdas, and tuple-like syntax for `Size` and `Rectangle`. Removed redundant tests and improved test readability and reliability. Enhanced error handling with null checks and ensured backward compatibility for deprecated events. Improved test coverage for resizing, clipboard operations, and invalid coordinates. Verified buffer integrity and screen updates after resizing. General improvements include replacing explicit type declarations with `var`, removing unused imports, and aligning code formatting for better readability. Refactor and improve code quality and test coverage Updated `ShadowView` for null safety using null-conditional operators. Simplified object initializations and modernized syntax across the codebase, including shorthand initializations and inline lambdas. Enhanced event handling logic and ensured compatibility with obsolete members. Refactored `FakeDriverTests` by removing redundant code, standardizing formatting, and improving test setup. Suppressed obsolete warnings where necessary. Improved XML documentation in `View.Layout.cs` for clarity and removed outdated references. Performed general cleanup, including removing unused namespaces, redundant comments, and ensuring consistent formatting. These changes enhance readability, maintainability, and runtime safety. * Code cleanup Refactor TimedEventsTests for readability and consistency Improved code readability and maintainability: - Enabled nullable reference types with `#nullable enable`. - Removed unused `using System.Diagnostics;`. - Updated namespace to `UnitTests.ApplicationTests`. - Replaced `Terminal.Gui.App.TimedEvents` with `TimedEvents`. - Reformatted XML documentation comments for alignment. - Used `var` and target-typed new expressions for consistency. - Reformatted `Parallel.For` loops and lambdas for clarity. - Added `Thread.Sleep(10)` to prevent excessive CPU usage in tests. - Improved assertions and event handler formatting in tests. Aligned with modern C# coding practices. * Code Cleanup - No more driver warnings. Refactor codebase and introduce FakeClipboard - Adjusted `.editorconfig` to change severity levels for CS0612, CS0618, and CS0672 diagnostics. - Replaced `FakeDriver.FakeClipboard` with a new `FakeClipboard` class for testing purposes, supporting exception handling and clipboard data manipulation. - Removed redundant methods (`MakeColor`, `MapKey`) and unused classes (`MockConsoleDriver`) to streamline the codebase. - Refactored `ConsoleDriverFacade` and `FakeDriver` to simplify logic and improve maintainability. - Updated tests to use `CreateFakeDriver` and removed or commented out obsolete tests. - Reformatted and cleaned up code for readability across multiple files. * Refactor FakeDriver - Code Cleanup Standardized console size management by replacing `WindowSizeMonitor` with `ConsoleSizeMonitor` across the codebase. Updated methods `GetWindowSize` and `SetWindowSize` to `GetSize` and `SetSize` for consistency. Refactored `FakeDriver` to use `SetScreenSize` and removed redundant methods. Simplified driver initialization by removing legacy `InternalInit` logic. Standardized ANSI escape sequences by replacing `CSI_ReportTerminalSizeInChars` with `CSI_ReportWindowSizeInChars`. Updated test cases to align with the new `ConsoleSizeMonitor` and `SetScreenSize` methods. Removed obsolete test utilities like `FakeSizeMonitor` and `FakeWindowSizeMonitor`. Performed general code cleanup, including removing unused classes, redundant code, and improving formatting. Fixed resizing logic issues and improved exception handling in driver methods. * Update Terminal.Gui/Drivers/OutputBuffer.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update Terminal.Gui/Drivers/MouseButtonStateEx.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update Terminal.Gui/App/MainLoop/IApplicationMainLoop.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update Tests/UnitTests/Views/ToplevelTests.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update Terminal.Gui/ViewBase/View.Layout.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Moved all Drawing tests to Paralleizable - proving Fakedriver works Enhanced `Ruler` and `Thickness` classes by adding an optional `IConsoleDriver? driver` parameter to decouple rendering from the default `Application.Driver`, improving flexibility and testability. Updated `DriverAssert` to support nullable drivers and added defensive checks. Refactored and expanded test cases for `Ruler`, `Thickness`, `LineCanvas`, and `StraightLineExtensions` to ensure comprehensive coverage, including zero-length intersections, line rendering, and exclusion logic. Migrated rendering-dependent tests to a parallelizable namespace. Removed redundant tests, improved naming conventions, and updated documentation for better maintainability and clarity. * Fixed Run<T> startup hang. Refactor: Simplify driver logic and update SetSize methods Removed FakeDriver safeguard in unit tests to simplify CreateDriver logic. Updated SetSize methods in NetOutput, UnixOutput, and WindowsOutput to do nothing instead of throwing NotImplementedException. Modified SizeChanged event in ConsoleDriverFacade to call SetScreenSize directly. Commented out unnecessary debug validation in DimAuto. These changes improve maintainability and reduce complexity. * Fixed intermittent unit test bug. Refactored `_cachedRunStateToplevel` to `CachedRunStateToplevel` as an internal static property, delegating its management to `ApplicationImpl` for improved encapsulation. Updated all references to use the new property and centralized its handling in `ApplicationImpl`. Removed the `MouseGrabHandler` property from `ApplicationImpl` and simplified driver-related assignments by replacing `Application.ForceDriver` and `Application.Screen` with direct references. Reset `CachedRunStateToplevel` during cleanup to ensure proper state management. Updated the `Invoke` method to use `Top` directly, aligning with the refactored design. Improved debug assertions and performed general cleanup to enhance code readability and maintainability. * Fixed intermittent bug an massive code cleanup of warnings. Refactor and enhance codebase for maintainability - Applied null-conditional operator (`!`) to improve null-safety. - Refactored tests for clarity, added new cases, and removed redundancies. - Introduced `FakeApplicationFactory` and `FakeSizeMonitor` for testing. - Removed unused code, including legacy `DecodeEscSeq` logic. - Reformatted code for readability and consistency. - Updated assertions for more accurate validation in tests. - Fixed potential null reference issues across multiple files. - Improved event handling with proper null checks. - Enhanced documentation for new classes and methods. - Modernized code with C# features like `record struct` and `nullable enable`. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: tig <585482+tig@users.noreply.github.com> Co-authored-by: Tig <tig@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> |
||
BDisp
|
d3f4c42785 |
Fixes 4132. .editorconfig has ambiguous configuration with same files (#4133)
Co-authored-by: Tig <tig@users.noreply.github.com> |
||
|
Tig
|
764a804ddd | Fixes #3209 - Formalize Cancellable Work Pattern and add helpers (#4092) | ||
dodexahedron
|
c94c0567dd |
Fixes #3240: editorconfig and project documentation sync with reformatting (#3241)
* Removed resharper settings from editorconfig * Remove constructors with frame parameters from Button class. * Remove constructors with frame parameters from CheckBox class. * Cleanup code. * Remove constructors with frame parameters from ComboBox class. * @BDisp Remove constructors with frame parameters from FrameView class. * Remove constructors with frame parameters from Label class. * Remove constructors with frame parameters from ListView class. * Remove constructors with frame parameters from ScrollBarView class. * Remove constructors with frame parameters from ScrollView class. * Remove namespace braces. * Cleanup code. * Cleanup code. * Cleanup code. * Remove constructors with frame parameters from TextField class. * Remove constructors with frame parameters from TimeField class. * Fixes #3182. OnResizeNeeded returns int.MaxValue and int.MaxValue when Application.Top is null, should return Size.Empty. * Remove constructors with frame parameters from Toplevel class. * Remove constructors with frame parameters from Window class. * Fix merge errors. * Revert "Fixes #3182. OnResizeNeeded returns int.MaxValue and int.MaxValue when Application.Top is null, should return Size.Empty." This reverts commit |
||
|
Tig
|
4430fe2cc6 |
Fixes #3192. Improve correctness / clarity of existing View.AutoSize functionality/unit tests (#3202)
* Removed resharper settings from editorconfig * Remove constructors with frame parameters from Button class. * Remove constructors with frame parameters from CheckBox class. * Cleanup code. * Remove constructors with frame parameters from ComboBox class. * @BDisp Remove constructors with frame parameters from FrameView class. * Remove constructors with frame parameters from Label class. * Remove constructors with frame parameters from ListView class. * Remove constructors with frame parameters from ScrollBarView class. * Remove constructors with frame parameters from ScrollView class. * Remove namespace braces. * Cleanup code. * Cleanup code. * Cleanup code. * Remove constructors with frame parameters from TextField class. * Remove constructors with frame parameters from TimeField class. * Fixes #3182. OnResizeNeeded returns int.MaxValue and int.MaxValue when Application.Top is null, should return Size.Empty. * Remove constructors with frame parameters from Toplevel class. * Remove constructors with frame parameters from Window class. * Fix merge errors. * Revert "Fixes #3182. OnResizeNeeded returns int.MaxValue and int.MaxValue when Application.Top is null, should return Size.Empty." This reverts commit |
||
|
Tig
|
4cc6339192 | Removed resharper settings from editorconfig (#3153) | ||
|
Tig
|
c6570a5bfd |
Fixes #3098 & #3099 - Slider bugs (#3121)
* Fixed bugs * Fixed #3098 * Fixed a slew of issues * Fixed a slew more of issues * Code cleanup. Fixed unit test failure * Code cleanup. * Code cleanup. * Code cleanup. |
||
|
Tig
|
dcb3b359ad |
Fixes #2926 - Refactor KeyEvent and KeyEventEventArgs to simplify (#2927)
* Adds basic MainLoop unit tests * Remove WinChange action from Curses * Remove WinChange action from Curses * Remove ProcessInput action from Windows MainLoop * Simplified MainLoop/ConsoleDriver by making MainLoop internal and moving impt fns to Application * Modernized Terminal resize events * Modernized Terminal resize events * Removed un used property * for _isWindowsTerminal devenv->wininit; not sure what changed * Modernized mouse/keyboard events (Action->EventHandler) * Updated OnMouseEvent API docs * Using WT_SESSION to detect WT * removes hacky GetParentProcess * Updates to fix #2634 (clear last line) * removes hacky GetParentProcess2 * Addressed mac resize issue * Addressed mac resize issue * Removes ConsoleDriver.PrepareToRun, has Init return MainLoop * Removes unneeded Attribute methods * Removed GetProcesssName * Removed GetProcesssName * Refactored KeyEvent and KeyEventEventArgs into a single class * Revert "Refactored KeyEvent and KeyEventEventArgs into a single class" This reverts commit |
||
|
Tig
|
b4552ee14b |
Fixes #2493. Move all layout code out of View (and Toplevel) into a layout helper class (#2544)
* Comment/warning clean up * Moved Text and Drawing out * Moved Layout out * Removed extra lines * Removed Mouse out * Reorgainzed View * API docs * removed border.cs * TopLevel.Resized -> TerminalResized * Mdi -> Overlapped * Removed confusing and un-needed WillPresent * privates -> _ * Tweaked RunLoop API |
||
|
BDisp
|
8a6c2a9fc1 |
Mouse events menu (#401)
* Fixes an issue in the sln file that despite not having been changed, git reports as changed. * Adding some settings for crlf and user specific. * Prevent button clicked event if the point of the pressed and released don't match. Also decreases the delay for the triple click. * Changes the menu button clicked event to button pressed to improve mouse clicks. * Removed the action that was running all the time after the first running. |
||
|
BDisp
|
49cd29853f |
All my pull-request at once (#345)
* Fixed key events traversal for modal dialogs The key must be propagated initially to the first chain element before evaluating if we should stop because of the handled or the Modal condition. Otherwise the modal dialog won't get any process key notification. This fixes |
||
Daniel Cazzulino
|
a7c8594721 |
Add indent_size which is honored by VS2019 and behaves like tab_width (#285)
`indent_size` came before `tab_width` and the latter is basically a fallback for the former, as far as I can understand https://github.com/microsoft/vscode-editorconfig/blob/master/src/editorConfigMain.ts#L248. However, VS behaves weirdly when one is defined and not the other. It gets the tabs completely wrong. If both have the same value, however, it works as expected. So make it easy for contributors on VS to contribute by adding this value. Hopefully, this will be a no-op on VSM. |
||
miguel
|
d0e187585e | Refactor the windows driver to avoid the races | ||
|
miguel
|
c5a3b7b01e | Split Mainloop into Unix, Net and Windows drivers so we can properly implement Windows input | ||
|
miguel
|
59a546f462 | Add |