* Initial plan
* Refactor tests to use modern ApplicationImpl.Coordinator architecture instead of legacy Application.RunIteration
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Changes before error encountered
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Replace Application.RunIteration implementation to use modern ApplicationImpl.Coordinator architecture
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Simplify Application.RunIteration to directly delegate to ApplicationImpl.Coordinator without legacy infrastructure
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Update multitasking.md documentation to use Application.AddTimeout/RemoveTimeout instead of deprecated Application.MainLoop methods
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Refactor contribution guidelines and documentation
- Consolidated all contribution-related instructions into `CONTRIBUTING.md` as the single source of truth.
- Updated `copilot-instructions.md` and `AGENTS.md` to reference `CONTRIBUTING.md`.
- Enhanced build, test, and CI/CD workflow documentation.
- Updated repository structure documentation in `README.md` and `CONTRIBUTING.md`.
- Reinforced coding conventions and streamlined testing requirements.
- Documented GitHub Actions workflows and provided local CI replication steps.
- Refined API documentation requirements and PR guidelines.
- Simplified `.sln` file and removed redundant content.
- Updated links to point to the latest documentation resources.
* Revamp bug report template for clarity and detail
Updated the bug report template to improve structure, readability, and comprehensiveness:
- Specified "Terminal.Gui" in the `about` section.
- Replaced bold headings with Markdown heading syntax.
- Enhanced "To Reproduce" with placeholders for code and behavior details.
- Added an "Environment" section to collect OS, terminal, PowerShell, .NET, and `Terminal.Gui` version details.
- Expanded "Screenshots" to include GIFs and terminal output instructions.
- Removed outdated "Desktop" and "Smartphone" sections, consolidating relevant details.
- Improved "Additional Context" with prompts for consistency, prior behavior, and error messages.
- Streamlined "For Maintainers" instructions for setting project and milestone.
These changes aim to make bug reports more actionable and easier to reproduce.
* Remove [Obsolete] attribute and pragma warnings from Application.RunIteration - method now uses modern architecture internally
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Refactor Application.Run.cs for clarity and cleanup
Removed debug assertions and unused/commented-out code to simplify logic and improve maintainability. Renamed `forceDraw` to `forceRedraw` in `LayoutAndDraw` for better clarity. Removed the internal `OnNotifyStopRunState` method and its associated logic, indicating a refactor of the stop notification mechanism.
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Tig <tig@users.noreply.github.com>
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Initial plan
* Refactor Application.Mouse - Create IMouse interface and Mouse implementation
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Add enhanced documentation for Application.Mouse property
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Add parallelizable unit tests for IMouse interface
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Refactor Application.Mouse for decoupling and parallelism
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Move HandleMouseGrab method to IMouseGrabHandler interface
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Add parallelizable tests for IMouse and IMouseGrabHandler interfaces
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Add MouseEventRoutingTests - 27 parallelizable tests for View mouse event handling
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Fix terminology: Replace parent/child with superView/subView in MouseEventRoutingTests
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Fix coding standards: Use explicit types and target-typed new() in test files
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Update coding standards documentation with explicit var and target-typed new() guidance
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Refactor Application classes and improve maintainability
Refactored `Sixel` property to be immutable, enhancing thread safety.
Cleaned up `ApplicationImpl` by removing redundant fields, restructuring
methods (`CreateDriver`, `CreateSubcomponents`), and improving exception
handling. Updated `Run<T>` and `Shutdown` methods for consistency.
Standardized logging/debugging messages and fixed formatting issues.
Reorganized `IApplication` interface, added detailed XML documentation,
and grouped related methods logically.
Performed general code cleanup, including fixing typos, improving
readability, and removing legacy/unnecessary code to reduce technical debt.
* Code cleanup
* Remove unreferenced LayoutAndDraw method from ApplicationImpl
* Code cleanup and TODOs
- Updated namespaces to reflect the new structure.
- Added `Driver`, `Force16Colors`, and `ForceDriver` properties.
- Introduced `Sixel` collection for sixel image management.
- Added lifecycle methods: `GetDriverTypes`, `Shutdown`, and events.
- Refactored `Init` to support legacy and modern drivers.
- Improved driver event handling and screen abstraction.
- Updated `Run` method to align with the application lifecycle.
- Simplified `IConsoleDriver` documentation.
- Removed redundant methods and improved code readability.
* Refactor LayoutAndDraw logic for better encapsulation
Refactored `Application.Run` to delegate `LayoutAndDraw` to
`ApplicationImpl.Instance.LayoutAndDraw`, improving separation
of concerns. Renamed `forceDraw` to `forceRedraw` for clarity
and moved `LayoutAndDraw` implementation to `ApplicationImpl`.
Added a new `LayoutAndDraw` method in `ApplicationImpl` to
handle layout and drawing, including managing `TopLevels`,
handling active popovers, and refreshing the screen. Updated
the `IApplication` interface to reflect the new method and
improved its documentation.
Implemented `RequestStop` in `ApplicationImpl` and fixed
formatting inconsistencies in `Run<T>`. Added TODOs for future
refactoring to encapsulate `Top` and `TopLevels` into an
`IViewHierarchy` and move certain properties to `IApplication`.
* Refactor ApplicationImpl to enhance mouse and keyboard support
Added a new `Mouse` property to the `ApplicationImpl` class,
replacing its previous declaration, to improve mouse
functionality. Updated `MouseGrabHandler` to initialize with
a default instance of `MouseGrabHandler`.
Added comments to ensure the preservation of existing keyboard
settings (`QuitKey`, `ArrangeKey`, `NextTabKey`) for backward
compatibility. These changes enhance clarity, functionality,
and maintainability of the class.
* Merge IMouseGrabHandler into IMouse - consolidate mouse handling into single interface
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Rename Mouse to MouseImpl and Keyboard to KeyboardImpl for consistency
Co-authored-by: tig <585482+tig@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: tig <585482+tig@users.noreply.github.com>
Co-authored-by: Tig <tig@users.noreply.github.com>
* Refactor Scrolling.cs for timer management and nullability
Enabled nullable reference types with `#nullable enable` for improved safety. Replaced the `pulsing` flag with a new `_progressTimer` object to better manage the progress bar's timer lifecycle. Updated `AppOnInitialized` and `AppUnloaded` methods to handle timer initialization and cleanup properly, preventing potential memory leaks.
Simplified code by removing unnecessary comments and aligning method signatures with nullable reference type annotations.
* Enable nullable types and add debugging utilities
* Runu tests 5 times
* Adjust abortTime in ScenarioTests to 1800
* Revert "Runu tests 5 times"
This reverts commit b9b5282315.
* Improve CI diagnostics and adjust scenario abort time
* Fix typos, update metadata,
Corrected typos in `ScenarioCategory` and comments in `Mazing.cs`.
Added the `System.Text` namespace to support additional functionality.
Introduced a new "Games" category in `ScenarioCategory`.
Updated `.DotSettings` to include "Mazing" in the user dictionary.
Improved overall code comments and metadata for clarity.
* Remove unnecessary null assertion for _progressTimer
* Update Examples/UICatalog/Scenarios/Scrolling.cs
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
---------
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Initial plan
* Remove legacy drivers and reorganize v2 architecture
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Extract Windows key helper utilities and fix build
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Fix all test references to legacy drivers
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Update documentation to reflect new driver architecture
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Remove V2.cd diagram file
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Fix test failures: support legacy drivers and update exception handling
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* updated driver names
* Move V2 tests from ConsoleDrivers/V2 to proper locations
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Rename ApplicationV2 to ModernApplicationImpl to remove v2 terminology
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Remove V2 terminology from test drivers and FakeDriver classes
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Merge ModernApplicationImpl into ApplicationImpl and move to App folder
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Create modern FakeDriver with component factory architecture in Terminal.Gui project
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Refactor: Move non-platform-dependent code from /Drivers to /App
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Code cleanup and org
* Unit test reorg
* Refactor MainLoop architecture: rename classes and enhance documentation for clarity
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Add comprehensive FakeDriver tests (WIP - some tests need fixes)
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Fixed FakeDriver build failures
* Fix all FakeDriver test failures - Application.Top creation and clipboard behaviors
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Fixed FakeDriver build failures2
* Remove hanging legacy FakeDriver tests that use Console.MockKeyPresses
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Fixed some tests
* Fixed more tests
* Fixed more tests
* Fix bad copilot (#4277)
* Update Terminal.Gui/Drivers/FakeDriver/FakeConsoleOutput.cs
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Refactor Application Init and Update Tests
Refactored `Application.Init` to improve initialization logic:
- Added fallback to `ForceDriver` when `driverName` is null.
- Changed repeated `Init` calls to throw `InvalidOperationException`.
- Updated `_driverName` assignment logic for robustness.
Enhanced `IConsoleDriver` with detailed remarks on implementations.
Revised test cases to align with updated `Application.Init` behavior:
- Replaced `FakeDriver` with `null` and `driverName: "fake"`.
- Skipped or commented out tests incompatible with new logic.
- Improved formatting and removed redundant setup code.
Improved code style and consistency across the codebase:
- Standardized parameter formatting and spacing.
- Removed outdated comments and unused code.
General cleanup to enhance readability and maintainability.
* Warp fix copilot (#4278)
* More fixes (#4279)
* Fixes/works around test failures and temporarily disable failing test
Updated `FakeDriver` to set `RunningUnitTests` to `true` and initialize dimensions using `FakeConsole`. Modified `TestRespondersDisposedAttribute` to set `ConsoleDriver.RunningUnitTests` in the `Before` method, ensuring proper behavior during unit tests.
Temporarily disabled the `Button_CanFocus_False_Raises_Accepted_Correctly` test in `ViewCommandTests` by adding a `Skip` parameter to the `[Fact]` attribute, referencing issue #4270.
* Allow all tests to run despite failures in UnitTests
Modified the `dotnet test` command in the `Run UnitTestsParallelizable` step to set `xunit.stopOnFail` to `false`. This ensures that the test runner does not stop execution on the first failure, allowing all tests to execute regardless of individual test outcomes.
* Refactor ApplicationScreenTests for cleaner setup/teardown
Refactored `ClearContents_Called_When_Top_Frame_Changes` test:
- Added `[AutoInitShutdown]` attribute for automatic lifecycle management.
- Replaced manual `Application.Init` and `Application.Top` setup with `Application.Begin` and `RunState`.
- Simplified event handling by defining `ClearedContents` handler inline.
- Removed explicit cleanup logic, relying on `Application.End` for teardown.
Updated `using` directives to include `UnitTests` namespace.
* Attempt to fix intermittent local test failures.
Update ApplicationImpl initialization parameter
Changed the second parameter of the `impl.Init` method in the
`FakeApplicationFactory` class from `"dotnet"` to `"fake"`.
* Code cleanup to cause Action to re-run.
* Stop tests on first failure in UnitTestsParallelizable
Updated the `dotnet test` command in `unit-tests.yml` to set the `xunit.stopOnFail` parameter to `true`. This change ensures that test execution halts immediately upon encountering a failure, allowing quicker identification and resolution of issues. Note that this may prevent the full test suite from running in the event of a failure.
* Allow all tests to run despite failures in CI
Updated `unit-tests.yml` to set `xunit.stopOnFail` to `false`
in both `Run UnitTests` and `Run UnitTestsParallelizable`
steps. This ensures that the test runner does not stop
execution on the first test failure, allowing all tests
to complete even if some fail.
* Enhance RuneExtensions docs and update user dictionary
Updated the `<remarks>` section in `RuneExtensions.GetColumns` to include details about the `wcwidth` implementation and improved readability with `<para>` tags. Added `wcwidth` to the user dictionary in `Terminal.sln.DotSettings` to avoid spelling errors.
* Improve XML doc formatting in RuneExtensions.cs
Updated the remarks section of the `GetColumns` method in the
`RuneExtensions` class to enhance readability by reformatting
and properly indenting `<para>` tags. The content remains
unchanged, describing the method's implementation via `wcwidth`
and its role as a Terminal.Gui extension for `System.Text.Rune`.
* Refactor drivers and improve clipboard handling
Replaced legacy drivers (`CursesDriver`, `NetDriver`) with
`UnixDriver` and `DotNetDriver` across the codebase, including
comments, method names, and test cases. Updated documentation
and remarks to reflect the new driver names and platforms.
Revamped clipboard handling with new platform-specific
implementations: `UnixClipboard` for Unix, `MacOSXClipboard`
for macOS, and `WSLClipboard` for Linux under WSL. Removed
the old `CursesClipboard` and consolidated clipboard logic.
Updated test cases to align with the new drivers and clipboard
implementations. Improved naming consistency and cleaned up
redundant code. Updated the README and documentation to
reflect these changes.
* Remove `PlatformColor` from `Attribute` struct
This commit removes the `PlatformColor` property from the `Attribute` struct, simplifying the codebase by eliminating platform-specific color handling. The following changes were made:
- Removed `PlatformColor` from the `Attribute` struct, including its initialization, usage, and related comments.
- Updated constructors to no longer initialize or use `PlatformColor`.
- Modified `Equals` and `GetHashCode` methods to exclude `PlatformColor`.
- Updated `UnixComponentFactory` documentation to remove references to "v2unix."
- Renamed `v2TestDriver` to `testDriver` in the `With` class for clarity.
- Removed `PlatformColor` references in `DriverAssert` and related error messages.
- Deleted test cases in `AttributeTests` that relied on `PlatformColor`.
- Cleaned up comments and TODOs related to `PlatformColor` and `UnixDriver`.
These changes reflect a shift away from platform-dependent color management, improving code clarity and reducing complexity.
Remove `PlatformColor` and simplify `Attribute` logic
The `PlatformColor` property has been removed from the `Attribute` struct, along with its associated logic, simplifying the codebase and eliminating platform-specific dependencies. Constructors, equality checks, and hash code generation in `Attribute` have been updated accordingly.
The `CurrentAttribute` property in `ConsoleDriver` and `OutputBuffer` has been simplified, removing dependencies on `Application.Driver`. The `MakeColor` method logic has been removed or simplified in related classes.
Tests in `AttributeTests` have been refactored to reflect these changes, focusing on `Foreground`, `Background`, and `Style`. Unix-specific logic tied to `PlatformColor` has been eliminated.
Additional updates include renaming parameters in the `With` class for clarity, simplifying `DriverAssert` output, and performing minor code cleanups to improve readability and maintainability.
* Refactor Terminal.Gui driver architecture for v2
Updated documentation to reflect the new modular driver architecture in Terminal.Gui v2.
- Revised `namespace-drivers.md` to include new components (`IConsoleInput`, `IConsoleOutput`, `IInputProcessor`, `IOutputBuffer`, `IWindowSizeMonitor`) and terminal size monitoring.
- Replaced "Key Components" with "Architecture Overview" and added details on the **Component Factory** pattern.
- Documented the four driver implementations (`DotNetDriver`, `WindowsDriver`, `UnixDriver`, `FakeDriver`) and their platform-specific optimizations.
- Added a "Threading Model" section to explain the multi-threaded design for responsive input handling.
- Updated examples to demonstrate driver capabilities and explicit driver selection.
In `drivers.md`:
- Expanded the "Overview" to emphasize the modular, component-based architecture.
- Reorganized "Drivers" into "Available Drivers" and added details on `FakeDriver` for unit testing.
- Added sections on "Initialization Flow," "Shutdown Flow," and platform-specific driver details.
- Provided examples for accessing driver components and creating custom drivers.
In `index.md`:
- Updated "Cross Platform" feature to reflect new driver names and clarified compatibility with SSH and monochrome terminals.
* Moved files around
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: tig <585482+tig@users.noreply.github.com>
Co-authored-by: Tig <tig@users.noreply.github.com>
Co-authored-by: Thomas Nind <31306100+tznind@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Fixes#4116. NativeAot and SelfContained projects aren't working well in release mode
* Revert delete nuget package because it fail in the git actions
* Trying automatize the nuget package installation
* Fixing UserProfile
* Trying fix push package for Unix OS
* Still triying to push nuget to the Unix
* Trying delete nuget package in the Pack target
* Trying fix git actions for release build
* Fix projects path
* Still fixing restore
* Add restore force parameter
* Build NativeAot and SelfContained projects before solution
* Build solution without restore
* Restore solutions packages before build
* Call dotnet restore before build the AOT and self-contained projects
* Remove unneeded run
* Revert "Remove unneeded run"
This reverts commit e04498d1ce.
* Trying fix racing fail unit tests
---------
Co-authored-by: Tig <tig@users.noreply.github.com>
* Tons of API doc updates
* Removed stale test
* Removed stale tests
* Fixed Skipped Shadow test 1
* Fixed Skipped Shadow test 2
* Fixed Skipped Shadow test 3
* Removed stale test
* Removed stale test2
* Explicit unregister of event handler on Application.Driver!.ClearedContents
* Added Toplevels to dict
* code cleanup
* spelling error
* Removed stale test3
* Removed stale test4
* Removed stale test5
* added script
* tweaked script
* tweaked script
* Created StressTests project; moved some tests
* Created IntegrationTests project; moved some tests
* New yml
* made old yml just unit tests
* Tweaked Button_IsDefault_Raises_Accepted_Correctly
* tweaked script
* cleaned up ymls
* tweakled up ymls
* stress tests...
* stress tests on ubuntu only
* Fixed WindowsDriver in InvokeLeakTest
* Fixed WindowsDriver in InvokeLeakTest2
* Added Directory.Packages.props.
Added Directory.Build.props
* Shortened StressTest time
* Removed dupe file.
* DemoFiles
* Moved all tests to ./Tests dir.
* Fixed release build issue
* Fixed .sln file
* Fixed .sl* files
* Fixing ymls
* Fixing interation tests
* Create link to the file TestHelpers.
* Created Tests/UnitTestsParallelizable.
Moved all obviously parallelizable tests.
Updated yml.
* fixing logs
* fixing logs2
* fixing logs3
* don't require stress to pass for PRs
* Fix a failure?
* tweaked script
* Coudl this be it?
* Moved tons of tests to parallelizable
* Fixed some stuff
* Script to find duplicate tests
* Testing workflows
* Updated to v4
* Fix RelativeBasePath issue
* Replace powershell to pwsh
* Add ignore projects.
* Removed dupe unit tests
* Code cleanup of tests
* Cleaned up test warnings
* yml tweak
* Moved setter
* tweak ymls
* just randomly throwing spaghetti at a wall
* Enable runing 5 test runners in par
* Turned off DEBUG_DISPOSABLE for par tests
* RunningUnitTests=true
* code cleanup (forcing more Action runs)
* DISABLE_DEBUG_IDISPOSABLE
* Added View.DebugIDisposable. False by default.
* Remobed bogus tareet
* Remobed bogus tareet2
* fixed warning
* added api doc
* fixed warning
* fixed warning
* fixed warning2
* fixed warning3
* fixed warning4
---------
Co-authored-by: BDisp <bd.bdisp@gmail.com>
* Fixes#3784. SelfContained and NativeAot projects should use the local package in the release mode.
* Run dotnet restore before build.
* Using local_packages folder for CI.
* Add build_release_consumer.
* Remove build_release_consumer.
* Fix folder for CI.
* Fix System.Text.Json vulnerability.
* Fix local_packageslocation.
* Add package sources to the packageSourceMapping tag.
* Using the original configuration.
* Only add the Terminal.Gui pattern in the LocalPackages.
* Fix the path folder separator with unit style.
* Using pack instead of build.
* Create LocalPackages Directory
* Add local_packages source.
* Using scripts to build release for NativeAot and SelfContained.
* Trying to fix path.
* Again.
* Fix the path for the package,
* Need to build before pack.
* Needs also build before pack locally.
* Fix build path.
