Commit Graph

200 Commits

Author SHA1 Message Date
Tig
6851b42a49 Fixes #2921 - MainLoop refactoring (#2922)
* Adds basic MainLoop unit tests

* Remove WinChange action from Curses

* Remove WinChange action from Curses

* Remove ProcessInput action from Windows MainLoop

* Simplified MainLoop/ConsoleDriver by making MainLoop internal and moving impt fns to Application

* Modernized Terminal resize events

* Modernized Terminal resize events

* Removed un used property

* for _isWindowsTerminal devenv->wininit; not sure what changed

* Modernized mouse/keyboard events (Action->EventHandler)

* Updated OnMouseEvent API docs

* Using WT_SESSION to detect WT

* removes hacky GetParentProcess

* Updates to fix #2634 (clear last line)

* removes hacky GetParentProcess2

* Addressed mac resize issue

* Addressed mac resize issue

* Removes ConsoleDriver.PrepareToRun, has Init return MainLoop

* Removes unneeded Attribute methods

* Removed GetProcesssName

* Removed GetProcesssName

* Refactored KeyEvent and KeyEventEventArgs into a single class

* Revert "Refactored KeyEvent and KeyEventEventArgs into a single class"

This reverts commit 88a00658db.

* Fixed key repeat issue; reverted stupidity on 1049/1047 confusion

* Updated CSI API Docs

* merge
2023-10-21 08:06:04 -07:00
BDisp
8ea6b105fc Fixes #2923. Ensures only clear Instances if they really was disposed. (#2924)
* Fixes #2923. Ensures only clear Instances if they really was disposed and fix unit tests.

* Add Ubuntu-20.04.

* xunit nuget package update.
2023-10-20 11:13:55 -06:00
Tig
2007f3b2d5 Adds Slider View (#2919)
* Ported to v2

* Fixed scneario - config

* Lots of goodness

* Lots of goodness

* Code cleanup

* Fixed mouse dragging

* Removed Header and margin stuf

* Removed Header and margin stuf

* Removed Header and margin stuf

* Fixed keyboard

* upgraded xunit

* Action -> EventHandler

* Got Range working correctly

* Added starter set of unit tests

* Cleans up dim/pos objs in dispose. See #2914.

* Fixed merge issues; renamed SliderOrientation and added changed event
2023-10-17 13:21:36 -04:00
tznind
e3323ec8c6 Remove use of HotFocus completely from TableView 2023-10-14 08:08:33 -06:00
tznind
46b9a15641 Use Focus not HotFocus for TableView selected cells 2023-10-14 08:08:33 -06:00
Tig Kindel
03c16fe893 ColorNames->ColorName 2023-10-13 23:58:49 -06:00
Tigger Kindel
c9ce86578c Removed GetColors (no longer needed) 2023-10-13 23:58:49 -06:00
Tigger Kindel
59339ebe22 Removed Attribute.Make (use new) 2023-10-13 23:58:49 -06:00
Tigger Kindel
4e89fae8c6 Fixed ColorPicker test failure 2023-10-13 23:58:49 -06:00
Tigger Kindel
4b51a912be Fixed ColorPicker test failure 2023-10-13 23:58:49 -06:00
Tigger Kindel
a8900a0b8c Disabled invalid Task.Delay calls 2023-10-13 23:58:49 -06:00
Tig Kindel
26580aca6a inital commit - proving Color can be made a class without breaking tons of code 2023-10-13 23:58:49 -06:00
Tigger Kindel
1c133ba364 Refactored CheckTimers into MainLoop and renamed/simplified 2023-10-05 22:21:59 -06:00
Tigger Kindel
bf606c4179 Moved CheckTimers to MainLoop 2023-10-05 22:21:59 -06:00
Tigger Kindel
05e203c7a4 lots of fixes 2023-10-04 06:42:47 -06:00
Tig
488542c869 Merge pull request #2844 from BDisp/v2_menu-can-execute-false-fix_2787
Fixes #2787. MenuItem with CanExecute returning false is select when a MenuBar is opened.
2023-09-29 11:22:56 -06:00
Tig
8b514dc313 Merge pull request #2845 from MaciekWin3/v2_develop
Fixes #2824. Add SearchText property to combobox in v2
2023-09-29 11:20:07 -06:00
Tig
0a0efe103a Merge pull request #2846 from BDisp/v2_alt-key-on-toplevel-with-menubar-fix_2810
Fixes #2810. Pressing Alt key on a Toplevel with only a MenuBar throws System.InvalidOperationException.
2023-09-29 11:19:52 -06:00
Tig
5ef85b6cfb Merge branch 'v2_develop' into v2_develop 2023-09-29 11:15:48 -06:00
Tig
6ffcaf46db Merge branch 'v2_develop' into v2_menu-can-execute-false-fix_2787 2023-09-29 11:15:37 -06:00
Tig
dd8ed4d0bf Merge pull request #2843 from BDisp/v2_statusitem-can-execute-fix_2789
Fixes #2789. StatusItem should have a disabled attribute if it can't execute.
2023-09-29 11:15:03 -06:00
Tig
63767a87bd Merge branch 'v2_develop' into v2_develop 2023-09-29 11:11:57 -06:00
RoxCian
e384b44d5a Fix unit test.
Fix an issue about date time formatting under non en-US culture in DateFieldTest.
2023-09-22 13:47:13 +08:00
BDisp
0829a81249 Merge branch 'v2_develop' into v2_alt-key-on-window-with-menubar-fix_2776 2023-08-31 16:39:10 +01:00
maciekwin3
ffea15f66b Add SearchText property to combobox 2023-08-31 10:44:51 +02:00
BDisp
1f5953b8ba Fixes #2787. MenuItem with CanExecute returning false is select when a MenuBar is opened. 2023-08-30 23:06:20 +01:00
BDisp
b70a16ab28 Fixes #2789. StatusItem should have a disabled attribute if it can't execute. 2023-08-30 22:25:00 +01:00
BDisp
b9f476a26d Fixes #2836. RequestStop while a ContextMenu is open can throw an exception. 2023-08-30 19:50:01 +01:00
BDisp
c50f92bf8e Reformatting. 2023-08-15 18:52:01 +01:00
BDisp
5a11b88f52 v2 Fixes #2810. Pressing Alt key on a Toplevel with only a MenuBar throws System.InvalidOperationException. 2023-08-15 18:31:54 +01:00
Tig
0df485a890 Fixes #666. Refactor ConsoleDrivers to simplify and remove duplicated code (#2612)
* Added ClipRegion; cleaned up driver code

* clip region unit tests

* api docs

* Moved color stuff from ConsoleDriver to Color.cs

* Removes unused ConsoleDriver APIs

* Code cleanup and Removes unused ConsoleDriver APIs

* Code cleanup and Removes unused ConsoleDriver APIs

* Work around https://github.com/gui-cs/Terminal.Gui/issues/2610

* adjusted unit tests

* initial commit

* Made Rows, Cols, Top, Left virtual

* Made Clipboard non-virtual

* Made EnableConsoleScrolling  non-virtual

* Made Contents non-virtual

* Pulled Row/Col up

* Made MoveTo virtual; fixed stupid FakeDriver cursor issue

* Made CurrentAttribute non-virtual

* Made SetAttribute  non-virtual

* Moved clipboard code out

* Code cleanup

* Removes dependecy on NStack from ConsoleDrivers - WIP

* Fixed unit tests

* Fixed unit tests

* Added list of unit tests needed

* Did some perf testing; tweaked code and charmap to address

* Brough in code from PR #2264 (but commented)

* Tons of code cleanup

* Fighting with ScrollView

* Fixing bugs

* Fixed TabView tests

* Fixed View.Visible test that was not really working

* Fixed unit tests

* Cleaned up clipboard APIs in attempt to track down unit test failure

* Add Cut_Preserves_Selection test

* Removed invalid code

* Removed invalid test code; unit tests now pass

* EscSeq* - Adjusted naming, added more sequences, made code more consistent, simplified, etc...

* Added CSI_SetGraphicsRendition

* NetDriver code cleanup

* code cleanup

* Cleaned up color handling in NetDriver

* refixed tabview unit test

* WindowsDriver color code cleanup

* WindowsDriver color code cleanup

* CursesDriver color code cleanup

* CursesDriver - Adding _BOLD has no effect. Further up the stack we cast the return of ColorToCursesColor from int to short and the _BOLD values don't fit in a short.

* CursesDriver color code - make code more accurate

* CursesDriver color code - make code more accurate

* Simplified ConsoleDriver.GetColors API

* Simplified ConsoleDriver.GetColors API further

* Improved encapslation of Attribute; prep for TrueColor & other attributes like blink

* Fixes #2249. CharacterMap isn't refreshing well non-BMP code points on scroll.

* Use GetRange to take some of the runes before convert to string.

* Attempting to fix unit tests not being cleaned up

* Fixes #2658 - ConsoleDriver.IsRuneSupported

* Fixes #2658 - ConsoleDriver.IsRuneSupported (for WindowsDriver)

* Check all the range values and not only the max value.

* Reducing code.

* Fixes #2674 - Unit test process doesn't exit

* Changed Cell to support IsDirty and list of Runes

* add support for rendering TrueColor output on Windows merging veeman & tznind code

* add colorconverter changes

* fixed merged v2_develop

* Fixing merge bugs

* Fixed merge bugs

* Fixed merge bugs - all unit tests pass

* Debugging netdriver

* More netdriver diag

* API docs for escutils

* Update unicode scenario to stress more stuff

* Contents: Now a 2D array of Cells; WIP

* AddRune and ClearContents no longer virtual/abstract

* WindowsDriver renders correctly again

* Progress on Curses

* Progress on Curses

* broke windowsdriver

* Cleaned up FakeMainLoop

* Cleaned up some build warnings

* Removed _init from AutoInitShutdown as it's not needed anymore

* Removed unused var

* Removed unused var

* Fixed nullabiltiy warning in LineCanvas

* Fixed charmap crash

* Fixes #2758 in v2

* Port testonfail fix to v2

* Remove EnableConsoleScrolling

* Backport #2764 from develop (clear last line)

* Remove uneeded usings

* Progress on unicode

* Merged in changes from PR #2786, Fixes #2784

* revamp charmap rendering

* Charmap option to show glyph widths

* Fixed issue with wide glpyhs being overwritten

* Fixed charmap startcodepoint change issue

* Added abiltiy to see ncurses verison/lib

* Fought with CursesDriver; giving up for now. See notes.

* Leverage Wcwidth nuget library instaed of our own tables

* enhanced charmap Details dialog

* Final attempt at fixing curses

---------

Co-authored-by: BDisp <bd.bdisp@gmail.com>
Co-authored-by: adstep <stephensonadamj@gmail.com>
2023-08-09 14:28:36 -06:00
tznind
4dbf2f4cfd Add test for marking event Handled and demo how to do custom drawing 2023-07-25 08:54:52 -06:00
tznind
101db86bfa Add TestTreeView_DrawLineEvent_WithScrolling test 2023-07-25 08:54:52 -06:00
tznind
78eebd1ce7 Add test TestTreeView_DrawLineEvent 2023-07-25 08:54:52 -06:00
BDisp
57db5a351b Add unit test. 2023-07-19 06:50:41 -06:00
Thomas Nind
7888365743 Fixes #2681- SpinnerView should not use SetNeedsDisplay for advancing its animations (#2710)
* Move spinnerview animation advancement to explicit method

* Update scenario

* Fix unit tests

---------

Co-authored-by: Tig <tig@users.noreply.github.com>
2023-07-12 08:50:55 -07:00
BDisp
325180ae48 Fixes #2680. Make the TextView API more extensible. (#2682)
* Fixes #2680. Make the TextView API more extensible.

* Remove unnecessary using.

* Add GetLine method.

* Change RuneCell Attribute property to ColorScheme property.

* Add LoadRuneCells method and unit test.

* Add helper method to set all the Colors.ColorSchemes with the same attribute.

* Change RuneCell to class.

* Add IEquatable<RuneCell> interface.

* Fix unit test.

* Still fixing unit test.

* Fixes #2688. ReadOnly TextView's broken scrolling after version update.

* keyModifiers must be reset after key up was been processed.

* Trying fix server unit test error.

* Prevents throw an exception if RuneCell is null.

* Still trying fix this unit test.

* Cleaning code.

* Fix when the RuneCell is null.

* Fix throwing an exception if current column position is greater than the line length.

* Fixes #2689. Autocomplete doesn't popup after typing the first character.

* Fix Used on TextField.

* Always use the original ColorScheme if RuneCell.ColorScheme is null.

* Fix Used on TextView.

* Add RuneCellEventArgs and draw colors events.

* Add two more samples to the scenario.

* Fix a bug which was causing unit tests with ColorScheme fail.

* Fix a issue when WordWrap is true by always loading the old text.

* Improves debugging in RuneCell.

* WordWrap is now preserving the ColorScheme of the unwrapped lines.

* Simplifying unit test.

* Ensures the foreground and background colors are never the same if Used is false.

* Remove nullable from the parameter.

* Merge syntax highlighting of quotes and keywords together

* Add IdxRow property into the RuneCellEventArgs.

* Fix pos calculation on windows
(where newline in Text is \r\n not \n)

* Fix events not being cleared when toggling samples.

* Change Undo and Redo to a public method.

* Changes some methods names to be more explicit.

* Call OnContentsChanged on needed methods and fix some more bugs.

* Adds InheritsPreviousColorScheme to allow LoadRuneCells uses personalized color schemes.

* Serializes and deserializes RuneCell to a .rce extension file.

* Prevents throwing if column is bigger than the line.

* Avoids create a color attribute without one of the foreground or background values. In Linux using -1 throws an exception.

* Replace SetAllAttributesBasedOn method with a ColorScheme constructor.

* Move RuneCell string extensions to TextView.cs

* Reverted parameter name from cell to rune.

* Change Row to UnwrappedPosition which provide the real unwrapped text position within the Col.

* Add brackets to Undo and Redo methods.

* Replace all the LoadXXX with Load and rely on the param type to differentiate.

* Open a file inside a using.

* Proves that the events run twice for WordWrap disabled and the enabled.

* Remove GetColumns extension for RuneCell.

* Add braces to Undo an Redo.

* Change comment.

* Add braces.

* Delete remarks tag.

* Explaining used color and ProcessInheritsPreviousColorScheme.

* Fix comment.

* Created a RuneCellTests.cs file.

* Rename to StringToLinesOfRuneCells.

* Make ToRuneCells private.

---------

Co-authored-by: Thomas <tznind@dundee.ac.uk>
Co-authored-by: Thomas Nind <31306100+tznind@users.noreply.github.com>
2023-07-06 11:49:41 -06:00
Thomas Nind
53c7eaf266 Fix tileview borders and enable tests (#2708)
* Fix compilation errors in tests

* Fix line lengths for border drawing

* Fix tile view tests by adding init calls
2023-07-05 16:47:51 -06:00
Thomas Nind
cd6cfd7f62 Fixes #2683 - Adds an ITableSource which wraps a TreeView<T> (#2685)
* WIP: Add TreeTableSource

* Improve expand/collapse

* Render branch/tree properly

* Simplify TreeTableSource to only allow one TreeView

* Add TestTreeTableSource_BasicExpanding test

* Add test combining checkbox and tree together

* Move tree example into main TableEditor scenario
(deleting TreeTableExample.cs)

* Mouse support for expanding/collapsing branches

* Make TreeTableSource work with CheckBoxTableSourceWrapperByObject<T>

* Add tests for mouse expand/collapse

* Improve quality of TableEditor scenario

* Fix mouse expanding not refreshing screen

* Fixed null reference when clicking in header lines

* Add null checks to scenario now it can show trees as well as data tables

* Switch to underscore prefix on private members

* Remove accidentally committed file

* Add setup/teardown to explicitly set driver checked/unchecked glyphs

---------

Co-authored-by: Tig <tig@users.noreply.github.com>
2023-07-05 16:45:42 -06:00
tznind
e70ce0f13b Add extra assertions to TestSpinnerView_AutoSpin 2023-05-28 06:36:51 +02:00
tznind
43c0fab462 Whitespace fix 2023-05-28 06:36:51 +02:00
tznind
94c3de473c Change AutoSpin from a method to a property 2023-05-28 06:36:51 +02:00
Thomas Nind
e2feeefa93 Fixes #2663 - No more nested classes (#2664)
* Move all public nested classes out into own files

* Move more nested classes out

* Tidy up and treat CA1034 as an error.  Fix remaining nested classes.

* Remove partial keyword from ThemeManager as it is no longer needed

* Rename Bar to BarSeriesBar to more clearly indicate it is part of GraphView subsystem

* Fix xmldoc references

* Revert nesting changes to ConsoleDrivers

* Change to file scoped namespaces and revert renames

- LineCanvasCell back to just Cell
- ApplicationRunState back to just RunState

* Switch to file scoped namespaces
2023-05-23 13:42:47 +02:00
BDisp
ef6f355f50 Fixes #2653. TextField is using the UTF8 encoding to handle substring not compatible with string. (#2654) 2023-05-22 06:18:18 +02:00
Thomas Nind
0ea7a871ce Adds TreeView MaxDepth (#2651) 2023-05-21 23:26:50 +02:00
Tig
4d6781e5f9 Fixes #2649 - Unit Tests on Windows are failing (#2650)
* attempt to fix

* Removed unneeded ToString() calls

* Forced all unit tests to use FakeClipboard
2023-05-21 17:45:02 +02:00
BDisp
713b2c4725 Fixes #92. Remove dependency on ustring. (#2620)
* Remove NStack and replace ustring to string.

* Add unit test and improving some code.

* Adjust code and fix all unit tests errors.

* Add XML Document and move the Rune folder into the Text folder.

* Improve unit tests with byte array on DecodeRune and DecodeLastRune.

* Fix unit test.

* 😂Code review

* Reduce unit tests code.

* Change StringExtensions.Make to StringExtensions.ToString and added some more unit tests.

* Fix merge errors.

* Remove GetTextWidth and calls replaced with StringExtensions.GetColumns.

* Hack to use UseSystemConsole passed in the command line arguments.

* Revert "Hack to use UseSystemConsole passed in the command line arguments."

This reverts commit b74d11c786.

* Remove Application.UseSystemConsole from the config file.

* Fix errors related by removing UseSystemConsole from the config file.

* Fixes #2633. DecodeEscSeq throw an exception if cki is null.

* Fix an exception if SelectedItem is -1.

* Set SelectedItem to 0 and remove unnecessary ToString.

* Using a unique ToString method for Rune and other for byte.

* Fix a bug where a wider rune is added with only a width of 1.

* Force the SelectedGlyph is the one that was typed after jumpList is executed.

* Added more InlineData to RuneTests.

* Reducing significantly the code by using Theory attribute in the TextFormatterTests.

* Override PositionCursor to handle the CharMap cursor position.

* Fix merge errors.

* Minor tweaks to API docs

---------

Co-authored-by: Tig Kindel <tig@users.noreply.github.com>
2023-05-20 19:35:32 +02:00
Thomas Nind
07c4c05729 Test fixes for tv-checkboxes merge (#2619)
* Add CheckBoxTableSourceWrapper

* Fix column offsets when there are checkboxes column

* Fix index

* Add CellToggledEventArgs and handle in CheckBoxTableSourceWrapper

* Add xmldoc for CheckBoxTableSourceWrapper

* Add tests and default keybinding for toggle to CheckBoxTableSourceWrapper

* Add unit tests for TableView checkboxes

* Split CheckBoxTableSource to two subclasses, one by index the other by object

* Add more tests for CheckBoxTableSourceWrapperByObject

* Refactor for readability

* Add UseRadioButtons

* Add test for radio buttons in table view

* Fix xmldoc

* Fix regression during radio refactoring

* Fix build errors for new glyph and draw method names

* Fix tests to expect new unicode glyphs

---------

Co-authored-by: Tig <tig@users.noreply.github.com>
2023-05-10 07:52:45 +02:00
Thomas Nind
6cd79ada3a Fixes #2587 - Add CheckBoxTableSourceWrapper for TableView checkboxes (#2589)
* Add CheckBoxTableSourceWrapper

* Fix column offsets when there are checkboxes column

* Fix index

* Add CellToggledEventArgs and handle in CheckBoxTableSourceWrapper

* Add xmldoc for CheckBoxTableSourceWrapper

* Add tests and default keybinding for toggle to CheckBoxTableSourceWrapper

* Add unit tests for TableView checkboxes

* Split CheckBoxTableSource to two subclasses, one by index the other by object

* Add more tests for CheckBoxTableSourceWrapperByObject

* Refactor for readability

* Add UseRadioButtons

* Add test for radio buttons in table view

* Fix xmldoc

* Fix regression during radio refactoring

* Fix build errors for new glyph and draw method names

---------

Co-authored-by: Tig <tig@users.noreply.github.com>
2023-05-10 07:33:19 +02:00
Thomas Nind
5317950928 Fixes #2601 - Adds ability to filter TreeView branches/leaves (v2) (#2604)
* Add ITreeViewFilter

* Fix for v2

* Fix for new private variable name
2023-05-10 07:32:45 +02:00