* Fixes#2558. MenuBar positions wrong in some situations.
* Replacing Application.Top with Application.Current.
* Fix typo.
* Fix shortcut tag overlapping help on smaller width and add more unit test.
* Resizing the console will close all opened menus.
* Resize first the console before show ContextMenu.
* Remove DriverFrame and DriverFrameOffset as not relevant.
* Replace _frame with Frame as requested.
* Fix xml document comment.
* Compare equality between Dialog and Application.Top.
* Move GetDriverLocationOffset and GetDriverLocationOffsetFromCurrent to the Menu.cs.
* Fix merge errors.
* Ensure menu is closed on click.
* Force Height always be 1 to avoid mouse events respond even outside bounds.
* Recovering UseSubMenusSingleFrame hope doesn't break again.
* Fix bugs and made requested changes.
---------
Co-authored-by: Tig <tig@users.noreply.github.com>
* Fixes#2482. Refactor Redraw - Non-virtual with the right set of virtual OnXXX methods.
* Change documentation comments.
* Fixes#2575 - TableView to use interface instead of System.Data.DataTable (#2576)
* WIP: Add ITableDataSource
* WIP: Refactor TableView
* WIP: Port CSVEditor
* WIP: Port TableEditor
* WIP: Port MultiColouredTable scenario
* Fix bug of adding duplicate column styles
* Update tests to use DataTableSource
* Tidy up
* Add EnumerableTableDataSource<T>
* Add test for EnumerableTableDataSource
* Add test for EnumerableTableDataSource
* Add code example to xmldoc
* Add ProcessTable scenario
* Rename ITableDataSource to ITableSource and update docs
* Rename EnumerableTableDataSource to EnumerableTableSource
* Fixed Frame != Bounds; changed UICat Scenarios list to use tableview!
* Fix scroll resetting in ProcessTable scenario
* Fix unit tests by setting Frame to same as Bounds
* Document why we have to measure our data for use with TableView
---------
Co-authored-by: Tig Kindel <tig@users.noreply.github.com>
* Fixes#2582 - Refactors FileDialog for cleaner data model (#2583)
* WIP: Add ITableDataSource
* WIP: Refactor TableView
* WIP: Port CSVEditor
* WIP: Port TableEditor
* WIP: Port MultiColouredTable scenario
* Fix bug of adding duplicate column styles
* Update tests to use DataTableSource
* Tidy up
* Add EnumerableTableDataSource<T>
* Add test for EnumerableTableDataSource
* Add test for EnumerableTableDataSource
* Add code example to xmldoc
* Add ProcessTable scenario
* Rename ITableDataSource to ITableSource and update docs
* Rename EnumerableTableDataSource to EnumerableTableSource
* Fixed Frame != Bounds; changed UICat Scenarios list to use tableview!
* Fix scroll resetting in ProcessTable scenario
* Fix unit tests by setting Frame to same as Bounds
* Document why we have to measure our data for use with TableView
* WIP: Simplify FileDialogs use of TableView
* WIP start migrating sorter
* WIP new filedialog table source mostly working
* WIP remove sorter class
* Refactor GetOrderByValue to be adjacent to GetColumnValue
* Fix collection navigator back so it ignores icon
* Fix unit tests
* Tidy up
* Fix UseColors
* Add test for UseColors
---------
Co-authored-by: Tig Kindel <tig@users.noreply.github.com>
* Fixes#2196. TextView: Setting Text places cursor at beginning, unlike TextField (#2572)
* Fixes#2196. TextView: Setting Text places cursor at beginning, unlike TextField
* Change all private members to have the _prefix.
* Renamed local member to prevLayoutStyle.
* Helper function for SetNeedsDisplay.
* Fixes#2569. Borders scenarios needed to be refactored. (#2570)
* Fixes#2569. Borders scenarios needed to be refactored.
* Fix border title with width equal to 4 and thickness top grater than 1.
* Improves border manipulation on borders scenarios.
* Prevents null value on the margin, border and padding thickness on the border scenarios.
* Remove NStack using dependence and fix prior commit.
* Refactoring the Frames scenario.
* Deleted borders scenarios.
* I did not realize that it was changed to SetSubViewNeedsDisplay.
* Re-layout; fixed colorpicker; fixed radio group
* Remove Thickness.IsEmpty as requested.
* Change the Frames scenario as requested.
---------
Co-authored-by: Tig Kindel <tig@users.noreply.github.com>
* Builds CollectionNavigator support into UI Catalog for TableView (#2584)
* Builds collectionnav support into UI cat for TableView
* Fixes keyboard mapping
* MultiSelect = false for TableView
* MultiSelect = false doesn't unbind ctrl-a
* Fixes#2581 Refactor CollectionNavigator so it supports TableView (#2586)
* Refactor CollectionNavigator to a base and a collection implementation
* Refactor CollectionNavigatorBase to look for first match smartly
* Add TableCollectionNavigator
* Make TableCollectionNavigator a core part of TableView
* Fix bad merge
* Added tests for tableview collection navigator
* Add FileDialogCollectionNavigator which ignores . and directory separator prefixes on file names
* whitespace fixes
---------
Co-authored-by: Tig <tig@users.noreply.github.com>
* Resolving merge conflicts.
* Fix merge errors.
* Fix merge errors.
* Add Command.Accept and snap to the selected glyph when ShowHorizontalScrollIndicator change to true.
* Reformat.
* Reformat again.
---------
Co-authored-by: Thomas Nind <31306100+tznind@users.noreply.github.com>
Co-authored-by: Tig Kindel <tig@users.noreply.github.com>
* Refactor CollectionNavigator to a base and a collection implementation
* Refactor CollectionNavigatorBase to look for first match smartly
* Add TableCollectionNavigator
* Make TableCollectionNavigator a core part of TableView
* Fix bad merge
* Added tests for tableview collection navigator
* Add FileDialogCollectionNavigator which ignores . and directory separator prefixes on file names
* whitespace fixes
---------
Co-authored-by: Tig <tig@users.noreply.github.com>
* Fixes#2569. Borders scenarios needed to be refactored.
* Fix border title with width equal to 4 and thickness top grater than 1.
* Improves border manipulation on borders scenarios.
* Prevents null value on the margin, border and padding thickness on the border scenarios.
* Remove NStack using dependence and fix prior commit.
* Refactoring the Frames scenario.
* Deleted borders scenarios.
* I did not realize that it was changed to SetSubViewNeedsDisplay.
* Re-layout; fixed colorpicker; fixed radio group
* Remove Thickness.IsEmpty as requested.
* Change the Frames scenario as requested.
---------
Co-authored-by: Tig Kindel <tig@users.noreply.github.com>
* Fixes#2196. TextView: Setting Text places cursor at beginning, unlike TextField
* Change all private members to have the _prefix.
* Renamed local member to prevLayoutStyle.
* Helper function for SetNeedsDisplay.
* WIP: Add ITableDataSource
* WIP: Refactor TableView
* WIP: Port CSVEditor
* WIP: Port TableEditor
* WIP: Port MultiColouredTable scenario
* Fix bug of adding duplicate column styles
* Update tests to use DataTableSource
* Tidy up
* Add EnumerableTableDataSource<T>
* Add test for EnumerableTableDataSource
* Add test for EnumerableTableDataSource
* Add code example to xmldoc
* Add ProcessTable scenario
* Rename ITableDataSource to ITableSource and update docs
* Rename EnumerableTableDataSource to EnumerableTableSource
* Fixed Frame != Bounds; changed UICat Scenarios list to use tableview!
* Fix scroll resetting in ProcessTable scenario
* Fix unit tests by setting Frame to same as Bounds
* Document why we have to measure our data for use with TableView
* WIP: Simplify FileDialogs use of TableView
* WIP start migrating sorter
* WIP new filedialog table source mostly working
* WIP remove sorter class
* Refactor GetOrderByValue to be adjacent to GetColumnValue
* Fix collection navigator back so it ignores icon
* Fix unit tests
* Tidy up
* Fix UseColors
* Add test for UseColors
---------
Co-authored-by: Tig Kindel <tig@users.noreply.github.com>
* WIP: Add ITableDataSource
* WIP: Refactor TableView
* WIP: Port CSVEditor
* WIP: Port TableEditor
* WIP: Port MultiColouredTable scenario
* Fix bug of adding duplicate column styles
* Update tests to use DataTableSource
* Tidy up
* Add EnumerableTableDataSource<T>
* Add test for EnumerableTableDataSource
* Add test for EnumerableTableDataSource
* Add code example to xmldoc
* Add ProcessTable scenario
* Rename ITableDataSource to ITableSource and update docs
* Rename EnumerableTableDataSource to EnumerableTableSource
* Fixed Frame != Bounds; changed UICat Scenarios list to use tableview!
* Fix scroll resetting in ProcessTable scenario
* Fix unit tests by setting Frame to same as Bounds
* Document why we have to measure our data for use with TableView
---------
Co-authored-by: Tig Kindel <tig@users.noreply.github.com>
* Add many styles to SpinnerView
* Add SpinnerStyles as a nested class
* Allow zero as valid spinner delay value
* Change from BorderStyle to LineStyle
* Rename SpinDelayInMilliseconds to just SpinDelay
---------
Co-authored-by: Tig <tig@users.noreply.github.com>
* Add additional LineStyles
* Fix WizardTests because of renamed runes
* BorderFrame -> Border
* Fix the layout of Border Scenarios
* Fix for LineCanvas clipping
Based on comment https://github.com/gui-cs/Terminal.Gui/pull/2533#issuecomment-1508982468
* Update LineCanvasTests.cs
* Rename Thick border to Heavy
(less confusion with "Thickness")
Also:
* Add a few more runes for potential future use
* Fix Unit Tests
* Fix LineDrawing scenario to use 1 unit longer lines (matching new LineCanvas API).
* Fix LineDrawing scenario to better match mouse cursor location
---------
Co-authored-by: tznind <tznind@dundee.ac.uk>
* Fix HotFocus color when FullRowSelecting being used for VLines on left/right of TableView
* Add AlwaysUseNormalColorForVerticalCellLines style setting
---------
Co-authored-by: Tig <tig@users.noreply.github.com>
* Add dir selection tests
* Make tests work on windows or linux
* Fixed multi-selection issues
- ".." no longer a valid multi select item
- Pressing Alt+O (or clicking ok) now prefers completing multi
selection (to completing text box path)
- Pressing Enter in text box still uses Path as selection (ignoring
any multi selection)
* Allow toggling <space> then <enter> to perform single dir select
* FileDialogState now remembers Path
Makes back button smoother in some nieche situations
* Added Culture property to FileDialog
* Fix bad date/time format
---------
Co-authored-by: Tig <tig@users.noreply.github.com>
* Add Style.HideHeaders to TableView
* Revisions to TableView HideHeaders from review
Also add to UICatalog TableEditor Scenario
* Allow ShowHorizontalHeaderUnderline to draw top border even when HideHeaders is enabled; AlwaysShowHeader will keep it there on scroll
* Add Unit Tests for TableView.Style.HideHeaders
* Rename HideHeaders to ShowHeaders and simplify logic
---------
Co-authored-by: tznind <tznind@dundee.ac.uk>
* Fixes menu frame and unit test on the #2483.
* Reverting some code. Only color on ScrollView is failing.
* Fixes for the unit test Draw_A_ContextManu_Over_A_Dialog pass.
* Comment/warning clean up
* Moved Text and Drawing out
* Moved Layout out
* Removed extra lines
* Removed Mouse out
* Reorgainzed View
* API docs
* removed border.cs
* TopLevel.Resized -> TerminalResized
* Mdi -> Overlapped
* Removed confusing and un-needed WillPresent
* privates -> _
* Tweaked RunLoop API
* POC
* View.DrawFrame now uses LineCanvas
* Fixes#2531. Toplevel should redraw only if it's needed.
* Fix toplevel when mdi is enabled preventing clear the screen twice.
* Massive LineCanvis updates
* Fixes#2534. Bounds isn't updating when the Frame is changed.
* Almost everything works!
* Had to disable a few tests but all unit test now pass again
* Deleted ConsoleDriver.DrawWindowFrame; hacked ProgressBar
* Deleted ConsoleDriver.DrawWindowTitle; moved to Frame.DrawTitle
* Renames BorderFrame to Border
* Removed old commented code
* Tweaked scenario
* Added auto convert \r\n to Enviornment.NewLine in TestHelpers.AssertEqual
* Fix merge errors.
* Fix AssertEqual newlines to platform-specific.
* Refactored frames drawing; view adds to its lineview, superview renders them
* New titlebar style based on Border.Top size; fixed bugs
* wzard bug
---------
Co-authored-by: BDisp <bd.bdisp@gmail.com>
* Added View.BorderStyle and renamed BorderStyle enum to LineStyle
* Fixed a lot of things and broke everything else
* Fixed things
* Updated DialogTests
* Updates including Rect unit tests
* Fixed Dialog & MessagBox tests
* Fixed AllviewsTester bug
* Fixed AllviewsTester bug
* Removed Border class
* Renamed View privates with _
* Removed comments in MessageBox.cs
* Investigating new file dialog
* Column sorting
* Add navigationStack
* Append autocomplete half working
* Change autocomplete append to use draw effect instead of selection effect
* WIP on FileDialog2
* Refactor sort order and add more 'ls' colors
* Refactor history to its own class
* FileDialog2 navigation fixes/improvements
* Added centered Title
* Add tree view and split container
* Add FileDialogState
* Add AllowsMultipleSelection
* Add result fields and Scenario
* Added FileDialo2 test file
* Fix FileDialog2 Redraw padding to respect max/min view bounds
* Fix unit tests and warnings
* Started on better keyboard navigation in FileDialog2
* Update to match new SplitContainer API
* Quality of Life improvements
* Fix recommending parent folder
* Remove border from SplitContainer in FileDialog2 and fixed tests
* Bugfixes and improvements to FileDialog2
* usability improvements to FileDialog2
* Add multi select and OpenMode
* Enforce OpenMode when making a multi selection
* Prevent typing illegal characters
* Added AllowedTypes to FileDialog2
* Added combo box filter AllowedType
* Improve code readability by reordering members
* Do not update FileDialog2 text box when selecting ".." in TableView
* Fix history navigation in FileDialog2
* Restore selection after navigating backwards in history
* Add FileDialog2 tests
* Make FileDialog2 Title user configurable
* Fix DirectTyping_Allowed unit test when running on linux
* Change Home/End to go to first/last cell in table in FileDialog2
* Remove overloaded Title property
* Switch to `ustring.IsNullOrEmpty`
* Update to latest TileView API
* Add TableView navigation by letter using CollectionNavigator
* Fix recreating search navigator too often
* Add tests for proper disposing
* Make Ctrl+F10 toggle split line focusability
* Fix layout bug in first tile when orientation is horizontal
* Switch to GenerateImage
* Fix not calling base constructor
* Revert "Merges latest LineCanvas into TileView"
* Fix keyboard tab navigation problems
* Workaround for changing CanFocus throwing Exceptions sometimes
* Update to latest splitcontainer API
* Adjust suggestions to be gray and properly update on keystrokes
* Move ok and cancel to bottom
* Add MustExist and fix multi selection of 1 result
* bugfixes and quality of life
* Navigating to .. clears path up to current dir
* Better arrow key navigation
* Make title pretty and informative
* Fix test
* Fix test
* Trim default Titles to be more compact and readable
* Fix bad merge changes
* Remove EscSeqReq files that are not in v2... came from develop?!
* Fix nullable and enable toggle select on table view
* Fix multi select return value
* Add icon and monochrome support
* Add search elements
* Add search for current directory
* WIP: Async search
* Thread safety and disposal
* Improve UX
* Fix for rapid search results
* Fix warnings and whitespace
* Don't add more than 10000 search results
* Add support for adjusting search matching
* Added ISearchMatcher example to FileDialog2Example
* Remove double spaces after periods
* Make MaxSearchResults a config setting
* Localization for FileDialog2
* Fix build error
* Support for custom open button Text
* Improve file dialog scenario UX
* Change feedback to a drawing effect in center of screen
* Explore MenuBar instead of ComboBox for AllowedTypes
* Fix prompt and move file open into try/catch for errors reading files
* Open menu when tabbed to
* FileDialog2 improvements
- Expose table/tree style properties
- Rename Monochrome to UseColors and default to false
- IconGetter no longer forces space
- On Windows in Scenario just use a backslash for folder icon (i.e. not unicode)
-
* Add style settings in scenario and make autocomplete case insensitive on Windows
* Move ok button text to Style
* xmldoc
* Remove old FileDialog and re-wire OpenDialog and SaveDialog to use FileDialog2 base
* localization
* Move open/save dialog to their own files
* Rename FileDialog2 to FileDialog
* Fix repetition in string
* Add IAllowedType
* Get rid of AllowedTypesIsStrict
User now adds the `IAllowedType` implementation `AllowedTypeAny`
* Add max length to AllowedType ToString
* Pressing Enter in find restarts search instead of confirm selection
* Add TreeRootGetter for customizing the quick access items in FileDialog
* Add FilesSelected event
Allows user to do things like confirm dialogs on selecting existing file(s)
* Update to new sender, event args signature
* Fix naming on MouseEventArgs
* Fix mouse events naming
* Revert "Fix naming on MouseEventArgs"
This reverts commit 2f557f52d9.
* Add deletion support
* Move delete keybinding to tableview
* Scaffold for rename and new operations
* Prevent delete dialog popping up again on cancel
* Add rename and new folder implementations
* Add rename,delete,new to context menu
* On rename or new, reselect the file in its new location in tree
* Support searching on multiple terms
* Localization support for new/rename/delete
* Refactor internal classes and add class diagram
* Move some visual properties to FileDialogStyle
* Ensure MultiSelected is never null and always contains Path if relevant
* Fix spacing/indentation
* WIP: Add new namespace Terminal.Gui.FileServices
* Improve appearance of back/forward/up
* Move SpinnerLabel to Views
* Add SpinnerView
* Code formatting
* Add AutoSpin test
* Avoid ever removing spinner timeout twice
* Make SpinnerView show/hide instead of stopping
* WIP: Refactor to use 3 sub PRs
- SpinnerView
- Suggest Append Autocomplete
- Caption TextField
* Add FilepathSuggestionGenerator
* WIP: FileDialog autocomplete append mostly working again
* Improve file autocomplete
* Move IconGetter to Style and provide default implementation
- Depends on `UseUnicodeCharacters`
- Also updated up/back/collapse/expand tree to use spicier icons
* Fix failing unit test
* Improved colors and layout
* Adjust use of unicode
* Fix UseUnicodeCharacters
* Update table style to include scroll indicators and lines
* Fix cycle suggestion with down cursor
* Adjust sort indicators
* Add default sort order on isDir then name
* Always use left/right unicode arrows
* Fix autocomplete suggesting in empty textbox
* Press escape to cancel ongoing search (when search box is focused)
* When entering a TreeView if there is no selection then select first object
* Move CursorIsAtEnd to TextField
* Improve layout
* Change UseColors to be a cell color fill
* Fxied tests for new apis
* Remove manual title drawing code
* Fix MoveEnd name conflicting with base class
* Fix merge conflicts
* Switched to IFileSystem for unit testing
* Add unit test
* Revert "Fix MoveEnd name conflicting with base class"
This reverts commit a5f9c07022.
* Fix MoveEnd name collision with 'new' keyword
* Fixed tree not toggling
* DateTime fixes and mocking
* Fix TestDirectoryContents_Windows
* Expose UseColors and UseUnicodeCharacters as config settings
* Fix linter settings having removed curly brackets
* Fix namespace on test
* Move tests to file services folder
* Remove the FileServices namespace
* Updated class diagram
* Clear title from tests for futureproofing
* Localization support for FileDialog title
* Remove trailing whitespace in "open existing"
* Fix listing suggestions immediately after folder path entered
---------
Co-authored-by: Tig <tig@users.noreply.github.com>
* Fixes#2511. Cannot cycle selections in lists/tables when Numlock is pressed.
* The Capslock, Numlock and Scrolllock tests can be run once.
* Done requested changes.
