Commit Graph

1896 Commits

Author SHA1 Message Date
BDisp
1540714951 Fixes #3698. ResourceManager GetResourceSet doesn't fallback to default for no translated keys. 2024-08-27 20:48:52 +01:00
BDisp
6498610de9 Fixes #3678. ContextMenu accesses disposed MenuBar. (#3681)
* Fixes #3678. ContextMenu accesses disposed MenuBar.

* Preserve always the last menu opened.

* Re-added MenuAllClosed event.

* Ensures call CleanUp if Application.MouseGrabView hold another MenuBar than the calling one.

* Fix unit tests.

* Passing the offending object instead of the View type.

* Add that to the dictionary to shut respeller up.

* Address a few warnings

* A question

* Just a little more cleanup

* Combine these and comment

* Slight additional cleanup

* More minor cleanup

We already know it is null. just make it the else instead of a new condition

* Nullable != true ===> is not true

* Unconditional break at the top is just a part of the while statement (inverted)

* Fixes #3687. ColorPicker isn't respecting the current UI culture.

* Fix @dodexahedron erroneous code.

* Cleanup comments.

---------

Co-authored-by: Brandon Thetford <github@snapsinazfs.com>
Co-authored-by: Tig <tig@users.noreply.github.com>
2024-08-23 09:47:09 -06:00
BDisp
c1d82947aa Fixes #3682. CanFocus true for Label works only for keyboard and not mouse. (#3683)
* Fixes #3682. CanFocus true for Label works only for keyboard and not mouse.

* Simplifying code.

---------

Co-authored-by: Tig <tig@users.noreply.github.com>
2024-08-23 09:46:52 -06:00
Tig
e21f158077 Fixes #3689. Release builds broken (#3690)
* Initial commit

* added #if DEBUG_IDISPOSABLE

* Tweaked yml
2024-08-23 09:22:00 -06:00
BDisp
3b6abeb741 Fixes #3679. WantContinuousButtonPressed mustn't force calling GrabMouse. (#3680)
Co-authored-by: Tig <tig@users.noreply.github.com>
2024-08-22 17:56:50 -06:00
Thomas Nind
38f84f7424 Fixes #2800 - Color picker (supporting hsl, hsv and rgb) (#3604)
* Readonly HSL view

* Make it possible to move between bars by moving to subview

* Basically working and with mouse support

* Fix HSL to work properly with double values instead of color matching

* Fix Value on ColorPicker to match HSL values

* Fix color spectrum

* Add Swatch and better sync with text box

* Work on jitter

* ColorPicker HSL working

* More keybindings

* Add ColorModel

* Support both HSL and HSV

* Add RGB

* Better mouse handling

* WIP: AttributeView and integrate into LineDrawing
(does not currently work properly)

* Fix color picking

* Add concept of an ITool

* Add ColorPickerStyle

* Fix selected cell rendering

* Add first test for ColorPicker2

* Add more RGB tests

* Improve ColorPicker2 setup process

* Tests and fixes for keyboard changing value R

* Fix margin on bars when no textfields

* Add mouse test

* Add tests for with text field

* Add more tests and fix bug sync component text field change with hex text field

(WIP - failing tests)

* Fix tests and fix clicking in a bar label area possibly not selecting

* Move AttributeView to LineDrawing and adjust to have a 'transparent pattern' too

* Render triangle in dark gray if background is black

* Add ColorChanged event

* Resharper Cleanup

* Xml comments and public/private adjustments

* Explore replacing diagram test with fragile Subview diving

* Migrate ColorPicker_DefaultBoot to sub asserts

* Port other tests

* Replace ColorPicker with new view

* Fix ColorPicker size to match scenarios size assumptions

* Split to separate files and ignore invalid test for ColorPicker

* Ignore also in mouse version of AllViews_Enter_Leave_Events

* Remove bool _updating from ColorPicker

Now instead we are more selective about what we update when and do so deterministically

* Typo fix

* Fix ReSharper bad renames in comments for "Value"

* Refactor to single implementation of 'prompt for color' logic

- Now called PromptForColor
- Shared by LineDrawing and ProgressBarStyles scenarios

* Sum runes instead of Length

* Hide ColorBar and SetValueWithoutRaisingEvent from public API

* Move ColorEventArgs to Drawing folder

* Move ColorModel to Drawing folder

* First try at Dim.Auto for ColorPicker

* Remove explicit width/height setting in most scenarios

* Remove explicit heights

* Fixed build/test issues.
Illustrated test best practice.

* WIP: Start working on test changes and add new options to ColorPickers scenario (Color Model and show textfields).

* Fix for R indicator arrow sometimes 'falling off' the drawn area.

* Add nullable enable

* Test fixes and refactor for avoiding Begin

* Make ColorEventArgs inherit from EventArgs<Color>

* Fix Dispose not being called on bars when switching color models

* Remove 'oldColor' from test now it is not supported

* Add initial stab at ColorPickerStyle.ShowName

* Use AppendAutocomplete for color names

* Implemented resoruce based colorname resolver

* Update GetTextField to support getting the color names field
Change style setting to ShowColorName

* Color name updates when navigating away from the named color

* Restore old color picker as ColorPicker16

* Add test that shows 'Save as' is currently considered a named color ><

* Fix GetW3CColorNames

* Removed dupe colors

* Revert to old color pickers

* Nullability question marks for everyone!

---------

Co-authored-by: Tig <tig@users.noreply.github.com>
2024-08-22 17:53:04 -06:00
Tig
b267e1698e V2 fix warnings (#3671)
* Fixed NumericUpDown warning

* Fixed Aot Warning

* Fixed warnings in Application.cs

* Fixed more NumericUpDown warning

* Fixed CommandImpl warning

* Fixed Thickness warnings

* Fixed Label warning

* Fixed warning

* Fixed menubar test warning

* Fixed warnings

* Fixed warnings

* Removed dead code

* Fixed warnings
2024-08-19 10:09:15 -06:00
BDisp
a0c03b11b6 Fixes #3635. Focus gets confused with ContextMenu. (#3663)
* Fixes #3635. Focus gets confused with ContextMenu.

* Improving unit test.

* Updated migration doc to include additional findings. (#3660)

* Updated migration doc to include additional findings.

* Updated per PR recommendations.

---------

Co-authored-by: Tig <tig@users.noreply.github.com>

---------

Co-authored-by: Tig <tig@users.noreply.github.com>
Co-authored-by: Brian Gentry <bgentry@trestledevelopment.com>
2024-08-19 09:14:00 -06:00
Tig
388c11da51 Merge branch 'v2_develop' into v2_3667_toplevel-menubar-statusbar-remove-fix 2024-08-19 08:37:55 -06:00
Brandon Thetford
dccc06366a Categorize the test fixture 2024-08-18 18:31:23 -07:00
Brandon Thetford
219cfb559a More code reduction. Put these in a primary constructor. Update uses. 2024-08-18 18:30:59 -07:00
Tig
34773a4d07 Merge branch 'v2_develop' into v2_3521-DimAuto-Equality 2024-08-18 17:16:51 -06:00
BDisp
936f9f52e0 Merge branch 'v2_develop' into v2_3667_toplevel-menubar-statusbar-remove-fix 2024-08-18 16:10:46 +01:00
BDisp
9635a434ed Fixes #3667. Null reference in v2 in FindDeepestView. 2024-08-18 15:56:34 +01:00
Tig
c00290ffcc Added unit test & fixed bug (#3666) 2024-08-17 09:22:52 -06:00
Tig
6a13e777ff class Pos -> record Pos 2024-08-14 13:02:11 -06:00
Tig
8edb06213e class Dim -> struct Dim 2024-08-14 09:28:47 -06:00
Tig
6ec69d7644 Code cleanup & doc fix 2024-08-13 15:41:11 -06:00
Tig
a8f929bed9 Fixed DimAuto and tests 2024-08-13 14:12:32 -06:00
Tig
29dc789d45 Merge branch 'v2_develop' into v2_3521-DimAuto-Equality 2024-08-13 14:04:07 -06:00
BDisp
a661fcecf7 Fixes #3652. Setting Menus causes unexpected Exception. (#3653)
* Moving ShortcutDelimiter from MenuBar to Key.

* Rename to ShortcutKey and change type to Key.

* Improving add and remove menu items dynamically.

* Code cleanup.

* Fix status bar shortcuts issues.

* Fix build error.

* Change HotKey type to Key.

* Change HotKey.setter to private.

* Fix warnings.

* Fix some bugs.

* Rename ShortcutDelimiter to Separator.

* Add Separator property into the Configuration Manager.

* Change XML doc for Separator.

* Replace KeyEvent with Key.

* Add unit test preventing the Key.Separator is never Null ('\0).
2024-08-13 13:46:00 -06:00
BDisp
63e75b7413 Fixes #3109. AOT support with .Net 8. (#3638)
* Add a native AOT project.

* Fixes Text.Json to work with native AOT.

* Fix silent errors on unit tests when testing the Red color which has a length of 3.

* Allowing test custom configuration without the config.json file match the unit tests configurations.

* Fix unit test if tested alone.

* Add native project into solution.

* Fix merge errors.

* Setting ConfigurationManager.ThrowOnJsonErrors as true to throw any serialization issue when published file runs.

* Remove unnecessary using's.

* Added unit test to ensure all serialization is properly configured.

* Fix warnings.

* Remove ThrowOnJsonErrors.

* Fix warnings.

---------

Co-authored-by: Tig <tig@users.noreply.github.com>
2024-08-06 12:05:36 -06:00
Tig
d47b184176 Added unit tests that fail 2024-08-06 09:38:05 -06:00
Tig
0bd50c5b93 Fixes #3641. CheckBox.State -> CheckBox.CheckState (#3648)
* State->CheckState.
Toggled->CheckStateChanging.

* Code cleanup & doc fix

* Updated migration guide

* Updated migration guide
2024-08-06 08:39:55 -06:00
Tig
12df9beebe Fixed linux/mac test failure 2024-08-05 18:03:08 -06:00
Tig
c0fc83bd78 Added Scenario and expanded API 2024-08-05 17:44:48 -06:00
Tig
126120b6dc Merged.
Feature complete
2024-08-05 12:36:13 -06:00
Tig
9865f72801 Merged with v2_develop.
Code cleanup
2024-08-05 09:14:33 -06:00
Tig
331ab51176 Updatd keyboard.md 2024-08-05 09:08:34 -06:00
Tig
e86a2fca2f Simplfiied app scope key setters 2024-08-05 08:54:05 -06:00
Tig
cebf1773af Added other types 2024-08-04 17:10:00 -06:00
Tig
a9f63ad138 Made unit tests more resiliant to config changes 2024-08-04 15:27:56 -06:00
Tig
f5b1984db7 Made unit tests more resiliant to config changes 2024-08-04 15:08:18 -06:00
Tig
271a73cba1 Made unit tests more resiliant to config changes 2024-08-04 12:14:13 -06:00
Tig
9526b4eabd Found and fixed another Shortcut bug 2024-08-03 21:59:28 -06:00
Tig
18ac4abab4 simplified test 2024-08-03 21:49:27 -06:00
Tig
87726454c9 Fixed KeyBinding issue @bdisp found 2024-08-03 17:16:06 -06:00
Tig
4985da476e Hacked in Application.Navigation.Set/GetFocused 2024-08-03 07:21:49 -06:00
Tig
8da833a4c6 Added Next/PrevTabKeys.
Refactored ApplicationNavigation in prep for further work
2024-08-02 13:57:23 -06:00
Tig
79e50b4d8f Nuked AlternateFwd/BkKeys.
Added Next/PrevTabGroupKey.
Fixed tests.
2024-08-02 13:41:53 -06:00
Tig
bb16e695fa merged with v2_develop 2024-08-02 11:56:45 -06:00
Tig
5768add496 Merge branch 'v2_develop' into v2-IOrientation 2024-08-02 13:22:59 -04:00
Tig
9a6e09f664 Merge branch 'v2_develop' into v2_2491-Refactor-TopLevel-Application-And-Focus 2024-08-02 13:18:39 -04:00
Tig
2f71fc0bc3 Code cleanup 2024-08-02 10:59:53 -06:00
BDisp
5910d13bd1 Remove unused using. 2024-07-31 18:10:04 +01:00
BDisp
60da57de43 Fixes #3632. Automatize getting cultures from the embedded resources strings for self-contained app. 2024-07-31 18:04:21 +01:00
Tig
469b3572d5 Revamped Scenario 2024-07-31 10:33:37 -04:00
Tig
6f4c7be477 Cleaned up some unit tests 2024-07-31 10:14:05 -04:00
Tig
38e517c921 Added AllViews_AtLeastOneNavKey_Leaves 2024-07-31 09:05:57 -04:00
Tig
47e1c87590 Added AllViews_AtLeastOneNavKey_Leaves 2024-07-31 09:05:26 -04:00