Commit Graph

494 Commits

Author SHA1 Message Date
BDisp
6498610de9 Fixes #3678. ContextMenu accesses disposed MenuBar. (#3681)
* Fixes #3678. ContextMenu accesses disposed MenuBar.

* Preserve always the last menu opened.

* Re-added MenuAllClosed event.

* Ensures call CleanUp if Application.MouseGrabView hold another MenuBar than the calling one.

* Fix unit tests.

* Passing the offending object instead of the View type.

* Add that to the dictionary to shut respeller up.

* Address a few warnings

* A question

* Just a little more cleanup

* Combine these and comment

* Slight additional cleanup

* More minor cleanup

We already know it is null. just make it the else instead of a new condition

* Nullable != true ===> is not true

* Unconditional break at the top is just a part of the while statement (inverted)

* Fixes #3687. ColorPicker isn't respecting the current UI culture.

* Fix @dodexahedron erroneous code.

* Cleanup comments.

---------

Co-authored-by: Brandon Thetford <github@snapsinazfs.com>
Co-authored-by: Tig <tig@users.noreply.github.com>
2024-08-23 09:47:09 -06:00
BDisp
c1d82947aa Fixes #3682. CanFocus true for Label works only for keyboard and not mouse. (#3683)
* Fixes #3682. CanFocus true for Label works only for keyboard and not mouse.

* Simplifying code.

---------

Co-authored-by: Tig <tig@users.noreply.github.com>
2024-08-23 09:46:52 -06:00
Tig
e21f158077 Fixes #3689. Release builds broken (#3690)
* Initial commit

* added #if DEBUG_IDISPOSABLE

* Tweaked yml
2024-08-23 09:22:00 -06:00
Thomas Nind
38f84f7424 Fixes #2800 - Color picker (supporting hsl, hsv and rgb) (#3604)
* Readonly HSL view

* Make it possible to move between bars by moving to subview

* Basically working and with mouse support

* Fix HSL to work properly with double values instead of color matching

* Fix Value on ColorPicker to match HSL values

* Fix color spectrum

* Add Swatch and better sync with text box

* Work on jitter

* ColorPicker HSL working

* More keybindings

* Add ColorModel

* Support both HSL and HSV

* Add RGB

* Better mouse handling

* WIP: AttributeView and integrate into LineDrawing
(does not currently work properly)

* Fix color picking

* Add concept of an ITool

* Add ColorPickerStyle

* Fix selected cell rendering

* Add first test for ColorPicker2

* Add more RGB tests

* Improve ColorPicker2 setup process

* Tests and fixes for keyboard changing value R

* Fix margin on bars when no textfields

* Add mouse test

* Add tests for with text field

* Add more tests and fix bug sync component text field change with hex text field

(WIP - failing tests)

* Fix tests and fix clicking in a bar label area possibly not selecting

* Move AttributeView to LineDrawing and adjust to have a 'transparent pattern' too

* Render triangle in dark gray if background is black

* Add ColorChanged event

* Resharper Cleanup

* Xml comments and public/private adjustments

* Explore replacing diagram test with fragile Subview diving

* Migrate ColorPicker_DefaultBoot to sub asserts

* Port other tests

* Replace ColorPicker with new view

* Fix ColorPicker size to match scenarios size assumptions

* Split to separate files and ignore invalid test for ColorPicker

* Ignore also in mouse version of AllViews_Enter_Leave_Events

* Remove bool _updating from ColorPicker

Now instead we are more selective about what we update when and do so deterministically

* Typo fix

* Fix ReSharper bad renames in comments for "Value"

* Refactor to single implementation of 'prompt for color' logic

- Now called PromptForColor
- Shared by LineDrawing and ProgressBarStyles scenarios

* Sum runes instead of Length

* Hide ColorBar and SetValueWithoutRaisingEvent from public API

* Move ColorEventArgs to Drawing folder

* Move ColorModel to Drawing folder

* First try at Dim.Auto for ColorPicker

* Remove explicit width/height setting in most scenarios

* Remove explicit heights

* Fixed build/test issues.
Illustrated test best practice.

* WIP: Start working on test changes and add new options to ColorPickers scenario (Color Model and show textfields).

* Fix for R indicator arrow sometimes 'falling off' the drawn area.

* Add nullable enable

* Test fixes and refactor for avoiding Begin

* Make ColorEventArgs inherit from EventArgs<Color>

* Fix Dispose not being called on bars when switching color models

* Remove 'oldColor' from test now it is not supported

* Add initial stab at ColorPickerStyle.ShowName

* Use AppendAutocomplete for color names

* Implemented resoruce based colorname resolver

* Update GetTextField to support getting the color names field
Change style setting to ShowColorName

* Color name updates when navigating away from the named color

* Restore old color picker as ColorPicker16

* Add test that shows 'Save as' is currently considered a named color ><

* Fix GetW3CColorNames

* Removed dupe colors

* Revert to old color pickers

* Nullability question marks for everyone!

---------

Co-authored-by: Tig <tig@users.noreply.github.com>
2024-08-22 17:53:04 -06:00
Tig
b267e1698e V2 fix warnings (#3671)
* Fixed NumericUpDown warning

* Fixed Aot Warning

* Fixed warnings in Application.cs

* Fixed more NumericUpDown warning

* Fixed CommandImpl warning

* Fixed Thickness warnings

* Fixed Label warning

* Fixed warning

* Fixed menubar test warning

* Fixed warnings

* Fixed warnings

* Removed dead code

* Fixed warnings
2024-08-19 10:09:15 -06:00
BDisp
a0c03b11b6 Fixes #3635. Focus gets confused with ContextMenu. (#3663)
* Fixes #3635. Focus gets confused with ContextMenu.

* Improving unit test.

* Updated migration doc to include additional findings. (#3660)

* Updated migration doc to include additional findings.

* Updated per PR recommendations.

---------

Co-authored-by: Tig <tig@users.noreply.github.com>

---------

Co-authored-by: Tig <tig@users.noreply.github.com>
Co-authored-by: Brian Gentry <bgentry@trestledevelopment.com>
2024-08-19 09:14:00 -06:00
BDisp
936f9f52e0 Merge branch 'v2_develop' into v2_3667_toplevel-menubar-statusbar-remove-fix 2024-08-18 16:10:46 +01:00
BDisp
9635a434ed Fixes #3667. Null reference in v2 in FindDeepestView. 2024-08-18 15:56:34 +01:00
Tig
c00290ffcc Added unit test & fixed bug (#3666) 2024-08-17 09:22:52 -06:00
BDisp
a661fcecf7 Fixes #3652. Setting Menus causes unexpected Exception. (#3653)
* Moving ShortcutDelimiter from MenuBar to Key.

* Rename to ShortcutKey and change type to Key.

* Improving add and remove menu items dynamically.

* Code cleanup.

* Fix status bar shortcuts issues.

* Fix build error.

* Change HotKey type to Key.

* Change HotKey.setter to private.

* Fix warnings.

* Fix some bugs.

* Rename ShortcutDelimiter to Separator.

* Add Separator property into the Configuration Manager.

* Change XML doc for Separator.

* Replace KeyEvent with Key.

* Add unit test preventing the Key.Separator is never Null ('\0).
2024-08-13 13:46:00 -06:00
BDisp
63e75b7413 Fixes #3109. AOT support with .Net 8. (#3638)
* Add a native AOT project.

* Fixes Text.Json to work with native AOT.

* Fix silent errors on unit tests when testing the Red color which has a length of 3.

* Allowing test custom configuration without the config.json file match the unit tests configurations.

* Fix unit test if tested alone.

* Add native project into solution.

* Fix merge errors.

* Setting ConfigurationManager.ThrowOnJsonErrors as true to throw any serialization issue when published file runs.

* Remove unnecessary using's.

* Added unit test to ensure all serialization is properly configured.

* Fix warnings.

* Remove ThrowOnJsonErrors.

* Fix warnings.

---------

Co-authored-by: Tig <tig@users.noreply.github.com>
2024-08-06 12:05:36 -06:00
Tig
0bd50c5b93 Fixes #3641. CheckBox.State -> CheckBox.CheckState (#3648)
* State->CheckState.
Toggled->CheckStateChanging.

* Code cleanup & doc fix

* Updated migration guide

* Updated migration guide
2024-08-06 08:39:55 -06:00
Tig
12df9beebe Fixed linux/mac test failure 2024-08-05 18:03:08 -06:00
Tig
c0fc83bd78 Added Scenario and expanded API 2024-08-05 17:44:48 -06:00
Tig
126120b6dc Merged.
Feature complete
2024-08-05 12:36:13 -06:00
Tig
9865f72801 Merged with v2_develop.
Code cleanup
2024-08-05 09:14:33 -06:00
Tig
cebf1773af Added other types 2024-08-04 17:10:00 -06:00
Tig
f5b1984db7 Made unit tests more resiliant to config changes 2024-08-04 15:08:18 -06:00
Tig
9526b4eabd Found and fixed another Shortcut bug 2024-08-03 21:59:28 -06:00
Tig
18ac4abab4 simplified test 2024-08-03 21:49:27 -06:00
Tig
87726454c9 Fixed KeyBinding issue @bdisp found 2024-08-03 17:16:06 -06:00
Tig
79e50b4d8f Nuked AlternateFwd/BkKeys.
Added Next/PrevTabGroupKey.
Fixed tests.
2024-08-02 13:41:53 -06:00
Tig
37f349004a WIP: More. Trying to fix TableView regression 2024-07-31 02:07:48 -04:00
Tig
cf1435ae96 WIP: Fixed stuff. Broke stuff. Making progress. 2024-07-29 16:59:58 -04:00
Tig
f2eb9ce6e2 WIP: More refining 2024-07-29 10:17:10 -04:00
Tig
3f19a6f04a Added low-level Focus tests 2024-07-26 08:00:45 -04:00
Tig
66f83ad2e6 Reduced duplicated code by leverating Navigationdirection enum 2024-07-25 16:37:22 -06:00
Tig
a935ef83df Merge remote-tracking branch 'refs/remotes/origin/v2_2491-Toplevel-Redesign' into v2_2491-Toplevel-Redesign 2024-07-25 14:50:19 -06:00
Tig
ccec0eec11 Documenting focus code 2024-07-25 12:16:10 -06:00
Tig
331d9726d7 nullable enable TopLevel 2024-07-24 16:18:20 -06:00
Tig
cb3e80666f Moved Overlapped stuff to ApplicationOverlap static class. Fixed nullable warnings. 2024-07-24 15:43:35 -06:00
Tig
f37ec5e04f Moved Overlapped stuff to ApplicationOverlap static class. Fixed nullable warnings. 2024-07-24 15:42:04 -06:00
Tig
022050db73 Fixed nullable warnings 7 2024-07-24 15:09:48 -06:00
Tig
ff47aa29b9 Fixed nullable warnings 6 2024-07-24 14:39:34 -06:00
Tig
73a9dc37c4 Fixed nullable warnings 2 2024-07-24 14:15:32 -06:00
Tig
4a56b84324 removed unneeded AlternateBack/FormardKey code from Toplevel 2024-07-24 12:41:28 -06:00
Tig
c03dd32031 Moved Toplevel keybindings out of Toplevel to Application.
Still need to move navigation code out of Toplevel
2024-07-24 12:28:30 -06:00
Tig
44ce74a5c0 Refactored Application into smaller files.
Made Application #nullable enable
2024-07-22 16:52:02 -06:00
Tig
f328f0c93f Initial commit. 2024-07-21 16:52:18 -06:00
Tig
0e70444e08 Renamed Width/Height/Size 2024-07-20 11:36:05 -06:00
Tig
6550cde7b5 Nuked Textformatter.AutoSize.
Removed references to AutoSize throughout.
Updated unit tests.
2024-07-20 11:17:46 -06:00
Tig
4128b515da Merge branch 'v2_develop' into v2_3499-Finish-DimAuto 2024-07-19 17:34:13 -06:00
Tig
fa847f4356 Revert "rebased against v2_develop"
This reverts commit 23737decec.
2024-07-19 17:32:53 -06:00
Tig
23737decec rebased against v2_develop 2024-07-19 17:02:14 -06:00
Cam Sinclair
952fc49709 Fix typos 2024-07-19 13:16:48 +10:00
Tig
b4e1b3ec5e All unit tests pass.
Made TextFormatter have independent Width/Height.
2024-07-18 15:24:11 -06:00
Tig
f6064be449 Fixed SetTextFormatterSize 2024-07-17 08:14:09 -06:00
Tig
a30dbe7286 Fixed broken Window test 2024-07-16 18:51:24 -06:00
Tig
e93eebb708 Fixed little things. 2024-07-16 18:40:51 -06:00
Tig
a3b606fe6e New unit tests. Lots of fixes 2024-07-15 16:36:05 -06:00