* Fixes#3678. ContextMenu accesses disposed MenuBar.
* Preserve always the last menu opened.
* Re-added MenuAllClosed event.
* Ensures call CleanUp if Application.MouseGrabView hold another MenuBar than the calling one.
* Fix unit tests.
* Passing the offending object instead of the View type.
* Add that to the dictionary to shut respeller up.
* Address a few warnings
* A question
* Just a little more cleanup
* Combine these and comment
* Slight additional cleanup
* More minor cleanup
We already know it is null. just make it the else instead of a new condition
* Nullable != true ===> is not true
* Unconditional break at the top is just a part of the while statement (inverted)
* Fixes#3687. ColorPicker isn't respecting the current UI culture.
* Fix @dodexahedron erroneous code.
* Cleanup comments.
---------
Co-authored-by: Brandon Thetford <github@snapsinazfs.com>
Co-authored-by: Tig <tig@users.noreply.github.com>
* Readonly HSL view
* Make it possible to move between bars by moving to subview
* Basically working and with mouse support
* Fix HSL to work properly with double values instead of color matching
* Fix Value on ColorPicker to match HSL values
* Fix color spectrum
* Add Swatch and better sync with text box
* Work on jitter
* ColorPicker HSL working
* More keybindings
* Add ColorModel
* Support both HSL and HSV
* Add RGB
* Better mouse handling
* WIP: AttributeView and integrate into LineDrawing
(does not currently work properly)
* Fix color picking
* Add concept of an ITool
* Add ColorPickerStyle
* Fix selected cell rendering
* Add first test for ColorPicker2
* Add more RGB tests
* Improve ColorPicker2 setup process
* Tests and fixes for keyboard changing value R
* Fix margin on bars when no textfields
* Add mouse test
* Add tests for with text field
* Add more tests and fix bug sync component text field change with hex text field
(WIP - failing tests)
* Fix tests and fix clicking in a bar label area possibly not selecting
* Move AttributeView to LineDrawing and adjust to have a 'transparent pattern' too
* Render triangle in dark gray if background is black
* Add ColorChanged event
* Resharper Cleanup
* Xml comments and public/private adjustments
* Explore replacing diagram test with fragile Subview diving
* Migrate ColorPicker_DefaultBoot to sub asserts
* Port other tests
* Replace ColorPicker with new view
* Fix ColorPicker size to match scenarios size assumptions
* Split to separate files and ignore invalid test for ColorPicker
* Ignore also in mouse version of AllViews_Enter_Leave_Events
* Remove bool _updating from ColorPicker
Now instead we are more selective about what we update when and do so deterministically
* Typo fix
* Fix ReSharper bad renames in comments for "Value"
* Refactor to single implementation of 'prompt for color' logic
- Now called PromptForColor
- Shared by LineDrawing and ProgressBarStyles scenarios
* Sum runes instead of Length
* Hide ColorBar and SetValueWithoutRaisingEvent from public API
* Move ColorEventArgs to Drawing folder
* Move ColorModel to Drawing folder
* First try at Dim.Auto for ColorPicker
* Remove explicit width/height setting in most scenarios
* Remove explicit heights
* Fixed build/test issues.
Illustrated test best practice.
* WIP: Start working on test changes and add new options to ColorPickers scenario (Color Model and show textfields).
* Fix for R indicator arrow sometimes 'falling off' the drawn area.
* Add nullable enable
* Test fixes and refactor for avoiding Begin
* Make ColorEventArgs inherit from EventArgs<Color>
* Fix Dispose not being called on bars when switching color models
* Remove 'oldColor' from test now it is not supported
* Add initial stab at ColorPickerStyle.ShowName
* Use AppendAutocomplete for color names
* Implemented resoruce based colorname resolver
* Update GetTextField to support getting the color names field
Change style setting to ShowColorName
* Color name updates when navigating away from the named color
* Restore old color picker as ColorPicker16
* Add test that shows 'Save as' is currently considered a named color ><
* Fix GetW3CColorNames
* Removed dupe colors
* Revert to old color pickers
* Nullability question marks for everyone!
---------
Co-authored-by: Tig <tig@users.noreply.github.com>
* Moving ShortcutDelimiter from MenuBar to Key.
* Rename to ShortcutKey and change type to Key.
* Improving add and remove menu items dynamically.
* Code cleanup.
* Fix status bar shortcuts issues.
* Fix build error.
* Change HotKey type to Key.
* Change HotKey.setter to private.
* Fix warnings.
* Fix some bugs.
* Rename ShortcutDelimiter to Separator.
* Add Separator property into the Configuration Manager.
* Change XML doc for Separator.
* Replace KeyEvent with Key.
* Add unit test preventing the Key.Separator is never Null ('\0).
This will require re-visiting the design at a deep level and fixing some long-standing but ignored issues such as how OnEnter/OnLeave don't follow proper cancelation design. Also, there's a need for keeping track of the old focus state of a tree of subviews when that tree loses focus; FocusDireciton is a hack that causes tons of confusion.
