* Initial plan
* Add ScreenChanged event, SetScreenSize method, and fix FakeDriver buffer initialization
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Add comprehensive tests for ScreenChanged event and buffer integrity
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Replace obsolete SizeChanged usage with ScreenChanged in core and tests
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Refactor terminal size event handling
Replaced `ScreenChanged` with `SizeChanged` across the codebase to standardize naming and improve clarity. Updated event handling logic, including subscriptions, unsubscriptions, and raising methods. Removed deprecated `ScreenChanged` event and backward compatibility code.
Refactored driver initialization to handle legacy `IConsoleDriver` types separately. Updated tests and mock implementations to align with the new `SizeChanged` event. Improved documentation and comments to reflect these changes.
These updates enhance maintainability, consistency, and modernize the architecture.
* Refactor & Code Cleanup: Replace IWindowSizeMonitor with IConsoleSizeMonitor
Renamed `IWindowSizeMonitor` to `IConsoleSizeMonitor` across the codebase, updating all references, method signatures, and event handlers. Replaced the `WindowSizeMonitor` class with the new `ConsoleSizeMonitor` implementation, which includes improved terminal size change handling via the `Poll` method.
Enabled nullable reference types in several files to enhance code safety. Updated test cases to reflect the new `IConsoleSizeMonitor` interface. Removed redundant code, simplified null checks, and corrected minor typos in comments. Streamlined the codebase by removing the obsolete `WindowSizeMonitor` class and its interface.
* Code cleanup - Refactor and enhance ShadowView and FakeDriverTests
Updated ShadowView.cs to use null-conditional operators and added null checks for safer access to `ScreenContents`. Refined XML documentation in View.Layout.cs for clarity and consistency.
Refactored FakeDriverTests.cs to leverage modern C# features, including shorthand object instantiation, inline lambdas, and tuple-like syntax for `Size` and `Rectangle`. Removed redundant tests and improved test readability and reliability.
Enhanced error handling with null checks and ensured backward compatibility for deprecated events. Improved test coverage for resizing, clipboard operations, and invalid coordinates. Verified buffer integrity and screen updates after resizing.
General improvements include replacing explicit type declarations with `var`, removing unused imports, and aligning code formatting for better readability.
Refactor and improve code quality and test coverage
Updated `ShadowView` for null safety using null-conditional operators. Simplified object initializations and modernized syntax across the codebase, including shorthand initializations and inline lambdas. Enhanced event handling logic and ensured compatibility with obsolete members.
Refactored `FakeDriverTests` by removing redundant code, standardizing formatting, and improving test setup. Suppressed obsolete warnings where necessary. Improved XML documentation in `View.Layout.cs` for clarity and removed outdated references.
Performed general cleanup, including removing unused namespaces, redundant comments, and ensuring consistent formatting. These changes enhance readability, maintainability, and runtime safety.
* Code cleanup
Refactor TimedEventsTests for readability and consistency
Improved code readability and maintainability:
- Enabled nullable reference types with `#nullable enable`.
- Removed unused `using System.Diagnostics;`.
- Updated namespace to `UnitTests.ApplicationTests`.
- Replaced `Terminal.Gui.App.TimedEvents` with `TimedEvents`.
- Reformatted XML documentation comments for alignment.
- Used `var` and target-typed new expressions for consistency.
- Reformatted `Parallel.For` loops and lambdas for clarity.
- Added `Thread.Sleep(10)` to prevent excessive CPU usage in tests.
- Improved assertions and event handler formatting in tests.
Aligned with modern C# coding practices.
* Code Cleanup - No more driver warnings.
Refactor codebase and introduce FakeClipboard
- Adjusted `.editorconfig` to change severity levels for CS0612, CS0618, and CS0672 diagnostics.
- Replaced `FakeDriver.FakeClipboard` with a new `FakeClipboard` class for testing purposes, supporting exception handling and clipboard data manipulation.
- Removed redundant methods (`MakeColor`, `MapKey`) and unused classes (`MockConsoleDriver`) to streamline the codebase.
- Refactored `ConsoleDriverFacade` and `FakeDriver` to simplify logic and improve maintainability.
- Updated tests to use `CreateFakeDriver` and removed or commented out obsolete tests.
- Reformatted and cleaned up code for readability across multiple files.
* Refactor FakeDriver - Code Cleanup
Standardized console size management by replacing `WindowSizeMonitor` with `ConsoleSizeMonitor` across the codebase. Updated methods `GetWindowSize` and `SetWindowSize` to `GetSize` and `SetSize` for consistency.
Refactored `FakeDriver` to use `SetScreenSize` and removed redundant methods. Simplified driver initialization by removing legacy `InternalInit` logic.
Standardized ANSI escape sequences by replacing `CSI_ReportTerminalSizeInChars` with `CSI_ReportWindowSizeInChars`.
Updated test cases to align with the new `ConsoleSizeMonitor` and `SetScreenSize` methods. Removed obsolete test utilities like `FakeSizeMonitor` and `FakeWindowSizeMonitor`.
Performed general code cleanup, including removing unused classes, redundant code, and improving formatting. Fixed resizing logic issues and improved exception handling in driver methods.
* Update Terminal.Gui/Drivers/OutputBuffer.cs
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update Terminal.Gui/Drivers/MouseButtonStateEx.cs
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update Terminal.Gui/App/MainLoop/IApplicationMainLoop.cs
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update Tests/UnitTests/Views/ToplevelTests.cs
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update Terminal.Gui/ViewBase/View.Layout.cs
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Moved all Drawing tests to Paralleizable - proving Fakedriver works
Enhanced `Ruler` and `Thickness` classes by adding an optional `IConsoleDriver? driver` parameter to decouple rendering from the default `Application.Driver`, improving flexibility and testability. Updated `DriverAssert` to support nullable drivers and added defensive checks.
Refactored and expanded test cases for `Ruler`, `Thickness`, `LineCanvas`, and `StraightLineExtensions` to ensure comprehensive coverage, including zero-length intersections, line rendering, and exclusion logic. Migrated rendering-dependent tests to a parallelizable namespace.
Removed redundant tests, improved naming conventions, and updated documentation for better maintainability and clarity.
* Fixed Run<T> startup hang.
Refactor: Simplify driver logic and update SetSize methods
Removed FakeDriver safeguard in unit tests to simplify
CreateDriver logic. Updated SetSize methods in NetOutput,
UnixOutput, and WindowsOutput to do nothing instead of
throwing NotImplementedException. Modified SizeChanged
event in ConsoleDriverFacade to call SetScreenSize directly.
Commented out unnecessary debug validation in DimAuto.
These changes improve maintainability and reduce complexity.
* Fixed intermittent unit test bug.
Refactored `_cachedRunStateToplevel` to `CachedRunStateToplevel` as an internal static property, delegating its management to `ApplicationImpl` for improved encapsulation. Updated all references to use the new property and centralized its handling in `ApplicationImpl`.
Removed the `MouseGrabHandler` property from `ApplicationImpl` and simplified driver-related assignments by replacing `Application.ForceDriver` and `Application.Screen` with direct references.
Reset `CachedRunStateToplevel` during cleanup to ensure proper state management. Updated the `Invoke` method to use `Top` directly, aligning with the refactored design. Improved debug assertions and performed general cleanup to enhance code readability and maintainability.
* Fixed intermittent bug an massive code cleanup of warnings.
Refactor and enhance codebase for maintainability
- Applied null-conditional operator (`!`) to improve null-safety.
- Refactored tests for clarity, added new cases, and removed redundancies.
- Introduced `FakeApplicationFactory` and `FakeSizeMonitor` for testing.
- Removed unused code, including legacy `DecodeEscSeq` logic.
- Reformatted code for readability and consistency.
- Updated assertions for more accurate validation in tests.
- Fixed potential null reference issues across multiple files.
- Improved event handling with proper null checks.
- Enhanced documentation for new classes and methods.
- Modernized code with C# features like `record struct` and `nullable enable`.
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: tig <585482+tig@users.noreply.github.com>
Co-authored-by: Tig <tig@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Move parallelizable to new file
* Add UseSameRuneTypeForWords property
* Add SelectWordOnlyOnDoubleClick property and ProcessDoubleClickSelection method
* Change IsSameRuneType method to also handle equivalent rune types
* Fix WordBackward and WordForward to support properly handle rune types
* Fix unit test to deal properly with the new roles of rune types
* Add new unit tests
* Remove duplicated unit test
* Add UseSameRuneTypeForWords and SelectWordOnlyOnDoubleClick handling into Editor scenario
* touching publish.yml
* ColorScheme->Scheme
* ColorScheme->Scheme 2
* Prototype of GetAttributeForRole
* Badly broke CM
* Further Badly broke CM
* Refactored CM big-time. View still broken
* All unit test pass again. Tons added. CM is still WIP, but Schemes is not mostly refactored and working.
* Actually:
All unit test pass again.
Tons added.
CM is still WIP, but Schemes is not mostly refactored and working.
* Bug fixes.
DeepMemberWiseClone cleanup
* Further cleanup of Scope<T>, ConfigProperty, etc.
* Made ConfigManager thread safe.
* WIP: Broken
* WIP: new deep clone impl
* WIP: new deep clone impl is done. Now fixing CM
* WIP:
- config.md
- Working on AOT clean up
- Core CM is broken; but known.
* WIP
* Merged.
Removed CM from Application.Init
* WIP
* More WIP; Less broke
* All CM unit tests pass... Not sure if it actually works though
* All unit tests pass... Themes are broken though in UI Cat
* CM Ready for review?
* Fixed failures due to TextStyles PR
* Working on Scheme/Attribute
* Working on Scheme/Attribute 2
* Working on Scheme/Attribute 3
* Working on Scheme/Attribute 4
* Working on Scheme/Attribute 5
* Working on Scheme/Attribute 6
* Added test to show how awful memory usage is
* Improved schema. Updated config.json
* Nade Scope<T> concurrentdictionary and added test to prove
* Made Themes ConcrurrentDictionary. Added bunches of tests
* Code cleanup
* Code cleanup 2
* Code cleanup 3
* Tweaking Scheme
* ClearJsonErrors
* ClearJsonErrors2
* Updated Attribute API
* It all (mostly) works!
* Skip odd unit test
* Messed with Themes
* Theme tweaks
* Code reorg. New .md stuff
* Fixed Enabled. Added mock driver
* Fixed a bunch of View.Enabled related issues
* Scheme -> Get/SetScheme()
* Cleanup
* Cleanup2
* Broke something
* Fixed everything
* Made CM.Enable better
* Text Style Scenario
* Added comments
* Fixed UI Catalog Theme Changing
* Fixed more dynamic CM update stuff
* Warning cleanup
* New Default Theme
* fixed unit test
* Refactoring Scheme and Attribute to fix inheritance
* more unit tests
* ConfigProperty is not updating schemes correctly
* All unit tests pass.
Code cleanup
* All unit tests pass.
Code cleanup2
* Fixed unit tests
* Upgraded TextField and TextView
* Fixed TextView !Enabled bug
* More updates to TextView. More unit tests for SchemeManager
* Upgraded CharMap
* API docs
* Fixe HexView API
* upgrade HexView
* Fixed shortcut KeyView
* Fixed more bugs. Added new themes
* updated themes
* upgraded Border
* Fixed themes memory usage...mostly
* Fixed themes memory usage...mostly2
* Fixed themes memory usage...2
* Fixed themes memory usage...3
* Added new colors
* Fixed GetHardCodedConfig bug
* Added Themes Scenario - WIP
* Added Themes Scenario
* Tweaked Themes Scenario
* Code cleanup
* Fixed json schmea
* updated deepdives
* updated deepdives
* Tweaked Themes Scenario
* Made Schemes a concurrent dict
* Test cleanup
* Thread safe ConfigProperty tests
* trying to make things more thread safe
* more trying to make things more thread safe
* Fixing bugs in shadowview
* Fixing bugs in shadowview 2
* Refactored GetViewsUnderMouse to GetViewsUnderLocation etc...
* Fixed dupe unit tests?
* Added better description of layout and coordiantes to deep dive
* Added better description of layout and coordiantes to deep dive
* Modified tests that call v2.AddTimeout; they were returning true which means restart the timer!
This was causing mac/linux unit test failures.
I think
* Fixed auto scheme.
Broke TextView/TextField selection
* Realized Attribute.IsExplicitlySet is stupid; just use nullable
* Fixed Attribute. Simplified. MOre theme testing
* Updated themes again
* GetViewsUnderMouse to GetViewsUnderLocation broke TransparentMouse.
* Fixing mouseunder bugs
* rewriting...
* All working again.
Shadows are now slick as snot.
GetViewsUnderLocation is rewritten to actually work and be readable.
Tons more low-level unit tests.
Margin is now actually ViewportSettings.Transparent.
* Code cleanup
* Code cleanup
* Code cleanup of color apis
* Fixed Hover/Highlight
* Update Examples/UICatalog/Scenarios/AllViewsTester.cs
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update Examples/UICatalog/Scenarios/CharacterMap/CharacterMap.cs
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update Examples/UICatalog/Scenarios/Clipping.cs
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Fixed race condition?
* reverted
* Simplified Attribute API by removing events from SetAttributeForRole
* Removed recursion from GetViewsAtLocation
* Removed unneeded code
* Code clean up.
Fixed Scheme bug.
* reverted temporary disable
* Adjusted scheme algo
* Upgraded TextValidateField
* Fixed TextValidate bugs
* Tweaks
* Frameview rounded border by default
* API doc cleanup
* Readme fix
* Addressed tznind feeback
* Fixed more unit test issues by protecting Application statics from being set if Application.Initialized is not true
* Fixed more unit test issues by protecting Application statics from being set if Application.Initialized is not true 2
* cleanup
---------
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Add collection search matcher
* Fix naming
* fix naming
* Move FileDialogCollectionNavigator to its own file (no longer private class)
Add class diagram for collectionNavigation
* Add ICollectionNavigator interface
* Move to separate file IListCollectionNavigator
* Update class diagram
* update class diagram
* Add tests for overriding ICollectionNavigatorMatcher
* xmldoc and nullability warning fixes
* Code Cleanup
* Make requested changes to naming and terminology
* Move to seperate namespace
* Update class diagram and change TreeView to reference the interface not concrete class
* Switch to implicit new
* highlight that this class also works with tree view
* Apply tig patch to ensure keybindings get priority over navigator
See: https://github.com/gui-cs/Terminal.Gui/issues/4027#issuecomment-2810020893
* Apply 'keybinding has priority' fix to TreeView too
* Apply 'keybindngs priority over navigation' fix to TableView
* Remove entire branch for selectively returning false now that it is default when there is a keybinding collision
* Make classes internal and remove 'custom' navigator that was configured in UICatlaogToplevel
* Change logging in collection navigator from Trace to Debug
* Switch to NewKeyDownEvent and directly setting HasFocus
* Remove application top dependency
* Remove references to application
* Remove Application
* Move new tests to parallel
---------
Co-authored-by: Tig <tig@users.noreply.github.com>
* Add constructor Key(int) and operator for handled with non-Bmp.
* Fix TextField non-BMP issues
* Fix TextField PositionCursor.
* Reformat
* Add IsValidInput method to handle clipboard paste when pressing CTRL+V in WT
* Add handle IsValidInput in FakeDriver and unit tests
* Fixes#3984 - `Margin` w/out shadow should not force draw (#3985)
* shortcut tests
* Generic demos
* Optimize Margin to not defer draw if there's no shadow
* Fixes#4041. WSLClipboard doesn't handles well with surrogate pairs
* Avoid running Clipboard.Contents twice
* Fixes#4042. Microsoft.VisualStudio.TestPlatform.ObjectModel.TestPlatformException: Could not find testhost
* Moving tests to the parallelizable unit tests
* Remove unused folder
* Prevent warnings about not installed nuget packages
* Using Toplevel instead of Application.Top
* Cleanup code
---------
Co-authored-by: Tig <tig@users.noreply.github.com>
* touching publish.yml
* Fixed UICatalog bugs. Added fluent tests.
* marked v1 menu stuff as obsolte
* Tweaks.
Added View.GetSubMenus<type>().
* fixed unit tests
* general messing around
* general messing around
* Playing with Fluent
* ColorScheme tweaks
* WIP: ColorScheme tweaks
* Playing with Fluent
* Merged from laptop2
* Hacky-ish fixes to:
- #4016
- #4014
* Fixed Region bug preventing menus without borders from working
* Tweaks
* Fixed a bunch of CM issues
* Fixed OoptionSelector
* ip
* FixedCM issues
* Fixed CM issues2
* Revert "FixedCM issues"
This reverts commit dd6c6a70a3.
* Reverted stuff
* Found and fixed bug in AllViews_Center_Properly
* Fixed CM issues2
* removed menuv2 onapplied.
Changed how UICatalog Applys CM
* changed test time out to see if it helkps with ubuntu fails
* reset app on fail?
* back to 1500ms
* Made StatusBar nullable.
* Code Cleanup.
* HexEditor Code Cleanup.
* HexEditor Code Cleanup.
* Back to 3000ms. Sigh.
* Trying different logic
* Trying different logic2
* Fixed potential crash in runlop
* Fixed potential crash in runlop2
* Tweaked Spinner stuff
* Removed TabView from TextEffects scenario. Not needed and possible culprit.
* back to 2000ms
* WIP: Revamping menu scenarios
* Menu Scenario refinements.
Fixed a few bugs.
Code cleanup.
* fixed unit test
* Fixed warnings
* Fixed warnings2
* Fixed File.Exit
* WIP: Dealing with QuitKey struggles
* WIP: Dealing with QuitKey struggles 2
* WIP: Dealing with QuitKey struggles 3
* Fixed ListView collection nav bug
* Fixed a bunch of menu stuff.
Fixed Appv2 stuff.
* Lots of refactoring and fixing
* Lots of unit test issues
* Fixed DebugIDisposable issues
* Fixed release build issue
* Fixed release build issue 2
* DebugIDisposable -> EnableDebugIDisposableAsserts and more
* DebugIDisposable -> EnableDebugIDisposableAsserts and more 2
* Fixed Menus scenario - context menu
* Added @bdisp suggested assert. Commented it out as it breaks tests.
* Code cleanup
* Fixed disposed but
* Fixed UICatalog exit
* Fixed Unit test I broke.
Added 'Minimal' Theme that turns off all borders etc...
* Subview clean up
* New Add/Remove event pattern
* Using Logging
* cleanup
* Subview -> SubView
* Test code cleanup. Killed many warnings.
* Fix tznind feedback
* Refactored AllViewTest helpers
* Moved keyboard tests to parallel
* Moved mouse tests to parallel
* Moved view tests to parallel
* Test code cleanup. Killed many warnings.
* dupe test
* Some mouse tests can't run in parallel because MouseGrabView
* Made SpinnerView more testable
* Moved more tests
* SubViews to IReadOnlyCollection<View>
* SubViews to IReadOnlyCollection<View> 2
* scrollbar tests
* shortcut tests
* Use InternalSubViews vs. _subviews
* Nuked View.IsAdded.
Added View.SuperViewChanged.
* API doc updats
* Unit Test tweak
* Unit Test tweak
