3 Commits

Author	SHA1	Message	Date
Tig	ff18ad4532	Fixes build warnings recently introduced (#4506) ... * Fixed warnings I recently introduced. Replaced nullable App references with null-forgiving operator (!) in MessageBox and dialog calls to suppress nullable warnings. Updated XML docs to use Dim.Fill() and clarified method references. Made Application.Popover registration null-safe. Fixed test output helper usage in ShadowTests. No functional changes. * Fixes Release build warnings	2025-12-17 12:57:38 -07:00
BDisp	1a54ff0872	Fixes #4502. Shadows in overlapping views are not rendered consistently (#4465) ... * Fixes Wide Glyphs * Fix some unit tests failure * Fix more unit tests * Fixes #4468 - `MouseGrab` regressions (#4469) * Fixed mouse grab issue * Fixed mouse grab regrssions. * Update Terminal.Gui/ViewBase/View.Mouse.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update Terminal.Gui/ViewBase/View.Mouse.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update Terminal.Gui/ViewBase/View.Mouse.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update Terminal.Gui/ViewBase/View.Mouse.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update Terminal.Gui/ViewBase/View.Mouse.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update Terminal.Gui/ViewBase/View.Mouse.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * code cleanup * Update Terminal.Gui/ViewBase/View.Mouse.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Addressing pr feedback * updated mouse.md --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Fixes #4050. Rename Command.Select and Selecting to Activate/Activating (#4470) * Initial plan * Rename Command.Select to Command.Activate and Selecting to Activating Co-authored-by: tig <585482+tig@users.noreply.github.com> * Add Activating event propagation to SuperView Co-authored-by: tig <585482+tig@users.noreply.github.com> * Update all comments and docs referencing Select to Activate Co-authored-by: tig <585482+tig@users.noreply.github.com> * Fix event log messages in examples to use Activating/Activate Co-authored-by: tig <585482+tig@users.noreply.github.com> * Revert automatic Activating event propagation that broke tests Co-authored-by: tig <585482+tig@users.noreply.github.com> * Update docfx documentation to use Activate/Activating terminology Co-authored-by: tig <585482+tig@users.noreply.github.com> * renames * Revert "Add Activating event propagation to SuperView" This reverts commit 6d82bee9ad. * added command diagrams * mermaid * updated level 3 * again * Select->Activate in MouseTests.cs * Update Terminal.Gui/Views/Selectors/FlagSelector.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Refactor: Rename Selecting to Activating in View APIs Renamed the `Selecting` event and `OnSelecting` method to `Activating` and `OnActivating` to better reflect their purpose. Updated all related comments, test method names, variables, and assertions in `View` and `ViewCommandTests` to align with the new terminology. Improved code clarity by using `_` for unused parameters in lambda expressions. Renamed properties like `HandleSelecting` to `HandleActivating` and adjusted naming conventions for consistency (e.g., `OnactivatingCount` to `OnActivatingCount`). These changes enhance readability, maintainability, and terminology consistency across the codebase. * Update Terminal.Gui/Views/Selectors/OptionSelector.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Typos --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: tig <585482+tig@users.noreply.github.com> Co-authored-by: Tig <tig@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Add support for wide glyphs into the ShadowStyle.Transparent * The "IsDirty" content of the wide glyphs should be completely false after being displayed on the screen. * FillRect must always call AddStr method to properly handle wide characters to invalidate overlapped wide glyphs, etc. * We must set clip to the driver screen in the case where the view isn't Adornment and SuperView is null, allowing dialogs, popovers, etc to be drawn * These assertions are important to ensure that the drawing state is consistent * Subviews must be drawn after the superview content being drawn * The attribute of next column of a wide glyph should be the same if it's in the clipped area * Applied #4486 * Updated root view clipping logic to use App's screen or a large default rectangle, ensuring proper drawing area. Added comments clarifying subview drawing order and explaining issues with certain Debug.Assert checks in complex hierarchies, suggesting unit tests instead. * Remove ClearFrame and always draw Margin if Thickness set Removed the unused ClearFrame method from the View class. Updated DrawAdornments to always draw the Margin when its Thickness is not empty, regardless of ShadowStyle. This simplifies the drawing logic and removes unnecessary checks. * Fix margin thickness adjustment * Fix shadow draw on overlapped views * Only draw shadows at the end of each runnable * Only call ClearNeedsDraw in the static Draw method * Replace unit test as requested * Also use reverse in margins although not making difference * Fix the ShadowStyle, ShadowWidth and ShadowHeight logic * Making sure nothing broke. * ShadowWidth and ShadowHeight always default to 1 at invalid values * Removes unused parameter * Using Rune.ReplacementChar to not confusing with space char inserted by the clearing region * Using Rune.ReplacementChar * Using Rune.ReplacementChar * Fix merge error * Fixing unit tests * Reverting changes * Fixing unit tests * Fix unit test * Fix shadow on overlapped views * Cleanup code --------- Co-authored-by: Tig <tig@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: tig <585482+tig@users.noreply.github.com>	2025-12-17 11:56:31 -07:00
Tig	0a9f4b8ef1	Fixes #4492, #4480 - Transparent shadows cause underlying wide glyph rendering issues (#4490) ... * WIP - experiments in fixing shadow rendering issues based on #4465 Previously, shadow size was fixed at 1x1. This change introduces ShadowWidth and ShadowHeight properties to both Margin and View, allowing variable shadow dimensions. The Margin class now manages its own shadow sizing, enforcing valid values based on ShadowStyle (e.g., Opaque and Transparent require a minimum of 1, and Opaque only allows 1). Margin.Thickness is dynamically adjusted to account for shadow size, with original values preserved and restored as needed. ShadowView rendering is updated to correctly handle wide graphemes (such as emojis) in the shadow area, preventing rendering errors. The View class exposes ShadowWidth and ShadowHeight, synchronizing with Margin. Extensive new unit tests verify correct behavior for shadow sizing, style changes, thickness adjustments, and rendering, including edge cases and visual output. Additional minor bug fixes and refactoring are included, such as proper management of Margin's cached clip region and correcting a loop order bug in ShadowView. The codebase is also modernized with recent C# features. * more merge * added border tests * Experiment... * Incorporated latest wideglyphs * Comment tweaks * Add Adornments and ViewportSettings editors to WideGlyphs Introduce AdornmentsEditor and ViewportSettingsEditor with custom border styles and positioning, enhancing UI editing capabilities. Also update arrangeableViewAtEven to use Color.Black and Color.Green, and adjust a commented border style from Dashed to Dotted. * Fix scenario editors and tweak scenarios. Enhance ShadowStyles with a second shadow window (transparent style) and a button event handler that shows a message box. In WideGlyphs, add AdornmentsEditor and ViewportSettingsEditor for view property editing, apply custom color schemes to arrangeable views, and update superView with a transparent shadow and increased shadow width. These changes improve interactivity and visualization in the demo scenarios. * Fix scenario editors and tweak scenarios. Enhance ShadowStyles with a second shadow window (transparent style) and a button event handler that shows a message box. In WideGlyphs, add AdornmentsEditor and ViewportSettingsEditor for view property editing, apply custom color schemes to arrangeable views, and update superView with a transparent shadow and increased shadow width. These changes improve interactivity and visualization in the demo scenarios. * Make replacement char themeable via Glyphs.ReplacementChar Adds Glyphs.ReplacementChar as a configurable replacement character, replacing all uses of Rune.ReplacementChar. The default is now a space (' ') and can be set via config.json. Updates all rendering, string decoding, and buffer invalidation logic to use the new property, ensuring consistency and themeability. Updates tests and comments accordingly. Also includes minor UI tweaks in WideGlyphs.cs and .DotSettings updates. * merging * merge errors * merged * merged * Refactor shadow properties to Margin; update tests ShadowWidth and ShadowHeight are now managed solely in the Margin class, with related properties and validation logic removed from View. All code and tests now use view.Margin.ShadowWidth/ShadowHeight. Tests and documentation were updated accordingly, and wide glyph handling in test output was improved for consistency. * Simplify ShadowSize; remove it from View as it's infreqnetly used. Make it a Size to reduce API surface area. Replace ShadowWidth/ShadowHeight with a single ShadowSize property (of type Size) in the Margin class and related code. Update all usages, validation logic, and tests to use ShadowSize.Width and ShadowSize.Height. Introduce TryValidateShadowSize for unified validation. Modernize code with C# features and improve clarity and maintainability by treating shadow dimensions as a single unit. * reveted * Fix wide glyph attribute handling for second column Ensure the attribute for the second column of wide glyphs is set correctly when within the clip region, addressing issues #4258 and #4492. Add comprehensive unit tests to verify correct attribute assignment and output rendering, including scenarios with transparent shadows. Remove obsolete test code for clarity. This improves color/style consistency for wide glyphs, especially in overlapping UI situations. * added url	2025-12-16 14:23:32 -07:00