Files
Terminal.Gui/Tests/TerminalGuiFluentTesting/GuiTestContext.cs
Tig be9d1939c1 Fixes #4372 - Genericize FlagSelector/OptionSelector, Replace RadioGroup (#4373)
* Refactor selectors and improve UI components

Refactored `MarginEditor` and `UICatalogTop` to use new `OptionSelector` and `FlagSelector` classes, introducing type-safe generic versions for better flexibility and maintainability. Added `SelectorBase` as a shared foundation for these components, along with the `SelectorStyles` enum for customizable styles.

Enhanced unit tests to cover new implementations and edge cases. Enabled nullable reference types for improved null safety. Improved code readability, reduced redundancy, and enhanced user experience with better hotkey management, focus handling, and layout adjustments.

* Refactor UI components and remove unused classes

Significant refactoring and simplification of the codebase:
- Updated `CharacterMap` to use `OptionSelector<UnicodeCategory>`.
- Removed `FlagSelector`, `FlagSelector<TEnum>`, and `FlagSelectorStyles`.
- Replaced `OptionSelector.Options` with `Labels` in `MenuBarv2`.
- Removed `OptionSelector` and its associated properties/methods.
- Updated terminology from "Activate" to "Select" across components.
- Refactored `SelectorBase` to align with new "Select" behavior.
- Removed redundant methods, properties, and event handlers.

These changes streamline the codebase, reduce complexity, and align with updated design principles.

* Fixes #4374 - 'Application.Screen' is empty when 'Init' returns

Refactor and enhance testability of ApplicationImpl

Refactored `ApplicationImpl` and related classes to improve modularity and testability. Replaced `FakeConsoleOutput` with `FakeOutput` and introduced `FakeInput` for better test isolation. Added platform-specific factories (`FakeNetComponentFactory`, `FakeWindowsComponentFactory`) to simplify fake component creation.

Refactored `GuiTestContext` into partial classes, adding methods for simulating user interactions and improving initialization logic. Enhanced error handling and logging during test setup.

Updated tests to use the new `FakeOutput` and `FakeInput` implementations. Standardized driver initialization with `Application.Init(null, "fake")`. Skipped tests relying on the fake driver due to known issues.

Performed general cleanup, modernized syntax, and removed redundant code to improve readability and maintainability.

* Disable "windows" test case in SynchronizationContextTests

The `InlineData("windows")` attribute in the
`SynchronizationContext_Post` test method has been commented out.
This change temporarily excludes the `"windows"` driverName from
the test suite while retaining other test cases (`"fake"`,
`"dotnet"`, and `"unix"`). The exclusion may be for debugging,
deprecation, or other maintenance purposes.

* Disable "windows" test case in SynchronizationContextTests

The `[InlineData("windows")]` attribute in the
`SynchronizationContextTests` class has been commented out,
disabling the test case for the `"windows"` driver name.

This change may have been made for debugging, deprecation, or
because the test is no longer relevant. Other test cases
(`"fake"`, `"dotnet"`, and `"unix"`) remain active.

* Update Terminal.Gui/Drivers/FakeDriver/FakeConsole.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update Terminal.Gui/Views/Selectors/SelectorStyles.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update Terminal.Gui/Views/Selectors/SelectorBase.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update Terminal.Gui/Views/Selectors/OptionSelector.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update Terminal.Gui/Views/Selectors/OptionSelector.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update Terminal.Gui/Views/Selectors/OptionSelector.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update Terminal.Gui/Views/Selectors/SelectorBase.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Backported Checkbox from Activate PR

* Backported Checkbox from Activate PR 2

* Backported Checkbox from Activate PR 3

* Backported Selctors Scenario

* Backported Bars Scenario

* Backported AllViewsTester Scenario

* Backported Dialogs Scenario

* Backported MessageBoxes Scenario

* Backported ArrangementEditor

* Backported mouse binding fix

* Update Terminal.Gui/Views/Selectors/OptionSelector.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update Terminal.Gui/Drivers/WindowsDriver/WindowsOutput.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update Terminal.Gui/Views/CheckBox.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Fixed typo

* Refactor ArrangementEditor event handling

Removed the `ArrangementFlagsOnValueChanged` method, which previously handled updates to `ViewToEdit` properties based on arrangement flags. Updated `ArrangementEditor_Initialized` to attach the event handler to `_arrangementSelector.ValueChanged`. The logic for handling arrangement changes has been refactored or relocated.

* Refactor AlignKeys for type safety and readability

Updated the `AlignKeys` method in the `Shortcuts` class to replace generic `View` references with the more specific `Shortcut` type. Improved type safety by using `IEnumerable<Shortcut>` and `.Cast<Shortcut>()`. Simplified the `max` calculation logic with a single LINQ query and removed redundant casting in the `foreach` loop. These changes enhance code readability, maintainability, and ensure better type safety.

* Refactor ArrangementEditor for clarity and consistency

Refactored `ArrangementEditor` to improve code readability and maintainability:
- Enabled nullable reference types with `#nullable enable`.
- Removed unused `using` directives.
- Adjusted namespace declaration for formatting consistency.
- Reformatted `_arrangementSelector` initialization and property assignment.
- Simplified `OnViewToEditChanged` logic with a ternary expression.
- Refactored `ArrangementEditor_Initialized` into a single-line block.

* Update Examples/UICatalog/Scenarios/Shortcuts.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update Terminal.Gui/Views/Selectors/OptionSelector.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Refactor and enhance OptionSelector and SelectorBase

Refactored `OptionSelector` and `SelectorBase` to simplify logic, improve hotkey assignment, and ensure robust behavior. Updated `Shortcuts.cs` and `DialogTests.cs` to address nullability issues.

Added comprehensive unit tests for `OptionSelector` and `SelectorBase`, covering properties, methods, edge cases, and layout behaviors. These changes improve code readability, maintainability, and functionality while adhering to modern C# practices.

* add FlagSelector comprehensive tests

Refactored `UncheckNone` and `UncheckAll` methods in `FlagSelector` to improve clarity and prevent concurrent modifications using a new `_updatingChecked` flag. Removed the old `UncheckNone` implementation and reorganized logic for maintainability.

Added extensive unit tests in `FlagSelectorTests` to validate functionality, including edge cases and generic implementations. Tests cover flag combination, toggling, "None" flag behavior, and enum-based generic handling.

Improved overall maintainability and test coverage for the `FlagSelector` class.

* Fixes #4375. UnixDriver fails Toplevel_TabGroup_Forward_Backward Fluent Tests

* Refactor RadioGroup to use OptionSelector

The `RadioGroup` class has been refactored to inherit from the `OptionSelector` class instead of `View`, marking it as `[Obsolete]` and recommending the use of `OptionSelector`.

The previous implementation of `RadioGroup` has been entirely removed, including its properties, methods, events, and internal logic. This includes initialization logic, key bindings, layout management, and event handling.

The new `RadioGroup` is now a thin wrapper around `OptionSelector` and implements the `IDesignable` interface. The `EnableForDesign` method has been simplified to set default options for design purposes.

This change simplifies the codebase and encourages the use of `OptionSelector` for managing mutually exclusive options.

* Backported focus tests and add bug-exposing test case

Refactored `AdvanceFocusTests` to improve assertion clarity by replacing `Assert.True`/`Assert.False` with `Assert.Equal`. Enhanced test documentation with detailed view hierarchy comments for better readability.

Added a new test case, `FocusNavigation_Should_Cycle_Back_To_Top_Level_Views`, which exposes a bug in focus navigation logic where focus does not cycle back to top-level views after traversing nested views.

Updated existing tests to ensure consistent handling of `TabBehavior` and made minor adjustments for improved validation of focus navigation logic.

* Remove all tests for RadioGroup component

The `RadioGroupTests.cs` file has been completely cleared of all test cases and associated code. This includes the removal of unit tests that validated the `RadioGroup` component's functionality, behavior, and edge cases.

The deleted tests covered:
- Default constructor behavior and initialization.
- Handling of the `SelectedItem` property, including edge cases.
- Hotkey bindings and their behavior under different focus states.
- Command handling for focus, selection, and acceptance.
- Orientation changes and their impact on layout.
- Event handling for `SelectedItemChanged`, `Selecting`, and `Accepting`.
- Mouse interactions, including single-click and double-click events.

This removal eliminates all automated validation for the `RadioGroup` component, leaving it untested and increasing the risk of regressions or undetected issues in future changes.

* Fix unix and fake fluent tests.

* More fixes for unix and fake drivers

* Change classes names for more consistency

* Fix typos in docs and method signature

Updated XML documentation in `FakeConsole.cs` to replace `<see cref="FakeDriver"/>` with `<exception cref="FakeDriver"></exception>` for clarity.

Corrected a parameter name in `WindowsOutput.cs`'s `WriteConsole` method from `numberOfCharsToWritten` to `numberOfCharsToWrite` to fix a typo and improve readability.

* Refactor: Replace RadioGroup with OptionSelector

Replaced all instances of `RadioGroup` with `OptionSelector` across the codebase to standardize the control for mutually exclusive options. Updated associated properties, methods, and event handlers to align with the `OptionSelector` API, including replacing `RadioLabels` with `AssignHotKeys` and `SelectedItemChanged` with `ValueChanged`.

Removed the `RadioGroup` class, marking it as obsolete. Updated documentation, comments, and test cases to reflect the new control. Adjusted layout and positioning logic in various scenarios to ensure UI consistency.

Refactored scenarios such as `Buttons`, `ColorPickers`, `DynamicMenuBar`, `FileDialogExamples`, `Images`, `PosAlignDemo`, `ProgressBarStyles`, `RegionScenario`, `Themes`, and others to use `OptionSelector`. Updated `Glyphs` and `View` classes to reflect the terminology change. Cleaned up redundant code and ensured compatibility across the application.

* Refactor OptionSelector to use Value instead of SelectedItem

Replaced the SelectedItem property with a nullable Value property across the codebase to simplify the API and improve consistency. Updated event handlers from SelectedItemChanged to ValueChanged and adjusted logic accordingly.

Refactored UI scenarios (e.g., Buttons, CharacterMap, ColorPickers) and dependent classes (e.g., BorderEditor, DimEditor, PosEditor) to use the new Value property. Improved null handling and streamlined initialization of controls.

Updated tests to validate the Value property and renamed test methods for clarity. Removed the RegionOpSelector class as it was no longer needed. Performed general code cleanup, including formatting and removal of redundant code.

* Refactor OptionSelector: Replace RadioLabels with Labels

Updated the `OptionSelector` class and its derived classes to replace the `RadioLabels` property with a more generic `Labels` property, aligning with the base class `SelectorBase`. This change standardizes the API and simplifies label-related functionality.

Refactored all instances of `RadioLabels` across the codebase, including property assignments, method calls, and references in scenarios, tests, and examples. Updated classes include `ColorPickers`, `Dialogs`, `DimAutoDemo`, `DynamicMenuBar`, `FileDialogExamples`, `Images`, `PosAlignDemo`, `Selectors`, `Shortcuts`, `TextAlignmentAndDirection`, `Themes`, `UnicodeInMenu`, `Wizards`, `UICatalogTop`, and `ScenarioTests`.

Modified `OptionSelector<TEnum>` to initialize `Labels` directly using `Enum.GetValues<TEnum>()`. Removed the `RadioLabels` property from `OptionSelector`, consolidating functionality under `Labels`.

Verified functionality through updated tests and scenarios to ensure consistent behavior with the previous implementation.

* Refactor: Replace "radio group" with "option selector"

Updated terminology across multiple classes to replace "radio group" with "option selector" for improved clarity and consistency.

- Removed unused `OptionSelector` in `ColorPickers`.
- Renamed `Title` in `DimAutoDemo` to "Options" and updated `BorderStyle`.
- Replaced `_radioItems` with `_optionLabels` in `DimEditor` and `PosEditor`.
- Renamed `styleRadioGroup` to `styleOptionSelector` in `MessageBoxes`.
- Renamed `radioGroup` to `optionSelector` in `UnicodeInMenu` and `OrientationTests`.
- Adjusted related references, event handlers, and UI properties.

These changes align the codebase with updated terminology and improve readability.

* Replace RadioGroup with OptionSelector and update docs

The `RadioGroup` control has been replaced or renamed to `OptionSelector`. Documentation has been updated to reflect this change, including the behavior of raising the `Selecting` event when an option is selected.

The navigation table now describes `OptionSelector` as supporting multiple options with actions like `Advance`, `SetValue+OnAccept`, and `Focus+SetValue`. A new section introduces the `OptionSelector` view, which displays mutually-exclusive items with hotkeys.

Enhancements to `Menuv2` and `MenuBarv2` include setting focus on `MenuItemv2` selections and raising the `SelectedMenuItemChanged` event. Additionally, a progress bar view has been introduced to visually indicate activity progress.

* Fixed `EndAfterFirstIteration`

Renamed the `EndAfterFirstIteration` property to `StopAfterFirstIteration` across the codebase for improved clarity and consistency. Updated all references in the `Application`, `ApplicationImpl`, `IApplication`, and `ITimedEvents` classes, as well as related tests and documentation.

Modified the application loop logic to use `StopAfterFirstIteration` for controlling the termination of the application after the first iteration. Set its default value to `false`.

Updated test cases, demo applications, and XML documentation to reflect the new property name. Added a new project, `OutputView`, to the solution with appropriate configuration entries.

Performed minor code cleanup to ensure consistency in naming and behavior.

* Enhance selectors and clean up documentation

- Added `args.Handled = true` to `CheckBox` event handlers in `FlagSelector` and `OptionSelector` to mark events as handled.
- Introduced `_value` field in `FlagSelector` and added a `Cycle` method in `OptionSelector` for better value management.
- Updated `OptionSelector` documentation to reference `OptionSelector<TEnum>` for type-safe enum usage.
- Improved `UpdateChecked` method documentation in `OptionSelector` to clarify exception behavior.
- Enabled nullable reference types in `FlagSelectorTests` and `SelectorBaseTests` and moved them to a new namespace.
- Removed outdated auto-generated content from `views.md`.
- Removed `CheckBox.DefaultHighlightStyle` from the default theme configuration in `OutputView.cs`.

* Update event handling and expand UI documentation

Modified `args.Handled` in `FlagSelector` and `OptionSelector` to allow `Accepting` event propagation, improving event handling behavior. Added comments to clarify the changes.

Expanded `views.md` with detailed documentation for built-in views and controls in *Terminal.Gui*, including descriptions, examples, and rendered outputs for components like `Bar`, `Button`, `CheckBox`, and more. This update enhances developer guidance for building terminal-based UIs.

* Fixed `EndAfterFirstIteration` in `ApplicationImpl`

Renamed the `EndAfterFirstIteration` property to `StopAfterFirstIteration` across the codebase for improved clarity. Updated its implementation to use a getter and setter that interact with the `ApplicationImpl.Instance` singleton for centralized management.

Modified the `RunLoop` method to check the new `StopAfterFirstIteration` property. Updated the default value to `false` in the `Application` class.

Added a private `_stopAfterFirstIteration` field and a corresponding public property in the `ApplicationImpl` class. Updated the `Run` method in `ApplicationImpl` to stop after the first iteration if the property is set to `true`, with appropriate logging.

Updated the `IApplication` interface to include the `StopAfterFirstIteration` property and clarified the behavior of the `RequestStop` method. Revised XML documentation comments to reflect these changes.

* Fixed EndfterFirstIteration in ApplicaitonImpl

Refactored `StopAfterFirstIteration` in `ApplicationImpl` to use an auto-property for simplicity. Updated `RunIteration` to call `view.RequestStop()` instead of modifying `view.Running`.

Replaced references to `Application.EndAfterFirstIteration` with `Application.StopAfterFirstIteration` across the codebase, including `ITimedEvents`, `ApplicationTests`, and `GlobalTestSetup`.

Added a new test, `InitRunShutdown_StopAfterFirstIteration_Stops`, to verify the application stops correctly after the first iteration. Updated related documentation and assertions for consistency.

* Refactor Value handling and improve type safety

Refactored `Value` handling across multiple classes to use nullable generic types, improving type safety and eliminating unnecessary casting. Simplified `ValueChanged` event handlers with concise lambda expressions.

Enhanced `FlagSelector<TFlagsEnum>` and `OptionSelector<TEnum>` with generic `ValueChanged` events and type-safe event handling. Added nullable reference type annotations to align with modern C# practices.

Improved test code by using null-forgiving operators and more descriptive assertions. Cleaned up redundant code and ensured consistency in `Value` handling. Updated `FlagSelectorTests` and `SelectorBaseTests` for better readability and maintainability.

Added the `System` namespace to `FlagSelectorTEnum.cs` for compatibility. Overall, these changes enhance code readability, maintainability, and robustness.

* Merged v2_develop

* Update README badges for v2_develop branch

Updated the `.NET Core` badge to reference the `v2_develop` branch. Adjusted the `codecov` badge to remove branch-specific paths and added a token parameter. Reorganized the `codecov` badge position in the README. Retained other badges without modification.

* codcov2

* fixed pos tests

* Improve cleanup, coverage config, and SpinnerStyle tests

Enhanced resource cleanup in `Pos.CombineTests.cs` by disposing of `Application.Top` to prevent leaks. Updated `codecov.yml` to focus coverage on `Terminal.Gui`, simplified path patterns, and clarified configurations.

Added `SpinnerStyleTests` with extensive unit tests for `SpinnerStyle` and its variants, covering default properties, behaviors, edge cases, and immutability. Organized tests for readability and ensured thorough validation of all spinner styles. Enabled nullable reference types for improved safety.

* Remove .NET Core badge; add comprehensive boundary tests

The `.NET Core` workflow badge was removed from the `README.md` file.

Added a comprehensive suite of unit tests for the `Region.DrawOuterBoundary` method in `DrawOuterBoundaryTests.cs`. These tests validate the method's behavior across various scenarios, including:
- Intersected, unioned, and complex shapes.
- Edge cases like empty regions, zero-width/height rectangles, and single-pixel rectangles.
- Specific shapes such as L-shaped, T-shaped, and hollow rectangles.
- Overlapping, adjacent, and separate rectangles.
- Thread safety with parallel drawing.
- Different line styles, custom attributes, and very large regions.
- Various positions, sizes, and multiple calls on the same canvas.

The tests use the `Xunit` framework and include both `[Fact]` and `[Theory]` test cases. These changes enhance the codebase's robustness and ensure correctness in a wide range of scenarios.

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: BDisp <bd.bdisp@gmail.com>
2025-11-11 20:37:33 -07:00

567 lines
19 KiB
C#

using System.Collections.Concurrent;
using System.Diagnostics;
using System.Drawing;
using System.Text;
using Microsoft.Extensions.Logging;
#pragma warning disable CS1591 // Missing XML comment for publicly visible type or member
namespace TerminalGuiFluentTesting;
/// <summary>
/// Fluent API context for testing a Terminal.Gui application. Create
/// an instance using <see cref="With"/> static class.
/// </summary>
public partial class GuiTestContext : IDisposable
{
// ===== Threading & Synchronization =====
private readonly CancellationTokenSource _runCancellationTokenSource = new ();
private readonly CancellationTokenSource? _timeoutCts;
private readonly Task? _runTask;
private readonly SemaphoreSlim _booting;
private readonly object _cancellationLock = new ();
private volatile bool _finished;
// ===== Exception Handling =====
private readonly object _backgroundExceptionLock = new ();
private Exception? _backgroundException;
// ===== Driver & Application State =====
private readonly FakeInput _fakeInput = new ();
private IOutput? _output;
private SizeMonitorImpl? _sizeMonitor;
private ApplicationImpl? _applicationImpl;
private TestDriver _driverType;
// ===== Application State Preservation (for restoration) =====
private IApplication? _originalApplicationInstance;
private ILogger? _originalLogger;
// ===== Test Configuration =====
private readonly bool _runApplication;
private TimeSpan _timeout;
// ===== Logging =====
private readonly object _logsLock = new ();
private readonly TextWriter? _logWriter;
private StringBuilder? _logsSb;
/// <summary>
/// Constructor for tests that only need Application.Init without running the main loop.
/// Uses the driver's default screen size instead of forcing a specific size.
/// </summary>
public GuiTestContext (TestDriver driver, TextWriter? logWriter = null, TimeSpan? timeout = null)
{
_logWriter = logWriter;
_runApplication = false;
_booting = new (0, 1);
_timeoutCts = new CancellationTokenSource (timeout ?? TimeSpan.FromSeconds (10)); // NEW
// Don't force a size - let the driver determine it
CommonInit (0, 0, driver, timeout);
try
{
InitializeApplication ();
_booting.Release ();
// After Init, Application.Screen should be set by the driver
if (Application.Screen == Rectangle.Empty)
{
throw new InvalidOperationException (
"Driver bug: Application.Screen is empty after Init. The driver should set the screen size during Init.");
}
}
catch (Exception ex)
{
lock (_backgroundExceptionLock) // NEW: Thread-safe exception handling
{
_backgroundException = ex;
}
if (_logWriter != null)
{
WriteOutLogs (_logWriter);
}
throw new ("Application initialization failed", ex);
}
lock (_backgroundExceptionLock) // NEW: Thread-safe check
{
if (_backgroundException != null)
{
throw new ("Application initialization failed", _backgroundException);
}
}
}
/// <summary>
/// Constructor for tests that need to run the application with Application.Run.
/// </summary>
internal GuiTestContext (Func<Toplevel> topLevelBuilder, int width, int height, TestDriver driver, TextWriter? logWriter = null, TimeSpan? timeout = null)
{
_logWriter = logWriter;
_runApplication = true;
_booting = new (0, 1);
CommonInit (width, height, driver, timeout);
// Start the application in a background thread
_runTask = Task.Run (
() =>
{
try
{
InitializeApplication ();
_booting.Release ();
Toplevel t = topLevelBuilder ();
t.Closed += (s, e) => { Finished = true; };
Application.Run (t); // This will block, but it's on a background thread now
t.Dispose ();
Logging.Trace ("Application.Run completed");
Application.Shutdown ();
_runCancellationTokenSource.Cancel ();
}
catch (OperationCanceledException)
{ }
catch (Exception ex)
{
_backgroundException = ex;
_fakeInput.ExternalCancellationTokenSource!.Cancel ();
}
finally
{
CleanupApplication ();
if (_logWriter != null)
{
WriteOutLogs (_logWriter);
}
}
},
_runCancellationTokenSource.Token);
// Wait for booting to complete with a timeout to avoid hangs
if (!_booting.WaitAsync (_timeout).Result)
{
throw new TimeoutException ($"Application failed to start within {_timeout}ms.");
}
ResizeConsole (width, height);
if (_backgroundException is { })
{
throw new ("Application crashed", _backgroundException);
}
}
private void InitializeApplication ()
{
ApplicationImpl.ChangeInstance (_applicationImpl);
_applicationImpl?.Init (null, GetDriverName ());
}
/// <summary>
/// Common initialization for both constructors.
/// </summary>
private void CommonInit (int width, int height, TestDriver driverType, TimeSpan? timeout)
{
_timeout = timeout ?? TimeSpan.FromSeconds (10);
_originalApplicationInstance = ApplicationImpl.Instance;
_originalLogger = Logging.Logger;
_logsSb = new ();
_driverType = driverType;
ILogger logger = LoggerFactory.Create (builder =>
builder.SetMinimumLevel (LogLevel.Trace)
.AddProvider (
new TextWriterLoggerProvider (
new ThreadSafeStringWriter (_logsSb, _logsLock))))
.CreateLogger ("Test Logging");
Logging.Logger = logger;
// ✅ Link _runCancellationTokenSource with a timeout
// This creates a token that responds to EITHER the run cancellation OR timeout
_fakeInput.ExternalCancellationTokenSource =
CancellationTokenSource.CreateLinkedTokenSource (
_runCancellationTokenSource.Token,
new CancellationTokenSource (_timeout).Token);
// Now when InputImpl.Run receives this ExternalCancellationTokenSource,
// it will create ANOTHER linked token internally that combines:
// - Its own runCancellationToken parameter
// - The ExternalCancellationTokenSource (which is already linked)
// This creates a chain: any of these triggers will stop input:
// 1. _runCancellationTokenSource.Cancel() (normal stop)
// 2. Timeout expires (test timeout)
// 3. Direct cancel of ExternalCancellationTokenSource (hard stop/error)
// Remove frame limit
Application.MaximumIterationsPerSecond = ushort.MaxValue;
//// Only set size if explicitly provided (width and height > 0)
//if (width > 0 && height > 0)
//{
// _output.SetSize (width, height);
//}
IComponentFactory? cf = null;
// TODO: As each drivers' IInput/IOutput implementations are made testable (e.g.
// TODO: safely injectable/mocked), we can expand this switch to use them.
switch (driverType)
{
case TestDriver.DotNet:
_output = new FakeOutput ();
_sizeMonitor = new (_output);
cf = new FakeComponentFactory (_fakeInput, _output, _sizeMonitor);
break;
case TestDriver.Windows:
_output = new FakeOutput ();
_sizeMonitor = new (_output);
cf = new FakeComponentFactory (_fakeInput, _output, _sizeMonitor);
break;
case TestDriver.Unix:
_output = new FakeOutput ();
_sizeMonitor = new (_output);
cf = new FakeComponentFactory (_fakeInput, _output, _sizeMonitor);
break;
case TestDriver.Fake:
_output = new FakeOutput ();
_sizeMonitor = new (_output);
cf = new FakeComponentFactory (_fakeInput, _output, _sizeMonitor);
break;
}
_applicationImpl = new (cf!);
Logging.Trace ($"Driver: {GetDriverName ()}. Timeout: {_timeout}");
}
private string GetDriverName ()
{
return _driverType switch
{
TestDriver.Windows => "windows",
TestDriver.DotNet => "dotnet",
TestDriver.Unix => "unix",
TestDriver.Fake => "fake",
_ =>
throw new ArgumentOutOfRangeException ()
};
}
/// <summary>
/// Gets whether the application has finished running; aka Stop has been called and the main loop has exited.
/// </summary>
public bool Finished
{
get => _finished;
private set => _finished = value;
}
/// <summary>
/// Performs the supplied <paramref name="doAction"/> immediately.
/// Enables running commands without breaking the Fluent API calls.
/// </summary>
/// <param name="doAction"></param>
/// <returns></returns>
public GuiTestContext Then (Action doAction)
{
try
{
Logging.Trace ($"Invoking action via WaitIteration");
WaitIteration (doAction);
}
catch (Exception ex)
{
_backgroundException = ex;
HardStop ();
throw;
}
return this;
}
/// <summary>
/// Waits until the end of the current iteration of the main loop. Optionally
/// running a given <paramref name="action"/> action on the UI thread at that time.
/// </summary>
/// <param name="action"></param>
/// <returns></returns>
public GuiTestContext WaitIteration (Action? action = null)
{
// If application has already exited don't wait!
if (Finished || _runCancellationTokenSource.Token.IsCancellationRequested || _fakeInput.ExternalCancellationTokenSource!.Token.IsCancellationRequested)
{
Logging.Warning ("WaitIteration called after context was stopped");
return this;
}
if (Thread.CurrentThread.ManagedThreadId == Application.MainThreadId)
{
throw new NotSupportedException ("Cannot WaitIteration during Invoke");
}
Logging.Trace ($"WaitIteration started");
action ??= () => { };
CancellationTokenSource ctsActionCompleted = new ();
Application.Invoke (() =>
{
try
{
action ();
//Logging.Trace ("Action completed");
ctsActionCompleted.Cancel ();
}
catch (Exception e)
{
Logging.Warning ($"Action failed with exception: {e}");
_backgroundException = e;
_fakeInput.ExternalCancellationTokenSource?.Cancel ();
}
});
// Blocks until either the token or the hardStopToken is cancelled.
// With linked tokens, we only need to wait on _runCancellationTokenSource and ctsLocal
// ExternalCancellationTokenSource is redundant because it's linked to _runCancellationTokenSource
WaitHandle.WaitAny (
[
_runCancellationTokenSource.Token.WaitHandle,
ctsActionCompleted.Token.WaitHandle
]);
// Logging.Trace ($"Return from WaitIteration");
return this;
}
public GuiTestContext WaitUntil (Func<bool> condition)
{
GuiTestContext? c = null;
var sw = Stopwatch.StartNew ();
//Logging.Trace ($"WaitUntil started with timeout {_timeout}");
while (!condition ())
{
if (sw.Elapsed > _timeout)
{
throw new TimeoutException ($"Failed to reach condition within {_timeout}ms");
}
c = WaitIteration ();
}
return c ?? this;
}
/// <summary>
/// Returns the last set position of the cursor.
/// </summary>
/// <returns></returns>
public Point GetCursorPosition () { return _output!.GetCursorPosition (); }
/// <summary>
/// Simulates changing the console size e.g. by resizing window in your operating system
/// </summary>
/// <param name="width">new Width for the console.</param>
/// <param name="height">new Height for the console.</param>
/// <returns></returns>
public GuiTestContext ResizeConsole (int width, int height) { return WaitIteration (() => { Application.Driver!.SetScreenSize (width, height); }); }
public GuiTestContext ScreenShot (string title, TextWriter? writer)
{
//Logging.Trace ($"{title}");
return WaitIteration (() =>
{
writer?.WriteLine (title + ":");
var text = Application.ToString ();
writer?.WriteLine (text);
});
}
/// <summary>
/// Stops the application and waits for the background thread to exit.
/// </summary>
public GuiTestContext Stop ()
{
Logging.Trace ($"Stopping application for driver: {GetDriverName ()}");
if (_runTask is null || _runTask.IsCompleted)
{
// If we didn't run the application, just cleanup
if (!_runApplication && !Finished)
{
try
{
Application.Shutdown ();
}
catch
{
// Ignore errors during shutdown
}
CleanupApplication ();
}
return this;
}
WaitIteration (() => { Application.RequestStop (); });
// Wait for the application to stop, but give it a 1-second timeout
const int WAIT_TIMEOUT_MS = 1000;
if (!_runTask.Wait (TimeSpan.FromMilliseconds (WAIT_TIMEOUT_MS)))
{
_runCancellationTokenSource.Cancel ();
// No need to manually cancel ExternalCancellationTokenSource
// App is having trouble shutting down, try sending some more shutdown stuff from this thread.
// If this doesn't work there will be test failures as the main loop continues to run during next test.
try
{
Application.RequestStop ();
Application.Shutdown ();
}
catch (Exception ex)
{
Logging.Critical ($"Application failed to stop in {WAIT_TIMEOUT_MS}. Then shutdown threw {ex}");
}
finally
{
Logging.Critical ($"Application failed to stop in {WAIT_TIMEOUT_MS}. Exception was thrown: {_backgroundException}");
}
}
_runCancellationTokenSource.Cancel ();
if (_backgroundException != null)
{
Logging.Critical ($"Exception occurred: {_backgroundException}");
//throw _ex; // Propagate any exception that happened in the background task
}
return this;
}
/// <summary>
/// Hard stops the application and waits for the background thread to exit.HardStop is used by the source generator for
/// wrapping Xunit assertions.
/// </summary>
public void HardStop (Exception? ex = null)
{
if (ex != null)
{
_backgroundException = ex;
}
Logging.Critical ($"HardStop called with exception: {_backgroundException}");
// With linked tokens, just cancelling ExternalCancellationTokenSource
// will cascade to stop everything
_fakeInput.ExternalCancellationTokenSource?.Cancel ();
WriteOutLogs (_logWriter);
Stop ();
}
/// <summary>
/// Writes all Terminal.Gui engine logs collected so far to the <paramref name="writer"/>
/// </summary>
/// <param name="writer"></param>
/// <returns></returns>
public GuiTestContext WriteOutLogs (TextWriter? writer)
{
if (writer is null)
{
return this;
}
lock (_logsLock)
{
writer.WriteLine (_logsSb!.ToString ());
}
return this; //WaitIteration();
}
internal void Fail (string reason)
{
Logging.Error ($"{reason}");
throw new (reason);
}
private void CleanupApplication ()
{
Logging.Trace ("CleanupApplication");
_fakeInput.ExternalCancellationTokenSource = null;
Application.ResetState (true);
ApplicationImpl.ChangeInstance (_originalApplicationInstance);
Logging.Logger = _originalLogger;
Finished = true;
Application.MaximumIterationsPerSecond = Application.DefaultMaximumIterationsPerSecond;
}
/// <summary>
/// Cleanup to avoid state bleed between tests
/// </summary>
public void Dispose ()
{
Logging.Trace ($"Disposing GuiTestContext");
Stop ();
bool shouldThrow = false;
Exception? exToThrow = null;
lock (_cancellationLock) // NEW: Thread-safe check
{
if (_fakeInput.ExternalCancellationTokenSource is { IsCancellationRequested: true })
{
shouldThrow = true;
lock (_backgroundExceptionLock)
{
exToThrow = _backgroundException;
}
}
// ✅ Dispose the linked token source
_fakeInput.ExternalCancellationTokenSource?.Dispose ();
}
_timeoutCts?.Dispose (); // NEW: Dispose timeout CTS
_runCancellationTokenSource?.Dispose ();
_fakeInput.Dispose ();
_output?.Dispose ();
_booting.Dispose ();
if (shouldThrow)
{
throw new ("Application was hard stopped...", exToThrow);
}
}
}