Files
Terminal.Gui/Tests/UnitTests/Views/TreeTableSourceTests.cs
Copilot 2be8397203 Remove legacy drivers, simplify architecture, and reorganize codebase structure (#4270)
* Initial plan

* Remove legacy drivers and reorganize v2 architecture

Co-authored-by: tig <585482+tig@users.noreply.github.com>

* Extract Windows key helper utilities and fix build

Co-authored-by: tig <585482+tig@users.noreply.github.com>

* Fix all test references to legacy drivers

Co-authored-by: tig <585482+tig@users.noreply.github.com>

* Update documentation to reflect new driver architecture

Co-authored-by: tig <585482+tig@users.noreply.github.com>

* Remove V2.cd diagram file

Co-authored-by: tig <585482+tig@users.noreply.github.com>

* Fix test failures: support legacy drivers and update exception handling

Co-authored-by: tig <585482+tig@users.noreply.github.com>

* updated driver names

* Move V2 tests from ConsoleDrivers/V2 to proper locations

Co-authored-by: tig <585482+tig@users.noreply.github.com>

* Rename ApplicationV2 to ModernApplicationImpl to remove v2 terminology

Co-authored-by: tig <585482+tig@users.noreply.github.com>

* Remove V2 terminology from test drivers and FakeDriver classes

Co-authored-by: tig <585482+tig@users.noreply.github.com>

* Merge ModernApplicationImpl into ApplicationImpl and move to App folder

Co-authored-by: tig <585482+tig@users.noreply.github.com>

* Create modern FakeDriver with component factory architecture in Terminal.Gui project

Co-authored-by: tig <585482+tig@users.noreply.github.com>

* Refactor: Move non-platform-dependent code from /Drivers to /App

Co-authored-by: tig <585482+tig@users.noreply.github.com>

* Code cleanup and org

* Unit test reorg

* Refactor MainLoop architecture: rename classes and enhance documentation for clarity

Co-authored-by: tig <585482+tig@users.noreply.github.com>

* Add comprehensive FakeDriver tests (WIP - some tests need fixes)

Co-authored-by: tig <585482+tig@users.noreply.github.com>

* Fixed FakeDriver build failures

* Fix all FakeDriver test failures - Application.Top creation and clipboard behaviors

Co-authored-by: tig <585482+tig@users.noreply.github.com>

* Fixed FakeDriver build failures2

* Remove hanging legacy FakeDriver tests that use Console.MockKeyPresses

Co-authored-by: tig <585482+tig@users.noreply.github.com>

* Fixed some tests

* Fixed more tests

* Fixed more tests

* Fix bad copilot (#4277)

* Update Terminal.Gui/Drivers/FakeDriver/FakeConsoleOutput.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Refactor Application Init and Update Tests

Refactored `Application.Init` to improve initialization logic:
- Added fallback to `ForceDriver` when `driverName` is null.
- Changed repeated `Init` calls to throw `InvalidOperationException`.
- Updated `_driverName` assignment logic for robustness.

Enhanced `IConsoleDriver` with detailed remarks on implementations.

Revised test cases to align with updated `Application.Init` behavior:
- Replaced `FakeDriver` with `null` and `driverName: "fake"`.
- Skipped or commented out tests incompatible with new logic.
- Improved formatting and removed redundant setup code.

Improved code style and consistency across the codebase:
- Standardized parameter formatting and spacing.
- Removed outdated comments and unused code.

General cleanup to enhance readability and maintainability.

* Warp fix copilot (#4278)

* More fixes (#4279)

* Fixes/works around test failures and temporarily disable failing test

Updated `FakeDriver` to set `RunningUnitTests` to `true` and initialize dimensions using `FakeConsole`. Modified `TestRespondersDisposedAttribute` to set `ConsoleDriver.RunningUnitTests` in the `Before` method, ensuring proper behavior during unit tests.

Temporarily disabled the `Button_CanFocus_False_Raises_Accepted_Correctly` test in `ViewCommandTests` by adding a `Skip` parameter to the `[Fact]` attribute, referencing issue #4270.

* Allow all tests to run despite failures in UnitTests

Modified the `dotnet test` command in the `Run UnitTestsParallelizable` step to set `xunit.stopOnFail` to `false`. This ensures that the test runner does not stop execution on the first failure, allowing all tests to execute regardless of individual test outcomes.

* Refactor ApplicationScreenTests for cleaner setup/teardown

Refactored `ClearContents_Called_When_Top_Frame_Changes` test:
- Added `[AutoInitShutdown]` attribute for automatic lifecycle management.
- Replaced manual `Application.Init` and `Application.Top` setup with `Application.Begin` and `RunState`.
- Simplified event handling by defining `ClearedContents` handler inline.
- Removed explicit cleanup logic, relying on `Application.End` for teardown.

Updated `using` directives to include `UnitTests` namespace.

* Attempt to fix intermittent local test failures.

Update ApplicationImpl initialization parameter

Changed the second parameter of the `impl.Init` method in the
`FakeApplicationFactory` class from `"dotnet"` to `"fake"`.

* Code cleanup to cause Action to re-run.

* Stop tests on first failure in UnitTestsParallelizable

Updated the `dotnet test` command in `unit-tests.yml` to set the `xunit.stopOnFail` parameter to `true`. This change ensures that test execution halts immediately upon encountering a failure, allowing quicker identification and resolution of issues. Note that this may prevent the full test suite from running in the event of a failure.

* Allow all tests to run despite failures in CI

Updated `unit-tests.yml` to set `xunit.stopOnFail` to `false`
in both `Run UnitTests` and `Run UnitTestsParallelizable`
steps. This ensures that the test runner does not stop
execution on the first test failure, allowing all tests
to complete even if some fail.

* Enhance RuneExtensions docs and update user dictionary

Updated the `<remarks>` section in `RuneExtensions.GetColumns` to include details about the `wcwidth` implementation and improved readability with `<para>` tags. Added `wcwidth` to the user dictionary in `Terminal.sln.DotSettings` to avoid spelling errors.

* Improve XML doc formatting in RuneExtensions.cs

Updated the remarks section of the `GetColumns` method in the
`RuneExtensions` class to enhance readability by reformatting
and properly indenting `<para>` tags. The content remains
unchanged, describing the method's implementation via `wcwidth`
and its role as a Terminal.Gui extension for `System.Text.Rune`.

* Refactor drivers and improve clipboard handling

Replaced legacy drivers (`CursesDriver`, `NetDriver`) with
`UnixDriver` and `DotNetDriver` across the codebase, including
comments, method names, and test cases. Updated documentation
and remarks to reflect the new driver names and platforms.

Revamped clipboard handling with new platform-specific
implementations: `UnixClipboard` for Unix, `MacOSXClipboard`
for macOS, and `WSLClipboard` for Linux under WSL. Removed
the old `CursesClipboard` and consolidated clipboard logic.

Updated test cases to align with the new drivers and clipboard
implementations. Improved naming consistency and cleaned up
redundant code. Updated the README and documentation to
reflect these changes.

* Remove `PlatformColor` from `Attribute` struct

This commit removes the `PlatformColor` property from the `Attribute` struct, simplifying the codebase by eliminating platform-specific color handling. The following changes were made:

- Removed `PlatformColor` from the `Attribute` struct, including its initialization, usage, and related comments.
- Updated constructors to no longer initialize or use `PlatformColor`.
- Modified `Equals` and `GetHashCode` methods to exclude `PlatformColor`.
- Updated `UnixComponentFactory` documentation to remove references to "v2unix."
- Renamed `v2TestDriver` to `testDriver` in the `With` class for clarity.
- Removed `PlatformColor` references in `DriverAssert` and related error messages.
- Deleted test cases in `AttributeTests` that relied on `PlatformColor`.
- Cleaned up comments and TODOs related to `PlatformColor` and `UnixDriver`.

These changes reflect a shift away from platform-dependent color management, improving code clarity and reducing complexity.

Remove `PlatformColor` and simplify `Attribute` logic

The `PlatformColor` property has been removed from the `Attribute` struct, along with its associated logic, simplifying the codebase and eliminating platform-specific dependencies. Constructors, equality checks, and hash code generation in `Attribute` have been updated accordingly.

The `CurrentAttribute` property in `ConsoleDriver` and `OutputBuffer` has been simplified, removing dependencies on `Application.Driver`. The `MakeColor` method logic has been removed or simplified in related classes.

Tests in `AttributeTests` have been refactored to reflect these changes, focusing on `Foreground`, `Background`, and `Style`. Unix-specific logic tied to `PlatformColor` has been eliminated.

Additional updates include renaming parameters in the `With` class for clarity, simplifying `DriverAssert` output, and performing minor code cleanups to improve readability and maintainability.

* Refactor Terminal.Gui driver architecture for v2

Updated documentation to reflect the new modular driver architecture in Terminal.Gui v2.

- Revised `namespace-drivers.md` to include new components (`IConsoleInput`, `IConsoleOutput`, `IInputProcessor`, `IOutputBuffer`, `IWindowSizeMonitor`) and terminal size monitoring.
- Replaced "Key Components" with "Architecture Overview" and added details on the **Component Factory** pattern.
- Documented the four driver implementations (`DotNetDriver`, `WindowsDriver`, `UnixDriver`, `FakeDriver`) and their platform-specific optimizations.
- Added a "Threading Model" section to explain the multi-threaded design for responsive input handling.
- Updated examples to demonstrate driver capabilities and explicit driver selection.

In `drivers.md`:
- Expanded the "Overview" to emphasize the modular, component-based architecture.
- Reorganized "Drivers" into "Available Drivers" and added details on `FakeDriver` for unit testing.
- Added sections on "Initialization Flow," "Shutdown Flow," and platform-specific driver details.
- Provided examples for accessing driver components and creating custom drivers.

In `index.md`:
- Updated "Cross Platform" feature to reflect new driver names and clarified compatibility with SSH and monochrome terminals.

* Moved files around

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: tig <585482+tig@users.noreply.github.com>
Co-authored-by: Tig <tig@users.noreply.github.com>
Co-authored-by: Thomas Nind <31306100+tznind@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2025-10-15 13:24:47 -06:00

324 lines
11 KiB
C#

using System.Text;
using UnitTests;
using Xunit.Abstractions;
namespace Terminal.Gui.ViewsTests;
public class TreeTableSourceTests : IDisposable
{
private readonly Rune _origChecked;
private readonly Rune _origUnchecked;
private readonly ITestOutputHelper _output;
public TreeTableSourceTests (ITestOutputHelper output)
{
_output = output;
_origChecked = Glyphs.CheckStateChecked;
_origUnchecked = Glyphs.CheckStateUnChecked;
Glyphs.CheckStateChecked = new Rune ('☑');
Glyphs.CheckStateUnChecked = new Rune ('☐');
}
public void Dispose ()
{
Glyphs.CheckStateChecked = _origChecked;
Glyphs.CheckStateUnChecked = _origUnchecked;
}
[Fact]
[SetupFakeDriver]
public void TestTreeTableSource_BasicExpanding_WithKeyboard ()
{
((IFakeConsoleDriver)Application.Driver!).SetBufferSize (100, 100);
TableView tv = GetTreeTable (out _);
tv.Style.GetOrCreateColumnStyle (1).MinAcceptableWidth = 1;
tv.Draw ();
var expected =
@"
│Name │Description │
├──────────────┼───────────────────────┤
│├+Lost Highway│Exciting night road │
│└+Route 66 │Great race course │";
DriverAssert.AssertDriverContentsAre (expected, _output);
Assert.Equal (2, tv.Table.Rows);
// top left is selected cell
Assert.Equal (0, tv.SelectedRow);
Assert.Equal (0, tv.SelectedColumn);
// when pressing right we should expand the top route
tv.NewKeyDownEvent (Key.CursorRight);
View.SetClipToScreen ();
tv.Draw ();
expected =
@"
│Name │Description │
├─────────────────┼────────────────────┤
│├-Lost Highway │Exciting night road │
││ ├─Ford Trans-Am│Talking thunderbird │
││ └─DeLorean │Time travelling car │
│└+Route 66 │Great race course │
";
DriverAssert.AssertDriverContentsAre (expected, _output);
// when pressing left we should collapse the top route again
tv.NewKeyDownEvent (Key.CursorLeft);
View.SetClipToScreen ();
tv.Draw ();
expected =
@"
│Name │Description │
├──────────────┼───────────────────────┤
│├+Lost Highway│Exciting night road │
│└+Route 66 │Great race course │
";
DriverAssert.AssertDriverContentsAre (expected, _output);
}
[Fact]
[SetupFakeDriver]
public void TestTreeTableSource_BasicExpanding_WithMouse ()
{
((IFakeConsoleDriver)Application.Driver!).SetBufferSize (100, 100);
TableView tv = GetTreeTable (out _);
tv.Style.GetOrCreateColumnStyle (1).MinAcceptableWidth = 1;
View.SetClipToScreen ();
tv.Draw ();
var expected =
@"
│Name │Description │
├──────────────┼───────────────────────┤
│├+Lost Highway│Exciting night road │
│└+Route 66 │Great race course │";
DriverAssert.AssertDriverContentsAre (expected, _output);
Assert.Equal (2, tv.Table.Rows);
// top left is selected cell
Assert.Equal (0, tv.SelectedRow);
Assert.Equal (0, tv.SelectedColumn);
Assert.True (tv.NewMouseEvent (new MouseEventArgs { Position = new (2, 2), Flags = MouseFlags.Button1Clicked }));
View.SetClipToScreen ();
tv.Draw ();
expected =
@"
│Name │Description │
├─────────────────┼────────────────────┤
│├-Lost Highway │Exciting night road │
││ ├─Ford Trans-Am│Talking thunderbird │
││ └─DeLorean │Time travelling car │
│└+Route 66 │Great race course │
";
DriverAssert.AssertDriverContentsAre (expected, _output);
// Clicking to the right/left of the expand/collapse does nothing
tv.NewMouseEvent (new MouseEventArgs { Position = new (3, 2), Flags = MouseFlags.Button1Clicked });
tv.Draw ();
DriverAssert.AssertDriverContentsAre (expected, _output);
tv.NewMouseEvent (new MouseEventArgs { Position = new (1, 2), Flags = MouseFlags.Button1Clicked });
tv.Draw ();
DriverAssert.AssertDriverContentsAre (expected, _output);
// Clicking on the + again should collapse
tv.NewMouseEvent (new MouseEventArgs { Position = new (2, 2), Flags = MouseFlags.Button1Clicked });
View.SetClipToScreen ();
tv.Draw ();
expected =
@"
│Name │Description │
├──────────────┼───────────────────────┤
│├+Lost Highway│Exciting night road │
│└+Route 66 │Great race course │";
DriverAssert.AssertDriverContentsAre (expected, _output);
}
[Fact]
[AutoInitShutdown]
public void TestTreeTableSource_CombinedWithCheckboxes ()
{
Toplevel top = new ();
TableView tv = GetTreeTable (out TreeView<IDescribedThing> treeSource);
CheckBoxTableSourceWrapperByIndex checkSource;
tv.Table = checkSource = new CheckBoxTableSourceWrapperByIndex (tv, tv.Table);
tv.Style.GetOrCreateColumnStyle (2).MinAcceptableWidth = 1;
top.Add (tv);
Application.Begin (top);
tv.Draw ();
var expected =
@"
│ │Name │Description │
├─┼──────────────┼─────────────────────┤
│☐│├+Lost Highway│Exciting night road │
│☐│└+Route 66 │Great race course │
";
DriverAssert.AssertDriverContentsAre (expected, _output);
Assert.Equal (2, tv.Table.Rows);
// top left is selected cell
Assert.Equal (0, tv.SelectedRow);
Assert.Equal (0, tv.SelectedColumn);
// when pressing right we move to tree column
tv.NewKeyDownEvent (Key.CursorRight);
// now we are in tree column
Assert.Equal (0, tv.SelectedRow);
Assert.Equal (1, tv.SelectedColumn);
Application.RaiseKeyDownEvent (Key.CursorRight);
View.SetClipToScreen ();
tv.Draw ();
expected =
@"
│ │Name │Description │
├─┼─────────────────┼──────────────────┤
│☐│├-Lost Highway │Exciting night roa│
│☐││ ├─Ford Trans-Am│Talking thunderbir│
│☐││ └─DeLorean │Time travelling ca│
│☐│└+Route 66 │Great race course │
";
DriverAssert.AssertDriverContentsAre (expected, _output);
tv.NewKeyDownEvent (Key.CursorDown);
tv.NewKeyDownEvent (Key.Space);
View.SetClipToScreen ();
tv.Draw ();
expected =
@"
│ │Name │Description │
├─┼─────────────────┼──────────────────┤
│☐│├-Lost Highway │Exciting night roa│
│☒││ ├─Ford Trans-Am│Talking thunderbir│
│☐││ └─DeLorean │Time travelling ca│
│☐│└+Route 66 │Great race course │
";
DriverAssert.AssertDriverContentsAre (expected, _output);
IDescribedThing [] selectedObjects = checkSource.CheckedRows.Select (treeSource.GetObjectOnRow).ToArray ();
IDescribedThing selected = Assert.Single (selectedObjects);
Assert.Equal ("Ford Trans-Am", selected.Name);
Assert.Equal ("Talking thunderbird car", selected.Description);
top.Dispose ();
}
private TableView GetTreeTable (out TreeView<IDescribedThing> tree)
{
var tableView = new TableView ();
tableView.SchemeName = "TopLevel";
tableView.Viewport = new Rectangle (0, 0, 40, 6);
tableView.Style.ShowHorizontalHeaderUnderline = true;
tableView.Style.ShowHorizontalHeaderOverline = false;
tableView.Style.AlwaysShowHeaders = true;
tableView.Style.SmoothHorizontalScrolling = true;
tree = new TreeView<IDescribedThing> ();
tree.AspectGetter = d => d.Name;
tree.TreeBuilder = new DelegateTreeBuilder<IDescribedThing> (
d => d is Road r
? r.Traffic
: Enumerable.Empty<IDescribedThing> ()
);
tree.AddObject (
new Road
{
Name = "Lost Highway",
Description = "Exciting night road",
Traffic = new List<Car>
{
new () { Name = "Ford Trans-Am", Description = "Talking thunderbird car" },
new () { Name = "DeLorean", Description = "Time travelling car" }
}
}
);
tree.AddObject (
new Road
{
Name = "Route 66",
Description = "Great race course",
Traffic = new List<Car>
{
new () { Name = "Pink Compact", Description = "Penelope Pitstop's car" },
new () { Name = "Mean Machine", Description = "Dick Dastardly's car" }
}
}
);
tableView.Table = new TreeTableSource<IDescribedThing> (
tableView,
"Name",
tree,
new Dictionary<string, Func<IDescribedThing, object>> { { "Description", d => d.Description } }
);
tableView.BeginInit ();
tableView.EndInit ();
tableView.LayoutSubViews ();
var top = new Toplevel ();
top.Add (tableView);
top.SetFocus ();
Assert.Equal (tableView, top.MostFocused);
return tableView;
}
private class Car : IDescribedThing
{
public string Name { get; set; }
public string Description { get; set; }
}
private interface IDescribedThing
{
string Description { get; }
string Name { get; }
}
private class Road : IDescribedThing
{
public List<Car> Traffic { get; set; }
public string Name { get; set; }
public string Description { get; set; }
}
}