Files
Terminal.Gui/Tests/UnitTestsParallelizable/View/Draw/NeedsDrawTests.cs
BDisp 00aaefb962 Fixes #3951. Adds View dependency to DimFunc and PosFunc (#4210)
* Fixes #4208. MainLoopSyncContext doesn't work with the v2 drivers

* Fixes #3951. Add DimFuncWithView with a View dependency

* Revert to iteration which will handle the necessary processes

* Revert "Revert to iteration which will handle the necessary processes"

This reverts commit 50015ac6da.

* Layout and draw before position cursor

* Add optional View parameter and property to the DimFunc and PosFunc

* Trying fix unit test error

* Revert layout changes

* Fixes #4216. Legacy drivers aren't refreshing the screen correctly on view drag

* Add assertion proving NeedsLayout is always false before call OnSubViewsLaidOut

* Fix unit test error

* Increasing time to abort

* Revert "Increasing time to abort"

This reverts commit d7306e72f3.

* Trying fix integration tests

* Still trying fix integrations unit tests

* Revert comment

* Layout is performed during the iteration

* Using Dim.Func with status bar view

* Still trying fix integrations tests by locking _subviews

* Still trying fix integrations tests by locking _subviews

* Add internal SnapshotSubviews method

* Remove lock from SnapshotSubviews method

* Using SnapshotSubviews method in the DrawSubViews method

* Remove lock from SnapshotSubviews method

* Using SnapshotSubviews method in the DrawSubViews method

* Using SnapshotSubviews

* Prevent new app if the previous wasn't yet finished

* Replace SnapshotSubviews method with ViewCollectionHelpers class

* Lock entire GuiTestContext constructor

* Using Snapshot in the ordered field

* Fixes #4221 Extra modifiers f1 to f4 in v2net (#4220)

* Assume we are running in a terminal that supports true color by default unless user explicitly forces 16

* Add support for extra modifiers for F1 to F4 keys

* Revert "Assume we are running in a terminal that supports true color by default unless user explicitly forces 16"

This reverts commit 4cc2530de0.

* Cleanup

* Update comments

* Code cleanup

---------

Co-authored-by: Tig <tig@users.noreply.github.com>

* Move ViewCollectionHelpers class to a separate file

* Remove Border.Layout call in the DoDrawAdornmentsSubViews method.

* Remove adornments layout call within the draw

---------

Co-authored-by: Tig <tig@users.noreply.github.com>
Co-authored-by: Thomas Nind <31306100+tznind@users.noreply.github.com>
2025-09-01 10:40:10 -06:00

313 lines
9.5 KiB
C#

#nullable enable
namespace Terminal.Gui.ViewTests;
[Trait ("Category", "Output")]
public class NeedsDrawTests
{
[Fact]
public void NeedsDraw_False_If_Width_Height_Zero ()
{
View view = new () { Width = 0, Height = 0 };
view.BeginInit ();
view.EndInit ();
Assert.False (view.NeedsDraw);
//Assert.False (view.SubViewNeedsDraw);
}
[Fact]
public void NeedsDraw_True_Initially_If_Width_Height_Not_Zero ()
{
View superView = new () { Width = 1, Height = 1 };
View view1 = new () { Width = 1, Height = 1 };
View view2 = new () { Width = 1, Height = 1 };
superView.Add (view1, view2);
superView.BeginInit ();
superView.EndInit ();
Assert.True (superView.NeedsDraw);
Assert.True (superView.SubViewNeedsDraw);
Assert.True (view1.NeedsDraw);
Assert.True (view2.NeedsDraw);
superView.Layout (); // NeedsDraw is always false if Layout is needed
superView.Draw ();
Assert.False (superView.NeedsDraw);
Assert.False (superView.SubViewNeedsDraw);
Assert.False (view1.NeedsDraw);
Assert.False (view2.NeedsDraw);
superView.SetNeedsDraw ();
Assert.True (superView.NeedsDraw);
Assert.True (superView.SubViewNeedsDraw);
Assert.True (view1.NeedsDraw);
Assert.True (view2.NeedsDraw);
}
[Fact]
public void NeedsDraw_True_After_Constructor ()
{
var view = new View { Width = 2, Height = 2 };
Assert.True (view.NeedsDraw);
view = new() { Width = 2, Height = 2, BorderStyle = LineStyle.Single };
Assert.True (view.NeedsDraw);
}
[Fact]
public void NeedsDraw_True_After_BeginInit ()
{
var view = new View { Width = 2, Height = 2, BorderStyle = LineStyle.Single };
Assert.True (view.NeedsDraw);
view.BeginInit ();
Assert.True (view.NeedsDraw);
view.NeedsDraw = false;
view.BeginInit ();
Assert.False (view.NeedsDraw); // Because layout is still needed
view.Layout ();
// NeedsDraw is true after layout and NeedsLayout is false if SubViewsLaidOut doesn't call SetNeedsLayout
Assert.True (view.NeedsDraw);
Assert.False (view.NeedsLayout);
}
[Fact]
public void NeedsDraw_True_After_EndInit_Where_Call_Layout ()
{
var view = new View { Width = 2, Height = 2, BorderStyle = LineStyle.Single };
Assert.True (view.NeedsDraw);
view.BeginInit ();
Assert.True (view.NeedsDraw);
view.EndInit ();
Assert.True (view.NeedsDraw);
view = new() { Width = 2, Height = 2, BorderStyle = LineStyle.Single };
view.BeginInit ();
view.NeedsDraw = false;
view.EndInit ();
Assert.True (view.NeedsDraw);
}
[Fact]
public void NeedsDraw_After_SetLayoutNeeded_And_Layout ()
{
var view = new View { Width = 2, Height = 2 };
Assert.True (view.NeedsDraw);
Assert.False (view.NeedsLayout);
view.Draw ();
Assert.False (view.NeedsDraw);
Assert.False (view.NeedsLayout);
view.SetNeedsLayout ();
Assert.False (view.NeedsDraw);
Assert.True (view.NeedsLayout);
view.Layout ();
Assert.True (view.NeedsDraw);
Assert.False (view.NeedsLayout);
}
[Fact]
public void NeedsDraw_False_After_SetRelativeLayout_Absolute_Dims ()
{
var view = new View { Width = 2, Height = 2 };
Assert.True (view.NeedsDraw);
view.Draw ();
Assert.False (view.NeedsDraw);
Assert.False (view.NeedsLayout);
// SRL won't change anything since the view frame wasn't changed
view.SetRelativeLayout (Application.Screen.Size);
Assert.False (view.NeedsDraw);
view.SetNeedsLayout ();
// SRL won't change anything since the view frame wasn't changed
// SRL doesn't depend on NeedsLayout, but LayoutSubViews does
view.SetRelativeLayout (Application.Screen.Size);
Assert.False (view.NeedsDraw);
Assert.True (view.NeedsLayout);
view.Layout ();
Assert.True (view.NeedsDraw);
Assert.False (view.NeedsLayout);
view.NeedsDraw = false;
// SRL won't change anything since the view frame wasn't changed. However, Layout has not been called
view.SetRelativeLayout (new (10, 10));
Assert.False (view.NeedsDraw);
}
[Fact]
public void NeedsDraw_False_After_SetRelativeLayout_Relative_Dims ()
{
var view = new View { Width = Dim.Percent (50), Height = Dim.Percent (50) };
View superView = new ()
{
Id = "superView",
Width = Dim.Fill (),
Height = Dim.Fill ()
};
// A layout wasn't called yet, so NeedsDraw is still empty
Assert.False (superView.NeedsDraw);
superView.Add (view);
// A layout wasn't called yet, so NeedsDraw is still empty
Assert.False (view.NeedsDraw);
Assert.False (superView.NeedsDraw);
superView.BeginInit ();
Assert.False (view.NeedsDraw);
Assert.False (superView.NeedsDraw);
superView.EndInit (); // Call Layout
Assert.True (view.NeedsDraw);
Assert.True (superView.NeedsDraw);
superView.SetRelativeLayout (Application.Screen.Size);
Assert.True (view.NeedsDraw);
Assert.True (superView.NeedsDraw);
}
[Fact]
public void NeedsDraw_False_After_SetRelativeLayout_10x10 ()
{
View superView = new ()
{
Id = "superView",
Width = Dim.Fill (),
Height = Dim.Fill ()
};
Assert.False (superView.NeedsDraw);
superView.Layout ();
Assert.True (superView.NeedsDraw);
superView.NeedsDraw = false;
superView.SetRelativeLayout (new (10, 10));
Assert.True (superView.NeedsDraw);
}
[Fact]
public void NeedsDraw_True_After_LayoutSubViews ()
{
var view = new View { Width = 2, Height = 2, BorderStyle = LineStyle.Single };
Assert.True (view.NeedsDraw);
view.BeginInit ();
Assert.True (view.NeedsDraw);
view.EndInit ();
Assert.True (view.NeedsDraw);
view.SetRelativeLayout (Application.Screen.Size);
Assert.True (view.NeedsDraw);
view.LayoutSubViews ();
Assert.True (view.NeedsDraw);
}
[Fact]
public void NeedsDraw_False_After_Draw ()
{
var view = new View { Width = 2, Height = 2, BorderStyle = LineStyle.Single };
Assert.True (view.NeedsDraw);
view.BeginInit ();
Assert.True (view.NeedsDraw);
view.EndInit ();
Assert.True (view.NeedsDraw);
view.SetRelativeLayout (Application.Screen.Size);
Assert.True (view.NeedsDraw);
view.LayoutSubViews ();
Assert.True (view.NeedsDraw);
view.Draw ();
Assert.False (view.NeedsDraw);
}
[Fact]
public void NeedsDrawRect_Is_Viewport_Relative ()
{
View superView = new ()
{
Id = "superView",
Width = 10,
Height = 10
};
Assert.Equal (new (0, 0, 10, 10), superView.Frame);
Assert.Equal (new (0, 0, 10, 10), superView.Viewport);
Assert.Equal (new (0, 0, 10, 10), superView.NeedsDrawRect);
var view = new View
{
Id = "view"
};
view.Frame = new (0, 1, 2, 3);
Assert.Equal (new (0, 1, 2, 3), view.Frame);
Assert.Equal (new (0, 0, 2, 3), view.Viewport);
Assert.Equal (new (0, 0, 2, 3), view.NeedsDrawRect);
superView.Add (view);
Assert.Equal (new (0, 0, 10, 10), superView.Frame);
Assert.Equal (new (0, 0, 10, 10), superView.Viewport);
Assert.Equal (new (0, 0, 10, 10), superView.NeedsDrawRect);
Assert.Equal (new (0, 1, 2, 3), view.Frame);
Assert.Equal (new (0, 0, 2, 3), view.Viewport);
Assert.Equal (new (0, 0, 2, 3), view.NeedsDrawRect);
view.Frame = new (3, 3, 5, 5);
Assert.Equal (new (3, 3, 5, 5), view.Frame);
Assert.Equal (new (0, 0, 5, 5), view.Viewport);
Assert.Equal (new (0, 0, 5, 5), view.NeedsDrawRect);
view.Frame = new (3, 3, 6, 6); // Grow right/bottom 1
Assert.Equal (new (3, 3, 6, 6), view.Frame);
Assert.Equal (new (0, 0, 6, 6), view.Viewport);
Assert.Equal (new (0, 0, 6, 6), view.NeedsDrawRect);
view.Frame = new (3, 3, 5, 5); // Shrink right/bottom 1
Assert.Equal (new (3, 3, 5, 5), view.Frame);
Assert.Equal (new (0, 0, 5, 5), view.Viewport);
Assert.Equal (new (0, 0, 5, 5), view.NeedsDrawRect);
view.SetContentSize (new (10, 10));
Assert.Equal (new (3, 3, 5, 5), view.Frame);
Assert.Equal (new (0, 0, 5, 5), view.Viewport);
Assert.Equal (new (0, 0, 5, 5), view.NeedsDrawRect);
view.Viewport = new (1, 1, 5, 5); // Scroll up/left 1
Assert.Equal (new (3, 3, 5, 5), view.Frame);
Assert.Equal (new (1, 1, 5, 5), view.Viewport);
Assert.Equal (new (0, 0, 5, 5), view.NeedsDrawRect);
view.Frame = new (3, 3, 6, 6); // Grow right/bottom 1
Assert.Equal (new (3, 3, 6, 6), view.Frame);
Assert.Equal (new (1, 1, 6, 6), view.Viewport);
Assert.Equal (new (1, 1, 6, 6), view.NeedsDrawRect);
view.Frame = new (3, 3, 5, 5);
Assert.Equal (new (3, 3, 5, 5), view.Frame);
Assert.Equal (new (1, 1, 5, 5), view.Viewport);
Assert.Equal (new (1, 1, 5, 5), view.NeedsDrawRect);
}
}