Files
Terminal.Gui/Tests/TerminalGuiFluentTesting/GuiTestContext.cs
Tig a84b2c4896 Fixes #4419, #4148, #4408 - Toplevel is GONE - Replaced by Runnable (#4422)
* WIP: Broken

* Got working. Mostly.

* Parllel tests pass

* More progres

* Fixed app tests.

* Mouse

* more progress.

* working on shortcut

* Shortcut accept on ENTER is broken.

* One left...

* More test progress.

* All unit tests pass. Still some issues though.

* tweak

* Fixed Integration Tests

* Fixed UI Catalog

* Tweaking CP to try to find race condition

* Refactor StandardColors and improve ColorPicker logic

Refactored `StandardColors` to use lazy initialization for static fields, improving performance and avoiding static constructor convoy effects. Introduced `NamesValueFactory` and `MapValueFactory` methods for encapsulated initialization logic.

Simplified `GetColorNames` to directly return `_names.Value`. Improved `TryParseColor` by clarifying default value usage and adopting object initializer syntax. Updated `TryNameColor` to use `_argbNameMap.Value`.

Refactored `GetArgb` for better readability. Replaced `MultiStandardColorNameResolver` with `StandardColorsNameResolver` in `ColorPicker`. Commented out `app.Init("Fake")` in `ColorPickerTests` for testing purposes.

Made minor formatting improvements, including updated comments and XML documentation for consistency.

* revert

* Throttle input loop to prevent CPU spinning

Introduce a 20ms delay in the input loop of `InputImpl<TInputRecord>`
to prevent excessive CPU usage when no input is available. Removed
the `DateTime dt = Now();` line and the `while (Peek())` block, which
previously enqueued input records.

This change improves resource management, especially in scenarios
where multiple `ApplicationImpl` instances are created in parallel
tests without calling `Shutdown()`. It prevents thread pool
exhaustion and ensures better performance in such cases.

* Refactor ApplicationImpl to use IDisposable pattern

Implemented the IDisposable pattern in ApplicationImpl to improve resource management. Added `Dispose` and `DisposeCore` methods, and marked the `Shutdown` method as obsolete, encouraging the use of `Dispose` or `using` statements instead. Updated the `IApplication` interface to inherit from IDisposable and added `GetResult` methods for retrieving run session results.

Refactored unit tests to adopt the new lifecycle management approach, replacing legacy `Shutdown` calls with `Dispose` or `using`. Removed fragile and obsolete tests, and re-enabled previously skipped tests after addressing underlying issues.

Updated `FakeApplicationLifecycle` and `SetupFakeApplicationAttribute` to align with the new disposal pattern. Improved documentation and examples to guide users toward modern usage patterns. Maintained backward compatibility for legacy singleton usage.

* Add IDisposable pattern with input loop throttling

- Add IDisposable to IApplication for proper resource cleanup
- Add 20ms throttle to input loop (prevents CPU spinning)
- Add Lazy<T> to StandardColors (eliminates convoy effect)
- Add MainLoopCoordinatorTests suite (5 new tests)
- Add Dispose() calls to all 16 ColorPickerTests
- Mark Application.Shutdown() as [Obsolete]

IApplication now requires Dispose() for cleanup

Performance: 100x CPU reduction, 15x faster disposal, tests complete in <5s

Fixes: Thread leaks, CPU saturation, test hangs in parallel execution
Docs: Updated application.md and newinv2.md with disposal patterns

* Refactor test for input loop throttling clarity

Updated `InputLoop_Throttle_Limits_Poll_Rate` test to improve clarity, reliability, and efficiency:
- Rewrote summary comment to clarify purpose and emphasize the 20ms throttle's role in preventing CPU spinning.
- Replaced `var` with explicit types for better readability.
- Reduced test duration from 1s to 500ms to improve test speed.
- Revised assertions:
  - Replaced range-based assertion with upper-bound check to ensure poll count is below 500, avoiding timing sensitivity issues.
  - Added assertion to verify the thread ran and was not immediately canceled.
- Added a 2-second timeout to `inputTask.Wait` and verified task completion.
- Improved comments to explain test behavior and reasoning behind changes.

* tweaks

* Fix nullabiltiy stuff.

* runnable fixes

* more nullabe

* More nullability

* warnings gone

* Fixed fluent test failure.

* Refactor ApplicationImpl and update Runnable layout logic

Refactored `ApplicationImpl.Run.cs` for improved readability and
atomicity:
- Combined `if (wasModal)` with `SessionStack?.TryPop` to streamline
  logic.
- Simplified restoration of `previousRunnable` by reducing nesting.
- Updated comments for clarity and retained `SetIsModal` call.

Simplified focus-setting logic in `ApplicationImpl.Run.cs` using
pattern matching for `TopRunnableView`.

In `Runnable<TResult>`, added `SetNeedsLayout` after `IsModalChanged`
to ensure layout updates. Removed an unused empty line for cleanup.

Corrected namespace in `GetViewsUnderLocationForRootTests.cs` to
align with test structure.

* Update layout on modal state change

A call to `SetNeedsLayout()` was added to the `OnIsModalChanged`
method in the `Runnable` class. This ensures that the layout
is updated whenever the modal state changes.

* Increase test timeout for inputTask.Wait to 10 seconds

Extended the timeout duration for the `inputTask.Wait` method
from 4 seconds to 10 seconds in `MainLoopCoordinatorTests`.
This change ensures the test has a longer window to complete
under conditions of increased load or slower execution
environments, reducing the likelihood of false test failures.

* Refactor project files and simplify test logic

Removed `<LangVersion>` and `<ImplicitUsings>` properties from
`UnitTests.csproj` and `UnitTests.Parallelizable.csproj` to rely
on default SDK settings and disable implicit global usings.

Simplified the `SizeChanged_Event_Still_Fires_For_Compatibility`
test in `FakeDriverTests` by removing the `screenChangedFired`
variable, its associated event handler, and related assertions.
Also removed obsolete warning suppression directives as they
are no longer needed.

* Reduce UnitTestsParallelizable iterations from 10 to 3

Reduced the number of iterations for the UnitTestsParallelizable
test suite from 10 to 3 to save time and resources while still
exposing concurrency issues. Updated the loop and log messages
to reflect the new iteration count.

* disabled InputLoop_Throttle_Limits_Poll_Rate

* Refactor app lifecycle and improve Runnable API

Refactored `Program.cs` to simplify application lifecycle:
- Modularized app creation, initialization, and disposal.
- Improved result handling and ensured proper resource cleanup.

Re-implemented `Runnable<TResult>` with a cleaner design:
- Retained functionality while improving readability and structure.
- Added XML documentation and followed the Cancellable Work Pattern.

Re-implemented `RunnableWrapper<TView, TResult>`:
- Enabled wrapping any `View` to make it runnable with typed results.
- Added examples and remarks for better developer guidance.

Re-implemented `ViewRunnableExtensions`:
- Provided fluent API for making views runnable with or without results.
- Enhanced documentation with examples for common use cases.

General improvements:
- Enhanced code readability, maintainability, and error handling.
- Replaced redundant code with cleaner, more maintainable versions.

* Modernize codebase for Terminal.Gui and MVVM updates

Refactored `LoginView` to remove redundant `Application.LayoutAndDraw()`
call. Enhanced `LoginViewModel` with new observable properties for
automatic property change notifications. Updated `Message` class to use
nullable generics for improved type safety.

Replaced legacy `Application.Init()` and `Application.Run()` calls with
the modern `IApplication` API across `Program.cs`, `Example.cs`, and
`ReactiveExample`. Ensured proper disposal of `IApplication` instances
to prevent resource leaks.

Updated `TerminalScheduler` to integrate with `IApplication` for
invoking actions and managing timeouts. Added null checks and improved
timeout disposal logic for robustness.

Refactored `ExampleWindow` for better readability and alignment with
modern `Terminal.Gui` conventions. Cleaned up unused imports and
improved code clarity across the codebase.

Updated README.md to reflect the latest `Terminal.Gui` practices,
including examples of the `IApplication` API and automatic UI refresh
handling. Renamed `LoginAction` to `LoginActions` for consistency.

* Refactor: Transition to IRunnable-based architecture

Replaced `Toplevel` with `Window` as the primary top-level UI element. Introduced the `IRunnable` interface to modernize the architecture, enabling greater flexibility and testability. Deprecated the static `Application` class in favor of the instance-based `IApplication` model, which supports multiple application contexts.

Updated methods like `Application.Run()` and `Application.RequestStop()` to use `IRunnable`. Removed or replaced legacy `Modal` properties with `IsModal`. Enhanced the `IApplication` interface with a fluent API, including methods like `Run<TRunnable>()` and `GetResult<T>()`.

Refactored tests and examples to align with the new architecture. Updated documentation to reflect the instance-based model. Deprecated obsolete members and methods, including `Application.Current` and `Application.TopRunnable`.

Improved event handling by replacing the `Accept` event with `Accepting` and using `e.Handled` for event processing. Updated threading examples to use `App?.Invoke()` or `app.Invoke()` for UI updates. Cleaned up redundant code and redefined modal behavior for better consistency.

These changes modernize the `Terminal.Gui` library, improving clarity, usability, and maintainability while ensuring backward compatibility where possible.

* Refactor: Replace Toplevel with Runnable class

This commit introduces a major architectural update to the `Terminal.Gui` library, replacing the legacy `Toplevel` class with the new `Runnable` class. The changes span the entire codebase, including core functionality, tests, documentation, and configuration files.

- **Core Class Replacement**:
  - Replaced `Toplevel` with `Runnable` as the base class for modal views and session management.
  - Updated all references to `Toplevel` in the codebase, including constructors, methods, and properties.

- **Configuration Updates**:
  - Updated `tui-config-schema.json` to reflect the new `Runnable` scheme.

- **New Classes**:
  - Added `UICatalogRunnable` for managing the UI Catalog application.
  - Introduced `Runnable<TResult>` as a generic base class for blocking sessions with result handling.

- **Documentation and Tests**:
  - Updated documentation to emphasize `Runnable` and mark `Toplevel` as obsolete.
  - Refactored test cases to use `Runnable` and ensure compatibility.

- **Behavioral Improvements**:
  - Enhanced lifecycle management and alignment with the `IRunnable` interface.
  - Improved clarity and consistency in naming conventions.

These changes modernize the library, improve flexibility, and provide a clearer architecture for developers.

* Refactor: Consolidate Runnable classes and decouple View from ApplicationImpl

- Made Runnable<TResult> inherit from Runnable (eliminating ~180 LOC duplication)
- Moved View init/layout/cursor logic from ApplicationImpl to Runnable lifecycle events
- ApplicationImpl.Begin now operates purely on IRunnable interface

Related to #4419

* Simplified the disposal logic in `ApplicationImpl.Run.cs` by replacing
the type-specific check for `View` with a more general check for
`IDisposable`. This ensures proper disposal of any `IDisposable`
object, improving robustness.

Removed the `FrameworkOwnedRunnable` property from the `ApplicationImpl`
class in `ApplicationImpl.cs` and the `IApplication` interface in
`IApplication.cs`. This eliminates the need to manage this property,
reducing complexity and improving maintainability.

Updated `application.md` to reflect the removal of the
`FrameworkOwnedRunnable` property, ensuring the documentation aligns
with the updated codebase.

* Replaces the legacy `Shutdown()` method with `Dispose()` to align
with the `IDisposable` pattern, ensuring proper resource cleanup
and simplifying the API. The `Dispose()` method is now the
recommended way to release resources, with `using` statements
encouraged for automatic disposal.

Key changes:
- Marked `Shutdown()` as obsolete; it now internally calls `Dispose()`.
- Updated the fluent API to remove `Shutdown()` from chaining.
- Enhanced session lifecycle management for thread safety.
- Updated tests to validate proper disposal and state reset.
- Improved `IRunnable` integration with automatic disposal for
  framework-created runnables.
- Maintained backward compatibility for the legacy static
  `Application` singleton.
- Refactored documentation and examples to reflect modern practices
  and emphasize `Dispose()` usage.

These changes modernize the `Terminal.Gui` lifecycle, improve
testability, and encourage alignment with .NET conventions.

* Refactor runnable app context handling in ApplicationImpl

Refactor how the application context is set for `runnable` objects
by introducing a new `SetApp` method in the `IRunnable` interface.
This replaces the previous logic of directly setting the `App`
property for `View` objects, making the process more generic and
encapsulated within `IRunnable` implementations.

Simplify `Mouse.UngrabMouse()` by removing the conditional check
and calling it unconditionally.

Make a minor formatting adjustment in the generic constraint of
`Run<TRunnable>` in `ApplicationImpl`.

Add `SetApp(IApplication app)` to the `IRunnable` interface and
implement it in the `Runnable` class to set the `App` property
to the provided application instance.

* Improve docs, tests, and modularity across the codebase

Reorganized and updated `CONTRIBUTING.md`:
- Added **Key Architecture Concepts** section and reordered the table of contents.
- Updated testing requirements to discourage legacy patterns.
- Added instructions for replicating CI workflows locally.
- Clarified PR guidelines and coding style expectations.

Enhanced `README.md` with detailed CI/CD workflow documentation.

Refactored `ColorPicker.Prompt` to use `IApplication` for improved modularity and testability.

Introduced `IApplicationScreenChangedTests` for comprehensive testing of `ScreenChanged` events and `Screen` property.

Refactored `ApplicationScreenTests` and `TextView.PromptForColors` to align with modern patterns.

Updated `Terminal.sln` to include `.github/workflows/README.md`.

Performed general cleanup:
- Removed outdated documentation links.
- Improved XML documentation and coding consistency.

* readme tweaks

* Improve thread safety, layout, and test coverage

Refactored `OutputBufferImpl.cs` to enhance thread safety by locking shared resources and adding bounds checks for columns and rows. Improved handling of wide characters and removed outdated TODO comments.

Updated `Runnable.cs` to call `SetNeedsDraw()` on modal state changes, ensuring proper layout and drawing updates. Simplified layout handling in `ApplicationImpl.Run.cs` by replacing redundant comments with a `LayoutAndDraw()` call.

Added a check in `AllViewsTester.cs` to skip creating instances of `RunnableWrapper` types with unsatisfiable generic constraints, logging a warning when encountered.

Enhanced `ListViewTests.cs` by adding explicit `app.LayoutAndDraw()` calls to validate visual output and ensure tests reflect the updated application state.

These changes improve robustness, prevent race conditions, and ensure consistent behavior across the application.

* Refactor: Rename Toplevel to Runnable and update logic

Updated the `Border` class to use `Command.Quit` instead of
`Command.QuitToplevel` in the `CloseButton.Accept` handler.

Renamed test methods in `GetViewsAtLocationTests.cs` to replace
"Toplevel" with "Runnable" for consistency. Updated `Runnable<bool>`
instances to use "topRunnable" as the `Id` property.

These changes align the codebase with updated naming conventions
and improve clarity.

* Removed `ToplevelTests` and migrated relevant test cases to
`MouseDragTests` with improved structure and coverage. Updated
tests to use `Application.Create`, `app.Begin`, and `app.End`
for better resource management and lifecycle handling.

Replaced direct event handling with `app.Mouse.RaiseMouseEvent`
to align with the application's event-handling mechanism. Added
`Runnable` objects to ensure views are properly initialized and
disposed of within the application context.

Enhanced tests to include assertions for minimum width and
height constraints during resize operations. Removed redundant
tests and streamlined logic to reduce duplication and improve
maintainability.

* Reorged Unit Test namespaces.

* more

* Refactor tests and update namespaces for consistency

Updated namespaces in `ArrangementTests.cs` and `MouseDragTests.cs` for better organization. Enhanced `ArrangementTests.cs` with additional checks for arrangement flags. Reformatted and re-added `MouseDragTests.cs` and `SchemeTests.cs` with modern C# features like nullable annotations and object initializers. Ensured no functional changes while improving code clarity and consistency.

* Fix nullability warnings in MouseDragTests.cs

Updated `app.End` calls to use the null-forgiving operator (`!`)
on `app.SessionStack` to ensure it is treated as non-null.
This change addresses potential nullability warnings and
improves code safety and clarity. Applied consistently across
all relevant test cases in the `MouseDragTests` class.
2025-12-01 12:54:21 -07:00

605 lines
21 KiB
C#

using System.Diagnostics;
using System.Drawing;
using System.Text;
using Microsoft.Extensions.Logging;
#pragma warning disable CS1591 // Missing XML comment for publicly visible type or member
namespace TerminalGuiFluentTesting;
/// <summary>
/// Fluent API context for testing a Terminal.Gui application. Create
/// an instance using <see cref="With"/> static class.
/// </summary>
public partial class GuiTestContext : IDisposable
{
// ===== Threading & Synchronization =====
private readonly CancellationTokenSource _runCancellationTokenSource = new ();
private readonly CancellationTokenSource? _timeoutCts;
private readonly Task? _runTask;
private readonly SemaphoreSlim _booting;
private readonly object _cancellationLock = new ();
private volatile bool _finished;
// ===== Exception Handling =====
private readonly object _backgroundExceptionLock = new ();
private Exception? _backgroundException;
// ===== Driver & Application State =====
private readonly FakeInput _fakeInput = new ();
private IOutput? _output;
private SizeMonitorImpl? _sizeMonitor;
private ApplicationImpl? _applicationImpl;
/// <summary>
/// The IApplication instance that was created.
/// </summary>
public IApplication? App => _applicationImpl;
private TestDriver _driverType;
// ===== Application State Preservation (for restoration) =====
private ILogger? _originalLogger;
// ===== Test Configuration =====
private readonly bool _runApplication;
private TimeSpan _timeout;
// ===== Logging =====
private readonly object _logsLock = new ();
private readonly TextWriter? _logWriter;
private StringBuilder? _logsSb;
/// <summary>
/// Constructor for tests that only need Application.Init without running the main loop.
/// Uses the driver's default screen size instead of forcing a specific size.
/// </summary>
public GuiTestContext (TestDriver driver, TextWriter? logWriter = null, TimeSpan? timeout = null)
{
_logWriter = logWriter;
_runApplication = false;
_booting = new (0, 1);
_timeoutCts = new CancellationTokenSource (timeout ?? TimeSpan.FromSeconds (10)); // NEW
// Don't force a size - let the driver determine it
CommonInit (0, 0, driver, timeout);
try
{
App?.Init (GetDriverName ());
_booting.Release ();
// After Init, Application.Screen should be set by the driver
if (_applicationImpl?.Screen == Rectangle.Empty)
{
throw new InvalidOperationException (
"Driver bug: Application.Screen is empty after Init. The driver should set the screen size during Init.");
}
}
catch (Exception ex)
{
lock (_backgroundExceptionLock) // NEW: Thread-safe exception handling
{
_backgroundException = ex;
}
if (_logWriter != null)
{
WriteOutLogs (_logWriter);
}
throw new ("Application initialization failed", ex);
}
lock (_backgroundExceptionLock) // NEW: Thread-safe check
{
if (_backgroundException != null)
{
throw new ("Application initialization failed", _backgroundException);
}
}
}
/// <summary>
/// Constructor for tests that need to run the application with Application.Run.
/// </summary>
internal GuiTestContext (Func<IRunnable> runnableBuilder, int width, int height, TestDriver driver, TextWriter? logWriter = null, TimeSpan? timeout = null)
{
_logWriter = logWriter;
_runApplication = true;
_booting = new (0, 1);
CommonInit (width, height, driver, timeout);
// Start the application in a background thread
_runTask = Task.Run (
() =>
{
try
{
try
{
App?.Init (GetDriverName ());
}
catch (Exception e)
{
Logging.Error(e.Message);
_runCancellationTokenSource.Cancel ();
}
finally
{
_booting.Release ();
}
if (App is { Initialized: true })
{
IRunnable runnable = runnableBuilder ();
runnable.IsRunningChanged += (s, e) =>
{
if (!e.Value)
{
Finished = true;
}
};
App?.Run (runnable); // This will block, but it's on a background thread now
if (runnable is View runnableView)
{
runnableView.Dispose ();
}
Logging.Trace ("Application.Run completed");
App?.Dispose ();
_runCancellationTokenSource.Cancel ();
}
}
catch (OperationCanceledException)
{
Logging.Trace ("OperationCanceledException");
}
catch (Exception ex)
{
_backgroundException = ex;
_fakeInput.ExternalCancellationTokenSource!.Cancel ();
}
finally
{
CleanupApplication ();
if (_logWriter != null)
{
WriteOutLogs (_logWriter);
}
}
},
_runCancellationTokenSource.Token);
// Wait for booting to complete with a timeout to avoid hangs
if (!_booting.WaitAsync (_timeout).Result)
{
throw new TimeoutException ($"Application failed to start within {_timeout}ms.");
}
ResizeConsole (width, height);
if (_backgroundException is { })
{
throw new ("Application crashed", _backgroundException);
}
}
/// <summary>
/// Common initialization for both constructors.
/// </summary>
private void CommonInit (int width, int height, TestDriver driverType, TimeSpan? timeout)
{
_timeout = timeout ?? TimeSpan.FromSeconds (30);
_originalLogger = Logging.Logger;
_logsSb = new ();
_driverType = driverType;
ILogger logger = LoggerFactory.Create (builder =>
builder.SetMinimumLevel (LogLevel.Trace)
.AddProvider (
new TextWriterLoggerProvider (
new ThreadSafeStringWriter (_logsSb, _logsLock))))
.CreateLogger ("Test Logging");
Logging.Logger = logger;
// ✅ Link _runCancellationTokenSource with a timeout
// This creates a token that responds to EITHER the run cancellation OR timeout
_fakeInput.ExternalCancellationTokenSource =
CancellationTokenSource.CreateLinkedTokenSource (
_runCancellationTokenSource.Token,
new CancellationTokenSource (_timeout).Token);
// Now when InputImpl.Run receives this ExternalCancellationTokenSource,
// it will create ANOTHER linked token internally that combines:
// - Its own runCancellationToken parameter
// - The ExternalCancellationTokenSource (which is already linked)
// This creates a chain: any of these triggers will stop input:
// 1. _runCancellationTokenSource.Cancel() (normal stop)
// 2. Timeout expires (test timeout)
// 3. Direct cancel of ExternalCancellationTokenSource (hard stop/error)
// Remove frame limit
Application.MaximumIterationsPerSecond = ushort.MaxValue;
IComponentFactory? cf = null;
_output = new FakeOutput ();
// Only set size if explicitly provided (width and height > 0)
if (width > 0 && height > 0)
{
_output.SetSize (width, height);
}
// TODO: As each drivers' IInput/IOutput implementations are made testable (e.g.
// TODO: safely injectable/mocked), we can expand this switch to use them.
switch (driverType)
{
case TestDriver.DotNet:
_sizeMonitor = new (_output);
cf = new FakeComponentFactory (_fakeInput, _output, _sizeMonitor);
break;
case TestDriver.Windows:
_sizeMonitor = new (_output);
cf = new FakeComponentFactory (_fakeInput, _output, _sizeMonitor);
break;
case TestDriver.Unix:
_sizeMonitor = new (_output);
cf = new FakeComponentFactory (_fakeInput, _output, _sizeMonitor);
break;
case TestDriver.Fake:
_sizeMonitor = new (_output);
cf = new FakeComponentFactory (_fakeInput, _output, _sizeMonitor);
break;
}
_applicationImpl = new (cf!);
Logging.Trace ($"Driver: {GetDriverName ()}. Timeout: {_timeout}");
}
private string GetDriverName ()
{
return _driverType switch
{
TestDriver.Windows => "windows",
TestDriver.DotNet => "dotnet",
TestDriver.Unix => "unix",
TestDriver.Fake => "fake",
_ =>
throw new ArgumentOutOfRangeException ()
};
}
/// <summary>
/// Gets whether the application has finished running; aka Stop has been called and the main loop has exited.
/// </summary>
public bool Finished
{
get => _finished;
private set => _finished = value;
}
/// <summary>
/// Performs the supplied <paramref name="doAction"/> immediately.
/// Enables running commands without breaking the Fluent API calls.
/// </summary>
/// <param name="doAction"></param>
/// <returns></returns>
public GuiTestContext Then (Action<IApplication> doAction)
{
try
{
Logging.Trace ($"Invoking action via WaitIteration");
WaitIteration (doAction);
}
catch (Exception ex)
{
_backgroundException = ex;
HardStop ();
throw;
}
return this;
}
/// <summary>
/// Waits until the end of the current iteration of the main loop. Optionally
/// running a given <paramref name="action"/> action on the UI thread at that time.
/// </summary>
/// <param name="action"></param>
/// <returns></returns>
public GuiTestContext WaitIteration (Action<IApplication>? action = null)
{
// If application has already exited don't wait!
if (Finished || _runCancellationTokenSource.Token.IsCancellationRequested || _fakeInput.ExternalCancellationTokenSource!.Token.IsCancellationRequested)
{
Logging.Warning ("WaitIteration called after context was stopped");
return this;
}
if (Thread.CurrentThread.ManagedThreadId == _applicationImpl?.MainThreadId)
{
throw new NotSupportedException ("Cannot WaitIteration during Invoke");
}
//Logging.Trace ($"WaitIteration started");
if (action is null)
{
action = (app) => { };
}
CancellationTokenSource ctsActionCompleted = new ();
App?.Invoke (app =>
{
try
{
action (app);
//Logging.Trace ("Action completed");
ctsActionCompleted.Cancel ();
}
catch (Exception e)
{
Logging.Warning ($"Action failed with exception: {e}");
_backgroundException = e;
_fakeInput.ExternalCancellationTokenSource?.Cancel ();
}
});
// Blocks until either the token or the hardStopToken is cancelled.
// With linked tokens, we only need to wait on _runCancellationTokenSource and ctsLocal
// ExternalCancellationTokenSource is redundant because it's linked to _runCancellationTokenSource
WaitHandle.WaitAny (
[
_runCancellationTokenSource.Token.WaitHandle,
ctsActionCompleted.Token.WaitHandle
]);
// Logging.Trace ($"Return from WaitIteration");
return this;
}
public GuiTestContext WaitUntil (Func<bool> condition)
{
GuiTestContext? c = null;
var sw = Stopwatch.StartNew ();
Logging.Trace ($"WaitUntil started with timeout {_timeout}");
int count = 0;
while (!condition ())
{
if (sw.Elapsed > _timeout)
{
throw new TimeoutException ($"Failed to reach condition within {_timeout}ms");
}
c = WaitIteration ();
count++;
}
Logging.Trace ($"WaitUntil completed after {sw.ElapsedMilliseconds}ms and {count} iterations");
return c ?? this;
}
/// <summary>
/// Returns the last set position of the cursor.
/// </summary>
/// <returns></returns>
public Point GetCursorPosition () { return _output!.GetCursorPosition (); }
/// <summary>
/// Simulates changing the console size e.g. by resizing window in your operating system
/// </summary>
/// <param name="width">new Width for the console.</param>
/// <param name="height">new Height for the console.</param>
/// <returns></returns>
public GuiTestContext ResizeConsole (int width, int height)
{
return WaitIteration ((app) => { app.Driver!.SetScreenSize (width, height); });
}
public GuiTestContext ScreenShot (string title, TextWriter? writer)
{
//Logging.Trace ($"{title}");
return WaitIteration ((app) =>
{
writer?.WriteLine (title + ":");
var text = app.Driver?.ToString ();
writer?.WriteLine (text);
});
}
public GuiTestContext AnsiScreenShot (string title, TextWriter? writer)
{
//Logging.Trace ($"{title}");
return WaitIteration ((app) =>
{
writer?.WriteLine (title + ":");
var text = app.Driver?.ToAnsi ();
writer?.WriteLine (text);
});
}
/// <summary>
/// Stops the application and waits for the background thread to exit.
/// </summary>
public GuiTestContext Stop ()
{
Logging.Trace ($"Stopping application for driver: {GetDriverName ()}");
if (_runTask is null || _runTask.IsCompleted)
{
// If we didn't run the application, just cleanup
if (!_runApplication && !Finished)
{
try
{
App?.Dispose ();
}
catch
{
// Ignore errors during shutdown
}
CleanupApplication ();
}
return this;
}
WaitIteration ((app) => { app.RequestStop (); });
// Wait for the application to stop, but give it a 1-second timeout
const int WAIT_TIMEOUT_MS = 1000;
if (!_runTask.Wait (TimeSpan.FromMilliseconds (WAIT_TIMEOUT_MS)))
{
_runCancellationTokenSource.Cancel ();
// No need to manually cancel ExternalCancellationTokenSource
// App is having trouble shutting down, try sending some more shutdown stuff from this thread.
// If this doesn't work there will be test failures as the main loop continues to run during next test.
try
{
App?.RequestStop ();
App?.Dispose ();
}
catch (Exception ex)
{
Logging.Critical ($"Application failed to stop in {WAIT_TIMEOUT_MS}. Then shutdown threw {ex}");
}
finally
{
Logging.Critical ($"Application failed to stop in {WAIT_TIMEOUT_MS}. Exception was thrown: {_backgroundException}");
}
}
_runCancellationTokenSource.Cancel ();
if (_backgroundException != null)
{
Logging.Critical ($"Exception occurred: {_backgroundException}");
//throw _ex; // Propagate any exception that happened in the background task
}
return this;
}
/// <summary>
/// Hard stops the application and waits for the background thread to exit.HardStop is used by the source generator for
/// wrapping Xunit assertions.
/// </summary>
public void HardStop (Exception? ex = null)
{
if (ex != null)
{
_backgroundException = ex;
}
Logging.Critical ($"HardStop called with exception: {_backgroundException}");
// With linked tokens, just cancelling ExternalCancellationTokenSource
// will cascade to stop everything
_fakeInput.ExternalCancellationTokenSource?.Cancel ();
WriteOutLogs (_logWriter);
Stop ();
}
/// <summary>
/// Writes all Terminal.Gui engine logs collected so far to the <paramref name="writer"/>
/// </summary>
/// <param name="writer"></param>
/// <returns></returns>
public GuiTestContext WriteOutLogs (TextWriter? writer)
{
if (writer is null)
{
return this;
}
lock (_logsLock)
{
writer.WriteLine (_logsSb!.ToString ());
}
return this; //WaitIteration();
}
internal void Fail (string reason)
{
Logging.Error ($"{reason}");
WriteOutLogs (_logWriter);
throw new (reason);
}
private void CleanupApplication ()
{
Logging.Trace ("CleanupApplication");
_fakeInput.ExternalCancellationTokenSource = null;
App?.ResetState (true);
Logging.Logger = _originalLogger!;
Finished = true;
Application.MaximumIterationsPerSecond = Application.DefaultMaximumIterationsPerSecond;
}
/// <summary>
/// Cleanup to avoid state bleed between tests
/// </summary>
public void Dispose ()
{
Logging.Trace ($"Disposing GuiTestContext");
Stop ();
bool shouldThrow = false;
Exception? exToThrow = null;
lock (_cancellationLock) // NEW: Thread-safe check
{
if (_fakeInput.ExternalCancellationTokenSource is { IsCancellationRequested: true })
{
shouldThrow = true;
lock (_backgroundExceptionLock)
{
exToThrow = _backgroundException;
}
}
// ✅ Dispose the linked token source
_fakeInput.ExternalCancellationTokenSource?.Dispose ();
}
_timeoutCts?.Dispose (); // NEW: Dispose timeout CTS
_runCancellationTokenSource?.Dispose ();
_fakeInput.Dispose ();
_output?.Dispose ();
_booting.Dispose ();
if (shouldThrow)
{
throw new ("Application was hard stopped...", exToThrow);
}
}
}