Files
Terminal.Gui/UnitTests/Application/KeyboardTests.cs
Tig dcb3b359ad Fixes #2926 - Refactor KeyEvent and KeyEventEventArgs to simplify (#2927)
* Adds basic MainLoop unit tests

* Remove WinChange action from Curses

* Remove WinChange action from Curses

* Remove ProcessInput action from Windows MainLoop

* Simplified MainLoop/ConsoleDriver by making MainLoop internal and moving impt fns to Application

* Modernized Terminal resize events

* Modernized Terminal resize events

* Removed un used property

* for _isWindowsTerminal devenv->wininit; not sure what changed

* Modernized mouse/keyboard events (Action->EventHandler)

* Updated OnMouseEvent API docs

* Using WT_SESSION to detect WT

* removes hacky GetParentProcess

* Updates to fix #2634 (clear last line)

* removes hacky GetParentProcess2

* Addressed mac resize issue

* Addressed mac resize issue

* Removes ConsoleDriver.PrepareToRun, has Init return MainLoop

* Removes unneeded Attribute methods

* Removed GetProcesssName

* Removed GetProcesssName

* Refactored KeyEvent and KeyEventEventArgs into a single class

* Revert "Refactored KeyEvent and KeyEventEventArgs into a single class"

This reverts commit 88a00658db.

* Fixed key repeat issue; reverted stupidity on 1049/1047 confusion

* Updated CSI API Docs

* merge

* Rearranged Event.cs to Keyboard.cs and Mouse.cs

* Renamed KeyEventEventArgs KeyEventArgs

* temp renamed KeyEvent OldKeyEvent

* Merged KeyEvent into KeyEventArgs

* Renamed Application.ProcessKey members

* Renamed Application.ProcessKey members

* Renamed Application.ProcessKey members

* Added Responder.KeyPressed

* Removed unused references

* Fixed arg naming

* InvokeKeybindings->InvokeKeyBindings

* InvokeKeybindings->InvokeKeyBindings

* Fixed unit tests fail

* More progress on refactoring key input; still broken and probably wrong

* Moved OnKeyPressed out of Responder and made ProcessKeyPrssed non-virtual

* Updated API docs

* Moved key handling from Responder to View

* Updated API docs

* Updated HotKey API docs

* Updated shortcut API docs

* Fixed responder unit tests

* Removed Shortcut from View as it is not used

* Removed unneeded OnHotKey override from Button

* Fixed BackTab logic

* Button now uses Key Bindings exclusively

* Button now uses Key Bindings exclusively

* Updated keyboard.md docs

* Fixed unit tests to account for Toplevel handling default button

* Added View.InvokeCommand API

* Modernized RadioGroup

* Removed ColdKey

* Modernized (partially) StatusBar

* Worked around FileDialog issue with Ctrl-F

* Fixed driver unit test; view must be focused to reciev key pressed

* Application code cleanup

* Start on updaing menu

* Menu now mostly works

* Menu Select refinement

* Fixed known menu bugs!

* Enabled HotKey to cause focus- experimental

* Fixes #3022 & adds unit test to prove it

* Actually Fixes #3022 & adds unit test to prove it

* Working through hotkey issues

* Misc fixes

* removed hot/cold key stuff from Keys scenario

* Fixed scenarios

* Simplified shortcut string handling

* Modernized Checkbox

* Modernized TileView

* Updated API docs

* Updated API docs

* attempting to publish v2 docs

* Revert "attempting to publish v2 docs"

This reverts commit 59dcec111b.

* Playing with api docs

* Removed Key.BackTab

* Removed Caps/Scroll/Numlock

* Partial removal of keymodifiers - unit tests pass

* Partial removal of keymodifiers - broke netdriver somewhere

* WindowsDriver & added KeyEventArgsTests

* Fixing menu shortcut/hotkeys - broke Menu.cs into separate files

* Fixed MenuBar!

* Finished modernizing Menu/MenuBar

* Removed Key.a-z. Broke lots of stuff

* checkout@v4

* progress on key mapping and formatting

* VK tests are still failing

* Fixed some unit tests

* Added Hotkey and Keybinding unit tests

* fixed unit test

* All unit tests pass again...

* Fixed broken unit tests

* KeyEventArgs.KeyValue -> AsRune

* Fixed bugs. Still some broken

* Added KeyEventArgs.IsAlpha. Added KeyEventArgs.cast ops. Fixed bugs. Unit tests pass

* Fixed WindowsDriver

* Oops.

* Refactoring based on bdisp's help. Not complete!

* removed calling into subviews from OnKeyBindings

* removed calling into subviews from OnKeyBindings

* Improved View KeyEvent unit tests

* More hotkey unit tests

* BIg change - Got rid of KeyPress w/in Application/Drivers

* Unit tests now pass again

* Refreshed API docs

* Better HotKey logic. More progress. Getting close.

* Fixed handling of shifted chars like ö

* Minor code cleanup

* Minor code cleanup2

* Why is build Action failing?

* Why is build Action failing??

* upgraded to .net8 to try to fix weird CI/CD build errors

* upgraded to .net8 to try to fix weird CI/CD build errors2

* Disabling TextViewTests to diagnose build errors

* reenable TextViewTests to diagnose build errors

* Arrrrrrg

* Merged v2_develop

* Fixed uppercase accented keys in WindowsDriver

* Fixed key binding api docs

* Experimental impl of CommandScope.SubViews for MenuBar

* Removed dead code from application.cs

* Removed dead code from application.cs

* Removed dead code from ConsoleDriver.cs

* Cleaned up some key binding stuff

* Disabled Alt to activate menu for now

* Updated label commands

* Fixed menu bugs. Upgraded menu unit tests

* Fixed unit tests

* Working on NetDriver

* fixed netdriver

* Fixed issues called out by @bdisp CR

* fixed CursesDriver

* added todo to netdriver

* Cherry picked treeview test fix 1b415e5

* Fix NetDriver.

* CommandScope->KeyBindingScope

* Address some tznind feedback

* Refactored KeyBindings big time!

* Added key consts to KeyEventArgs and renamed Key to ConsoleDriverKey

* Fixed some API docs

* Moved ConsoleDriverKey to ConsoleDriver.cs

* Renamed Key->ConsoleDriverKey

* Renamed Key->ConsoleDriverKey

* Renamed Key->ConsoleDriverKey

* renamed file I forgot to rename before

* Updated name and API docs of KeyEventArgs.isAlpha

* Fixed issues with OnKeyUp not doing the right thing.

* Fixed MainLoop.Running never being used

* Fixed MainLoop.Running never being used - unit tests

* Claned up BUGBUG comments

* Disabled a unit test to see why ci/cd tests are failing

* Removed defunct commented code

* Removed more defunct commented code

* Re-eanbled unit test; jsut removing one test case...

* Disabled more...

* Renambed Global->Applicaton and updated scope API docs

* Disabled more unit tests...

* Removed dead code

* Disabled more unit tests...2

* Disabled more unit tests...3

* Renambed Global->Applicaton and updated scope API docs 2

* Added more KeyBinding scope tests

* Added more KeyBinding scope tests2

* ConsoleDriverKey too long. Key too ambiguous. Settled on KeyCode. (Partialy because eventually I want to intro a class named Key).

* KeyEventArgs improvements. cast to Rune must be explicit as it's lossy

* Fixed warnings

* Renamed KeyEventArgs to Key... progress on fixing broken stuff that resulted

* Fix ConsoleKeyMapping bugs.

* Fix NetDriver issue from converting a lower case to a upper case.

* Started migration to Key from KeyCode - e.g. made HotKeys all consistent.

* Fixed build warnings

* Added key defns to Key

* KeyBindings now uses Key vs. KeyCode

* Verified by tweaking UICatalog

* Fixed treeview test ... again

* Renamed ProcessKeyDown/Up to NewKeyDown/Up and OnKeyPressed to OnProcessKeyDown to make things more clear

* Added test AllViews_KeyDown_All_EventsFire unit tests and fixed a few Views that were wrong

* fixed stupid KeyUp event bug

* If key not handled, return false for datefield

* dotnet test --no-restore --verbosity diag

* dotnet test --blame

* run tests on windows

* Fix TestVKPacket unit test and move it to ConsoleKeyMappingTests.cs file.

* Remove unnecessary commented code.

* Tweaked unit tests and removed Key.BareKey

* Fixed little details and updated api docs

* updated api docs

* AddKeyBindingsForHotKey: KeyCode->Key

* Cleaned up more old KeyCode usages. Added TODOs

---------

Co-authored-by: BDisp <bd.bdisp@gmail.com>
2023-12-16 12:04:23 -07:00

396 lines
12 KiB
C#

using System;
using System.Linq;
using Xunit;
using Xunit.Abstractions;
namespace Terminal.Gui.ApplicationTests;
public class KeyboardTests {
readonly ITestOutputHelper _output;
public KeyboardTests (ITestOutputHelper output)
{
this._output = output;
#if DEBUG_IDISPOSABLE
Responder.Instances.Clear ();
RunState.Instances.Clear ();
#endif
}
[Fact]
public void KeyUp_Event ()
{
Application.Init (new FakeDriver ());
// Setup some fake keypresses (This)
var input = "Tests";
// Put a control-q in at the end
FakeConsole.MockKeyPresses.Push (new ConsoleKeyInfo ('Q', ConsoleKey.Q, shift: false, alt: false, control: true));
foreach (var c in input.Reverse ()) {
if (char.IsLetter (c)) {
FakeConsole.MockKeyPresses.Push (new ConsoleKeyInfo (c, (ConsoleKey)char.ToUpper (c), shift: char.IsUpper (c), alt: false, control: false));
} else {
FakeConsole.MockKeyPresses.Push (new ConsoleKeyInfo (c, (ConsoleKey)c, shift: false, alt: false, control: false));
}
}
int stackSize = FakeConsole.MockKeyPresses.Count;
int iterations = 0;
Application.Iteration += (s, a) => {
iterations++;
// Stop if we run out of control...
if (iterations > 10) {
Application.RequestStop ();
}
};
int keyUps = 0;
var output = string.Empty;
Application.Top.KeyUp += (object sender, Key args) => {
if (args.KeyCode != (KeyCode.CtrlMask | KeyCode.Q)) {
output += args.AsRune;
}
keyUps++;
};
Application.Run (Application.Top);
// Input string should match output
Assert.Equal (input, output);
// # of key up events should match stack size
//Assert.Equal (stackSize, keyUps);
// We can't use numbers variables on the left side of an Assert.Equal/NotEqual,
// it must be literal (Linux only).
Assert.Equal (6, keyUps);
// # of key up events should match # of iterations
Assert.Equal (stackSize, iterations);
Application.Shutdown ();
Assert.Null (Application.Current);
Assert.Null (Application.Top);
Assert.Null (Application.MainLoop);
Assert.Null (Application.Driver);
}
[Fact]
public void AlternateForwardKey_AlternateBackwardKey_Tests ()
{
Application.Init (new FakeDriver ());
var top = Application.Top;
var w1 = new Window ();
var v1 = new TextField ();
var v2 = new TextView ();
w1.Add (v1, v2);
var w2 = new Window ();
var v3 = new CheckBox ();
var v4 = new Button ();
w2.Add (v3, v4);
top.Add (w1, w2);
Application.Iteration += (s, a) => {
Assert.True (v1.HasFocus);
// Using default keys.
top.NewKeyDownEvent (new (KeyCode.CtrlMask | KeyCode.Tab));
Assert.True (v2.HasFocus);
top.NewKeyDownEvent (new (KeyCode.CtrlMask | KeyCode.Tab));
Assert.True (v3.HasFocus);
top.NewKeyDownEvent (new (KeyCode.CtrlMask | KeyCode.Tab));
Assert.True (v4.HasFocus);
top.NewKeyDownEvent (new (KeyCode.CtrlMask | KeyCode.Tab));
Assert.True (v1.HasFocus);
top.NewKeyDownEvent (new (KeyCode.ShiftMask | KeyCode.CtrlMask | KeyCode.Tab));
Assert.True (v4.HasFocus);
top.NewKeyDownEvent (new (KeyCode.ShiftMask | KeyCode.CtrlMask | KeyCode.Tab));
Assert.True (v3.HasFocus);
top.NewKeyDownEvent (new (KeyCode.ShiftMask | KeyCode.CtrlMask | KeyCode.Tab));
Assert.True (v2.HasFocus);
top.NewKeyDownEvent (new (KeyCode.ShiftMask | KeyCode.CtrlMask | KeyCode.Tab));
Assert.True (v1.HasFocus);
top.NewKeyDownEvent (new (KeyCode.CtrlMask | KeyCode.PageDown));
Assert.True (v2.HasFocus);
top.NewKeyDownEvent (new (KeyCode.CtrlMask | KeyCode.PageDown));
Assert.True (v3.HasFocus);
top.NewKeyDownEvent (new (KeyCode.CtrlMask | KeyCode.PageDown));
Assert.True (v4.HasFocus);
top.NewKeyDownEvent (new (KeyCode.CtrlMask | KeyCode.PageDown));
Assert.True (v1.HasFocus);
top.NewKeyDownEvent (new (KeyCode.CtrlMask | KeyCode.PageUp));
Assert.True (v4.HasFocus);
top.NewKeyDownEvent (new (KeyCode.CtrlMask | KeyCode.PageUp));
Assert.True (v3.HasFocus);
top.NewKeyDownEvent (new (KeyCode.CtrlMask | KeyCode.PageUp));
Assert.True (v2.HasFocus);
top.NewKeyDownEvent (new (KeyCode.CtrlMask | KeyCode.PageUp));
Assert.True (v1.HasFocus);
// Using another's alternate keys.
Application.AlternateForwardKey = KeyCode.F7;
Application.AlternateBackwardKey = KeyCode.F6;
top.NewKeyDownEvent (new (KeyCode.F7));
Assert.True (v2.HasFocus);
top.NewKeyDownEvent (new (KeyCode.F7));
Assert.True (v3.HasFocus);
top.NewKeyDownEvent (new (KeyCode.F7));
Assert.True (v4.HasFocus);
top.NewKeyDownEvent (new (KeyCode.F7));
Assert.True (v1.HasFocus);
top.NewKeyDownEvent (new (KeyCode.F6));
Assert.True (v4.HasFocus);
top.NewKeyDownEvent (new (KeyCode.F6));
Assert.True (v3.HasFocus);
top.NewKeyDownEvent (new (KeyCode.F6));
Assert.True (v2.HasFocus);
top.NewKeyDownEvent (new (KeyCode.F6));
Assert.True (v1.HasFocus);
Application.RequestStop ();
};
Application.Run (top);
// Replacing the defaults keys to avoid errors on others unit tests that are using it.
Application.AlternateForwardKey = KeyCode.PageDown | KeyCode.CtrlMask;
Application.AlternateBackwardKey = KeyCode.PageUp | KeyCode.CtrlMask;
Application.QuitKey = KeyCode.Q | KeyCode.CtrlMask;
Assert.Equal (KeyCode.PageDown | KeyCode.CtrlMask, Application.AlternateForwardKey.KeyCode);
Assert.Equal (KeyCode.PageUp | KeyCode.CtrlMask, Application.AlternateBackwardKey.KeyCode);
Assert.Equal (KeyCode.Q | KeyCode.CtrlMask, Application.QuitKey.KeyCode);
// Shutdown must be called to safely clean up Application if Init has been called
Application.Shutdown ();
}
[Fact]
[AutoInitShutdown]
public void QuitKey_Getter_Setter ()
{
var top = Application.Top;
var isQuiting = false;
top.Closing += (s, e) => {
isQuiting = true;
e.Cancel = true;
};
Application.Begin (top);
top.Running = true;
Assert.Equal (KeyCode.Q | KeyCode.CtrlMask, Application.QuitKey.KeyCode);
Application.Driver.SendKeys ('Q', ConsoleKey.Q, false, false, true);
Assert.True (isQuiting);
isQuiting = false;
Application.OnKeyDown(new Key ( KeyCode.Q | KeyCode.CtrlMask));
Assert.True (isQuiting);
isQuiting = false;
Application.QuitKey = KeyCode.C | KeyCode.CtrlMask;
Application.Driver.SendKeys ('Q', ConsoleKey.Q, false, false, true);
Assert.False (isQuiting);
Application.OnKeyDown (new Key (KeyCode.Q | KeyCode.CtrlMask));
Assert.False (isQuiting);
Application.OnKeyDown (Application.QuitKey);
Assert.True (isQuiting);
// Reset the QuitKey to avoid throws errors on another tests
Application.QuitKey = KeyCode.Q | KeyCode.CtrlMask;
}
[Fact]
[AutoInitShutdown]
public void EnsuresTopOnFront_CanFocus_True_By_Keyboard_And_Mouse ()
{
var top = Application.Top;
var win = new Window () { Title = "win", X = 0, Y = 0, Width = 20, Height = 10 };
var tf = new TextField () { Width = 10 };
win.Add (tf);
var win2 = new Window () { Title = "win2", X = 22, Y = 0, Width = 20, Height = 10 };
var tf2 = new TextField () { Width = 10 };
win2.Add (tf2);
top.Add (win, win2);
Application.Begin (top);
Assert.True (win.CanFocus);
Assert.True (win.HasFocus);
Assert.True (win2.CanFocus);
Assert.False (win2.HasFocus);
Assert.Equal ("win2", ((Window)top.Subviews [top.Subviews.Count - 1]).Title);
top.NewKeyDownEvent (new (KeyCode.CtrlMask | KeyCode.Tab));
Assert.True (win.CanFocus);
Assert.False (win.HasFocus);
Assert.True (win2.CanFocus);
Assert.True (win2.HasFocus);
Assert.Equal ("win2", ((Window)top.Subviews [top.Subviews.Count - 1]).Title);
top.NewKeyDownEvent (new (KeyCode.CtrlMask | KeyCode.Tab));
Assert.True (win.CanFocus);
Assert.True (win.HasFocus);
Assert.True (win2.CanFocus);
Assert.False (win2.HasFocus);
Assert.Equal ("win", ((Window)top.Subviews [top.Subviews.Count - 1]).Title);
win2.MouseEvent (new MouseEvent () { Flags = MouseFlags.Button1Pressed });
Assert.True (win.CanFocus);
Assert.False (win.HasFocus);
Assert.True (win2.CanFocus);
Assert.True (win2.HasFocus);
Assert.Equal ("win2", ((Window)top.Subviews [top.Subviews.Count - 1]).Title);
win2.MouseEvent (new MouseEvent () { Flags = MouseFlags.Button1Released });
Assert.Null (Toplevel._dragPosition);
}
[Fact]
[AutoInitShutdown]
public void EnsuresTopOnFront_CanFocus_False_By_Keyboard_And_Mouse ()
{
var top = Application.Top;
var win = new Window () { Title = "win", X = 0, Y = 0, Width = 20, Height = 10 };
var tf = new TextField () { Width = 10 };
win.Add (tf);
var win2 = new Window () { Title = "win2", X = 22, Y = 0, Width = 20, Height = 10 };
var tf2 = new TextField () { Width = 10 };
win2.Add (tf2);
top.Add (win, win2);
Application.Begin (top);
Assert.True (win.CanFocus);
Assert.True (win.HasFocus);
Assert.True (win2.CanFocus);
Assert.False (win2.HasFocus);
Assert.Equal ("win2", ((Window)top.Subviews [top.Subviews.Count - 1]).Title);
win.CanFocus = false;
Assert.False (win.CanFocus);
Assert.False (win.HasFocus);
Assert.True (win2.CanFocus);
Assert.True (win2.HasFocus);
Assert.Equal ("win2", ((Window)top.Subviews [top.Subviews.Count - 1]).Title);
top.NewKeyDownEvent (new (KeyCode.CtrlMask | KeyCode.Tab));
Assert.True (win2.CanFocus);
Assert.False (win.HasFocus);
Assert.True (win2.CanFocus);
Assert.True (win2.HasFocus);
Assert.Equal ("win2", ((Window)top.Subviews [top.Subviews.Count - 1]).Title);
top.NewKeyDownEvent (new (KeyCode.CtrlMask | KeyCode.Tab));
Assert.False (win.CanFocus);
Assert.False (win.HasFocus);
Assert.True (win2.CanFocus);
Assert.True (win2.HasFocus);
Assert.Equal ("win2", ((Window)top.Subviews [top.Subviews.Count - 1]).Title);
win.MouseEvent (new MouseEvent () { Flags = MouseFlags.Button1Pressed });
Assert.False (win.CanFocus);
Assert.False (win.HasFocus);
Assert.True (win2.CanFocus);
Assert.True (win2.HasFocus);
Assert.Equal ("win2", ((Window)top.Subviews [top.Subviews.Count - 1]).Title);
win2.MouseEvent (new MouseEvent () { Flags = MouseFlags.Button1Released });
Assert.Null (Toplevel._dragPosition);
}
// test Application key Bindings
public class ScopedKeyBindingView : View {
public bool ApplicationCommand { get; set; }
public bool HotKeyCommand { get; set; }
public bool FocusedCommand { get; set; }
public ScopedKeyBindingView ()
{
AddCommand (Command.Save, () => ApplicationCommand = true);
AddCommand (Command.Default, () => HotKeyCommand = true);
AddCommand (Command.Left, () => FocusedCommand = true);
KeyBindings.Add (KeyCode.A, KeyBindingScope.Application, Command.Save);
HotKey = KeyCode.H;
KeyBindings.Add (KeyCode.F, KeyBindingScope.Focused, Command.Left);
}
}
[Fact]
[AutoInitShutdown]
public void OnKeyDown_Application_KeyBinding ()
{
var view = new ScopedKeyBindingView ();
var invoked = false;
view.InvokingKeyBindings += (s, e) => invoked = true;
Application.Top.Add (view);
Application.Begin (Application.Top);
Application.OnKeyDown (new (KeyCode.A));
Assert.True (invoked);
Assert.True (view.ApplicationCommand);
invoked = false;
view.ApplicationCommand = false;
view.KeyBindings.Remove (KeyCode.A);
Application.OnKeyDown (new (KeyCode.A)); // old
Assert.False (invoked);
Assert.False (view.ApplicationCommand);
view.KeyBindings.Add (KeyCode.A | KeyCode.CtrlMask, KeyBindingScope.Application, Command.Save);
Application.OnKeyDown (new (KeyCode.A)); // old
Assert.False (invoked);
Assert.False (view.ApplicationCommand);
Application.OnKeyDown (new (KeyCode.A | KeyCode.CtrlMask)); // new
Assert.True (invoked);
Assert.True (view.ApplicationCommand);
invoked = false;
Application.OnKeyDown (new (KeyCode.H));
Assert.True (invoked);
invoked = false;
Assert.False (view.HasFocus);
Application.OnKeyDown (new (KeyCode.F));
Assert.False (invoked);
Assert.True (view.ApplicationCommand);
Assert.True (view.HotKeyCommand);
Assert.False (view.FocusedCommand);
}
[Fact]
[AutoInitShutdown]
public void OnKeyDown_Application_KeyBinding_Negative ()
{
var view = new ScopedKeyBindingView ();
var invoked = false;
view.InvokingKeyBindings += (s, e) => invoked = true;
Application.Top.Add (view);
Application.Begin (Application.Top);
Application.OnKeyDown (new (KeyCode.A | KeyCode.CtrlMask));
Assert.False (invoked);
Assert.False (view.ApplicationCommand);
Assert.False (view.HotKeyCommand);
Assert.False (view.FocusedCommand);
invoked = false;
Assert.False (view.HasFocus);
Application.OnKeyDown (new (KeyCode.Z));
Assert.False (invoked);
Assert.False (view.ApplicationCommand);
Assert.False (view.HotKeyCommand);
Assert.False (view.FocusedCommand);
}
}