mirror of
https://github.com/gui-cs/Terminal.Gui.git
synced 2025-12-27 00:07:58 +01:00
0f9e6f091d
* Replace all 342 `== null` with `is null`
* Replace 354 `!= null` with `is { }`
* Wrap these in conditionals since they break tests against Release configuration
The members they depend on do not exist in Release configuration
* Split these up and dispose properly
This test needs to be revisited for several reasons at some point.
* Fix release configuration tests
* Declare interface these already support
* Annotate constructor properly and use throw helper
* Move class to its own file
* Rename these files so they nest in the solution explorer
* Make this a record type and remove now-redundant/illegal members
* Reference passing to avoid some struct copies
* Simplify this
* Carry reference passing through as appropriate
* Turn this into a record struct
* Remove unused internal constructor and its test
It was only used by that test.
* Simplify this constructor
* This should be a property
* Simplify constructor
* Simplify GetHashCode
* Mark this ignored just in case
* Missed a couple of opportunities for reference passing
* record struct already does this by value
* Remove unused class
* Simplify the type initializer and Reset method
* Implement INotifyCollectionChanged and IDictionary by delegating to ColorSchemes
* Fix for reflection-based configuration
* Make CI build happy by disambiguiating this attribute
* Add PERF, NOTE, QUESTION, and CONCURRENCY tags for the todo explorer
* Make this string comparison faster.
* Add a tag for unclear intent
* This is a constant
* Turn this into a constant via use of a unicode literal
* Remove this method and its test
It is unused
There's no guarantee at all that the parent process is the terminal.
There are good reasons, including that one, why there's no simple way to do it in .net.
It's also of course a windows-only thing, if using WMI.
* With the WMI method gone, we no longer need this
* Make this more efficient
* Add detail to this property's XmlDoc
* Move the general properties up top because order matters
* Make sure any constants defined at higher levels are not clobbered and define a couple more
* Put InternalsVisibleTo in its own group
* Sort dependencies alphabetically and update
* Global usings
* Split to one type per file
* Collection expression
* Fix naming
* Inline to avoid copies
* This is already a value copy (struct)
* Combine to one non-destructive mutation
* Avoid some potential boxing
* Turn on null analysis here
* Remove unnecessary cast and use real type name
* Seal this
* Fix name
* Move nested class to a nested file (no type layout change made)
* Undo naming change that isn't changed globally until next batch
* Rename Rect to Rectangle in preparation for removal
* Add baseline test for ToString checking for current behavior.
* Change to behavior matching System.Drawing.Rectangle
* Fix this test
This is not a test of Rectangle, so trust that Rectangle gets it right.
* Fix these tests the same way as the previous commit
* These should be testing against the Rectangles, not the strings
* Slightly de-couple these as well
* Test against Rectangles, not strings
* Collection expressions and constants
* Remove this
* Perform proper platform-agnostic normalization
* Make this easier to follow (naming only)
* Add a category to this
* Use raw strings for better clarity
* Some more categorization
* Re-apply backed-out naming change from parent branch
* Change GetHashCode to be equivalent to System.Drawing.Rectangle
* Update this since 6.0.0 is no longer available and prevents build
* This check is redundant with the rectangle check below
* Re-apply Rect->Rectangle name changes in these files
416 lines
15 KiB
C#
416 lines
15 KiB
C#
using Xunit.Abstractions;
|
|
|
|
//using GraphViewTests = Terminal.Gui.Views.GraphViewTests;
|
|
|
|
// Alias Console to MockConsole so we don't accidentally use Console
|
|
|
|
namespace Terminal.Gui.ViewTests;
|
|
|
|
public class AbsoluteLayoutTests
|
|
{
|
|
private readonly ITestOutputHelper _output;
|
|
public AbsoluteLayoutTests (ITestOutputHelper output) { _output = output; }
|
|
|
|
[Fact]
|
|
[TestRespondersDisposed]
|
|
public void AbsoluteLayout_Change_Frame ()
|
|
{
|
|
var frame = new Rectangle (1, 2, 3, 4);
|
|
var newFrame = new Rectangle (1, 2, 30, 40);
|
|
|
|
var v = new View ();
|
|
Assert.True (v.LayoutStyle == LayoutStyle.Absolute);
|
|
v.Dispose ();
|
|
|
|
v = new View { Frame = frame };
|
|
Assert.True (v.LayoutStyle == LayoutStyle.Absolute);
|
|
|
|
v.Frame = newFrame;
|
|
Assert.True (v.LayoutStyle == LayoutStyle.Absolute);
|
|
Assert.Equal (newFrame, v.Frame);
|
|
|
|
Assert.Equal (
|
|
new Rectangle (0, 0, newFrame.Width, newFrame.Height),
|
|
v.Bounds
|
|
); // With Absolute Bounds *is* deterministic before Layout
|
|
Assert.Equal (Pos.At (1), v.X);
|
|
Assert.Equal (Pos.At (2), v.Y);
|
|
Assert.Equal (Dim.Sized (30), v.Width);
|
|
Assert.Equal (Dim.Sized (40), v.Height);
|
|
v.Dispose ();
|
|
|
|
v = new View { X = frame.X, Y = frame.Y, Text = "v" };
|
|
v.Frame = newFrame;
|
|
Assert.True (v.LayoutStyle == LayoutStyle.Absolute);
|
|
Assert.Equal (newFrame, v.Frame);
|
|
|
|
Assert.Equal (
|
|
new Rectangle (0, 0, newFrame.Width, newFrame.Height),
|
|
v.Bounds
|
|
); // With Absolute Bounds *is* deterministic before Layout
|
|
Assert.Equal (Pos.At (1), v.X);
|
|
Assert.Equal (Pos.At (2), v.Y);
|
|
Assert.Equal (Dim.Sized (30), v.Width);
|
|
Assert.Equal (Dim.Sized (40), v.Height);
|
|
v.Dispose ();
|
|
|
|
newFrame = new Rectangle (10, 20, 30, 40);
|
|
v = new View { Frame = frame };
|
|
v.Frame = newFrame;
|
|
Assert.True (v.LayoutStyle == LayoutStyle.Absolute);
|
|
Assert.Equal (newFrame, v.Frame);
|
|
|
|
Assert.Equal (
|
|
new Rectangle (0, 0, newFrame.Width, newFrame.Height),
|
|
v.Bounds
|
|
); // With Absolute Bounds *is* deterministic before Layout
|
|
Assert.Equal (Pos.At (10), v.X);
|
|
Assert.Equal (Pos.At (20), v.Y);
|
|
Assert.Equal (Dim.Sized (30), v.Width);
|
|
Assert.Equal (Dim.Sized (40), v.Height);
|
|
v.Dispose ();
|
|
|
|
v = new View { X = frame.X, Y = frame.Y, Text = "v" };
|
|
v.Frame = newFrame;
|
|
Assert.True (v.LayoutStyle == LayoutStyle.Absolute);
|
|
Assert.Equal (newFrame, v.Frame);
|
|
|
|
Assert.Equal (
|
|
new Rectangle (0, 0, newFrame.Width, newFrame.Height),
|
|
v.Bounds
|
|
); // With Absolute Bounds *is* deterministic before Layout
|
|
Assert.Equal (Pos.At (10), v.X);
|
|
Assert.Equal (Pos.At (20), v.Y);
|
|
Assert.Equal (Dim.Sized (30), v.Width);
|
|
Assert.Equal (Dim.Sized (40), v.Height);
|
|
v.Dispose ();
|
|
}
|
|
|
|
[Fact]
|
|
[TestRespondersDisposed]
|
|
public void AbsoluteLayout_Change_Height_or_Width_Absolute ()
|
|
{
|
|
var frame = new Rectangle (1, 2, 3, 4);
|
|
var newFrame = new Rectangle (1, 2, 30, 40);
|
|
|
|
var v = new View { Frame = frame };
|
|
v.Height = newFrame.Height;
|
|
v.Width = newFrame.Width;
|
|
Assert.True (v.LayoutStyle == LayoutStyle.Absolute);
|
|
Assert.Equal (newFrame, v.Frame);
|
|
|
|
Assert.Equal (
|
|
new Rectangle (0, 0, newFrame.Width, newFrame.Height),
|
|
v.Bounds
|
|
); // With Absolute Bounds *is* deterministic before Layout
|
|
Assert.Equal (Pos.At (1), v.X);
|
|
Assert.Equal (Pos.At (2), v.Y);
|
|
Assert.Equal ($"Absolute({newFrame.Height})", v.Height.ToString ());
|
|
Assert.Equal ($"Absolute({newFrame.Width})", v.Width.ToString ());
|
|
v.Dispose ();
|
|
}
|
|
|
|
[Fact]
|
|
[TestRespondersDisposed]
|
|
public void AbsoluteLayout_Change_Height_or_Width_MakesComputed ()
|
|
{
|
|
var v = new View { Frame = Rectangle.Empty };
|
|
v.Height = Dim.Fill ();
|
|
v.Width = Dim.Fill ();
|
|
Assert.True (v.LayoutStyle == LayoutStyle.Computed);
|
|
v.Dispose ();
|
|
}
|
|
|
|
[Fact]
|
|
[TestRespondersDisposed]
|
|
public void AbsoluteLayout_Change_X_or_Y_Absolute ()
|
|
{
|
|
var frame = new Rectangle (1, 2, 3, 4);
|
|
var newFrame = new Rectangle (10, 20, 3, 4);
|
|
|
|
var v = new View { Frame = frame };
|
|
v.X = newFrame.X;
|
|
v.Y = newFrame.Y;
|
|
Assert.True (v.LayoutStyle == LayoutStyle.Absolute);
|
|
Assert.Equal (newFrame, v.Frame);
|
|
|
|
Assert.Equal (
|
|
new Rectangle (0, 0, newFrame.Width, newFrame.Height),
|
|
v.Bounds
|
|
); // With Absolute Bounds *is* deterministic before Layout
|
|
Assert.Equal ($"Absolute({newFrame.X})", v.X.ToString ());
|
|
Assert.Equal ($"Absolute({newFrame.Y})", v.Y.ToString ());
|
|
Assert.Equal (Dim.Sized (3), v.Width);
|
|
Assert.Equal (Dim.Sized (4), v.Height);
|
|
v.Dispose ();
|
|
}
|
|
|
|
[Fact]
|
|
[TestRespondersDisposed]
|
|
public void AbsoluteLayout_Change_X_or_Y_MakesComputed ()
|
|
{
|
|
var v = new View { Frame = Rectangle.Empty };
|
|
v.X = Pos.Center ();
|
|
v.Y = Pos.Center ();
|
|
Assert.True (v.LayoutStyle == LayoutStyle.Computed);
|
|
v.Dispose ();
|
|
}
|
|
|
|
[Fact]
|
|
[TestRespondersDisposed]
|
|
public void AbsoluteLayout_Change_X_Y_Height_Width_Absolute ()
|
|
{
|
|
var v = new View { Frame = Rectangle.Empty };
|
|
v.X = 1;
|
|
v.Y = 2;
|
|
v.Height = 3;
|
|
v.Width = 4;
|
|
Assert.True (v.LayoutStyle == LayoutStyle.Absolute);
|
|
v.Dispose ();
|
|
|
|
v = new View { Frame = Rectangle.Empty };
|
|
v.X = Pos.Center ();
|
|
v.Y = Pos.Center ();
|
|
v.Width = Dim.Fill ();
|
|
v.Height = Dim.Fill ();
|
|
Assert.True (v.LayoutStyle == LayoutStyle.Computed);
|
|
v.Dispose ();
|
|
|
|
v = new View { Frame = Rectangle.Empty };
|
|
v.X = Pos.Center ();
|
|
v.Y = Pos.Center ();
|
|
v.Width = Dim.Fill ();
|
|
v.Height = Dim.Fill ();
|
|
Assert.True (v.LayoutStyle == LayoutStyle.Computed);
|
|
|
|
v.X = 1;
|
|
Assert.True (v.LayoutStyle == LayoutStyle.Computed);
|
|
v.Dispose ();
|
|
|
|
v = new View { Frame = Rectangle.Empty };
|
|
v.X = Pos.Center ();
|
|
v.Y = Pos.Center ();
|
|
v.Width = Dim.Fill ();
|
|
v.Height = Dim.Fill ();
|
|
Assert.True (v.LayoutStyle == LayoutStyle.Computed);
|
|
|
|
v.Y = 2;
|
|
Assert.True (v.LayoutStyle == LayoutStyle.Computed);
|
|
v.Dispose ();
|
|
|
|
v = new View { Frame = Rectangle.Empty };
|
|
v.X = Pos.Center ();
|
|
v.Y = Pos.Center ();
|
|
v.Width = Dim.Fill ();
|
|
v.Height = Dim.Fill ();
|
|
Assert.True (v.LayoutStyle == LayoutStyle.Computed);
|
|
|
|
v.Width = 3;
|
|
Assert.True (v.LayoutStyle == LayoutStyle.Computed);
|
|
v.Dispose ();
|
|
|
|
v = new View { Frame = Rectangle.Empty };
|
|
v.X = Pos.Center ();
|
|
v.Y = Pos.Center ();
|
|
v.Width = Dim.Fill ();
|
|
v.Height = Dim.Fill ();
|
|
Assert.True (v.LayoutStyle == LayoutStyle.Computed);
|
|
|
|
v.Height = 3;
|
|
Assert.True (v.LayoutStyle == LayoutStyle.Computed);
|
|
v.Dispose ();
|
|
|
|
v = new View { Frame = Rectangle.Empty };
|
|
v.X = Pos.Center ();
|
|
v.Y = Pos.Center ();
|
|
v.Width = Dim.Fill ();
|
|
v.Height = Dim.Fill ();
|
|
Assert.True (v.LayoutStyle == LayoutStyle.Computed);
|
|
|
|
v.X = 1;
|
|
v.Y = 2;
|
|
v.Height = 3;
|
|
v.Width = 4;
|
|
Assert.True (v.LayoutStyle == LayoutStyle.Absolute);
|
|
v.Dispose ();
|
|
}
|
|
|
|
[Fact]
|
|
[TestRespondersDisposed]
|
|
public void AbsoluteLayout_Constructor ()
|
|
{
|
|
var v = new View ();
|
|
Assert.True (v.LayoutStyle == LayoutStyle.Absolute);
|
|
v.Dispose ();
|
|
|
|
var frame = Rectangle.Empty;
|
|
v = new View { Frame = frame };
|
|
Assert.True (v.LayoutStyle == LayoutStyle.Absolute);
|
|
Assert.Equal (frame, v.Frame);
|
|
|
|
Assert.Equal (
|
|
new Rectangle (0, 0, frame.Width, frame.Height),
|
|
v.Bounds
|
|
); // With Absolute Bounds *is* deterministic before Layout
|
|
Assert.Equal (Pos.At (0), v.X);
|
|
Assert.Equal (Pos.At (0), v.Y);
|
|
Assert.Equal (Dim.Sized (0), v.Width);
|
|
Assert.Equal (Dim.Sized (0), v.Height);
|
|
v.Dispose ();
|
|
|
|
frame = new Rectangle (1, 2, 3, 4);
|
|
v = new View { Frame = frame };
|
|
Assert.True (v.LayoutStyle == LayoutStyle.Absolute);
|
|
Assert.Equal (frame, v.Frame);
|
|
|
|
Assert.Equal (
|
|
new Rectangle (0, 0, frame.Width, frame.Height),
|
|
v.Bounds
|
|
); // With Absolute Bounds *is* deterministic before Layout
|
|
Assert.Equal (Pos.At (1), v.X);
|
|
Assert.Equal (Pos.At (2), v.Y);
|
|
Assert.Equal (Dim.Sized (3), v.Width);
|
|
Assert.Equal (Dim.Sized (4), v.Height);
|
|
v.Dispose ();
|
|
|
|
v = new View { Frame = frame, Text = "v" };
|
|
Assert.True (v.LayoutStyle == LayoutStyle.Absolute);
|
|
Assert.Equal (frame, v.Frame);
|
|
|
|
Assert.Equal (
|
|
new Rectangle (0, 0, frame.Width, frame.Height),
|
|
v.Bounds
|
|
); // With Absolute Bounds *is* deterministic before Layout
|
|
Assert.Equal (Pos.At (1), v.X);
|
|
Assert.Equal (Pos.At (2), v.Y);
|
|
Assert.Equal (Dim.Sized (3), v.Width);
|
|
Assert.Equal (Dim.Sized (4), v.Height);
|
|
v.Dispose ();
|
|
|
|
v = new View { X = frame.X, Y = frame.Y, Text = "v" };
|
|
Assert.True (v.LayoutStyle == LayoutStyle.Absolute);
|
|
|
|
// BUGBUG: v2 - I think the default size should be 0,0 not 1,1
|
|
// That is correct it should be 0,0 because AutoSize is false
|
|
// and the size wasn't set on the initializer
|
|
Assert.Equal (new Rectangle (frame.X, frame.Y, 0, 0), v.Frame);
|
|
Assert.Equal (new Rectangle (0, 0, 0, 0), v.Bounds); // With Absolute Bounds *is* deterministic before Layout
|
|
Assert.Equal (Pos.At (1), v.X);
|
|
Assert.Equal (Pos.At (2), v.Y);
|
|
Assert.Equal (Dim.Sized (0), v.Width);
|
|
Assert.Equal (Dim.Sized (0), v.Height);
|
|
v.Dispose ();
|
|
|
|
v = new View ();
|
|
Assert.True (v.LayoutStyle == LayoutStyle.Absolute);
|
|
Assert.Equal (new Rectangle (0, 0, 0, 0), v.Frame);
|
|
Assert.Equal (new Rectangle (0, 0, 0, 0), v.Bounds); // With Absolute Bounds *is* deterministic before Layout
|
|
Assert.Equal (Pos.At (0), v.X);
|
|
Assert.Equal (Pos.At (0), v.Y);
|
|
Assert.Equal (Dim.Sized (0), v.Width);
|
|
Assert.Equal (Dim.Sized (0), v.Height);
|
|
v.Dispose ();
|
|
|
|
v = new View { X = frame.X, Y = frame.Y, Width = frame.Width, Height = frame.Height };
|
|
Assert.True (v.LayoutStyle == LayoutStyle.Absolute);
|
|
Assert.Equal (new Rectangle (frame.X, frame.Y, 3, 4), v.Frame);
|
|
Assert.Equal (new Rectangle (0, 0, 3, 4), v.Bounds); // With Absolute Bounds *is* deterministic before Layout
|
|
Assert.Equal (Pos.At (1), v.X);
|
|
Assert.Equal (Pos.At (2), v.Y);
|
|
Assert.Equal (Dim.Sized (3), v.Width);
|
|
Assert.Equal (Dim.Sized (4), v.Height);
|
|
v.Dispose ();
|
|
}
|
|
|
|
[Fact]
|
|
[TestRespondersDisposed]
|
|
public void AbsoluteLayout_LayoutSubviews ()
|
|
{
|
|
var superRect = new Rectangle (0, 0, 100, 100);
|
|
var super = new View { Frame = superRect, Text = "super" };
|
|
Assert.True (super.LayoutStyle == LayoutStyle.Absolute);
|
|
var v1 = new View { X = 0, Y = 0, Width = 10, Height = 10 };
|
|
Assert.True (v1.LayoutStyle == LayoutStyle.Absolute);
|
|
|
|
var v2 = new View { X = 10, Y = 10, Width = 10, Height = 10 };
|
|
Assert.True (v2.LayoutStyle == LayoutStyle.Absolute);
|
|
|
|
super.Add (v1, v2);
|
|
Assert.True (v1.LayoutStyle == LayoutStyle.Absolute);
|
|
Assert.True (v2.LayoutStyle == LayoutStyle.Absolute);
|
|
|
|
super.LayoutSubviews ();
|
|
Assert.Equal (new Rectangle (0, 0, 10, 10), v1.Frame);
|
|
Assert.Equal (new Rectangle (10, 10, 10, 10), v2.Frame);
|
|
super.Dispose ();
|
|
}
|
|
|
|
[Fact]
|
|
public void AbsoluteLayout_Setting_Bounds_Location_NotEmpty ()
|
|
{
|
|
// TODO: Should we enforce Bounds.X/Y == 0? The code currently ignores value.X/Y which is
|
|
// TODO: correct behavior, but is silent. Perhaps an exception?
|
|
var frame = new Rectangle (1, 2, 3, 4);
|
|
var newBounds = new Rectangle (10, 20, 30, 40);
|
|
var view = new View { Frame = frame };
|
|
view.Bounds = newBounds;
|
|
Assert.Equal (new Rectangle (0, 0, 30, 40), view.Bounds);
|
|
Assert.Equal (new Rectangle (1, 2, 30, 40), view.Frame);
|
|
}
|
|
|
|
[Fact]
|
|
public void AbsoluteLayout_Setting_Bounds_Sets_Frame ()
|
|
{
|
|
var frame = new Rectangle (1, 2, 3, 4);
|
|
var newBounds = new Rectangle (0, 0, 30, 40);
|
|
|
|
var v = new View { Frame = frame };
|
|
Assert.True (v.LayoutStyle == LayoutStyle.Absolute);
|
|
|
|
v.Bounds = newBounds;
|
|
Assert.True (v.LayoutStyle == LayoutStyle.Absolute);
|
|
Assert.Equal (newBounds, v.Bounds);
|
|
Assert.Equal (new Rectangle (1, 2, newBounds.Width, newBounds.Height), v.Frame);
|
|
Assert.Equal (new Rectangle (0, 0, newBounds.Width, newBounds.Height), v.Bounds);
|
|
Assert.Equal (Pos.At (1), v.X);
|
|
Assert.Equal (Pos.At (2), v.Y);
|
|
Assert.Equal (Dim.Sized (30), v.Width);
|
|
Assert.Equal (Dim.Sized (40), v.Height);
|
|
|
|
newBounds = new Rectangle (0, 0, 3, 4);
|
|
v.Bounds = newBounds;
|
|
Assert.Equal (newBounds, v.Bounds);
|
|
Assert.Equal (new Rectangle (1, 2, newBounds.Width, newBounds.Height), v.Frame);
|
|
Assert.Equal (new Rectangle (0, 0, newBounds.Width, newBounds.Height), v.Bounds);
|
|
Assert.Equal (Pos.At (1), v.X);
|
|
Assert.Equal (Pos.At (2), v.Y);
|
|
Assert.Equal (Dim.Sized (3), v.Width);
|
|
Assert.Equal (Dim.Sized (4), v.Height);
|
|
|
|
v.BorderStyle = LineStyle.Single;
|
|
|
|
// Bounds should shrink
|
|
Assert.Equal (new Rectangle (0, 0, 1, 2), v.Bounds);
|
|
|
|
// Frame should not change
|
|
Assert.Equal (new Rectangle (1, 2, 3, 4), v.Frame);
|
|
Assert.Equal (Pos.At (1), v.X);
|
|
Assert.Equal (Pos.At (2), v.Y);
|
|
Assert.Equal (Dim.Sized (3), v.Width);
|
|
Assert.Equal (Dim.Sized (4), v.Height);
|
|
|
|
// Now set bounds bigger as before
|
|
newBounds = new Rectangle (0, 0, 3, 4);
|
|
v.Bounds = newBounds;
|
|
Assert.Equal (newBounds, v.Bounds);
|
|
|
|
// Frame grows because there's now a border
|
|
Assert.Equal (new Rectangle (1, 2, 5, 6), v.Frame);
|
|
Assert.Equal (new Rectangle (0, 0, newBounds.Width, newBounds.Height), v.Bounds);
|
|
Assert.Equal (Pos.At (1), v.X);
|
|
Assert.Equal (Pos.At (2), v.Y);
|
|
Assert.Equal (Dim.Sized (5), v.Width);
|
|
Assert.Equal (Dim.Sized (6), v.Height);
|
|
}
|
|
}
|