Files
Terminal.Gui/UnitTests/View/Layout/LayoutTests.cs
dodexahedron 0f9e6f091d Stage 1 of #3256 - Prepare Rect for removal (#3260)
* Replace all 342 `== null` with `is null`

* Replace 354 `!= null` with `is { }`

* Wrap these in conditionals since they break tests against Release configuration

The members they depend on do not exist in Release configuration

* Split these up and dispose properly

This test needs to be revisited for several reasons at some point.

* Fix release configuration tests

* Declare interface these already support

* Annotate constructor properly and use throw helper

* Move class to its own file

* Rename these files so they nest in the solution explorer

* Make this a record type and remove now-redundant/illegal members

* Reference passing to avoid some struct copies

* Simplify this

* Carry reference passing through as appropriate

* Turn this into a record struct

* Remove unused internal constructor and its test

It was only used by that test.

* Simplify this constructor

* This should be a property

* Simplify constructor

* Simplify GetHashCode

* Mark this ignored just in case

* Missed a couple of opportunities for reference passing

* record struct already does this by value

* Remove unused class

* Simplify the type initializer and Reset method

* Implement INotifyCollectionChanged and IDictionary by delegating to ColorSchemes

* Fix for reflection-based configuration

* Make CI  build happy by disambiguiating this attribute

* Add PERF, NOTE, QUESTION, and CONCURRENCY tags for the todo explorer

* Make this string comparison faster.

* Add a tag for unclear intent

* This is a constant

* Turn this into a constant via use of a unicode literal

* Remove this method and its test

It is unused
There's no guarantee at all that the parent process is the terminal.
There are good reasons, including that one, why there's no simple way to do it in .net.
It's also of course a windows-only thing, if using WMI.

* With the WMI method gone, we no longer need this

* Make this more efficient

* Add detail to this property's XmlDoc

* Move the general properties up top because order matters

* Make sure any constants defined at higher levels are not clobbered and define a couple more

* Put InternalsVisibleTo in its own group

* Sort dependencies alphabetically and update

* Global usings

* Split to one type per file

* Collection expression

* Fix naming

* Inline to avoid copies

* This is already a value copy (struct)

* Combine to one non-destructive mutation

* Avoid some potential boxing

* Turn on null analysis here

* Remove unnecessary cast and use real type name

* Seal this

* Fix name

* Move nested class to a nested file (no type layout change made)

* Undo naming change that isn't changed globally until next batch

* Rename Rect to Rectangle in preparation for removal

* Add baseline test for ToString checking for current behavior.

* Change to behavior matching System.Drawing.Rectangle

* Fix this test

This is not a test of Rectangle, so trust that Rectangle gets it right.

* Fix these tests the same way as the previous commit

* These should be testing against the Rectangles, not the strings

* Slightly de-couple these as well

* Test against Rectangles, not strings

* Collection expressions and constants

* Remove this

* Perform proper platform-agnostic normalization

* Make this easier to follow (naming only)

* Add a category to this

* Use raw strings for better clarity

* Some more categorization

* Re-apply backed-out naming change from parent branch

* Change GetHashCode to be equivalent to System.Drawing.Rectangle

* Update this since 6.0.0 is no longer available and prevents build

* This check is redundant with the rectangle check below

* Re-apply Rect->Rectangle name changes in these files
2024-02-22 16:46:04 -07:00

699 lines
20 KiB
C#

using Xunit.Abstractions;
// Alias Console to MockConsole so we don't accidentally use Console
namespace Terminal.Gui.ViewTests;
public class LayoutTests
{
private readonly ITestOutputHelper _output;
public LayoutTests (ITestOutputHelper output) { _output = output; }
// Tested in AbsoluteLayoutTests.cs
// public void Pos_Dim_Are_Null_If_Not_Initialized_On_Constructor_IsAdded_False ()
[Theory]
[AutoInitShutdown]
[InlineData (1)]
[InlineData (2)]
[InlineData (3)]
[InlineData (4)]
[InlineData (5)]
[InlineData (6)]
[InlineData (7)]
[InlineData (8)]
[InlineData (9)]
[InlineData (10)]
public void Dim_CenteredSubView_85_Percent_Height (int height)
{
var win = new Window { Width = Dim.Fill (), Height = Dim.Fill () };
var subview = new Window
{
X = Pos.Center (), Y = Pos.Center (), Width = Dim.Percent (85), Height = Dim.Percent (85)
};
win.Add (subview);
RunState rs = Application.Begin (win);
var firstIteration = false;
((FakeDriver)Application.Driver).SetBufferSize (20, height);
Application.RunIteration (ref rs, ref firstIteration);
var expected = string.Empty;
switch (height)
{
case 1:
//Assert.Equal (new Rect (0, 0, 17, 0), subview.Frame);
expected = @"
────────────────────";
break;
case 2:
//Assert.Equal (new Rect (0, 0, 17, 1), subview.Frame);
expected = @"
┌──────────────────┐
└──────────────────┘
";
break;
case 3:
//Assert.Equal (new Rect (0, 0, 17, 2), subview.Frame);
expected = @"
┌──────────────────┐
│ │
└──────────────────┘
";
break;
case 4:
//Assert.Equal (new Rect (0, 0, 17, 3), subview.Frame);
expected = @"
┌──────────────────┐
│ ─────────────── │
│ │
└──────────────────┘";
break;
case 5:
//Assert.Equal (new Rect (0, 0, 17, 3), subview.Frame);
expected = @"
┌──────────────────┐
│ ┌─────────────┐ │
│ └─────────────┘ │
│ │
└──────────────────┘";
break;
case 6:
//Assert.Equal (new Rect (0, 0, 17, 3), subview.Frame);
expected = @"
┌──────────────────┐
│ ┌─────────────┐ │
│ │ │ │
│ └─────────────┘ │
│ │
└──────────────────┘";
break;
case 7:
//Assert.Equal (new Rect (0, 0, 17, 3), subview.Frame);
expected = @"
┌──────────────────┐
│ ┌─────────────┐ │
│ │ │ │
│ │ │ │
│ └─────────────┘ │
│ │
└──────────────────┘";
break;
case 8:
//Assert.Equal (new Rect (0, 0, 17, 3), subview.Frame);
expected = @"
┌──────────────────┐
│ ┌─────────────┐ │
│ │ │ │
│ │ │ │
│ │ │ │
│ └─────────────┘ │
│ │
└──────────────────┘";
break;
case 9:
//Assert.Equal (new Rect (0, 0, 17, 3), subview.Frame);
expected = @"
┌──────────────────┐
│ │
│ ┌─────────────┐ │
│ │ │ │
│ │ │ │
│ │ │ │
│ └─────────────┘ │
│ │
└──────────────────┘";
break;
case 10:
//Assert.Equal (new Rect (0, 0, 17, 3), subview.Frame);
expected = @"
┌──────────────────┐
│ │
│ ┌─────────────┐ │
│ │ │ │
│ │ │ │
│ │ │ │
│ │ │ │
│ └─────────────┘ │
│ │
└──────────────────┘";
break;
}
_ = TestHelpers.AssertDriverContentsWithFrameAre (expected, _output);
Application.End (rs);
}
[Theory]
[AutoInitShutdown]
[InlineData (1)]
[InlineData (2)]
[InlineData (3)]
[InlineData (4)]
[InlineData (5)]
[InlineData (6)]
[InlineData (7)]
[InlineData (8)]
[InlineData (9)]
[InlineData (10)]
public void Dim_CenteredSubView_85_Percent_Width (int width)
{
var win = new Window { Width = Dim.Fill (), Height = Dim.Fill () };
var subview = new Window
{
X = Pos.Center (), Y = Pos.Center (), Width = Dim.Percent (85), Height = Dim.Percent (85)
};
win.Add (subview);
RunState rs = Application.Begin (win);
var firstIteration = false;
((FakeDriver)Application.Driver).SetBufferSize (width, 7);
Application.RunIteration (ref rs, ref firstIteration);
var expected = string.Empty;
switch (width)
{
case 1:
Assert.Equal (new Rectangle (0, 0, 0, 4), subview.Frame);
expected = @"
│";
break;
case 2:
Assert.Equal (new Rectangle (0, 0, 0, 4), subview.Frame);
expected = @"
┌┐
││
││
││
││
││
└┘";
break;
case 3:
Assert.Equal (new Rectangle (0, 0, 0, 4), subview.Frame);
expected = @"
┌─┐
│ │
│ │
│ │
│ │
│ │
└─┘";
break;
case 4:
Assert.Equal (new Rectangle (0, 0, 1, 4), subview.Frame);
expected = @"
┌──┐
││ │
││ │
││ │
││ │
│ │
└──┘";
break;
case 5:
Assert.Equal (new Rectangle (0, 0, 2, 4), subview.Frame);
expected = @"
┌───┐
│┌┐ │
│││ │
│││ │
│└┘ │
│ │
└───┘";
break;
case 6:
Assert.Equal (new Rectangle (0, 0, 3, 4), subview.Frame);
expected = @"
┌────┐
│┌─┐ │
││ │ │
││ │ │
│└─┘ │
│ │
└────┘";
break;
case 7:
Assert.Equal (new Rectangle (0, 0, 4, 4), subview.Frame);
expected = @"
┌─────┐
│┌──┐ │
││ │ │
││ │ │
│└──┘ │
│ │
└─────┘";
break;
case 8:
Assert.Equal (new Rectangle (0, 0, 5, 4), subview.Frame);
expected = @"
┌──────┐
│┌───┐ │
││ │ │
││ │ │
│└───┘ │
│ │
└──────┘";
break;
case 9:
Assert.Equal (new Rectangle (1, 0, 5, 4), subview.Frame);
expected = @"
┌───────┐
│ ┌───┐ │
│ │ │ │
│ │ │ │
│ └───┘ │
│ │
└───────┘";
break;
case 10:
Assert.Equal (new Rectangle (1, 0, 6, 4), subview.Frame);
expected = @"
┌────────┐
│ ┌────┐ │
│ │ │ │
│ │ │ │
│ └────┘ │
│ │
└────────┘";
break;
}
_ = TestHelpers.AssertDriverContentsWithFrameAre (expected, _output);
Application.End (rs);
}
[Fact]
[AutoInitShutdown]
public void DimFill_SizedCorrectly ()
{
var view = new View { Width = Dim.Fill (), Height = Dim.Fill (), BorderStyle = LineStyle.Single };
Application.Top.Add (view);
RunState rs = Application.Begin (Application.Top);
((FakeDriver)Application.Driver).SetBufferSize (32, 5);
//view.SetNeedsLayout ();
Application.Top.LayoutSubviews ();
//view.SetRelativeLayout (new Rect (0, 0, 32, 5));
Assert.Equal (32, view.Frame.Width);
Assert.Equal (5, view.Frame.Height);
}
[Fact]
[TestRespondersDisposed]
public void Draw_Throws_IndexOutOfRangeException_With_Negative_Bounds ()
{
Application.Init (new FakeDriver ());
Toplevel top = Application.Top;
var view = new View { X = -2, Text = "view" };
top.Add (view);
Application.Iteration += (s, a) =>
{
Assert.Equal (-2, view.X);
Application.RequestStop ();
};
try
{
Application.Run ();
}
catch (IndexOutOfRangeException ex)
{
// After the fix this exception will not be caught.
Assert.IsType<IndexOutOfRangeException> (ex);
}
// Shutdown must be called to safely clean up Application if Init has been called
Application.Shutdown ();
}
[Fact]
[TestRespondersDisposed]
public void Draw_Vertical_Throws_IndexOutOfRangeException_With_Negative_Bounds ()
{
Application.Init (new FakeDriver ());
Toplevel top = Application.Top;
var view = new View { Y = -2, Height = 10, TextDirection = TextDirection.TopBottom_LeftRight, Text = "view" };
top.Add (view);
Application.Iteration += (s, a) =>
{
Assert.Equal (-2, view.Y);
Application.RequestStop ();
};
try
{
Application.Run ();
}
catch (IndexOutOfRangeException ex)
{
// After the fix this exception will not be caught.
Assert.IsType<IndexOutOfRangeException> (ex);
}
// Shutdown must be called to safely clean up Application if Init has been called
Application.Shutdown ();
}
[Fact]
public void LayoutSubviews_No_SuperView ()
{
var root = new View ();
var first = new View
{
Id = "first",
X = 1,
Y = 2,
Height = 3,
Width = 4
};
root.Add (first);
var second = new View { Id = "second" };
root.Add (second);
second.X = Pos.Right (first) + 1;
root.LayoutSubviews ();
Assert.Equal (6, second.Frame.X);
root.Dispose ();
first.Dispose ();
second.Dispose ();
}
[Fact]
public void LayoutSubviews_RootHas_SuperView ()
{
var top = new View ();
var root = new View ();
top.Add (root);
var first = new View
{
Id = "first",
X = 1,
Y = 2,
Height = 3,
Width = 4
};
root.Add (first);
var second = new View { Id = "second" };
root.Add (second);
second.X = Pos.Right (first) + 1;
root.LayoutSubviews ();
Assert.Equal (6, second.Frame.X);
root.Dispose ();
top.Dispose ();
first.Dispose ();
second.Dispose ();
}
[Fact]
public void LayoutSubviews_ViewThatRefsSubView_Throws ()
{
var root = new View ();
var super = new View ();
root.Add (super);
var sub = new View ();
super.Add (sub);
super.Width = Dim.Width (sub);
Assert.Throws<InvalidOperationException> (() => root.LayoutSubviews ());
root.Dispose ();
super.Dispose ();
}
// Was named AutoSize_Pos_Validation_Do_Not_Throws_If_NewValue_Is_PosAbsolute_And_OldValue_Is_Another_Type_After_Sets_To_LayoutStyle_Absolute ()
// but doesn't actually have anything to do with AutoSize.
[Fact]
public void
Pos_Validation_Do_Not_Throws_If_NewValue_Is_PosAbsolute_And_OldValue_Is_Another_Type_After_Sets_To_LayoutStyle_Absolute ()
{
Application.Init (new FakeDriver ());
Toplevel t = Application.Top;
var w = new Window { X = Pos.Left (t) + 2, Y = Pos.At (2) };
var v = new View { X = Pos.Center (), Y = Pos.Percent (10) };
w.Add (v);
t.Add (w);
t.Ready += (s, e) =>
{
v.Frame = new Rectangle (2, 2, 10, 10);
Assert.Equal (2, v.X = 2);
Assert.Equal (2, v.Y = 2);
};
Application.Iteration += (s, a) => Application.RequestStop ();
Application.Run ();
Application.Shutdown ();
}
[Fact]
[AutoInitShutdown]
public void PosCombine_DimCombine_View_With_SubViews ()
{
var clicked = false;
Toplevel top = Application.Top;
var win1 = new Window { Id = "win1", Width = 20, Height = 10 };
var view1 = new View { Text = "view1", AutoSize = true }; // BUGBUG: AutoSize or Width must be set
var win2 = new Window { Id = "win2", Y = Pos.Bottom (view1) + 1, Width = 10, Height = 3 };
var view2 = new View { Id = "view2", Width = Dim.Fill (), Height = 1, CanFocus = true };
view2.MouseClick += (sender, e) => clicked = true;
var view3 = new View { Id = "view3", Width = Dim.Fill (1), Height = 1, CanFocus = true };
view2.Add (view3);
win2.Add (view2);
win1.Add (view1, win2);
top.Add (win1);
RunState rs = Application.Begin (top);
TestHelpers.AssertDriverContentsWithFrameAre (
@"
┌──────────────────┐
│view1 │
│ │
│┌────────┐ │
││ │ │
│└────────┘ │
│ │
│ │
│ │
└──────────────────┘",
_output
);
Assert.Equal (new Rectangle (0, 0, 80, 25), top.Frame);
Assert.Equal (new Rectangle (0, 0, 5, 1), view1.Frame);
Assert.Equal (new Rectangle (0, 0, 20, 10), win1.Frame);
Assert.Equal (new Rectangle (0, 2, 10, 3), win2.Frame);
Assert.Equal (new Rectangle (0, 0, 8, 1), view2.Frame);
Assert.Equal (new Rectangle (0, 0, 7, 1), view3.Frame);
var foundView = View.FindDeepestView (top, 9, 4, out int rx, out int ry);
Assert.Equal (foundView, view2);
Application.OnMouseEvent (
new MouseEventEventArgs (
new MouseEvent { X = 9, Y = 4, Flags = MouseFlags.Button1Clicked }
)
);
Assert.True (clicked);
Application.End (rs);
}
[Fact]
public void PosCombine_Refs_SuperView_Throws ()
{
Application.Init (new FakeDriver ());
var w = new Window { X = Pos.Left (Application.Top) + 2, Y = Pos.Top (Application.Top) + 2 };
var f = new FrameView ();
var v1 = new View { X = Pos.Left (w) + 2, Y = Pos.Top (w) + 2 };
var v2 = new View { X = Pos.Left (v1) + 2, Y = Pos.Top (v1) + 2 };
f.Add (v1, v2);
w.Add (f);
Application.Top.Add (w);
f.X = Pos.X (Application.Top) + Pos.X (v2) - Pos.X (v1);
f.Y = Pos.Y (Application.Top) + Pos.Y (v2) - Pos.Y (v1);
Application.Top.LayoutComplete += (s, e) =>
{
Assert.Equal (0, Application.Top.Frame.X);
Assert.Equal (0, Application.Top.Frame.Y);
Assert.Equal (2, w.Frame.X);
Assert.Equal (2, w.Frame.Y);
Assert.Equal (2, f.Frame.X);
Assert.Equal (2, f.Frame.Y);
Assert.Equal (4, v1.Frame.X);
Assert.Equal (4, v1.Frame.Y);
Assert.Equal (6, v2.Frame.X);
Assert.Equal (6, v2.Frame.Y);
};
Application.Iteration += (s, a) => Application.RequestStop ();
Assert.Throws<InvalidOperationException> (() => Application.Run ());
Application.Shutdown ();
}
[Fact]
public void TopologicalSort_Missing_Add ()
{
var root = new View ();
var sub1 = new View ();
root.Add (sub1);
var sub2 = new View ();
sub1.Width = Dim.Width (sub2);
Assert.Throws<InvalidOperationException> (() => root.LayoutSubviews ());
sub2.Width = Dim.Width (sub1);
Assert.Throws<InvalidOperationException> (() => root.LayoutSubviews ());
root.Dispose ();
sub1.Dispose ();
sub2.Dispose ();
}
[Fact]
public void TopologicalSort_Recursive_Ref ()
{
var root = new View ();
var sub1 = new View ();
root.Add (sub1);
var sub2 = new View ();
root.Add (sub2);
sub2.Width = Dim.Width (sub2);
Exception exception = Record.Exception (root.LayoutSubviews);
Assert.Null (exception);
root.Dispose ();
sub1.Dispose ();
sub2.Dispose ();
}
[Fact]
[AutoInitShutdown]
public void TrySetHeight_ForceValidatePosDim ()
{
var top = new View { X = 0, Y = 0, Height = 20 };
var v = new View { Height = Dim.Fill (), ValidatePosDim = true };
top.Add (v);
Assert.False (v.TrySetHeight (10, out int rHeight));
Assert.Equal (10, rHeight);
v.Height = Dim.Fill (1);
Assert.False (v.TrySetHeight (10, out rHeight));
Assert.Equal (9, rHeight);
v.Height = 0;
Assert.True (v.TrySetHeight (10, out rHeight));
Assert.Equal (10, rHeight);
Assert.False (v.IsInitialized);
Application.Top.Add (top);
Application.Begin (Application.Top);
Assert.True (v.IsInitialized);
v.Height = 15;
Assert.True (v.TrySetHeight (5, out rHeight));
Assert.Equal (5, rHeight);
}
[Fact]
[AutoInitShutdown]
public void TrySetWidth_ForceValidatePosDim ()
{
var top = new View { X = 0, Y = 0, Width = 80 };
var v = new View { Width = Dim.Fill (), ValidatePosDim = true };
top.Add (v);
Assert.False (v.TrySetWidth (70, out int rWidth));
Assert.Equal (70, rWidth);
v.Width = Dim.Fill (1);
Assert.False (v.TrySetWidth (70, out rWidth));
Assert.Equal (69, rWidth);
v.Width = 0;
Assert.True (v.TrySetWidth (70, out rWidth));
Assert.Equal (70, rWidth);
Assert.False (v.IsInitialized);
Application.Top.Add (top);
Application.Begin (Application.Top);
Assert.True (v.IsInitialized);
v.Width = 75;
Assert.True (v.TrySetWidth (60, out rWidth));
Assert.Equal (60, rWidth);
}
}