Files
Terminal.Gui/UnitTests/View/SubviewTests.cs
dodexahedron 0f9e6f091d Stage 1 of #3256 - Prepare Rect for removal (#3260)
* Replace all 342 `== null` with `is null`

* Replace 354 `!= null` with `is { }`

* Wrap these in conditionals since they break tests against Release configuration

The members they depend on do not exist in Release configuration

* Split these up and dispose properly

This test needs to be revisited for several reasons at some point.

* Fix release configuration tests

* Declare interface these already support

* Annotate constructor properly and use throw helper

* Move class to its own file

* Rename these files so they nest in the solution explorer

* Make this a record type and remove now-redundant/illegal members

* Reference passing to avoid some struct copies

* Simplify this

* Carry reference passing through as appropriate

* Turn this into a record struct

* Remove unused internal constructor and its test

It was only used by that test.

* Simplify this constructor

* This should be a property

* Simplify constructor

* Simplify GetHashCode

* Mark this ignored just in case

* Missed a couple of opportunities for reference passing

* record struct already does this by value

* Remove unused class

* Simplify the type initializer and Reset method

* Implement INotifyCollectionChanged and IDictionary by delegating to ColorSchemes

* Fix for reflection-based configuration

* Make CI  build happy by disambiguiating this attribute

* Add PERF, NOTE, QUESTION, and CONCURRENCY tags for the todo explorer

* Make this string comparison faster.

* Add a tag for unclear intent

* This is a constant

* Turn this into a constant via use of a unicode literal

* Remove this method and its test

It is unused
There's no guarantee at all that the parent process is the terminal.
There are good reasons, including that one, why there's no simple way to do it in .net.
It's also of course a windows-only thing, if using WMI.

* With the WMI method gone, we no longer need this

* Make this more efficient

* Add detail to this property's XmlDoc

* Move the general properties up top because order matters

* Make sure any constants defined at higher levels are not clobbered and define a couple more

* Put InternalsVisibleTo in its own group

* Sort dependencies alphabetically and update

* Global usings

* Split to one type per file

* Collection expression

* Fix naming

* Inline to avoid copies

* This is already a value copy (struct)

* Combine to one non-destructive mutation

* Avoid some potential boxing

* Turn on null analysis here

* Remove unnecessary cast and use real type name

* Seal this

* Fix name

* Move nested class to a nested file (no type layout change made)

* Undo naming change that isn't changed globally until next batch

* Rename Rect to Rectangle in preparation for removal

* Add baseline test for ToString checking for current behavior.

* Change to behavior matching System.Drawing.Rectangle

* Fix this test

This is not a test of Rectangle, so trust that Rectangle gets it right.

* Fix these tests the same way as the previous commit

* These should be testing against the Rectangles, not the strings

* Slightly de-couple these as well

* Test against Rectangles, not strings

* Collection expressions and constants

* Remove this

* Perform proper platform-agnostic normalization

* Make this easier to follow (naming only)

* Add a category to this

* Use raw strings for better clarity

* Some more categorization

* Re-apply backed-out naming change from parent branch

* Change GetHashCode to be equivalent to System.Drawing.Rectangle

* Update this since 6.0.0 is no longer available and prevents build

* This check is redundant with the rectangle check below

* Re-apply Rect->Rectangle name changes in these files
2024-02-22 16:46:04 -07:00

334 lines
13 KiB
C#

using System.Text;
using Xunit.Abstractions;
namespace Terminal.Gui.ViewTests;
public class SubviewTests
{
private readonly ITestOutputHelper _output;
public SubviewTests (ITestOutputHelper output) { _output = output; }
[Fact]
[TestRespondersDisposed]
public void Added_Removed ()
{
var v = new View { Frame = new Rectangle (0, 0, 10, 24) };
var t = new View ();
v.Added += (s, e) =>
{
Assert.Same (v.SuperView, e.Parent);
Assert.Same (t, e.Parent);
Assert.Same (v, e.Child);
};
v.Removed += (s, e) =>
{
Assert.Same (t, e.Parent);
Assert.Same (v, e.Child);
Assert.True (v.SuperView == null);
};
t.Add (v);
Assert.True (t.Subviews.Count == 1);
t.Remove (v);
Assert.True (t.Subviews.Count == 0);
t.Dispose ();
v.Dispose ();
}
[Fact]
[AutoInitShutdown]
public void GetTopSuperView_Test ()
{
var v1 = new View ();
var fv1 = new FrameView ();
fv1.Add (v1);
var tf1 = new TextField ();
var w1 = new Window ();
w1.Add (fv1, tf1);
var top1 = new Toplevel ();
top1.Add (w1);
var v2 = new View ();
var fv2 = new FrameView ();
fv2.Add (v2);
var tf2 = new TextField ();
var w2 = new Window ();
w2.Add (fv2, tf2);
var top2 = new Toplevel ();
top2.Add (w2);
Assert.Equal (top1, v1.GetTopSuperView ());
Assert.Equal (top2, v2.GetTopSuperView ());
v1.Dispose ();
fv1.Dispose ();
tf1.Dispose ();
w1.Dispose ();
top1.Dispose ();
v2.Dispose ();
fv2.Dispose ();
tf2.Dispose ();
w2.Dispose ();
top2.Dispose ();
}
[Fact]
[TestRespondersDisposed]
public void Initialized_Event_Comparing_With_Added_Event ()
{
Application.Init (new FakeDriver ());
var top = new Toplevel { Id = "0" }; // Frame: 0, 0, 80, 25; Bounds: 0, 0, 80, 25
var winAddedToTop = new Window
{
Id = "t", Width = Dim.Fill (), Height = Dim.Fill ()
}; // Frame: 0, 0, 80, 25; Bounds: 0, 0, 78, 23
var v1AddedToWin = new View
{
Id = "v1", Width = Dim.Fill (), Height = Dim.Fill ()
}; // Frame: 1, 1, 78, 23 (because Windows has a border)
var v2AddedToWin = new View
{
Id = "v2", Width = Dim.Fill (), Height = Dim.Fill ()
}; // Frame: 1, 1, 78, 23 (because Windows has a border)
var svAddedTov1 = new View
{
Id = "sv1", Width = Dim.Fill (), Height = Dim.Fill ()
}; // Frame: 1, 1, 78, 23 (same as it's superview v1AddedToWin)
int tc = 0, wc = 0, v1c = 0, v2c = 0, sv1c = 0;
winAddedToTop.Added += (s, e) =>
{
Assert.Equal (e.Parent.Frame.Width, winAddedToTop.Frame.Width);
Assert.Equal (e.Parent.Frame.Height, winAddedToTop.Frame.Height);
};
v1AddedToWin.Added += (s, e) =>
{
Assert.Equal (e.Parent.Frame.Width, v1AddedToWin.Frame.Width);
Assert.Equal (e.Parent.Frame.Height, v1AddedToWin.Frame.Height);
};
v2AddedToWin.Added += (s, e) =>
{
Assert.Equal (e.Parent.Frame.Width, v2AddedToWin.Frame.Width);
Assert.Equal (e.Parent.Frame.Height, v2AddedToWin.Frame.Height);
};
svAddedTov1.Added += (s, e) =>
{
Assert.Equal (e.Parent.Frame.Width, svAddedTov1.Frame.Width);
Assert.Equal (e.Parent.Frame.Height, svAddedTov1.Frame.Height);
};
top.Initialized += (s, e) =>
{
tc++;
Assert.Equal (1, tc);
Assert.Equal (1, wc);
Assert.Equal (1, v1c);
Assert.Equal (1, v2c);
Assert.Equal (1, sv1c);
Assert.True (top.CanFocus);
Assert.True (winAddedToTop.CanFocus);
Assert.False (v1AddedToWin.CanFocus);
Assert.False (v2AddedToWin.CanFocus);
Assert.False (svAddedTov1.CanFocus);
Application.Refresh ();
};
winAddedToTop.Initialized += (s, e) =>
{
wc++;
Assert.Equal (top.Bounds.Width, winAddedToTop.Frame.Width);
Assert.Equal (top.Bounds.Height, winAddedToTop.Frame.Height);
};
v1AddedToWin.Initialized += (s, e) =>
{
v1c++;
// Top.Frame: 0, 0, 80, 25; Top.Bounds: 0, 0, 80, 25
// BUGBUG: This is wrong, it should be 78, 23. This test has always been broken.
// in no way should the v1AddedToWin.Frame be the same as the Top.Frame/Bounds
// as it is a subview of winAddedToTop, which has a border!
//Assert.Equal (top.Bounds.Width, v1AddedToWin.Frame.Width);
//Assert.Equal (top.Bounds.Height, v1AddedToWin.Frame.Height);
};
v2AddedToWin.Initialized += (s, e) =>
{
v2c++;
// Top.Frame: 0, 0, 80, 25; Top.Bounds: 0, 0, 80, 25
// BUGBUG: This is wrong, it should be 78, 23. This test has always been broken.
// in no way should the v2AddedToWin.Frame be the same as the Top.Frame/Bounds
// as it is a subview of winAddedToTop, which has a border!
//Assert.Equal (top.Bounds.Width, v2AddedToWin.Frame.Width);
//Assert.Equal (top.Bounds.Height, v2AddedToWin.Frame.Height);
};
svAddedTov1.Initialized += (s, e) =>
{
sv1c++;
// Top.Frame: 0, 0, 80, 25; Top.Bounds: 0, 0, 80, 25
// BUGBUG: This is wrong, it should be 78, 23. This test has always been broken.
// in no way should the svAddedTov1.Frame be the same as the Top.Frame/Bounds
// because sv1AddedTov1 is a subview of v1AddedToWin, which is a subview of
// winAddedToTop, which has a border!
//Assert.Equal (top.Bounds.Width, svAddedTov1.Frame.Width);
//Assert.Equal (top.Bounds.Height, svAddedTov1.Frame.Height);
Assert.False (svAddedTov1.CanFocus);
Assert.Throws<InvalidOperationException> (() => svAddedTov1.CanFocus = true);
Assert.False (svAddedTov1.CanFocus);
};
v1AddedToWin.Add (svAddedTov1);
winAddedToTop.Add (v1AddedToWin, v2AddedToWin);
top.Add (winAddedToTop);
Application.Iteration += (s, a) =>
{
Application.Refresh ();
top.Running = false;
};
Application.Run (top);
Application.Shutdown ();
Assert.Equal (1, tc);
Assert.Equal (1, wc);
Assert.Equal (1, v1c);
Assert.Equal (1, v2c);
Assert.Equal (1, sv1c);
Assert.True (top.CanFocus);
Assert.True (winAddedToTop.CanFocus);
Assert.False (v1AddedToWin.CanFocus);
Assert.False (v2AddedToWin.CanFocus);
Assert.False (svAddedTov1.CanFocus);
v1AddedToWin.CanFocus = true;
Assert.False (svAddedTov1.CanFocus); // False because sv1 was disposed and it isn't a subview of v1.
}
[Fact]
[TestRespondersDisposed]
public void Initialized_Event_Will_Be_Invoked_When_Added_Dynamically ()
{
Application.Init (new FakeDriver ());
var t = new Toplevel { Id = "0" };
var w = new Window { Id = "t", Width = Dim.Fill (), Height = Dim.Fill () };
var v1 = new View { Id = "v1", Width = Dim.Fill (), Height = Dim.Fill () };
var v2 = new View { Id = "v2", Width = Dim.Fill (), Height = Dim.Fill () };
int tc = 0, wc = 0, v1c = 0, v2c = 0, sv1c = 0;
t.Initialized += (s, e) =>
{
tc++;
Assert.Equal (1, tc);
Assert.Equal (1, wc);
Assert.Equal (1, v1c);
Assert.Equal (1, v2c);
Assert.Equal (0, sv1c); // Added after t in the Application.Iteration.
Assert.True (t.CanFocus);
Assert.True (w.CanFocus);
Assert.False (v1.CanFocus);
Assert.False (v2.CanFocus);
Application.Refresh ();
};
w.Initialized += (s, e) =>
{
wc++;
Assert.Equal (t.Bounds.Width, w.Frame.Width);
Assert.Equal (t.Bounds.Height, w.Frame.Height);
};
v1.Initialized += (s, e) =>
{
v1c++;
//Assert.Equal (t.Bounds.Width, v1.Frame.Width);
//Assert.Equal (t.Bounds.Height, v1.Frame.Height);
};
v2.Initialized += (s, e) =>
{
v2c++;
//Assert.Equal (t.Bounds.Width, v2.Frame.Width);
//Assert.Equal (t.Bounds.Height, v2.Frame.Height);
};
w.Add (v1, v2);
t.Add (w);
Application.Iteration += (s, a) =>
{
var sv1 = new View { Id = "sv1", Width = Dim.Fill (), Height = Dim.Fill () };
sv1.Initialized += (s, e) =>
{
sv1c++;
Assert.NotEqual (t.Frame.Width, sv1.Frame.Width);
Assert.NotEqual (t.Frame.Height, sv1.Frame.Height);
Assert.False (sv1.CanFocus);
Assert.Throws<InvalidOperationException> (() => sv1.CanFocus = true);
Assert.False (sv1.CanFocus);
};
v1.Add (sv1);
Application.Refresh ();
t.Running = false;
};
Application.Run (t);
Application.Shutdown ();
Assert.Equal (1, tc);
Assert.Equal (1, wc);
Assert.Equal (1, v1c);
Assert.Equal (1, v2c);
Assert.Equal (1, sv1c);
Assert.True (t.CanFocus);
Assert.True (w.CanFocus);
Assert.False (v1.CanFocus);
Assert.False (v2.CanFocus);
}
[Fact]
[TestRespondersDisposed]
public void IsAdded_Added_Removed ()
{
var top = new Toplevel ();
var view = new View ();
Assert.False (view.IsAdded);
top.Add (view);
Assert.True (view.IsAdded);
top.Remove (view);
Assert.False (view.IsAdded);
top.Dispose ();
view.Dispose ();
}
}