mirror of
https://github.com/gui-cs/Terminal.Gui.git
synced 2025-12-27 00:07:58 +01:00
* Initial plan * Change MessageBox to return nullable int instead of -1 Co-authored-by: tig <585482+tig@users.noreply.github.com> * Initial plan * Add fencing to prevent mixing Application models Co-authored-by: tig <585482+tig@users.noreply.github.com> * Fix fence logic to work with parallel tests Co-authored-by: tig <585482+tig@users.noreply.github.com> * WIP: Fixing Application issues. * Refactor error messages into constants Co-authored-by: tig <585482+tig@users.noreply.github.com> * Refactor ConfigurationProperty properties to use static backing fields and raise events Co-authored-by: tig <585482+tig@users.noreply.github.com> * Reset static Application properties in ResetStateStatic Co-authored-by: tig <585482+tig@users.noreply.github.com> * Refactor tests to decouple from global Application state Commented out `driver ??= Application.Driver` assignments in `DriverAssert` to prevent automatic global driver assignment. Removed `Application.ResetState(true)` calls and commented out state validation assertions in `GlobalTestSetup` to reduce dependency on global state. Reintroduced `ApplicationForceDriverTests` and `ApplicationModelFencingTests` to validate `ForceDriver` behavior and ensure proper handling of legacy and modern Application models. Skipped certain `ToAnsiTests` that rely on `Application`. Removed direct `Application.Driver` assignments in `ViewDrawingClippingTests` and `ViewDrawingFlowTests`. Performed general cleanup of redundant code and unused imports to simplify the codebase. * WIP: Fixed Parallel tests; non-Parallel still broken Refactor application model usage tracking Refactored `ApplicationModelUsage` into a public enum in the new `Terminal.Gui.App` namespace, making it accessible across the codebase. Replaced the private `_modelUsage` field in `ApplicationImpl` with a public static `ModelUsage` property to improve clarity and accessibility. Renamed error message constants for consistency and updated methods like `SetInstance` and `MarkInstanceBasedModelUsed` to use the new `ModelUsage` property. Removed the private `ApplicationModelUsage` enum from `ApplicationImpl`. Updated test cases to use `ApplicationImpl.Instance` instead of `Application.Create` to enforce the legacy static model. Skipped obsolete tests in `ApplicationForceDriverTests` and added null checks in `DriverAssert` and `SelectorBase` to handle edge cases. Commented out an unused line in `WindowsOutput` and made general improvements to code readability, maintainability, and consistency. * WIP: Almost there! Refactored tests and code to align with the modern instance-based application model. Key changes include: - Disabled Sixel rendering in `OutputBase.cs` due to dependency on legacy static `Application` object. - Hardcoded `force16Colors` to `false` in `WindowsOutput.cs` with a `BUGBUG` note. - Updated `ApplicationImplTests` to use `ApplicationImpl.SetInstance` and return `ApplicationImpl.Instance`. - Refactored `ApplicationModelFencingTests` to use `Application.Create()` and added `ResetModelUsageTracking()` for model switching. - Removed legacy `DriverTests` and reintroduced updated versions with cross-platform driver tests. - Reverted `ArrangementTests` and `ShortcutTests` to use legacy static `ApplicationImpl.Instance`. - Reintroduced driver tests in `DriverTests.cs` with modern `Application.Create()` and added `TestTop` for driver content verification. - General cleanup, including removal of outdated code and addition of `BUGBUG` notes for temporary workarounds. * Fixed all modelusage bugs? Replaced static `Application` references with instance-based `App` context across the codebase. Updated calls to `Application.RequestStop()` and `Application.Screen` to use `App?.RequestStop()` and `App?.Screen` for better encapsulation and flexibility. Refactored test infrastructure to align with the new context, including reintroducing `FakeApplicationFactory` and `FakeApplicationLifecycle` for testing purposes. Improved logging, error handling, and test clarity by adding `logWriter` support and simplifying test setup. Removed redundant or obsolete code, such as `NetSequences` and the old `FakeApplicationFactory` implementation. Updated documentation to reflect the new `IApplication.RequestStop()` usage. * merged * Refactor KeyboardImpl and modernize MessageBoxTests Refactored the `KeyboardImpl` class to remove hardcoded default key values, replacing them with uninitialized fields for dynamic configuration. Updated key binding logic to use `ReplaceCommands` instead of `Add` for better handling of dynamic changes. Removed unnecessary `KeyBindings.Clear()` calls to avoid side effects. Rewrote `MessageBoxTests.cs` to improve readability, maintainability, and adherence to modern C# standards. Enabled nullable reference checks, updated the namespace, and restructured test methods for clarity. Marked non-functional tests with `[Theory(Skip)]` and improved test organization with parameterized inputs. Enhanced test assertions, lifecycle handling, and error handling across the test suite. Updated `UICatalog_AboutBox` to use multiline string literals for expected outputs. These changes improve the overall maintainability and flexibility of the codebase. * Atempt to fix windows only CI/CD Unit tests failure Refactor Application lifecycle and test cleanup Refactored the `Application` class to phase out legacy static properties `SessionStack` and `TopRunnable` from `Application.Current.cs`. These were reintroduced in a new file `Application.TopRunnable.cs` for better modularity, while retaining their `[Obsolete]` status. Updated `ApplicationPopoverTests.cs` to replace `Application.ResetState(true)` with `Application.Shutdown()` for consistent application state cleanup. Added explicit cleanup for `Application.TopRunnable` in relevant test cases to ensure proper resource management. Adjusted namespaces and `using` directives to support the new structure. These changes improve code organization and align with updated application lifecycle management practices. * Fixes #<Issue> - Dispose TopRunnable in cleanup logic Updated the `finally` block in `ApplicationPopoverTests` to dispose of the `Application.TopRunnable` object if it is not null, ensuring proper resource cleanup. Previously, the property was being set to `null` without disposal. The `Application.Shutdown()` call remains unchanged. * Improve thread safety, reduce static dependencies, and align the codebase with the updated `IApplication` interface. Refactored the `MainThreadId` property to improve encapsulation: - Updated `Application.MainThreadId` to use `ApplicationImpl.Instance` directly. - Added `MainThreadId` to `ApplicationImpl` and `IApplication`. - Removed redundant `MainThreadId` from `ApplicationImpl.Run.cs`. Updated `EnqueueMouseEvent` to include an `IApplication?` parameter: - Modified `FakeInputProcessor`, `InputProcessorImpl`, and `WindowsInputProcessor` to support the new parameter. - Updated `IInputProcessor` interface to reflect the new method signature. - Adjusted `GuiTestContext` and `EnqueueMouseEventTests` to pass `IApplication` where required. Improved test coverage and code maintainability: - Added test cases for negative positions and empty mouse events. - Commented out legacy code in `GraphView` and `FakeDriverBase`. - Enhanced readability in `EnqueueMouseEventTests`. These changes improve thread safety, reduce static dependencies, and align the codebase with the updated `IApplication` interface. * Fixed more bugs. Enabled nullable reference types across multiple files to improve code safety. Refactored and modularized test classes, improving readability and maintainability. Removed outdated test cases and added new tests for edge cases, including culture-specific and non-Gregorian calendar handling. Addressed timeout issues in `ScenarioTests` with a watchdog timer and improved error handling. Updated `ApplicationImplTests` to use instance fields instead of static references for better test isolation. Refactored `ScenarioTests` to dynamically load and test all UI Catalog scenarios, with macOS-specific skips for known issues. Aligned `MessageBox.Query` calls with updated API signatures. Performed general code cleanup, including removing unused directives, improving formatting, and consolidating repetitive logic into helper methods. * Made the `InputBindings<TEvent, TBinding>` class thread-safe by replacing the internal `Dictionary<TEvent, TBinding>` with `ConcurrentDictionary<TEvent, TBinding>`. This fixes parallel test failures where "Collection was modified; enumeration operation may not execute" exceptions were thrown. ## Changes Made ### 1. InputBindings.cs - **File**: `Terminal.Gui/Input/InputBindings.cs` - **Change**: Replaced `Dictionary` with `ConcurrentDictionary` - **Key modifications**: - Changed `_bindings` from `Dictionary<TEvent, TBinding>` to `ConcurrentDictionary<TEvent, TBinding>` - Updated `Add()` methods to use `TryAdd()` instead of checking with `TryGet()` then `Add()` - Updated `Remove()` to use `TryRemove()` (no need to check existence first) - Updated `ReplaceCommands()` to use `ContainsKey()` instead of `TryGet()` - Added `.ToList()` to `GetAllFromCommands()` to create a snapshot for safe enumeration - Added comment explaining that `ConcurrentDictionary` provides snapshot enumeration in `GetBindings()` - Added `.ToArray()` to `Clear(Command[])` to create snapshot before iteration ### 2. Thread Safety Test Suite - **File**: `Tests/UnitTestsParallelizable/Input/InputBindingsThreadSafetyTests.cs` - **New file** with comprehensive thread safety tests: - `Add_ConcurrentAccess_NoExceptions` - Tests concurrent additions - `GetBindings_DuringConcurrentModification_NoExceptions` - Tests enumeration during modifications - `TryGet_ConcurrentAccess_ReturnsConsistentResults` - Tests concurrent reads - `Clear_ConcurrentAccess_NoExceptions` - Tests concurrent clearing - `Remove_ConcurrentAccess_NoExceptions` - Tests concurrent removals - `Replace_ConcurrentAccess_NoExceptions` - Tests concurrent replacements - `GetAllFromCommands_DuringModification_NoExceptions` - Tests LINQ queries during modifications - `MixedOperations_ConcurrentAccess_NoExceptions` - Tests mixed operations (add/read/remove) - `KeyBindings_ConcurrentAccess_NoExceptions` - Tests actual `KeyBindings` class - `MouseBindings_ConcurrentAccess_NoExceptions` - Tests actual `MouseBindings` class ## Benefits of ConcurrentDictionary Approach 1. **Lock-Free Reads**: Most read operations don't require locks, improving performance 2. **Snapshot Enumeration**: Built-in support for safe enumeration during concurrent modifications 3. **Simplified Code**: No need for explicit `lock` statements or lock objects 4. **Better Scalability**: Multiple threads can read/write simultaneously 5. **No "Collection was modified" Exceptions**: Enumeration creates a snapshot ## Performance Characteristics - **Read Operations**: Lock-free, very fast - **Write Operations**: Uses fine-grained locking internally, minimal contention - **Memory Overhead**: Slightly higher than `Dictionary` but negligible in practice - **Enumeration**: Creates a snapshot, safe for concurrent modifications ## Test Results - **Original failing test now passes**: `ApplicationImplTests.Init_CreatesKeybindings` - **10 new thread safety tests**: All passing - **All 11,741 parallelizable tests**: All passing (11,731 passed, 10 skipped) - **All 1,779 non-parallelizable tests**: All passing (1,762 passed, 17 skipped) - **No compilation errors**: Clean build with no xUnit1031 warnings (suppressed with pragmas) ## Verification The original failure was: ``` System.InvalidOperationException: Collection was modified; enumeration operation may not execute. ``` This occurred in parallelizable tests when multiple threads accessed `KeyBindings.GetBindings()` simultaneously. The `ConcurrentDictionary` implementation resolves this by providing thread-safe operations and snapshot enumeration. ## Notes - The xUnit1031 warnings about using `Task.WaitAll` instead of `async/await` have been suppressed with `#pragma warning disable xUnit1031` directives, as these are intentional blocking operations in stress tests that test concurrent scenarios - All existing functionality is preserved; this is a drop-in replacement - No changes to public API surface - Existing tests continue to pass * Make InputBindings and KeyboardImpl thread-safe for concurrent access Replace Dictionary with ConcurrentDictionary in InputBindings<TEvent, TBinding> and KeyboardImpl to enable safe parallel test execution and multi-threaded usage. Changes: - InputBindings: Replace Dictionary with ConcurrentDictionary for _bindings - InputBindings: Make Replace() atomic using AddOrUpdate instead of Remove+Add - InputBindings: Make ReplaceCommands() atomic using AddOrUpdate - InputBindings: Add IsValid() check to both Add() overloads - InputBindings: Add defensive .ToList()/.ToArray() for safe LINQ enumeration - KeyboardImpl: Replace Dictionary with ConcurrentDictionary for _commandImplementations - KeyboardImpl: Change AddKeyBindings() to use ReplaceCommands for idempotent initialization - Add 10 comprehensive thread safety tests for InputBindings - Add 9 comprehensive thread safety tests for KeyboardImpl The ConcurrentDictionary implementation provides: - Lock-free reads for better performance under concurrent access - Atomic operations for Replace/ReplaceCommands preventing race conditions - Snapshot enumeration preventing "Collection was modified" exceptions - No breaking API changes - maintains backward compatibility All 11,750 parallelizable tests pass (11,740 passed, 10 skipped). Fixes race conditions that caused ApplicationImplTests.Init_CreatesKeybindings to fail intermittently during parallel test execution. * Decouple ApplicationImpl from Application static props Removed initialization of `Force16Colors` and `ForceDriver` from `Application` static properties in the `ApplicationImpl` constructor. The class still subscribes to the `Force16ColorsChanged` and `ForceDriverChanged` events, but no longer sets initial values for these properties. This change simplifies the constructor and reduces coupling between `ApplicationImpl` and `Application`. * Refactored keyboard initialization in `ApplicationImpl` to use `Application` static properties for default key assignments, ensuring synchronization with pre-`Init()` changes. Improved `KeyboardImpl` initialization to avoid premature `ApplicationImpl.Instance` access, enhancing testability. Standardized constant naming conventions and improved code readability in thread safety tests for `KeyboardImpl` and `InputBindings`. Updated `TestInputBindings` implementation for clarity and conciseness. Applied consistent code style improvements across files, including spacing, formatting, and variable naming, to enhance maintainability and readability. * Fix race conditions in parallel tests - thread-safe ApplicationImpl and KeyboardImpl Fixes intermittent failures in parallel tests caused by three separate race conditions: 1. **KeyboardImpl constructor race condition** - Constructor was accessing Application.QuitKey/ArrangeKey/etc which triggered ApplicationImpl.Instance getter, setting ModelUsage=LegacyStatic before Application.Create() was called - Changed constructor to initialize keys with hard-coded defaults instead - Added synchronization from Application static properties during Init() 2. **InputBindings.Replace() race condition** - Between GetOrAdd(oldEventArgs) and AddOrUpdate(newEventArgs), another thread could modify bindings, causing stale data to overwrite valid bindings - Added early return for same-key case (oldEventArgs == newEventArgs) - Kept atomic operations with proper updateValueFactory handling - Added detailed thread-safety documentation 3. **ApplicationImpl model usage fence checks race condition** - Two threads calling Init() simultaneously could both pass fence checks before either set ModelUsage, allowing improper model mixing - Added _modelUsageLock for thread-safe synchronization - Made all ModelUsage operations atomic (Instance getter, SetInstance, MarkInstanceBasedModelUsed, ResetModelUsageTracking, Init fence checks) **Files Changed:** - Terminal.Gui/App/ApplicationImpl.cs - Added _modelUsageLock, made all ModelUsage access thread-safe - Terminal.Gui/App/ApplicationImpl.Lifecycle.cs - Thread-safe fence checks in Init(), sync keyboard keys from Application properties - Terminal.Gui/App/Keyboard/KeyboardImpl.cs - Fixed constructor to not trigger ApplicationImpl.Instance - Terminal.Gui/Input/InputBindings.cs - Fixed Replace() race condition with proper atomic operations **Testing:** - All 11 ApplicationImplTests pass - All 9 KeyboardImplThreadSafetyTests pass - All 10 InputBindingsThreadSafetyTests pass - No more intermittent "Cannot use modern instance-based model after using legacy static Application model" errors in parallel test execution The root cause was KeyboardImpl constructor accessing Application static properties during object creation, which would lazily initialize ApplicationImpl.Instance and set the wrong ModelUsage before Application.Create() could mark it as InstanceBased. * Warning cleanup * docs: Add comprehensive MessageBox and Clipboard API documentation - Updated MessageBox class docs with nullable return value explanation - Created docfx/docs/messagebox-clipboard-changes-v2.md migration guide - Updated migratingfromv1.md with quick links to major changes - Created PR-SUMMARY.md documenting all changes - Added examples for both instance-based and legacy patterns - Documented application model fencing and thread safety improvements The documentation covers: • MessageBox nullable int? returns (null = cancelled) • Clipboard refactoring from static to instance-based • Application model usage fencing to prevent pattern mixing • Thread safety improvements in KeyboardImpl and InputBindings • Complete migration guide with code examples • Benefits and rationale for all changes * Refactor static properties to use backing fields Refactored static properties in multiple classes (`Button`, `CheckBox`, `Dialog`, `FrameView`, `MessageBox`, `StatusBar`, and `Window`) to use private backing fields for better encapsulation and configurability. Default values are now stored in private static fields, allowing overrides via configuration files (e.g., `Resources/config.json`). Updated property definitions to use `get`/`set` accessors interacting with the backing fields. Retained the `[ConfigurationProperty]` attribute to ensure runtime configurability. Removed redundant code, improved XML documentation, adjusted namespace declarations for consistency, and performed general code cleanup to enhance readability and maintainability. * Fix Windows-only parallel test failure by preventing ConfigurationManager from triggering ApplicationImpl.Instance Problem: `MessageBoxTests.Location_And_Size_Correct` was failing only on Windows in parallel tests with: System.InvalidOperationException: Cannot use modern instance-based model (Application.Create) after using legacy static Application model (Application.Init/ApplicationImpl.Instance). Root Cause (maybe): View classes (MessageBox, Dialog, Window, Button, CheckBox, FrameView, StatusBar) had `[ConfigurationProperty]` decorated auto-properties with inline initializers. When ConfigurationManager's module initializer scanned assemblies using reflection, accessing these auto-properties could trigger lazy initialization of other static members, which in some cases indirectly referenced `ApplicationImpl.Instance`, marking the model as "legacy" before parallel tests called `Application.Create()`. Solution: Converted all `[ConfigurationProperty]` auto-properties in View classes to use private backing fields with explicit getters/setters, matching the pattern used by `Application.QuitKey`. This prevents any code execution during reflection-based property discovery. Files Changed: - Terminal.Gui/Views/MessageBox.cs - 4 properties converted - Terminal.Gui/Views/Dialog.cs - 6 properties converted - Terminal.Gui/Views/Window.cs - 2 properties converted - Terminal.Gui/Views/Button.cs - 2 properties converted - Terminal.Gui/Views/CheckBox.cs - 1 property converted - Terminal.Gui/Views/FrameView.cs - 1 property converted - Terminal.Gui/Views/StatusBar.cs - 1 property converted Test Reorganization: - Moved `ConfigurationManagerTests.GetConfigPropertiesByScope_Gets` from UnitTestsParallelizable to UnitTests (defines custom ConfigurationProperty which affects global state) - Moved `SourcesManagerTests.Sources_StaysConsistentWhenUpdateFails` from UnitTestsParallelizable to UnitTests (modifies static ConfigurationManager.ThrowOnJsonErrors property) Best Practice: All `[ConfigurationProperty]` decorated static properties should use private backing fields to avoid triggering lazy initialization during ConfigurationManager's module initialization. Fixes: Windows-only parallel test failure in MessageBoxTests * Add thread-safety to CollectionNavigator classes - Add lock-based synchronization to CollectionNavigatorBase for _searchString and _lastKeystroke fields - Add lock-based synchronization to CollectionNavigator for Collection property access - Protect ElementAt and GetCollectionLength methods with locks - Add 6 comprehensive thread-safety tests covering: - Concurrent SearchString access - Concurrent Collection property access - Concurrent navigation operations (50 parallel tasks) - Concurrent collection modification with readers/writers - Concurrent search string changes - Stress test with 100 tasks × 1000 operations each All tests pass (31/31) including new thread-safety tests. The implementation uses lock-based synchronization rather than concurrent collections because: - IList interface is not thread-safe by design - CollectionNavigator is internal and used by UI components (ListView/TreeView) - Matches existing Terminal.Gui patterns (Scope<T>, ConfigProperty) - Provides simpler and more predictable behavior Fixes thread-safety issues when CollectionNavigator is accessed from multiple threads. * cleanup * Run parallel unit tests 10 times with varying parallelization to expose concurrency issues Co-authored-by: tig <585482+tig@users.noreply.github.com> * Fix parallel unit tests workflow - use proper xUnit parallelization parameters Co-authored-by: tig <585482+tig@users.noreply.github.com> * Fix environment variable reference in workflow - use proper bash syntax Co-authored-by: tig <585482+tig@users.noreply.github.com> * Run parallel tests 10 times sequentially instead of matrix expansion Co-authored-by: tig <585482+tig@users.noreply.github.com> * Make ConfigurationManager thread-safe - use ConcurrentDictionary and add locks Co-authored-by: tig <585482+tig@users.noreply.github.com> * Add Debug.Fail to detect legacy Application usage in parallelizable tests Co-authored-by: tig <585482+tig@users.noreply.github.com> * Move ScrollSliderTests to UnitTests project - they access legacy Application model Co-authored-by: tig <585482+tig@users.noreply.github.com> * Revert ScrollSliderTests move and document root cause analysis Co-authored-by: tig <585482+tig@users.noreply.github.com> * Remove Debug.Fail and move ScrollSliderTests to UnitTests project Co-authored-by: tig <585482+tig@users.noreply.github.com> * Re-add Debug.Fail to detect legacy Application usage in parallelizable tests Co-authored-by: tig <585482+tig@users.noreply.github.com> * Refactor tests and improve parallelization support Commented out `Debug.Fail` statements in `Application.Lifecycle.cs` and `ApplicationImpl.cs` to prevent interruptions during parallel tests. Refactored `ToString` in `ApplicationImpl.cs` to use an expression-bodied member and removed unused imports. Rewrote tests in `ClipRegionTests.cs` and `ScrollSliderTests.cs` to remove global state dependencies and migrated them to the `UnitTests_Parallelizable` namespace. Enabled nullable annotations and updated assertions for clarity and modern patterns. Improved test coverage by adding scenarios for clamping, layout, and size calculations. Updated `README.md` to include `[SetupFakeApplication]` in the list of patterns that block parallelization and clarified migration guidelines. Replaced `[SetupFakeDriver]` with `[SetupFakeApplication]` in examples. Added `<Folder Include="Drivers\" />` to `UnitTests.csproj` for better organization. Adjusted test project references to reflect test migration. Enhanced test output validation in `ScrollSliderTests.cs`. Removed redundant test cases and improved documentation to align with modern C# practices and ensure maintainability. * marked as a "TODO" for potential future configurability. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: tig <585482+tig@users.noreply.github.com> Co-authored-by: Tig <tig@users.noreply.github.com>
592 lines
20 KiB
C#
592 lines
20 KiB
C#
using System.Diagnostics;
|
|
using System.Drawing;
|
|
using System.Text;
|
|
using Microsoft.Extensions.Logging;
|
|
|
|
#pragma warning disable CS1591 // Missing XML comment for publicly visible type or member
|
|
|
|
namespace TerminalGuiFluentTesting;
|
|
|
|
/// <summary>
|
|
/// Fluent API context for testing a Terminal.Gui application. Create
|
|
/// an instance using <see cref="With"/> static class.
|
|
/// </summary>
|
|
public partial class GuiTestContext : IDisposable
|
|
{
|
|
|
|
// ===== Threading & Synchronization =====
|
|
private readonly CancellationTokenSource _runCancellationTokenSource = new ();
|
|
private readonly CancellationTokenSource? _timeoutCts;
|
|
private readonly Task? _runTask;
|
|
private readonly SemaphoreSlim _booting;
|
|
private readonly object _cancellationLock = new ();
|
|
private volatile bool _finished;
|
|
|
|
// ===== Exception Handling =====
|
|
private readonly object _backgroundExceptionLock = new ();
|
|
private Exception? _backgroundException;
|
|
|
|
// ===== Driver & Application State =====
|
|
private readonly FakeInput _fakeInput = new ();
|
|
private IOutput? _output;
|
|
private SizeMonitorImpl? _sizeMonitor;
|
|
private ApplicationImpl? _applicationImpl;
|
|
|
|
/// <summary>
|
|
/// The IApplication instance that was created.
|
|
/// </summary>
|
|
public IApplication? App => _applicationImpl;
|
|
|
|
private TestDriver _driverType;
|
|
|
|
// ===== Application State Preservation (for restoration) =====
|
|
private ILogger? _originalLogger;
|
|
|
|
// ===== Test Configuration =====
|
|
private readonly bool _runApplication;
|
|
private TimeSpan _timeout;
|
|
|
|
// ===== Logging =====
|
|
private readonly object _logsLock = new ();
|
|
private readonly TextWriter? _logWriter;
|
|
private StringBuilder? _logsSb;
|
|
|
|
|
|
/// <summary>
|
|
/// Constructor for tests that only need Application.Init without running the main loop.
|
|
/// Uses the driver's default screen size instead of forcing a specific size.
|
|
/// </summary>
|
|
public GuiTestContext (TestDriver driver, TextWriter? logWriter = null, TimeSpan? timeout = null)
|
|
{
|
|
_logWriter = logWriter;
|
|
_runApplication = false;
|
|
_booting = new (0, 1);
|
|
_timeoutCts = new CancellationTokenSource (timeout ?? TimeSpan.FromSeconds (10)); // NEW
|
|
|
|
// Don't force a size - let the driver determine it
|
|
CommonInit (0, 0, driver, timeout);
|
|
|
|
try
|
|
{
|
|
App?.Init (GetDriverName ());
|
|
_booting.Release ();
|
|
|
|
// After Init, Application.Screen should be set by the driver
|
|
if (_applicationImpl?.Screen == Rectangle.Empty)
|
|
{
|
|
throw new InvalidOperationException (
|
|
"Driver bug: Application.Screen is empty after Init. The driver should set the screen size during Init.");
|
|
}
|
|
}
|
|
catch (Exception ex)
|
|
{
|
|
lock (_backgroundExceptionLock) // NEW: Thread-safe exception handling
|
|
{
|
|
_backgroundException = ex;
|
|
}
|
|
|
|
if (_logWriter != null)
|
|
{
|
|
WriteOutLogs (_logWriter);
|
|
}
|
|
|
|
throw new ("Application initialization failed", ex);
|
|
}
|
|
|
|
lock (_backgroundExceptionLock) // NEW: Thread-safe check
|
|
{
|
|
if (_backgroundException != null)
|
|
{
|
|
throw new ("Application initialization failed", _backgroundException);
|
|
}
|
|
}
|
|
}
|
|
|
|
/// <summary>
|
|
/// Constructor for tests that need to run the application with Application.Run.
|
|
/// </summary>
|
|
internal GuiTestContext (Func<Toplevel> topLevelBuilder, int width, int height, TestDriver driver, TextWriter? logWriter = null, TimeSpan? timeout = null)
|
|
{
|
|
_logWriter = logWriter;
|
|
_runApplication = true;
|
|
_booting = new (0, 1);
|
|
|
|
CommonInit (width, height, driver, timeout);
|
|
|
|
// Start the application in a background thread
|
|
_runTask = Task.Run (
|
|
() =>
|
|
{
|
|
try
|
|
{
|
|
try
|
|
{
|
|
App?.Init (GetDriverName ());
|
|
}
|
|
catch (Exception e)
|
|
{
|
|
Logging.Error(e.Message);
|
|
_runCancellationTokenSource.Cancel ();
|
|
}
|
|
finally
|
|
{
|
|
_booting.Release ();
|
|
}
|
|
|
|
if (App is { Initialized: true })
|
|
{
|
|
Toplevel t = topLevelBuilder ();
|
|
t.Closed += (s, e) => { Finished = true; };
|
|
App?.Run (t); // This will block, but it's on a background thread now
|
|
|
|
t.Dispose ();
|
|
Logging.Trace ("Application.Run completed");
|
|
App?.Shutdown ();
|
|
_runCancellationTokenSource.Cancel ();
|
|
}
|
|
}
|
|
catch (OperationCanceledException)
|
|
{
|
|
Logging.Trace ("OperationCanceledException");
|
|
}
|
|
catch (Exception ex)
|
|
{
|
|
_backgroundException = ex;
|
|
_fakeInput.ExternalCancellationTokenSource!.Cancel ();
|
|
}
|
|
finally
|
|
{
|
|
CleanupApplication ();
|
|
if (_logWriter != null)
|
|
{
|
|
WriteOutLogs (_logWriter);
|
|
}
|
|
}
|
|
},
|
|
_runCancellationTokenSource.Token);
|
|
|
|
// Wait for booting to complete with a timeout to avoid hangs
|
|
if (!_booting.WaitAsync (_timeout).Result)
|
|
{
|
|
throw new TimeoutException ($"Application failed to start within {_timeout}ms.");
|
|
}
|
|
|
|
ResizeConsole (width, height);
|
|
|
|
if (_backgroundException is { })
|
|
{
|
|
throw new ("Application crashed", _backgroundException);
|
|
}
|
|
}
|
|
|
|
|
|
/// <summary>
|
|
/// Common initialization for both constructors.
|
|
/// </summary>
|
|
private void CommonInit (int width, int height, TestDriver driverType, TimeSpan? timeout)
|
|
{
|
|
_timeout = timeout ?? TimeSpan.FromSeconds (10);
|
|
_originalLogger = Logging.Logger;
|
|
_logsSb = new ();
|
|
_driverType = driverType;
|
|
|
|
ILogger logger = LoggerFactory.Create (builder =>
|
|
builder.SetMinimumLevel (LogLevel.Trace)
|
|
.AddProvider (
|
|
new TextWriterLoggerProvider (
|
|
new ThreadSafeStringWriter (_logsSb, _logsLock))))
|
|
.CreateLogger ("Test Logging");
|
|
Logging.Logger = logger;
|
|
|
|
// ✅ Link _runCancellationTokenSource with a timeout
|
|
// This creates a token that responds to EITHER the run cancellation OR timeout
|
|
_fakeInput.ExternalCancellationTokenSource =
|
|
CancellationTokenSource.CreateLinkedTokenSource (
|
|
_runCancellationTokenSource.Token,
|
|
new CancellationTokenSource (_timeout).Token);
|
|
|
|
// Now when InputImpl.Run receives this ExternalCancellationTokenSource,
|
|
// it will create ANOTHER linked token internally that combines:
|
|
// - Its own runCancellationToken parameter
|
|
// - The ExternalCancellationTokenSource (which is already linked)
|
|
// This creates a chain: any of these triggers will stop input:
|
|
// 1. _runCancellationTokenSource.Cancel() (normal stop)
|
|
// 2. Timeout expires (test timeout)
|
|
// 3. Direct cancel of ExternalCancellationTokenSource (hard stop/error)
|
|
|
|
// Remove frame limit
|
|
Application.MaximumIterationsPerSecond = ushort.MaxValue;
|
|
|
|
IComponentFactory? cf = null;
|
|
|
|
_output = new FakeOutput ();
|
|
|
|
// Only set size if explicitly provided (width and height > 0)
|
|
if (width > 0 && height > 0)
|
|
{
|
|
_output.SetSize (width, height);
|
|
}
|
|
|
|
// TODO: As each drivers' IInput/IOutput implementations are made testable (e.g.
|
|
// TODO: safely injectable/mocked), we can expand this switch to use them.
|
|
switch (driverType)
|
|
{
|
|
case TestDriver.DotNet:
|
|
_sizeMonitor = new (_output);
|
|
cf = new FakeComponentFactory (_fakeInput, _output, _sizeMonitor);
|
|
|
|
break;
|
|
case TestDriver.Windows:
|
|
_sizeMonitor = new (_output);
|
|
cf = new FakeComponentFactory (_fakeInput, _output, _sizeMonitor);
|
|
|
|
break;
|
|
case TestDriver.Unix:
|
|
_sizeMonitor = new (_output);
|
|
cf = new FakeComponentFactory (_fakeInput, _output, _sizeMonitor);
|
|
|
|
break;
|
|
case TestDriver.Fake:
|
|
_sizeMonitor = new (_output);
|
|
cf = new FakeComponentFactory (_fakeInput, _output, _sizeMonitor);
|
|
|
|
break;
|
|
}
|
|
|
|
_applicationImpl = new (cf!);
|
|
Logging.Trace ($"Driver: {GetDriverName ()}. Timeout: {_timeout}");
|
|
}
|
|
|
|
private string GetDriverName ()
|
|
{
|
|
return _driverType switch
|
|
{
|
|
TestDriver.Windows => "windows",
|
|
TestDriver.DotNet => "dotnet",
|
|
TestDriver.Unix => "unix",
|
|
TestDriver.Fake => "fake",
|
|
_ =>
|
|
throw new ArgumentOutOfRangeException ()
|
|
};
|
|
}
|
|
|
|
/// <summary>
|
|
/// Gets whether the application has finished running; aka Stop has been called and the main loop has exited.
|
|
/// </summary>
|
|
public bool Finished
|
|
{
|
|
get => _finished;
|
|
private set => _finished = value;
|
|
}
|
|
|
|
|
|
/// <summary>
|
|
/// Performs the supplied <paramref name="doAction"/> immediately.
|
|
/// Enables running commands without breaking the Fluent API calls.
|
|
/// </summary>
|
|
/// <param name="doAction"></param>
|
|
/// <returns></returns>
|
|
public GuiTestContext Then (Action<IApplication> doAction)
|
|
{
|
|
try
|
|
{
|
|
Logging.Trace ($"Invoking action via WaitIteration");
|
|
WaitIteration (doAction);
|
|
}
|
|
catch (Exception ex)
|
|
{
|
|
_backgroundException = ex;
|
|
HardStop ();
|
|
|
|
throw;
|
|
}
|
|
|
|
return this;
|
|
}
|
|
|
|
/// <summary>
|
|
/// Waits until the end of the current iteration of the main loop. Optionally
|
|
/// running a given <paramref name="action"/> action on the UI thread at that time.
|
|
/// </summary>
|
|
/// <param name="action"></param>
|
|
/// <returns></returns>
|
|
public GuiTestContext WaitIteration (Action<IApplication>? action = null)
|
|
{
|
|
// If application has already exited don't wait!
|
|
if (Finished || _runCancellationTokenSource.Token.IsCancellationRequested || _fakeInput.ExternalCancellationTokenSource!.Token.IsCancellationRequested)
|
|
{
|
|
Logging.Warning ("WaitIteration called after context was stopped");
|
|
|
|
return this;
|
|
}
|
|
|
|
if (Thread.CurrentThread.ManagedThreadId == _applicationImpl?.MainThreadId)
|
|
{
|
|
throw new NotSupportedException ("Cannot WaitIteration during Invoke");
|
|
}
|
|
|
|
//Logging.Trace ($"WaitIteration started");
|
|
if (action is null)
|
|
{
|
|
action = (app) => { };
|
|
}
|
|
CancellationTokenSource ctsActionCompleted = new ();
|
|
|
|
App?.Invoke (app =>
|
|
{
|
|
try
|
|
{
|
|
action (app);
|
|
|
|
//Logging.Trace ("Action completed");
|
|
ctsActionCompleted.Cancel ();
|
|
}
|
|
catch (Exception e)
|
|
{
|
|
Logging.Warning ($"Action failed with exception: {e}");
|
|
_backgroundException = e;
|
|
_fakeInput.ExternalCancellationTokenSource?.Cancel ();
|
|
}
|
|
});
|
|
|
|
// Blocks until either the token or the hardStopToken is cancelled.
|
|
// With linked tokens, we only need to wait on _runCancellationTokenSource and ctsLocal
|
|
// ExternalCancellationTokenSource is redundant because it's linked to _runCancellationTokenSource
|
|
WaitHandle.WaitAny (
|
|
[
|
|
_runCancellationTokenSource.Token.WaitHandle,
|
|
ctsActionCompleted.Token.WaitHandle
|
|
]);
|
|
|
|
// Logging.Trace ($"Return from WaitIteration");
|
|
return this;
|
|
}
|
|
|
|
public GuiTestContext WaitUntil (Func<bool> condition)
|
|
{
|
|
GuiTestContext? c = null;
|
|
var sw = Stopwatch.StartNew ();
|
|
|
|
Logging.Trace ($"WaitUntil started with timeout {_timeout}");
|
|
|
|
int count = 0;
|
|
while (!condition ())
|
|
{
|
|
if (sw.Elapsed > _timeout)
|
|
{
|
|
throw new TimeoutException ($"Failed to reach condition within {_timeout}ms");
|
|
}
|
|
|
|
c = WaitIteration ();
|
|
count++;
|
|
}
|
|
|
|
Logging.Trace ($"WaitUntil completed after {sw.ElapsedMilliseconds}ms and {count} iterations");
|
|
return c ?? this;
|
|
}
|
|
|
|
|
|
/// <summary>
|
|
/// Returns the last set position of the cursor.
|
|
/// </summary>
|
|
/// <returns></returns>
|
|
public Point GetCursorPosition () { return _output!.GetCursorPosition (); }
|
|
|
|
/// <summary>
|
|
/// Simulates changing the console size e.g. by resizing window in your operating system
|
|
/// </summary>
|
|
/// <param name="width">new Width for the console.</param>
|
|
/// <param name="height">new Height for the console.</param>
|
|
/// <returns></returns>
|
|
public GuiTestContext ResizeConsole (int width, int height) { return WaitIteration ((app) => { app.Driver!.SetScreenSize (width, height); }); }
|
|
|
|
public GuiTestContext ScreenShot (string title, TextWriter? writer)
|
|
{
|
|
//Logging.Trace ($"{title}");
|
|
return WaitIteration ((app) =>
|
|
{
|
|
writer?.WriteLine (title + ":");
|
|
var text = app.Driver?.ToString ();
|
|
|
|
writer?.WriteLine (text);
|
|
});
|
|
}
|
|
|
|
public GuiTestContext AnsiScreenShot (string title, TextWriter? writer)
|
|
{
|
|
//Logging.Trace ($"{title}");
|
|
return WaitIteration ((app) =>
|
|
{
|
|
writer?.WriteLine (title + ":");
|
|
var text = app.Driver?.ToAnsi ();
|
|
|
|
writer?.WriteLine (text);
|
|
});
|
|
}
|
|
|
|
/// <summary>
|
|
/// Stops the application and waits for the background thread to exit.
|
|
/// </summary>
|
|
public GuiTestContext Stop ()
|
|
{
|
|
Logging.Trace ($"Stopping application for driver: {GetDriverName ()}");
|
|
|
|
if (_runTask is null || _runTask.IsCompleted)
|
|
{
|
|
// If we didn't run the application, just cleanup
|
|
if (!_runApplication && !Finished)
|
|
{
|
|
try
|
|
{
|
|
App?.Shutdown ();
|
|
}
|
|
catch
|
|
{
|
|
// Ignore errors during shutdown
|
|
}
|
|
|
|
CleanupApplication ();
|
|
}
|
|
|
|
return this;
|
|
}
|
|
|
|
WaitIteration ((app) => { app.RequestStop (); });
|
|
|
|
// Wait for the application to stop, but give it a 1-second timeout
|
|
const int WAIT_TIMEOUT_MS = 1000;
|
|
|
|
if (!_runTask.Wait (TimeSpan.FromMilliseconds (WAIT_TIMEOUT_MS)))
|
|
{
|
|
_runCancellationTokenSource.Cancel ();
|
|
|
|
// No need to manually cancel ExternalCancellationTokenSource
|
|
|
|
// App is having trouble shutting down, try sending some more shutdown stuff from this thread.
|
|
// If this doesn't work there will be test failures as the main loop continues to run during next test.
|
|
try
|
|
{
|
|
App?.RequestStop ();
|
|
App?.Shutdown ();
|
|
}
|
|
catch (Exception ex)
|
|
{
|
|
Logging.Critical ($"Application failed to stop in {WAIT_TIMEOUT_MS}. Then shutdown threw {ex}");
|
|
}
|
|
finally
|
|
{
|
|
Logging.Critical ($"Application failed to stop in {WAIT_TIMEOUT_MS}. Exception was thrown: {_backgroundException}");
|
|
}
|
|
}
|
|
|
|
_runCancellationTokenSource.Cancel ();
|
|
|
|
if (_backgroundException != null)
|
|
{
|
|
Logging.Critical ($"Exception occurred: {_backgroundException}");
|
|
//throw _ex; // Propagate any exception that happened in the background task
|
|
}
|
|
|
|
return this;
|
|
}
|
|
|
|
/// <summary>
|
|
/// Hard stops the application and waits for the background thread to exit.HardStop is used by the source generator for
|
|
/// wrapping Xunit assertions.
|
|
/// </summary>
|
|
public void HardStop (Exception? ex = null)
|
|
{
|
|
if (ex != null)
|
|
{
|
|
_backgroundException = ex;
|
|
}
|
|
|
|
Logging.Critical ($"HardStop called with exception: {_backgroundException}");
|
|
|
|
// With linked tokens, just cancelling ExternalCancellationTokenSource
|
|
// will cascade to stop everything
|
|
_fakeInput.ExternalCancellationTokenSource?.Cancel ();
|
|
WriteOutLogs (_logWriter);
|
|
Stop ();
|
|
}
|
|
|
|
/// <summary>
|
|
/// Writes all Terminal.Gui engine logs collected so far to the <paramref name="writer"/>
|
|
/// </summary>
|
|
/// <param name="writer"></param>
|
|
/// <returns></returns>
|
|
public GuiTestContext WriteOutLogs (TextWriter? writer)
|
|
{
|
|
if (writer is null)
|
|
{
|
|
return this;
|
|
}
|
|
|
|
lock (_logsLock)
|
|
{
|
|
writer.WriteLine (_logsSb!.ToString ());
|
|
}
|
|
|
|
return this; //WaitIteration();
|
|
}
|
|
|
|
internal void Fail (string reason)
|
|
{
|
|
Logging.Error ($"{reason}");
|
|
|
|
throw new (reason);
|
|
}
|
|
|
|
private void CleanupApplication ()
|
|
{
|
|
Logging.Trace ("CleanupApplication");
|
|
_fakeInput.ExternalCancellationTokenSource = null;
|
|
|
|
App?.ResetState (true);
|
|
Logging.Logger = _originalLogger!;
|
|
Finished = true;
|
|
|
|
Application.MaximumIterationsPerSecond = Application.DefaultMaximumIterationsPerSecond;
|
|
}
|
|
|
|
|
|
/// <summary>
|
|
/// Cleanup to avoid state bleed between tests
|
|
/// </summary>
|
|
public void Dispose ()
|
|
{
|
|
Logging.Trace ($"Disposing GuiTestContext");
|
|
Stop ();
|
|
|
|
bool shouldThrow = false;
|
|
Exception? exToThrow = null;
|
|
|
|
lock (_cancellationLock) // NEW: Thread-safe check
|
|
{
|
|
if (_fakeInput.ExternalCancellationTokenSource is { IsCancellationRequested: true })
|
|
{
|
|
shouldThrow = true;
|
|
lock (_backgroundExceptionLock)
|
|
{
|
|
exToThrow = _backgroundException;
|
|
}
|
|
}
|
|
|
|
// ✅ Dispose the linked token source
|
|
_fakeInput.ExternalCancellationTokenSource?.Dispose ();
|
|
}
|
|
|
|
_timeoutCts?.Dispose (); // NEW: Dispose timeout CTS
|
|
_runCancellationTokenSource?.Dispose ();
|
|
_fakeInput.Dispose ();
|
|
_output?.Dispose ();
|
|
_booting.Dispose ();
|
|
|
|
if (shouldThrow)
|
|
{
|
|
throw new ("Application was hard stopped...", exToThrow);
|
|
}
|
|
}
|
|
|
|
}
|