Files
Terminal.Gui/UnitTests/View/KeyboardEventTests.cs
Tig dcb3b359ad Fixes #2926 - Refactor KeyEvent and KeyEventEventArgs to simplify (#2927)
* Adds basic MainLoop unit tests

* Remove WinChange action from Curses

* Remove WinChange action from Curses

* Remove ProcessInput action from Windows MainLoop

* Simplified MainLoop/ConsoleDriver by making MainLoop internal and moving impt fns to Application

* Modernized Terminal resize events

* Modernized Terminal resize events

* Removed un used property

* for _isWindowsTerminal devenv->wininit; not sure what changed

* Modernized mouse/keyboard events (Action->EventHandler)

* Updated OnMouseEvent API docs

* Using WT_SESSION to detect WT

* removes hacky GetParentProcess

* Updates to fix #2634 (clear last line)

* removes hacky GetParentProcess2

* Addressed mac resize issue

* Addressed mac resize issue

* Removes ConsoleDriver.PrepareToRun, has Init return MainLoop

* Removes unneeded Attribute methods

* Removed GetProcesssName

* Removed GetProcesssName

* Refactored KeyEvent and KeyEventEventArgs into a single class

* Revert "Refactored KeyEvent and KeyEventEventArgs into a single class"

This reverts commit 88a00658db.

* Fixed key repeat issue; reverted stupidity on 1049/1047 confusion

* Updated CSI API Docs

* merge

* Rearranged Event.cs to Keyboard.cs and Mouse.cs

* Renamed KeyEventEventArgs KeyEventArgs

* temp renamed KeyEvent OldKeyEvent

* Merged KeyEvent into KeyEventArgs

* Renamed Application.ProcessKey members

* Renamed Application.ProcessKey members

* Renamed Application.ProcessKey members

* Added Responder.KeyPressed

* Removed unused references

* Fixed arg naming

* InvokeKeybindings->InvokeKeyBindings

* InvokeKeybindings->InvokeKeyBindings

* Fixed unit tests fail

* More progress on refactoring key input; still broken and probably wrong

* Moved OnKeyPressed out of Responder and made ProcessKeyPrssed non-virtual

* Updated API docs

* Moved key handling from Responder to View

* Updated API docs

* Updated HotKey API docs

* Updated shortcut API docs

* Fixed responder unit tests

* Removed Shortcut from View as it is not used

* Removed unneeded OnHotKey override from Button

* Fixed BackTab logic

* Button now uses Key Bindings exclusively

* Button now uses Key Bindings exclusively

* Updated keyboard.md docs

* Fixed unit tests to account for Toplevel handling default button

* Added View.InvokeCommand API

* Modernized RadioGroup

* Removed ColdKey

* Modernized (partially) StatusBar

* Worked around FileDialog issue with Ctrl-F

* Fixed driver unit test; view must be focused to reciev key pressed

* Application code cleanup

* Start on updaing menu

* Menu now mostly works

* Menu Select refinement

* Fixed known menu bugs!

* Enabled HotKey to cause focus- experimental

* Fixes #3022 & adds unit test to prove it

* Actually Fixes #3022 & adds unit test to prove it

* Working through hotkey issues

* Misc fixes

* removed hot/cold key stuff from Keys scenario

* Fixed scenarios

* Simplified shortcut string handling

* Modernized Checkbox

* Modernized TileView

* Updated API docs

* Updated API docs

* attempting to publish v2 docs

* Revert "attempting to publish v2 docs"

This reverts commit 59dcec111b.

* Playing with api docs

* Removed Key.BackTab

* Removed Caps/Scroll/Numlock

* Partial removal of keymodifiers - unit tests pass

* Partial removal of keymodifiers - broke netdriver somewhere

* WindowsDriver & added KeyEventArgsTests

* Fixing menu shortcut/hotkeys - broke Menu.cs into separate files

* Fixed MenuBar!

* Finished modernizing Menu/MenuBar

* Removed Key.a-z. Broke lots of stuff

* checkout@v4

* progress on key mapping and formatting

* VK tests are still failing

* Fixed some unit tests

* Added Hotkey and Keybinding unit tests

* fixed unit test

* All unit tests pass again...

* Fixed broken unit tests

* KeyEventArgs.KeyValue -> AsRune

* Fixed bugs. Still some broken

* Added KeyEventArgs.IsAlpha. Added KeyEventArgs.cast ops. Fixed bugs. Unit tests pass

* Fixed WindowsDriver

* Oops.

* Refactoring based on bdisp's help. Not complete!

* removed calling into subviews from OnKeyBindings

* removed calling into subviews from OnKeyBindings

* Improved View KeyEvent unit tests

* More hotkey unit tests

* BIg change - Got rid of KeyPress w/in Application/Drivers

* Unit tests now pass again

* Refreshed API docs

* Better HotKey logic. More progress. Getting close.

* Fixed handling of shifted chars like ö

* Minor code cleanup

* Minor code cleanup2

* Why is build Action failing?

* Why is build Action failing??

* upgraded to .net8 to try to fix weird CI/CD build errors

* upgraded to .net8 to try to fix weird CI/CD build errors2

* Disabling TextViewTests to diagnose build errors

* reenable TextViewTests to diagnose build errors

* Arrrrrrg

* Merged v2_develop

* Fixed uppercase accented keys in WindowsDriver

* Fixed key binding api docs

* Experimental impl of CommandScope.SubViews for MenuBar

* Removed dead code from application.cs

* Removed dead code from application.cs

* Removed dead code from ConsoleDriver.cs

* Cleaned up some key binding stuff

* Disabled Alt to activate menu for now

* Updated label commands

* Fixed menu bugs. Upgraded menu unit tests

* Fixed unit tests

* Working on NetDriver

* fixed netdriver

* Fixed issues called out by @bdisp CR

* fixed CursesDriver

* added todo to netdriver

* Cherry picked treeview test fix 1b415e5

* Fix NetDriver.

* CommandScope->KeyBindingScope

* Address some tznind feedback

* Refactored KeyBindings big time!

* Added key consts to KeyEventArgs and renamed Key to ConsoleDriverKey

* Fixed some API docs

* Moved ConsoleDriverKey to ConsoleDriver.cs

* Renamed Key->ConsoleDriverKey

* Renamed Key->ConsoleDriverKey

* Renamed Key->ConsoleDriverKey

* renamed file I forgot to rename before

* Updated name and API docs of KeyEventArgs.isAlpha

* Fixed issues with OnKeyUp not doing the right thing.

* Fixed MainLoop.Running never being used

* Fixed MainLoop.Running never being used - unit tests

* Claned up BUGBUG comments

* Disabled a unit test to see why ci/cd tests are failing

* Removed defunct commented code

* Removed more defunct commented code

* Re-eanbled unit test; jsut removing one test case...

* Disabled more...

* Renambed Global->Applicaton and updated scope API docs

* Disabled more unit tests...

* Removed dead code

* Disabled more unit tests...2

* Disabled more unit tests...3

* Renambed Global->Applicaton and updated scope API docs 2

* Added more KeyBinding scope tests

* Added more KeyBinding scope tests2

* ConsoleDriverKey too long. Key too ambiguous. Settled on KeyCode. (Partialy because eventually I want to intro a class named Key).

* KeyEventArgs improvements. cast to Rune must be explicit as it's lossy

* Fixed warnings

* Renamed KeyEventArgs to Key... progress on fixing broken stuff that resulted

* Fix ConsoleKeyMapping bugs.

* Fix NetDriver issue from converting a lower case to a upper case.

* Started migration to Key from KeyCode - e.g. made HotKeys all consistent.

* Fixed build warnings

* Added key defns to Key

* KeyBindings now uses Key vs. KeyCode

* Verified by tweaking UICatalog

* Fixed treeview test ... again

* Renamed ProcessKeyDown/Up to NewKeyDown/Up and OnKeyPressed to OnProcessKeyDown to make things more clear

* Added test AllViews_KeyDown_All_EventsFire unit tests and fixed a few Views that were wrong

* fixed stupid KeyUp event bug

* If key not handled, return false for datefield

* dotnet test --no-restore --verbosity diag

* dotnet test --blame

* run tests on windows

* Fix TestVKPacket unit test and move it to ConsoleKeyMappingTests.cs file.

* Remove unnecessary commented code.

* Tweaked unit tests and removed Key.BareKey

* Fixed little details and updated api docs

* updated api docs

* AddKeyBindingsForHotKey: KeyCode->Key

* Cleaned up more old KeyCode usages. Added TODOs

---------

Co-authored-by: BDisp <bd.bdisp@gmail.com>
2023-12-16 12:04:23 -07:00

458 lines
12 KiB
C#

using System;
using Xunit;
using Xunit.Abstractions;
// Alias Console to MockConsole so we don't accidentally use Console
using Console = Terminal.Gui.FakeConsole;
namespace Terminal.Gui.ViewTests;
public class KeyboardEventTests {
readonly ITestOutputHelper _output;
public KeyboardEventTests (ITestOutputHelper output) => _output = output;
[Fact]
public void KeyPress_Handled_Cancels ()
{
var view = new View ();
bool invokingKeyBindingsInvoked = false;
bool processKeyPressInvoked = false;
bool setHandledTo = false;
view.KeyDown += (s, e) => {
e.Handled = setHandledTo;
Assert.Equal (setHandledTo, e.Handled);
Assert.Equal (KeyCode.N, e.KeyCode);
};
view.InvokingKeyBindings += (s, e) => {
invokingKeyBindingsInvoked = true;
Assert.False (e.Handled);
Assert.Equal (KeyCode.N, e.KeyCode);
};
view.ProcessKeyDown += (s, e) => {
processKeyPressInvoked = true;
Assert.False (e.Handled);
Assert.Equal (KeyCode.N, e.KeyCode);
};
view.NewKeyDownEvent (new Key (KeyCode.N));
Assert.True (invokingKeyBindingsInvoked);
Assert.True (processKeyPressInvoked);
invokingKeyBindingsInvoked = false;
processKeyPressInvoked = false;
setHandledTo = true;
view.NewKeyDownEvent (new Key (KeyCode.N));
Assert.False (invokingKeyBindingsInvoked);
Assert.False (processKeyPressInvoked);
}
[Fact]
public void InvokingKeyBindings_Handled_Cancels ()
{
var view = new View ();
bool keyPressInvoked = false;
bool invokingKeyBindingsInvoked = false;
bool processKeyPressInvoked = false;
bool setHandledTo = false;
view.KeyDown += (s, e) => {
keyPressInvoked = true;
Assert.False (e.Handled);
Assert.Equal (KeyCode.N, e.KeyCode);
};
view.InvokingKeyBindings += (s, e) => {
invokingKeyBindingsInvoked = true;
e.Handled = setHandledTo;
Assert.Equal (setHandledTo, e.Handled);
Assert.Equal (KeyCode.N, e.KeyCode);
};
view.ProcessKeyDown += (s, e) => {
processKeyPressInvoked = true;
processKeyPressInvoked = true;
Assert.False (e.Handled);
Assert.Equal (KeyCode.N, e.KeyCode);
};
view.NewKeyDownEvent (new Key (KeyCode.N));
Assert.True (keyPressInvoked);
Assert.True (invokingKeyBindingsInvoked);
Assert.True (processKeyPressInvoked);
keyPressInvoked = false;
invokingKeyBindingsInvoked = false;
processKeyPressInvoked = false;
setHandledTo = true;
view.NewKeyDownEvent (new Key (KeyCode.N));
Assert.True (keyPressInvoked);
Assert.True (invokingKeyBindingsInvoked);
Assert.False (processKeyPressInvoked);
}
[Theory]
[InlineData (null, null)]
[InlineData (true, true)]
[InlineData (false, false)]
public void OnInvokingKeyBindings_Returns_Nullable_Properly (bool? toReturn, bool? expected)
{
var view = new KeyBindingsTestView ();
view.CommandReturns = toReturn;
bool? result = view.OnInvokingKeyBindings (new Key (KeyCode.A));
Assert.Equal (expected, result);
}
/// <summary>
/// A view that overrides the OnKey* methods so we can test that they are called.
/// </summary>
public class KeyBindingsTestView : View {
public bool? CommandReturns { get; set; }
public KeyBindingsTestView ()
{
CanFocus = true;
AddCommand (Command.Default, () => CommandReturns);
KeyBindings.Add (KeyCode.A, Command.Default);
}
}
[Fact]
public void KeyDown_Handled_True_Stops_Processing ()
{
bool keyDown = false;
bool invokingKeyBindings = false;
bool keyPressed = false;
var view = new OnKeyTestView ();
Assert.True (view.CanFocus);
view.CancelVirtualMethods = false;
view.KeyDown += (s, e) => {
Assert.Equal (KeyCode.A, e.KeyCode);
Assert.False (keyDown);
Assert.False (view.OnKeyDownContinued);
e.Handled = true;
keyDown = true;
};
view.InvokingKeyBindings += (s, e) => {
Assert.Equal (KeyCode.A, e.KeyCode);
Assert.False (keyPressed);
Assert.False (view.OnInvokingKeyBindingsContinued);
e.Handled = true;
invokingKeyBindings = true;
};
view.ProcessKeyDown += (s, e) => {
Assert.Equal (KeyCode.A, e.KeyCode);
Assert.False (keyPressed);
Assert.False (view.OnKeyPressedContinued);
e.Handled = true;
keyPressed = true;
};
view.NewKeyDownEvent (new Key (KeyCode.A));
Assert.True (keyDown);
Assert.False (invokingKeyBindings);
Assert.False (keyPressed);
Assert.False (view.OnKeyDownContinued);
Assert.False (view.OnInvokingKeyBindingsContinued);
Assert.False (view.OnKeyPressedContinued);
}
[Fact]
public void InvokingKeyBindings_Handled_True_Stops_Processing ()
{
bool keyDown = false;
bool invokingKeyBindings = false;
bool keyPressed = false;
var view = new OnKeyTestView ();
Assert.True (view.CanFocus);
view.CancelVirtualMethods = false;
view.KeyDown += (s, e) => {
Assert.Equal (KeyCode.A, e.KeyCode);
Assert.False (keyDown);
Assert.False (view.OnKeyDownContinued);
e.Handled = false;
keyDown = true;
};
view.InvokingKeyBindings += (s, e) => {
Assert.Equal (KeyCode.A, e.KeyCode);
Assert.False (keyPressed);
Assert.False (view.OnInvokingKeyBindingsContinued);
e.Handled = true;
invokingKeyBindings = true;
};
view.ProcessKeyDown += (s, e) => {
Assert.Equal (KeyCode.A, e.KeyCode);
Assert.False (keyPressed);
Assert.False (view.OnKeyPressedContinued);
e.Handled = true;
keyPressed = true;
};
view.NewKeyDownEvent (new Key (KeyCode.A));
Assert.True (keyDown);
Assert.True (invokingKeyBindings);
Assert.False (keyPressed);
Assert.True (view.OnKeyDownContinued);
Assert.False (view.OnInvokingKeyBindingsContinued);
Assert.False (view.OnKeyPressedContinued);
}
[Fact]
public void KeyPressed_Handled_True_Stops_Processing ()
{
bool keyDown = false;
bool invokingKeyBindings = false;
bool keyPressed = false;
var view = new OnKeyTestView ();
Assert.True (view.CanFocus);
view.CancelVirtualMethods = false;
view.KeyDown += (s, e) => {
Assert.Equal (KeyCode.A, e.KeyCode);
Assert.False (keyDown);
Assert.False (view.OnKeyDownContinued);
e.Handled = false;
keyDown = true;
};
view.InvokingKeyBindings += (s, e) => {
Assert.Equal (KeyCode.A, e.KeyCode);
Assert.False (keyPressed);
Assert.False (view.OnInvokingKeyBindingsContinued);
e.Handled = false;
invokingKeyBindings = true;
};
view.ProcessKeyDown += (s, e) => {
Assert.Equal (KeyCode.A, e.KeyCode);
Assert.False (keyPressed);
Assert.False (view.OnKeyPressedContinued);
e.Handled = true;
keyPressed = true;
};
view.NewKeyDownEvent (new Key (KeyCode.A));
Assert.True (keyDown);
Assert.True (invokingKeyBindings);
Assert.True (keyPressed);
Assert.True (view.OnKeyDownContinued);
Assert.True (view.OnInvokingKeyBindingsContinued);
Assert.False (view.OnKeyPressedContinued);
}
[Fact]
public void KeyUp_Handled_True_Stops_Processing ()
{
bool keyUp = false;
var view = new OnKeyTestView ();
Assert.True (view.CanFocus);
view.CancelVirtualMethods = false;
view.KeyUp += (s, e) => {
Assert.Equal (KeyCode.A, e.KeyCode);
Assert.False (keyUp);
Assert.False (view.OnKeyPressedContinued);
e.Handled = true;
keyUp = true;
};
view.NewKeyUpEvent (new Key (KeyCode.A));
Assert.True (keyUp);
Assert.False (view.OnKeyUpContinued);
Assert.False (view.OnKeyDownContinued);
Assert.False (view.OnInvokingKeyBindingsContinued);
Assert.False (view.OnKeyPressedContinued);
}
/// <summary>
/// A view that overrides the OnKey* methods so we can test that they are called.
/// </summary>
public class OnKeyTestView : View {
public bool CancelVirtualMethods { set; private get; }
public OnKeyTestView () => CanFocus = true;
public override string Text { get; set; }
public bool OnKeyDownContinued { get; set; }
public bool OnInvokingKeyBindingsContinued { get; set; }
public bool OnKeyPressedContinued { get; set; }
public bool OnKeyUpContinued { get; set; }
public override bool OnKeyDown (Key keyEvent)
{
if (base.OnKeyDown (keyEvent)) {
return true;
}
OnKeyDownContinued = true;
return CancelVirtualMethods;
}
public override bool? OnInvokingKeyBindings (Key keyEvent)
{
bool? handled = base.OnInvokingKeyBindings (keyEvent);
if (handled != null && (bool)handled) {
return true;
}
OnInvokingKeyBindingsContinued = true;
return CancelVirtualMethods;
}
public override bool OnProcessKeyDown (Key keyEvent)
{
if (base.OnProcessKeyDown (keyEvent)) {
return true;
}
OnKeyPressedContinued = true;
return CancelVirtualMethods;
}
public override bool OnKeyUp (Key keyEvent)
{
if (base.OnKeyUp (keyEvent)) {
return true;
}
OnKeyUpContinued = true;
return CancelVirtualMethods;
}
}
[Theory]
[InlineData (true, false, false)]
[InlineData (true, true, false)]
[InlineData (true, true, true)]
public void Events_Are_Called_With_Only_Key_Modifiers (bool shift, bool alt, bool control)
{
bool keyDown = false;
bool keyPressed = false;
bool keyUp = false;
var view = new OnKeyTestView ();
view.CancelVirtualMethods = false;
view.KeyDown += (s, e) => {
Assert.Equal (KeyCode.Null, e.KeyCode & ~KeyCode.CtrlMask & ~KeyCode.AltMask & ~KeyCode.ShiftMask);
Assert.Equal (shift, e.IsShift);
Assert.Equal (alt, e.IsAlt);
Assert.Equal (control, e.IsCtrl);
Assert.False (keyDown);
Assert.False (view.OnKeyDownContinued);
keyDown = true;
};
view.ProcessKeyDown += (s, e) => {
keyPressed = true;
};
view.KeyUp += (s, e) => {
Assert.Equal (KeyCode.Null, e.KeyCode & ~KeyCode.CtrlMask & ~KeyCode.AltMask & ~KeyCode.ShiftMask);
Assert.Equal (shift, e.IsShift);
Assert.Equal (alt, e.IsAlt);
Assert.Equal (control, e.IsCtrl);
Assert.False (keyUp);
Assert.False (view.OnKeyUpContinued);
keyUp = true;
};
//view.ProcessKeyDownEvent (new (Key.Null | (shift ? Key.ShiftMask : 0) | (alt ? Key.AltMask : 0) | (control ? Key.CtrlMask : 0)));
//Assert.True (keyDown);
//Assert.True (view.OnKeyDownWasCalled);
//Assert.True (view.OnProcessKeyDownWasCalled);
view.NewKeyDownEvent (new Key (KeyCode.Null | (shift ? KeyCode.ShiftMask : 0) | (alt ? KeyCode.AltMask : 0) | (control ? KeyCode.CtrlMask : 0)));
Assert.True (keyPressed);
Assert.True (view.OnKeyDownContinued);
Assert.True (view.OnKeyPressedContinued);
view.NewKeyUpEvent (new Key (KeyCode.Null | (shift ? KeyCode.ShiftMask : 0) | (alt ? KeyCode.AltMask : 0) | (control ? KeyCode.CtrlMask : 0)));
Assert.True (keyUp);
Assert.True (view.OnKeyUpContinued);
}
/// <summary>
/// This tests that when a new key down event is sent to the view
/// the view will fire the 3 key-down related events: KeyDown, InvokingKeyBindings, and ProcessKeyDown.
/// Note that KeyUp is independent.
/// </summary>
[Fact]
public void AllViews_KeyDown_All_EventsFire ()
{
foreach (var view in TestHelpers.GetAllViews ()) {
if (view == null) {
_output.WriteLine ($"ERROR: null view from {nameof (TestHelpers.GetAllViews)}");
continue;
}
_output.WriteLine ($"Testing {view.GetType ().Name}");
bool keyDown = false;
view.KeyDown += (s, a) => {
a.Handled = false; // don't handle it so the other events are called
keyDown = true;
};
bool invokingKeyBindings = false;
view.InvokingKeyBindings += (s, a) => {
a.Handled = false; // don't handle it so the other events are called
invokingKeyBindings = true;
};
bool keyDownProcessed = false;
view.ProcessKeyDown += (s, a) => {
a.Handled = true;
keyDownProcessed = true;
};
Assert.True (view.NewKeyDownEvent (Key.A)); // this will be true because the ProcessKeyDown event handled it
Assert.True (keyDown);
Assert.True (invokingKeyBindings);
Assert.True (keyDownProcessed);
view.Dispose ();
}
}
/// <summary>
/// This tests that when a new key up event is sent to the view
/// the view will fire the 1 key-up related event: KeyUp
/// </summary>
[Fact]
public void AllViews_KeyUp_All_EventsFire ()
{
foreach (var view in TestHelpers.GetAllViews ()) {
if (view == null) {
_output.WriteLine ($"ERROR: null view from {nameof (TestHelpers.GetAllViews)}");
continue;
}
_output.WriteLine ($"Testing {view.GetType ().Name}");
bool keyUp = false;
view.KeyUp += (s, a) => {
a.Handled = true;
keyUp = true;
};
Assert.True (view.NewKeyUpEvent (Key.A)); // this will be true because the KeyUp event handled it
Assert.True (keyUp);
view.Dispose ();
}
}
}