mirror of
https://github.com/gui-cs/Terminal.Gui.git
synced 2025-12-28 16:58:01 +01:00
* Consider width2 chars that are not IsBmp
* Apply same fix in WindowsDriver
* Explicitly use type of local variable
* Revert changes to WindowsDriver
* Assume we are running in a terminal that supports true color by default unless user explicitly forces 16
* Switch to SetAttribute and WriteConsole instead of WriteConsoleOutput for 16 color mode
* Fix some cursor issues (WIP)
* Remove concept of 'dirty rows' from v2 as its never actually used
* Remove damageRegion as it does nothing
* Make string builder to console writing simpler
* Radically simplify Write method
* Simplify conditional logic
* Simplify restoring cursor position
* Reference local variable for console buffer
* Reduce calls to ConsoleWrite by accumulating till attribute changes
* When resizing v2 16 color mode on windows, recreate the back buffer to match its size
* Fixes for VTS enabled
* Fix _lastSize never being assigned
* Fixes VTS for Force16Colors
* Fixes force16Colors in VTS
* Fixes escape sequences always echoing in non-VTS
* Force Force16Colors in non-VTS. It have a bug in adding a newline in the last line
* WIP Add base class for NetOutput
* Abstract away how we change attribute
* WIP - Make WindowsOutput use base class
* WIP working to fix set cursor position
* Remove commented out code
* Fixes legacy output mode
* Fixes size with no alt buffer supported on VTS and size restore after maximized.
* Fix set cursor which also fixes the broken surrogate pairs
* Add force parameter
* Fixes an issue that only happens with Windows Terminal when paste surrogate pairs by press Ctrl+V
* In Windows escape sequences must be sent during the lifetime of the console which is created in input handle
* Ensure flush the input buffer before reset the console
* Flush input buffer before reset console in v2win
* Fixes issue in v2net not being refreshing the menu bar at start
* Only force layout and draw on size changed.
* Fix v2net issue not draw first line by forcing set cursor position
* Set _lastCursorPosition nullable and remove bool force from set cursor position
* Remove force parameter
* Add v2 version of fake driver attribute
* Make direct replacement and wire up window resizing events
* Update casts to use V2 fake driver instead
* Adjust interfaces to expose less internals
* Fix not raising iteration event in v2
* WIP investigate what it takes to do resize and redraw using TextAlignment_Centered as example
* Sketch adding component factory
* Create relevant fake component factories
* Add window size monitor into factory
* Fake size monitor injecting
* Add helper for faking console resize in AutoInitShutdown tests
* Fix size setting in FakeDriverV2
* Switch to new method
* Fix IsLegacy becoming false when using blank constructor
* Fix for Ready not being raised when showing same top twice also fixes garbage collection issue if running millions of top levels
* Fix tests
* Remove auto init
* Restore conditional compilation stuff
* Restore 'if running unit tests' logic
* Check only for the output being specific classes for the suppression
* Fix ShadowView blowing up with index out of bounds error
* Fix resize in fluent tests
* Fix for people using Iteration call directly
* Fix more calls to iteration to use
AutoInitShutdownAttribute.RunIteration ();
* Add comment
* Remove assumption that Run with prior view not disposed should throw
* Fix timings in Dialog_Opened_From_Another_Dialog
* Fix Zero_Buttons_Works
* Standardize and fix Button_IsDefault_True_Return_His_Index_On_Accepting
* Fix iteration counts on MessageBoxTests
* Fix WizartTests and DrawTests_Ruler
* Implement SendKeys into ConsoleDriverFacade
* Fix SendKeys in console driver facade such that FileDialogTests works
Fix when Clip is null in popover
* Add missing dispose call to test
* Fix support for Esc in facade SendKeys
* Fix AutocompleteTests
* Fix various tests
* Replace LayoutAndDraw with run iteration
* Fix draw issues
* fix draw order
* Fix run iteration calls
* Fix unit tests
* Fix SendKeys in facade.
* Manipulate upper and lower cases.
* Add IsValidInput method to the interface.
* Fix SendKeys scenario
* Fixes surrogate pairs in the label
* Make tests more sensible - they are testing draw functionality. Callbacks do not need to happen in Iteration method
* Fix tests and harden cleanup in AutoInitShutdownAttribute v2 lifecycle dispose
* Delete extra create input call
* Fix mocks and order of exceptions thrown in Run when things are not initialized
* Revert use of `MapConsoleKeyInfoToKeyCode`
* Ignore casing as it is not what test is really about
* Clear application top and top levels before each auto init shutdown test
* Fix for unstable tests
* Restore actually working SendKeys code
* option to pass logger in fluent ctor
* restore ToArray
* Fix SendKeys method and add extension to unit test
* Leverage the EscSeqUtils.MapConsoleKeyInfo method to avoid duplicate code
* Remove unnecessary hack
* Using only KeyCode for rKeys
* Recover modifier keys in surrogate pairs
* Reformat
* Remove iteration limit for benchmarking in v2
* remove iteration delay to identify bugs
* Remove nudge to unique key and make Then run on UI thread
* fix fluid assertions
* Ensure UI operations all happen on UI thread
* Add explicit error for WaitIteration during an invoke
* Remove timeout added for debug
* Catch failing asserts better
* Fix screenshot
* Fix null ref
* Fix race condition in processing input
* Test fixing
* Standardize asserts
* Remove calls to layout and draw, remove pointless lock and enable reading Cancelled from Dialog even if it is disposed
* fix bad merge
* Make logs access threadsafe
* add extra wait to remove race between iteration end and assert
* Code cleanup
* Remove test for crash on access Cancelled after dispose as this is no longer a restriction
* Change resize console to run on UI thread - fixing race condition with redrawing
* Restore original frame rate after test
* Restore nudge to unique key
* Code Cleanup
* Fix for cascading failures when an assert fails in a specific test
* fix for bad merge
* Address PR feedback
* Move classes to seperate files and add xmldoc
* xml doc warnings
* More xml comments docs
* Fix spelling
---------
Co-authored-by: BDisp <bd.bdisp@gmail.com>
305 lines
9.1 KiB
C#
305 lines
9.1 KiB
C#
#nullable enable
|
||
using System.Text;
|
||
using UnitTests;
|
||
using Xunit.Abstractions;
|
||
|
||
namespace Terminal.Gui.ViewTests;
|
||
|
||
[Trait ("Category", "Output")]
|
||
public class ClipTests (ITestOutputHelper _output)
|
||
{
|
||
[Fact]
|
||
[SetupFakeDriver]
|
||
public void Move_Is_Not_Constrained_To_Viewport ()
|
||
{
|
||
var view = new View
|
||
{
|
||
X = 1,
|
||
Y = 1,
|
||
Width = 3, Height = 3
|
||
};
|
||
view.Margin!.Thickness = new (1);
|
||
|
||
view.Move (0, 0);
|
||
Assert.Equal (new (2, 2), new Point (Application.Driver!.Col, Application.Driver!.Row));
|
||
|
||
view.Move (-1, -1);
|
||
Assert.Equal (new (1, 1), new Point (Application.Driver!.Col, Application.Driver!.Row));
|
||
|
||
view.Move (1, 1);
|
||
Assert.Equal (new (3, 3), new Point (Application.Driver!.Col, Application.Driver!.Row));
|
||
}
|
||
|
||
[Fact]
|
||
[SetupFakeDriver]
|
||
public void AddRune_Is_Constrained_To_Viewport ()
|
||
{
|
||
var view = new View
|
||
{
|
||
X = 1,
|
||
Y = 1,
|
||
Width = 3, Height = 3
|
||
};
|
||
view.Padding!.Thickness = new (1);
|
||
view.Padding.Diagnostics = ViewDiagnosticFlags.Thickness;
|
||
view.BeginInit ();
|
||
view.EndInit ();
|
||
view.Draw ();
|
||
|
||
// Only valid location w/in Viewport is 0, 0 (view) - 2, 2 (screen)
|
||
Assert.Equal ((Rune)' ', Application.Driver?.Contents! [2, 2].Rune);
|
||
|
||
// When we exit Draw, the view is excluded from the clip. So drawing at 0,0, is not valid and is clipped.
|
||
view.AddRune (0, 0, Rune.ReplacementChar);
|
||
Assert.Equal ((Rune)' ', Application.Driver?.Contents! [2, 2].Rune);
|
||
|
||
view.AddRune (-1, -1, Rune.ReplacementChar);
|
||
Assert.Equal ((Rune)'P', Application.Driver?.Contents! [1, 1].Rune);
|
||
|
||
view.AddRune (1, 1, Rune.ReplacementChar);
|
||
Assert.Equal ((Rune)'P', Application.Driver?.Contents! [3, 3].Rune);
|
||
}
|
||
|
||
[Theory]
|
||
[InlineData (0, 0, 1, 1)]
|
||
[InlineData (0, 0, 2, 2)]
|
||
[InlineData (-1, -1, 2, 2)]
|
||
[SetupFakeDriver]
|
||
public void FillRect_Fills_HonorsClip (int x, int y, int width, int height)
|
||
{
|
||
var superView = new View { Width = Dim.Fill (), Height = Dim.Fill () };
|
||
|
||
var view = new View
|
||
{
|
||
Text = "X",
|
||
X = 1, Y = 1,
|
||
Width = 3, Height = 3,
|
||
BorderStyle = LineStyle.Single
|
||
};
|
||
superView.Add (view);
|
||
superView.BeginInit ();
|
||
superView.EndInit ();
|
||
superView.LayoutSubViews ();
|
||
|
||
superView.Draw ();
|
||
|
||
DriverAssert.AssertDriverContentsWithFrameAre (
|
||
@"
|
||
┌─┐
|
||
│X│
|
||
└─┘",
|
||
_output);
|
||
|
||
Rectangle toFill = new (x, y, width, height);
|
||
View.SetClipToScreen ();
|
||
view.FillRect (toFill);
|
||
|
||
DriverAssert.AssertDriverContentsWithFrameAre (
|
||
@"
|
||
┌─┐
|
||
│ │
|
||
└─┘",
|
||
_output);
|
||
|
||
// Now try to clear beyond Viewport (invalid; clipping should prevent)
|
||
superView.SetNeedsDraw ();
|
||
superView.Draw ();
|
||
|
||
DriverAssert.AssertDriverContentsWithFrameAre (
|
||
@"
|
||
┌─┐
|
||
│X│
|
||
└─┘",
|
||
_output);
|
||
toFill = new (-width, -height, width, height);
|
||
view.FillRect (toFill);
|
||
|
||
DriverAssert.AssertDriverContentsWithFrameAre (
|
||
@"
|
||
┌─┐
|
||
│X│
|
||
└─┘",
|
||
_output);
|
||
|
||
// Now try to clear beyond Viewport (valid)
|
||
superView.SetNeedsDraw ();
|
||
superView.Draw ();
|
||
|
||
DriverAssert.AssertDriverContentsWithFrameAre (
|
||
@"
|
||
┌─┐
|
||
│X│
|
||
└─┘",
|
||
_output);
|
||
toFill = new (-1, -1, width + 1, height + 1);
|
||
|
||
View.SetClipToScreen ();
|
||
view.FillRect (toFill);
|
||
|
||
DriverAssert.AssertDriverContentsWithFrameAre (
|
||
@"
|
||
┌─┐
|
||
│ │
|
||
└─┘",
|
||
_output);
|
||
|
||
// Now clear too much size
|
||
superView.SetNeedsDraw ();
|
||
superView.Draw ();
|
||
|
||
DriverAssert.AssertDriverContentsWithFrameAre (
|
||
@"
|
||
┌─┐
|
||
│X│
|
||
└─┘",
|
||
_output);
|
||
toFill = new (0, 0, width * 2, height * 2);
|
||
View.SetClipToScreen ();
|
||
view.FillRect (toFill);
|
||
|
||
DriverAssert.AssertDriverContentsWithFrameAre (
|
||
@"
|
||
┌─┐
|
||
│ │
|
||
└─┘",
|
||
_output);
|
||
}
|
||
|
||
// TODO: Simplify this test to just use AddRune directly
|
||
[Fact]
|
||
[SetupFakeDriver]
|
||
[Trait ("Category", "Unicode")]
|
||
public void Clipping_Wide_Runes ()
|
||
{
|
||
((IFakeDriverV2)Application.Driver!).SetBufferSize (30, 1);
|
||
|
||
var top = new View
|
||
{
|
||
Id = "top",
|
||
Width = Dim.Fill (),
|
||
Height = Dim.Fill ()
|
||
};
|
||
|
||
var frameView = new View
|
||
{
|
||
Id = "frameView",
|
||
Width = Dim.Fill (),
|
||
Height = Dim.Fill (),
|
||
Text = """
|
||
これは広いルーンラインです。
|
||
"""
|
||
};
|
||
frameView.Border!.LineStyle = LineStyle.Single;
|
||
frameView.Border.Thickness = new (1, 0, 0, 0);
|
||
|
||
top.Add (frameView);
|
||
View.SetClipToScreen ();
|
||
top.Layout ();
|
||
top.Draw ();
|
||
|
||
var expectedOutput = """
|
||
│これは広いルーンラインです。
|
||
""";
|
||
|
||
DriverAssert.AssertDriverContentsWithFrameAre (expectedOutput, _output);
|
||
|
||
var view = new View
|
||
{
|
||
Text = "0123456789",
|
||
|
||
//Text = "ワイドルー。",
|
||
X = 2,
|
||
Height = Dim.Auto (),
|
||
Width = Dim.Auto (),
|
||
BorderStyle = LineStyle.Single
|
||
};
|
||
view.Border!.Thickness = new (1, 0, 1, 0);
|
||
|
||
top.Add (view);
|
||
top.Layout ();
|
||
View.SetClipToScreen ();
|
||
top.Draw ();
|
||
|
||
// 012345678901234567890123456789012345678
|
||
// 012 34 56 78 90 12 34 56 78 90 12 34 56 78
|
||
// │こ れ は 広 い ル ー ン ラ イ ン で す 。
|
||
// 01 2345678901234 56 78 90 12 34 56
|
||
// │<> |0123456989│<39> ン ラ イ ン で す 。
|
||
expectedOutput = """
|
||
│<EFBFBD>│0123456789│<EFBFBD>ンラインです。
|
||
""";
|
||
|
||
DriverAssert.AssertDriverContentsWithFrameAre (expectedOutput, _output);
|
||
}
|
||
|
||
// TODO: Add more AddRune tests to cover all the cases where wide runes are clipped
|
||
|
||
[Fact]
|
||
[SetupFakeDriver]
|
||
public void SetClip_ClipVisibleContentOnly_VisibleContentIsClipped ()
|
||
{
|
||
// Screen is 25x25
|
||
// View is 25x25
|
||
// Viewport is (0, 0, 23, 23)
|
||
// ContentSize is (10, 10)
|
||
// ViewportToScreen is (1, 1, 23, 23)
|
||
// Visible content is (1, 1, 10, 10)
|
||
// Expected clip is (1, 1, 10, 10) - same as visible content
|
||
Rectangle expectedClip = new (1, 1, 10, 10);
|
||
|
||
// Arrange
|
||
var view = new View
|
||
{
|
||
Width = Dim.Fill (),
|
||
Height = Dim.Fill (),
|
||
ViewportSettings = ViewportSettingsFlags.ClipContentOnly
|
||
};
|
||
view.SetContentSize (new Size (10, 10));
|
||
view.Border!.Thickness = new (1);
|
||
view.BeginInit ();
|
||
view.EndInit ();
|
||
Assert.Equal (view.Frame, View.GetClip ()!.GetBounds ());
|
||
|
||
// Act
|
||
view.AddViewportToClip ();
|
||
|
||
// Assert
|
||
Assert.Equal (expectedClip, View.GetClip ()!.GetBounds ());
|
||
view.Dispose ();
|
||
}
|
||
|
||
[Fact]
|
||
[SetupFakeDriver]
|
||
public void SetClip_Default_ClipsToViewport ()
|
||
{
|
||
// Screen is 25x25
|
||
// View is 25x25
|
||
// Viewport is (0, 0, 23, 23)
|
||
// ContentSize is (10, 10)
|
||
// ViewportToScreen is (1, 1, 23, 23)
|
||
// Visible content is (1, 1, 10, 10)
|
||
// Expected clip is (1, 1, 23, 23) - same as Viewport
|
||
Rectangle expectedClip = new (1, 1, 23, 23);
|
||
|
||
// Arrange
|
||
var view = new View
|
||
{
|
||
Width = Dim.Fill (),
|
||
Height = Dim.Fill ()
|
||
};
|
||
view.SetContentSize (new Size (10, 10));
|
||
view.Border!.Thickness = new (1);
|
||
view.BeginInit ();
|
||
view.EndInit ();
|
||
Assert.Equal (view.Frame, View.GetClip ()!.GetBounds ());
|
||
view.Viewport = view.Viewport with { X = 1, Y = 1 };
|
||
|
||
// Act
|
||
view.AddViewportToClip ();
|
||
|
||
// Assert
|
||
Assert.Equal (expectedClip, View.GetClip ()!.GetBounds ());
|
||
view.Dispose ();
|
||
}
|
||
}
|