mirror of
https://github.com/gui-cs/Terminal.Gui.git
synced 2025-12-26 15:57:56 +01:00
* Initial plan * Refactor Application.Mouse - Create IMouse interface and Mouse implementation Co-authored-by: tig <585482+tig@users.noreply.github.com> * Add enhanced documentation for Application.Mouse property Co-authored-by: tig <585482+tig@users.noreply.github.com> * Add parallelizable unit tests for IMouse interface Co-authored-by: tig <585482+tig@users.noreply.github.com> * Refactor Application.Mouse for decoupling and parallelism Co-authored-by: tig <585482+tig@users.noreply.github.com> * Move HandleMouseGrab method to IMouseGrabHandler interface Co-authored-by: tig <585482+tig@users.noreply.github.com> * Add parallelizable tests for IMouse and IMouseGrabHandler interfaces Co-authored-by: tig <585482+tig@users.noreply.github.com> * Add MouseEventRoutingTests - 27 parallelizable tests for View mouse event handling Co-authored-by: tig <585482+tig@users.noreply.github.com> * Fix terminology: Replace parent/child with superView/subView in MouseEventRoutingTests Co-authored-by: tig <585482+tig@users.noreply.github.com> * Fix coding standards: Use explicit types and target-typed new() in test files Co-authored-by: tig <585482+tig@users.noreply.github.com> * Update coding standards documentation with explicit var and target-typed new() guidance Co-authored-by: tig <585482+tig@users.noreply.github.com> * Refactor Application classes and improve maintainability Refactored `Sixel` property to be immutable, enhancing thread safety. Cleaned up `ApplicationImpl` by removing redundant fields, restructuring methods (`CreateDriver`, `CreateSubcomponents`), and improving exception handling. Updated `Run<T>` and `Shutdown` methods for consistency. Standardized logging/debugging messages and fixed formatting issues. Reorganized `IApplication` interface, added detailed XML documentation, and grouped related methods logically. Performed general code cleanup, including fixing typos, improving readability, and removing legacy/unnecessary code to reduce technical debt. * Code cleanup * Remove unreferenced LayoutAndDraw method from ApplicationImpl * Code cleanup and TODOs - Updated namespaces to reflect the new structure. - Added `Driver`, `Force16Colors`, and `ForceDriver` properties. - Introduced `Sixel` collection for sixel image management. - Added lifecycle methods: `GetDriverTypes`, `Shutdown`, and events. - Refactored `Init` to support legacy and modern drivers. - Improved driver event handling and screen abstraction. - Updated `Run` method to align with the application lifecycle. - Simplified `IConsoleDriver` documentation. - Removed redundant methods and improved code readability. * Refactor LayoutAndDraw logic for better encapsulation Refactored `Application.Run` to delegate `LayoutAndDraw` to `ApplicationImpl.Instance.LayoutAndDraw`, improving separation of concerns. Renamed `forceDraw` to `forceRedraw` for clarity and moved `LayoutAndDraw` implementation to `ApplicationImpl`. Added a new `LayoutAndDraw` method in `ApplicationImpl` to handle layout and drawing, including managing `TopLevels`, handling active popovers, and refreshing the screen. Updated the `IApplication` interface to reflect the new method and improved its documentation. Implemented `RequestStop` in `ApplicationImpl` and fixed formatting inconsistencies in `Run<T>`. Added TODOs for future refactoring to encapsulate `Top` and `TopLevels` into an `IViewHierarchy` and move certain properties to `IApplication`. * Refactor ApplicationImpl to enhance mouse and keyboard support Added a new `Mouse` property to the `ApplicationImpl` class, replacing its previous declaration, to improve mouse functionality. Updated `MouseGrabHandler` to initialize with a default instance of `MouseGrabHandler`. Added comments to ensure the preservation of existing keyboard settings (`QuitKey`, `ArrangeKey`, `NextTabKey`) for backward compatibility. These changes enhance clarity, functionality, and maintainability of the class. * Merge IMouseGrabHandler into IMouse - consolidate mouse handling into single interface Co-authored-by: tig <585482+tig@users.noreply.github.com> * Rename Mouse to MouseImpl and Keyboard to KeyboardImpl for consistency Co-authored-by: tig <585482+tig@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: tig <585482+tig@users.noreply.github.com> Co-authored-by: Tig <tig@users.noreply.github.com>
101 lines
4.0 KiB
C#
101 lines
4.0 KiB
C#
namespace UnitTests.Parallelizable;
|
|
|
|
/// <summary>
|
|
/// Ensures that tests can run in parallel without interference
|
|
/// by setting various Terminal.Gui static properties to their default values. E.g. View.EnableDebugIDisposableAsserts.
|
|
/// Annotate all test classes with [Collection("Global Test Setup")] or have it inherit from this class.
|
|
/// </summary>
|
|
public class GlobalTestSetup : IDisposable
|
|
{
|
|
public GlobalTestSetup ()
|
|
{
|
|
#if DEBUG_IDISPOSABLE
|
|
// Ensure EnableDebugIDisposableAsserts is false before tests run
|
|
View.EnableDebugIDisposableAsserts = false;
|
|
#endif
|
|
CheckDefaultState ();
|
|
}
|
|
|
|
public void Dispose ()
|
|
{
|
|
// Optionally reset EnableDebugIDisposableAsserts after tests. Don't do this.
|
|
// View.EnableDebugIDisposableAsserts = true;
|
|
|
|
// Reset application state just in case a test changed something.
|
|
// TODO: Add an Assert to ensure none of the state of Application changed.
|
|
// TODO: Add an Assert to ensure none of the state of ConfigurationManager changed.
|
|
CheckDefaultState ();
|
|
Application.ResetState (true);
|
|
}
|
|
|
|
// IMPORTANT: Ensure this matches the code in Init_ResetState_Resets_Properties
|
|
// here: .\Tests\UnitTests\Application\ApplicationTests.cs
|
|
private void CheckDefaultState ()
|
|
{
|
|
#if DEBUG_IDISPOSABLE
|
|
Assert.False (View.EnableDebugIDisposableAsserts, "View.EnableDebugIDisposableAsserts should be false for Parallelizable tests.");
|
|
#endif
|
|
|
|
// Check that all Application fields and properties are set to their default values
|
|
|
|
// Public Properties
|
|
Assert.Null (Application.Top);
|
|
Assert.Null (Application.Mouse.MouseGrabView);
|
|
|
|
// Don't check Application.ForceDriver
|
|
// Assert.Empty (Application.ForceDriver);
|
|
// Don't check Application.Force16Colors
|
|
//Assert.False (Application.Force16Colors);
|
|
Assert.Null (Application.Driver);
|
|
Assert.Null (Application.MainLoop);
|
|
Assert.False (Application.EndAfterFirstIteration);
|
|
Assert.Equal (Key.Tab.WithShift, Application.PrevTabKey);
|
|
Assert.Equal (Key.Tab, Application.NextTabKey);
|
|
Assert.Equal (Key.F6.WithShift, Application.PrevTabGroupKey);
|
|
Assert.Equal (Key.F6, Application.NextTabGroupKey);
|
|
Assert.Equal (Key.Esc, Application.QuitKey);
|
|
|
|
// Internal properties
|
|
Assert.False (Application.Initialized);
|
|
Assert.Equal (Application.GetSupportedCultures (), Application.SupportedCultures);
|
|
Assert.Equal (Application.GetAvailableCulturesFromEmbeddedResources (), Application.SupportedCultures);
|
|
Assert.False (Application._forceFakeConsole);
|
|
Assert.Equal (-1, Application.MainThreadId);
|
|
Assert.Empty (Application.TopLevels);
|
|
Assert.Empty (Application.CachedViewsUnderMouse);
|
|
|
|
// Mouse
|
|
// Do not reset _lastMousePosition
|
|
//Assert.Null (Application._lastMousePosition);
|
|
|
|
// Navigation
|
|
Assert.Null (Application.Navigation);
|
|
|
|
// Popover
|
|
Assert.Null (Application.Popover);
|
|
|
|
// Events - Can't check
|
|
//Assert.Null (Application.NotifyNewRunState);
|
|
//Assert.Null (Application.NotifyNewRunState);
|
|
//Assert.Null (Application.Iteration);
|
|
//Assert.Null (Application.SizeChanging);
|
|
//Assert.Null (Application.GrabbedMouse);
|
|
//Assert.Null (Application.UnGrabbingMouse);
|
|
//Assert.Null (Application.GrabbedMouse);
|
|
//Assert.Null (Application.UnGrabbedMouse);
|
|
//Assert.Null (Application.MouseEvent);
|
|
//Assert.Null (Application.KeyDown);
|
|
//Assert.Null (Application.KeyUp);
|
|
}
|
|
|
|
}
|
|
|
|
// Define a collection for the global setup
|
|
[CollectionDefinition ("Global Test Setup")]
|
|
public class GlobalTestSetupCollection : ICollectionFixture<GlobalTestSetup>
|
|
{
|
|
// This class has no code and is never instantiated.
|
|
// Its purpose is to apply the [CollectionDefinition] attribute
|
|
// and associate the GlobalTestSetup with the test collection.
|
|
}
|