mirror of
https://github.com/gui-cs/Terminal.Gui.git
synced 2025-12-26 15:57:56 +01:00
3e1637aac8
* Fixes #2776. Pressing Alt key on a Window with only a MenuBar throws System.InvalidOperationException. * Add unit test. * Fix extra bracket. * Prevents throw exception if Application.Current is null. * Fix unit test because OnLeave is now invoked on toplevel removing, preventing two views having focus. * Fix unit test method name. * Fix Window by not layout on his subviews when adding a new view after the Application.Begin was already running. * FindAndOpenMenuByHotkey now search inside Menus and inside his Children. * Add unit test for Window LayoutSubviews and FindAndOpenChildrenMenuByHotkey menu method. * Prevents button to be clear when it's invisible. * Fixes 2780. Moving a Window that is Application.Top shouldn't be allowed. * Fix condition if Window and Application.Top. * Always LayoutSubviews and PositionToplevels after Clear. * Fixes #2787. MenuItem with CanExecute returning false is select when a MenuBar is opened. * Leveraging the power of CanExecute feature. * Fixes #2789. StatusItem should have a disabled attribute if it can't execute. * Allows positioning a child window outside the limits of the menu and the status bar. * Change to a more appropriate name. * Simplifies all the run actions. * Prevents open menu bar if it's invisible and close all opened menus. * Fix mdi run loop. * Fix hot key on mdi toplevels. * Fix position on mdi toplevels. * Fix Top.Redraw by set state.Toplevel.SetNeedsDisplay if it's needed to redraw. * Fix MdiTop by repainted when a keystroke is generated by keyboard. * Rename local fields. * Force redraw if application.Top needs display. * Added more features to the scenario. * Change the scenarios to run as Application.Top instead of sub-views. * Add a new scenario similar but as Mdi Container. * Add a bunch of new unit tests to prove all this PR. * Only it's need to redraw Application.Top if it's a Mdi Container. * Remove unnecessary code. * Unit test that proves that a MDI child leaves no trace when the location is changed. * Removes unnecessary Application.Init because theses uses Run<T> which already call it. * Ensures a menu bar been closed after run an action. * Ensures that another view can be focused if not IsMenuOpen and LastFocused is null, instead of focused the menu itself. * Ensures a focused contentview subview being focused if MostFocused is null. * Ensures a MdiTop subview to have priority if it's focused and thus make it Current. * Allow a MdiChild be closed when pressing Application.QuitKey. * More unit tests proving the changes. * Ensures the top.MostFocused is focused. * Ensures MdiChild on the front if MdiTop.MostFocused isn't valid, like ContentView. * Add unit test showing MdiChild on the front. * Fix an issue where NullReferenceException can be throws everywhere while get the Application.MdiChildes property. --------- Co-authored-by: Tig <tig@users.noreply.github.com>
368 lines
12 KiB
C#
368 lines
12 KiB
C#
using System;
|
|
using Xunit;
|
|
using Xunit.Abstractions;
|
|
//using GraphViewTests = Terminal.Gui.Views.GraphViewTests;
|
|
|
|
// Alias Console to MockConsole so we don't accidentally use Console
|
|
using Console = Terminal.Gui.FakeConsole;
|
|
using NStack;
|
|
using Terminal.Gui;
|
|
|
|
namespace Terminal.Gui.TopLevelTests {
|
|
public class WindowTests {
|
|
readonly ITestOutputHelper output;
|
|
|
|
public WindowTests (ITestOutputHelper output)
|
|
{
|
|
this.output = output;
|
|
}
|
|
|
|
[Fact]
|
|
public void New_Initializes ()
|
|
{
|
|
// Parameterless
|
|
var r = new Window ();
|
|
Assert.NotNull (r);
|
|
Assert.Equal (ustring.Empty, r.Title);
|
|
Assert.Equal (LayoutStyle.Computed, r.LayoutStyle);
|
|
Assert.Equal ("Window()({X=0,Y=0,Width=0,Height=0})", r.ToString ());
|
|
Assert.True (r.CanFocus);
|
|
Assert.False (r.HasFocus);
|
|
Assert.Equal (new Rect (0, 0, 0, 0), r.Bounds);
|
|
Assert.Equal (new Rect (0, 0, 0, 0), r.Frame);
|
|
Assert.Null (r.Focused);
|
|
Assert.NotNull (r.ColorScheme);
|
|
Assert.Equal (Dim.Fill (0), r.Width);
|
|
Assert.Equal (Dim.Fill (0), r.Height);
|
|
Assert.Null (r.X);
|
|
Assert.Null (r.Y);
|
|
Assert.False (r.IsCurrentTop);
|
|
Assert.Empty (r.Id);
|
|
Assert.NotEmpty (r.Subviews);
|
|
Assert.False (r.WantContinuousButtonPressed);
|
|
Assert.False (r.WantMousePositionReports);
|
|
Assert.Null (r.SuperView);
|
|
Assert.Null (r.MostFocused);
|
|
Assert.Equal (TextDirection.LeftRight_TopBottom, r.TextDirection);
|
|
|
|
// Empty Rect
|
|
r = new Window (Rect.Empty, "title");
|
|
Assert.NotNull (r);
|
|
Assert.Equal ("title", r.Title);
|
|
Assert.Equal (LayoutStyle.Absolute, r.LayoutStyle);
|
|
Assert.Equal ("Window()({X=0,Y=0,Width=0,Height=0})", r.ToString ());
|
|
Assert.True (r.CanFocus);
|
|
Assert.False (r.HasFocus);
|
|
Assert.Equal (new Rect (0, 0, 0, 0), r.Bounds);
|
|
Assert.Equal (new Rect (0, 0, 0, 0), r.Frame);
|
|
Assert.Null (r.Focused);
|
|
Assert.NotNull (r.ColorScheme);
|
|
Assert.Null (r.Width); // All view Dim are initialized now in the IsAdded setter,
|
|
Assert.Null (r.Height); // avoiding Dim errors.
|
|
Assert.Null (r.X); // All view Pos are initialized now in the IsAdded setter,
|
|
Assert.Null (r.Y); // avoiding Pos errors.
|
|
Assert.False (r.IsCurrentTop);
|
|
Assert.Empty (r.Id);
|
|
Assert.NotEmpty (r.Subviews);
|
|
Assert.False (r.WantContinuousButtonPressed);
|
|
Assert.False (r.WantMousePositionReports);
|
|
Assert.Null (r.SuperView);
|
|
Assert.Null (r.MostFocused);
|
|
Assert.Equal (TextDirection.LeftRight_TopBottom, r.TextDirection);
|
|
|
|
// Rect with values
|
|
r = new Window (new Rect (1, 2, 3, 4), "title");
|
|
Assert.Equal ("title", r.Title);
|
|
Assert.NotNull (r);
|
|
Assert.Equal (LayoutStyle.Absolute, r.LayoutStyle);
|
|
Assert.Equal ("Window()({X=1,Y=2,Width=3,Height=4})", r.ToString ());
|
|
Assert.True (r.CanFocus);
|
|
Assert.False (r.HasFocus);
|
|
Assert.Equal (new Rect (0, 0, 3, 4), r.Bounds);
|
|
Assert.Equal (new Rect (1, 2, 3, 4), r.Frame);
|
|
Assert.Null (r.Focused);
|
|
Assert.NotNull (r.ColorScheme);
|
|
Assert.Null (r.Width);
|
|
Assert.Null (r.Height);
|
|
Assert.Null (r.X);
|
|
Assert.Null (r.Y);
|
|
Assert.False (r.IsCurrentTop);
|
|
Assert.Empty (r.Id);
|
|
Assert.NotEmpty (r.Subviews);
|
|
Assert.False (r.WantContinuousButtonPressed);
|
|
Assert.False (r.WantMousePositionReports);
|
|
Assert.Null (r.SuperView);
|
|
Assert.Null (r.MostFocused);
|
|
Assert.Equal (TextDirection.LeftRight_TopBottom, r.TextDirection);
|
|
r.Dispose ();
|
|
}
|
|
|
|
[Fact]
|
|
public void Set_Title_Fires_TitleChanging ()
|
|
{
|
|
var r = new Window ();
|
|
Assert.Equal (ustring.Empty, r.Title);
|
|
|
|
string expectedOld = null;
|
|
string expectedDuring = null;
|
|
string expectedAfter = null;
|
|
bool cancel = false;
|
|
r.TitleChanging += (args) => {
|
|
Assert.Equal (expectedOld, args.OldTitle);
|
|
Assert.Equal (expectedDuring, args.NewTitle);
|
|
args.Cancel = cancel;
|
|
};
|
|
|
|
expectedOld = string.Empty;
|
|
r.Title = expectedDuring = expectedAfter = "title";
|
|
Assert.Equal (expectedAfter, r.Title.ToString ());
|
|
|
|
expectedOld = r.Title.ToString ();
|
|
r.Title = expectedDuring = expectedAfter = "a different title";
|
|
Assert.Equal (expectedAfter, r.Title.ToString ());
|
|
|
|
// Now setup cancelling the change and change it back to "title"
|
|
cancel = true;
|
|
expectedOld = r.Title.ToString ();
|
|
r.Title = expectedDuring = "title";
|
|
Assert.Equal (expectedAfter, r.Title.ToString ());
|
|
r.Dispose ();
|
|
|
|
}
|
|
|
|
[Fact]
|
|
public void Set_Title_Fires_TitleChanged ()
|
|
{
|
|
var r = new Window ();
|
|
Assert.Equal (ustring.Empty, r.Title);
|
|
|
|
string expectedOld = null;
|
|
string expected = null;
|
|
r.TitleChanged += (args) => {
|
|
Assert.Equal (expectedOld, args.OldTitle);
|
|
Assert.Equal (r.Title, args.NewTitle);
|
|
};
|
|
|
|
expected = "title";
|
|
expectedOld = r.Title.ToString ();
|
|
r.Title = expected;
|
|
Assert.Equal (expected, r.Title.ToString ());
|
|
|
|
expected = "another title";
|
|
expectedOld = r.Title.ToString ();
|
|
r.Title = expected;
|
|
Assert.Equal (expected, r.Title.ToString ());
|
|
r.Dispose ();
|
|
}
|
|
|
|
[Fact, AutoInitShutdown]
|
|
public void MenuBar_And_StatusBar_Inside_Window ()
|
|
{
|
|
var menu = new MenuBar (new MenuBarItem [] {
|
|
new MenuBarItem ("File", new MenuItem [] {
|
|
new MenuItem ("Open", "", null),
|
|
new MenuItem ("Quit", "", null),
|
|
}),
|
|
new MenuBarItem ("Edit", new MenuItem [] {
|
|
new MenuItem ("Copy", "", null),
|
|
})
|
|
});
|
|
|
|
var sb = new StatusBar (new StatusItem [] {
|
|
new StatusItem (Key.CtrlMask | Key.Q, "~^Q~ Quit", null),
|
|
new StatusItem (Key.CtrlMask | Key.O, "~^O~ Open", null),
|
|
new StatusItem (Key.CtrlMask | Key.C, "~^C~ Copy", null),
|
|
});
|
|
|
|
var fv = new FrameView ("Frame View") {
|
|
Y = 1,
|
|
Width = Dim.Fill (),
|
|
Height = Dim.Fill (1)
|
|
};
|
|
var win = new Window ();
|
|
win.Add (menu, sb, fv);
|
|
var top = Application.Top;
|
|
top.Add (win);
|
|
Application.Begin (top);
|
|
((FakeDriver)Application.Driver).SetBufferSize (20, 10);
|
|
|
|
TestHelpers.AssertDriverContentsWithFrameAre (@"
|
|
┌──────────────────┐
|
|
│ File Edit │
|
|
│┌ Frame View ────┐│
|
|
││ ││
|
|
││ ││
|
|
││ ││
|
|
││ ││
|
|
│└────────────────┘│
|
|
│ ^Q Quit │ ^O Open│
|
|
└──────────────────┘", output);
|
|
|
|
((FakeDriver)Application.Driver).SetBufferSize (40, 20);
|
|
|
|
TestHelpers.AssertDriverContentsWithFrameAre (@"
|
|
┌──────────────────────────────────────┐
|
|
│ File Edit │
|
|
│┌ Frame View ────────────────────────┐│
|
|
││ ││
|
|
││ ││
|
|
││ ││
|
|
││ ││
|
|
││ ││
|
|
││ ││
|
|
││ ││
|
|
││ ││
|
|
││ ││
|
|
││ ││
|
|
││ ││
|
|
││ ││
|
|
││ ││
|
|
││ ││
|
|
│└────────────────────────────────────┘│
|
|
│ ^Q Quit │ ^O Open │ ^C Copy │
|
|
└──────────────────────────────────────┘", output);
|
|
|
|
((FakeDriver)Application.Driver).SetBufferSize (20, 10);
|
|
|
|
TestHelpers.AssertDriverContentsWithFrameAre (@"
|
|
┌──────────────────┐
|
|
│ File Edit │
|
|
│┌ Frame View ────┐│
|
|
││ ││
|
|
││ ││
|
|
││ ││
|
|
││ ││
|
|
│└────────────────┘│
|
|
│ ^Q Quit │ ^O Open│
|
|
└──────────────────┘", output);
|
|
}
|
|
|
|
[Fact, AutoInitShutdown]
|
|
public void Activating_MenuBar_By_Alt_Key_Does_Not_Throw ()
|
|
{
|
|
var menu = new MenuBar (new MenuBarItem [] {
|
|
new MenuBarItem ("Child", new MenuItem [] {
|
|
new MenuItem ("_Create Child", "", null)
|
|
})
|
|
});
|
|
var win = new Window ();
|
|
win.Add (menu);
|
|
Application.Top.Add (win);
|
|
Application.Begin (Application.Top);
|
|
|
|
var exception = Record.Exception (() => win.ProcessHotKey (new KeyEvent (Key.AltMask, new KeyModifiers { Alt = true })));
|
|
Assert.Null (exception);
|
|
}
|
|
|
|
[Fact, AutoInitShutdown]
|
|
public void Adding_Center_Window_Child_To_Window_Parent_Always_LayoutSubviews ()
|
|
{
|
|
var parentWin = new Window ();
|
|
View childWin = null;
|
|
|
|
var menu = new MenuBar (new MenuBarItem [] {
|
|
new MenuBarItem ("Child", new MenuItem [] {
|
|
new MenuItem ("_Create Child", "", () => {
|
|
childWin = new Window () {
|
|
X = Pos.Center (),
|
|
Y = Pos.Center (),
|
|
Width = 10,
|
|
Height = 10
|
|
};
|
|
parentWin.Add (childWin);
|
|
})
|
|
}),
|
|
new MenuBarItem ("View", new MenuBarItem [] {
|
|
new MenuBarItem ("Create", new MenuItem [] {
|
|
new MenuItem("_TextField", "", () => {
|
|
var tf = new TextField ("Test") {
|
|
X = Pos.Center (),
|
|
Y = Pos.Center (),
|
|
Width = 5
|
|
};
|
|
childWin.Add (tf);
|
|
})
|
|
})
|
|
})
|
|
});
|
|
|
|
parentWin.Add (menu);
|
|
Application.Top.Add (parentWin);
|
|
Application.Begin (Application.Top);
|
|
((FakeDriver)Application.Driver).SetBufferSize (20, 20);
|
|
|
|
TestHelpers.AssertDriverContentsWithFrameAre (@"
|
|
┌──────────────────┐
|
|
│ Child View │
|
|
│ │
|
|
│ │
|
|
│ │
|
|
│ │
|
|
│ │
|
|
│ │
|
|
│ │
|
|
│ │
|
|
│ │
|
|
│ │
|
|
│ │
|
|
│ │
|
|
│ │
|
|
│ │
|
|
│ │
|
|
│ │
|
|
│ │
|
|
└──────────────────┘", output);
|
|
|
|
Assert.True (parentWin.ProcessHotKey (new KeyEvent (Key.C | Key.AltMask, new KeyModifiers { Alt = true })));
|
|
Application.MainLoop.MainIteration ();
|
|
parentWin.Redraw (parentWin.Bounds);
|
|
TestHelpers.AssertDriverContentsWithFrameAre (@"
|
|
┌──────────────────┐
|
|
│ Child View │
|
|
│ │
|
|
│ │
|
|
│ │
|
|
│ ┌────────┐ │
|
|
│ │ │ │
|
|
│ │ │ │
|
|
│ │ │ │
|
|
│ │ │ │
|
|
│ │ │ │
|
|
│ │ │ │
|
|
│ │ │ │
|
|
│ │ │ │
|
|
│ └────────┘ │
|
|
│ │
|
|
│ │
|
|
│ │
|
|
│ │
|
|
└──────────────────┘", output);
|
|
|
|
Assert.True (parentWin.ProcessHotKey (new KeyEvent (Key.T | Key.AltMask, new KeyModifiers { Alt = true })));
|
|
Application.MainLoop.MainIteration ();
|
|
childWin.Redraw (childWin.Bounds);
|
|
TestHelpers.AssertDriverContentsWithFrameAre (@"
|
|
┌──────────────────┐
|
|
│ Child View │
|
|
│ │
|
|
│ │
|
|
│ │
|
|
│ ┌────────┐ │
|
|
│ │ │ │
|
|
│ │ │ │
|
|
│ │ │ │
|
|
│ │ Test │ │
|
|
│ │ │ │
|
|
│ │ │ │
|
|
│ │ │ │
|
|
│ │ │ │
|
|
│ └────────┘ │
|
|
│ │
|
|
│ │
|
|
│ │
|
|
│ │
|
|
└──────────────────┘", output);
|
|
}
|
|
}
|
|
}
|