mirror of
https://github.com/gui-cs/Terminal.Gui.git
synced 2025-12-26 07:47:54 +01:00
* Initial plan
* Rename Command.Select to Command.Activate and Selecting to Activating
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Add Activating event propagation to SuperView
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Update all comments and docs referencing Select to Activate
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Fix event log messages in examples to use Activating/Activate
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Revert automatic Activating event propagation that broke tests
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Update docfx documentation to use Activate/Activating terminology
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* renames
* Revert "Add Activating event propagation to SuperView"
This reverts commit 6d82bee9ad.
* added command diagrams
* mermaid
* updated level 3
* again
* Select->Activate in MouseTests.cs
* Update Terminal.Gui/Views/Selectors/FlagSelector.cs
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Refactor: Rename Selecting to Activating in View APIs
Renamed the `Selecting` event and `OnSelecting` method to
`Activating` and `OnActivating` to better reflect their purpose.
Updated all related comments, test method names, variables,
and assertions in `View` and `ViewCommandTests` to align with
the new terminology.
Improved code clarity by using `_` for unused parameters in
lambda expressions. Renamed properties like `HandleSelecting`
to `HandleActivating` and adjusted naming conventions for
consistency (e.g., `OnactivatingCount` to `OnActivatingCount`).
These changes enhance readability, maintainability, and
terminology consistency across the codebase.
* Update Terminal.Gui/Views/Selectors/OptionSelector.cs
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Typos
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: tig <585482+tig@users.noreply.github.com>
Co-authored-by: Tig <tig@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
474 lines
13 KiB
C#
474 lines
13 KiB
C#
|
|
namespace ViewBaseTests.Commands;
|
|
public class ViewCommandTests
|
|
{
|
|
#region OnAccept/Accept tests
|
|
|
|
[Fact]
|
|
public void Accept_Command_Raises_NoFocus ()
|
|
{
|
|
var view = new ViewEventTester ();
|
|
Assert.False (view.HasFocus);
|
|
|
|
Assert.False (view.InvokeCommand (Command.Accept)); // there's no superview, so it should return true?
|
|
|
|
Assert.Equal (1, view.OnAcceptedCount);
|
|
|
|
Assert.Equal (1, view.AcceptedCount);
|
|
|
|
Assert.False (view.HasFocus);
|
|
}
|
|
|
|
[Fact]
|
|
public void Accept_Command_Handle_OnAccept_NoEvent ()
|
|
{
|
|
var view = new ViewEventTester ();
|
|
Assert.False (view.HasFocus);
|
|
|
|
view.HandleOnAccepted = true;
|
|
Assert.True (view.InvokeCommand (Command.Accept));
|
|
|
|
Assert.Equal (1, view.OnAcceptedCount);
|
|
|
|
Assert.Equal (0, view.AcceptedCount);
|
|
}
|
|
|
|
[Fact]
|
|
public void Accept_Handle_Event_OnAccept_Returns_True ()
|
|
{
|
|
var view = new View ();
|
|
var acceptInvoked = false;
|
|
|
|
view.Accepting += ViewOnAccept;
|
|
|
|
bool? ret = view.InvokeCommand (Command.Accept);
|
|
Assert.True (ret);
|
|
Assert.True (acceptInvoked);
|
|
|
|
return;
|
|
|
|
void ViewOnAccept (object? sender, CommandEventArgs e)
|
|
{
|
|
acceptInvoked = true;
|
|
e.Handled = true;
|
|
}
|
|
}
|
|
|
|
[Fact]
|
|
public void Accept_Command_Invokes_Accept_Event ()
|
|
{
|
|
var view = new View ();
|
|
var accepted = false;
|
|
|
|
view.Accepting += ViewOnAccept;
|
|
|
|
view.InvokeCommand (Command.Accept);
|
|
Assert.True (accepted);
|
|
|
|
return;
|
|
|
|
void ViewOnAccept (object? sender, CommandEventArgs e) { accepted = true; }
|
|
}
|
|
|
|
// Accept on subview should bubble up to parent
|
|
[Fact]
|
|
public void Accept_Command_Bubbles_Up_To_SuperView ()
|
|
{
|
|
var view = new ViewEventTester { Id = "view" };
|
|
var subview = new ViewEventTester { Id = "subview" };
|
|
view.Add (subview);
|
|
|
|
subview.InvokeCommand (Command.Accept);
|
|
Assert.Equal (1, subview.OnAcceptedCount);
|
|
Assert.Equal (1, view.OnAcceptedCount);
|
|
|
|
subview.HandleOnAccepted = true;
|
|
subview.InvokeCommand (Command.Accept);
|
|
Assert.Equal (2, subview.OnAcceptedCount);
|
|
Assert.Equal (1, view.OnAcceptedCount);
|
|
|
|
subview.HandleOnAccepted = false;
|
|
subview.HandleAccepted = true;
|
|
subview.InvokeCommand (Command.Accept);
|
|
Assert.Equal (3, subview.OnAcceptedCount);
|
|
Assert.Equal (1, view.OnAcceptedCount);
|
|
|
|
// Add a super view to test deeper hierarchy
|
|
var superView = new ViewEventTester { Id = "superView" };
|
|
superView.Add (view);
|
|
|
|
subview.InvokeCommand (Command.Accept);
|
|
Assert.Equal (4, subview.OnAcceptedCount);
|
|
Assert.Equal (1, view.OnAcceptedCount);
|
|
Assert.Equal (0, superView.OnAcceptedCount);
|
|
|
|
subview.HandleAccepted = false;
|
|
subview.InvokeCommand (Command.Accept);
|
|
Assert.Equal (5, subview.OnAcceptedCount);
|
|
Assert.Equal (2, view.OnAcceptedCount);
|
|
Assert.Equal (1, superView.OnAcceptedCount);
|
|
|
|
view.HandleAccepted = true;
|
|
subview.InvokeCommand (Command.Accept);
|
|
Assert.Equal (6, subview.OnAcceptedCount);
|
|
Assert.Equal (3, view.OnAcceptedCount);
|
|
Assert.Equal (1, superView.OnAcceptedCount);
|
|
}
|
|
|
|
[Fact]
|
|
public void MouseClick_Does_Not_Invoke_Accept_Command ()
|
|
{
|
|
var view = new ViewEventTester ();
|
|
view.NewMouseEvent (new () { Flags = MouseFlags.Button1Clicked, Position = Point.Empty, View = view });
|
|
|
|
Assert.Equal (0, view.OnAcceptedCount);
|
|
}
|
|
|
|
#endregion OnAccept/Accept tests
|
|
|
|
#region Accepted tests
|
|
|
|
[Fact]
|
|
public void Accepted_Event_Is_Raised_After_Accepting_When_Handled ()
|
|
{
|
|
View view = new ();
|
|
var acceptingInvoked = false;
|
|
var acceptedInvoked = false;
|
|
|
|
view.Accepting += (sender, e) =>
|
|
{
|
|
acceptingInvoked = true;
|
|
e.Handled = true;
|
|
};
|
|
|
|
view.Accepted += (sender, e) =>
|
|
{
|
|
acceptedInvoked = true;
|
|
Assert.True (acceptingInvoked); // Accepting should be raised first
|
|
};
|
|
|
|
bool? ret = view.InvokeCommand (Command.Accept);
|
|
Assert.True (ret);
|
|
Assert.True (acceptingInvoked);
|
|
Assert.True (acceptedInvoked);
|
|
}
|
|
|
|
[Fact]
|
|
public void Accepted_Event_Not_Raised_When_Accepting_Not_Handled ()
|
|
{
|
|
View view = new ();
|
|
var acceptingInvoked = false;
|
|
var acceptedInvoked = false;
|
|
|
|
view.Accepting += (sender, e) =>
|
|
{
|
|
acceptingInvoked = true;
|
|
e.Handled = false;
|
|
};
|
|
|
|
view.Accepted += (sender, e) =>
|
|
{
|
|
acceptedInvoked = true;
|
|
};
|
|
|
|
// When not handled, Accept bubbles to SuperView, so returns false (no superview)
|
|
bool? ret = view.InvokeCommand (Command.Accept);
|
|
Assert.False (ret);
|
|
Assert.True (acceptingInvoked);
|
|
Assert.False (acceptedInvoked); // Should not be invoked when not handled
|
|
}
|
|
|
|
[Fact]
|
|
public void Accepted_Event_Cannot_Be_Cancelled ()
|
|
{
|
|
View view = new ();
|
|
var acceptedInvoked = false;
|
|
|
|
view.Accepting += (sender, e) =>
|
|
{
|
|
e.Handled = true;
|
|
};
|
|
|
|
view.Accepted += (sender, e) =>
|
|
{
|
|
acceptedInvoked = true;
|
|
// Accepted event has Handled property but it doesn't affect flow
|
|
e.Handled = false;
|
|
};
|
|
|
|
bool? ret = view.InvokeCommand (Command.Accept);
|
|
Assert.True (ret);
|
|
Assert.True (acceptedInvoked);
|
|
}
|
|
|
|
[Fact]
|
|
public void OnAccepted_Called_When_Accepting_Handled ()
|
|
{
|
|
OnAcceptedTestView view = new ();
|
|
|
|
view.Accepting += (sender, e) =>
|
|
{
|
|
e.Handled = true;
|
|
};
|
|
|
|
view.InvokeCommand (Command.Accept);
|
|
Assert.Equal (1, view.OnAcceptedCallCount);
|
|
}
|
|
|
|
[Fact]
|
|
public void OnAccepted_Not_Called_When_Accepting_Not_Handled ()
|
|
{
|
|
OnAcceptedTestView view = new ();
|
|
|
|
view.Accepting += (sender, e) =>
|
|
{
|
|
e.Handled = false;
|
|
};
|
|
|
|
view.InvokeCommand (Command.Accept);
|
|
Assert.Equal (0, view.OnAcceptedCallCount);
|
|
}
|
|
|
|
private class OnAcceptedTestView : View
|
|
{
|
|
public int OnAcceptedCallCount { get; private set; }
|
|
|
|
protected override void OnAccepted (CommandEventArgs args)
|
|
{
|
|
OnAcceptedCallCount++;
|
|
base.OnAccepted (args);
|
|
}
|
|
}
|
|
|
|
#endregion Accepted tests
|
|
|
|
#region OnActivating/Activating tests
|
|
|
|
[Theory]
|
|
[CombinatorialData]
|
|
public void Activate_Command_Raises_SetsFocus (bool canFocus)
|
|
{
|
|
var view = new ViewEventTester
|
|
{
|
|
CanFocus = canFocus
|
|
};
|
|
|
|
Assert.Equal (canFocus, view.CanFocus);
|
|
Assert.False (view.HasFocus);
|
|
|
|
view.InvokeCommand (Command.Activate);
|
|
|
|
Assert.Equal (1, view.OnActivatingCount);
|
|
|
|
Assert.Equal (1, view.ActivatingCount);
|
|
|
|
Assert.Equal (canFocus, view.HasFocus);
|
|
}
|
|
|
|
[Fact]
|
|
public void Activate_Command_Handle_OnActivating_NoEvent ()
|
|
{
|
|
var view = new ViewEventTester ();
|
|
Assert.False (view.HasFocus);
|
|
|
|
view.HandleOnActivating = true;
|
|
Assert.True (view.InvokeCommand (Command.Activate));
|
|
|
|
Assert.Equal (1, view.OnActivatingCount);
|
|
|
|
Assert.Equal (0, view.ActivatingCount);
|
|
}
|
|
|
|
[Fact]
|
|
public void Activate_Command_Handle_Event_OnActivating_Returns_True ()
|
|
{
|
|
var view = new View ();
|
|
var activatingInvoked = false;
|
|
|
|
view.Activating += ViewOnActivating;
|
|
|
|
bool? ret = view.InvokeCommand (Command.Activate);
|
|
Assert.True (ret);
|
|
Assert.True (activatingInvoked);
|
|
|
|
return;
|
|
|
|
void ViewOnActivating (object? sender, CommandEventArgs e)
|
|
{
|
|
activatingInvoked = true;
|
|
e.Handled = true;
|
|
}
|
|
}
|
|
|
|
[Fact]
|
|
public void Activate_Command_Invokes_Activating_Event ()
|
|
{
|
|
var view = new View ();
|
|
var activating = false;
|
|
|
|
view.Activating += ViewOnActivating;
|
|
|
|
view.InvokeCommand (Command.Activate);
|
|
Assert.True (activating);
|
|
|
|
return;
|
|
|
|
void ViewOnActivating (object? sender, CommandEventArgs e) { activating = true; }
|
|
}
|
|
|
|
[Fact]
|
|
public void MouseClick_Invokes_Activate_Command ()
|
|
{
|
|
var view = new ViewEventTester ();
|
|
view.NewMouseEvent (new () { Flags = MouseFlags.Button1Clicked, Position = Point.Empty, View = view });
|
|
|
|
Assert.Equal (1, view.OnActivatingCount);
|
|
}
|
|
|
|
#endregion OnActivating/Activating tests
|
|
|
|
#region OnHotKey/HotKey tests
|
|
|
|
[Fact]
|
|
public void HotKey_Command_SetsFocus ()
|
|
{
|
|
var view = new View ();
|
|
|
|
view.CanFocus = true;
|
|
Assert.False (view.HasFocus);
|
|
view.InvokeCommand (Command.HotKey);
|
|
Assert.True (view.HasFocus);
|
|
}
|
|
|
|
#endregion OnHotKey/HotKey tests
|
|
|
|
#region InvokeCommand Tests
|
|
|
|
|
|
[Fact]
|
|
public void InvokeCommand_NotBound_Invokes_CommandNotBound ()
|
|
{
|
|
ViewEventTester view = new ();
|
|
|
|
view.InvokeCommand (Command.NotBound);
|
|
|
|
Assert.False (view.HasFocus);
|
|
Assert.Equal (1, view.OnCommandNotBoundCount);
|
|
Assert.Equal (1, view.CommandNotBoundCount);
|
|
}
|
|
|
|
[Fact]
|
|
public void InvokeCommand_Command_Not_Bound_Invokes_CommandNotBound ()
|
|
{
|
|
ViewEventTester view = new ();
|
|
|
|
view.InvokeCommand (Command.New);
|
|
|
|
Assert.False (view.HasFocus);
|
|
Assert.Equal (1, view.OnCommandNotBoundCount);
|
|
Assert.Equal (1, view.CommandNotBoundCount);
|
|
}
|
|
|
|
[Fact]
|
|
public void InvokeCommand_Command_Bound_Does_Not_Invoke_CommandNotBound ()
|
|
{
|
|
ViewEventTester view = new ();
|
|
|
|
view.InvokeCommand (Command.Accept);
|
|
|
|
Assert.False (view.HasFocus);
|
|
Assert.Equal (0, view.OnCommandNotBoundCount);
|
|
Assert.Equal (0, view.CommandNotBoundCount);
|
|
}
|
|
|
|
#endregion
|
|
|
|
public class ViewEventTester : View
|
|
{
|
|
public ViewEventTester ()
|
|
{
|
|
Id = "viewEventTester";
|
|
CanFocus = true;
|
|
|
|
Accepting += (_, a) =>
|
|
{
|
|
a.Handled = HandleAccepted;
|
|
AcceptedCount++;
|
|
};
|
|
|
|
HandlingHotKey += (_, a) =>
|
|
{
|
|
a.Handled = HandleHandlingHotKey;
|
|
HandlingHotKeyCount++;
|
|
};
|
|
|
|
Activating += (_, a) =>
|
|
{
|
|
a.Handled = HandleActivating;
|
|
ActivatingCount++;
|
|
};
|
|
|
|
CommandNotBound += (_, a) =>
|
|
{
|
|
a.Handled = HandleCommandNotBound;
|
|
CommandNotBoundCount++;
|
|
};
|
|
}
|
|
|
|
public int OnAcceptedCount { get; set; }
|
|
public int AcceptedCount { get; set; }
|
|
public bool HandleOnAccepted { get; set; }
|
|
|
|
/// <inheritdoc/>
|
|
protected override bool OnAccepting (CommandEventArgs args)
|
|
{
|
|
OnAcceptedCount++;
|
|
|
|
return HandleOnAccepted;
|
|
}
|
|
|
|
public bool HandleAccepted { get; set; }
|
|
|
|
public int OnHandlingHotKeyCount { get; set; }
|
|
public int HandlingHotKeyCount { get; set; }
|
|
public bool HandleOnHandlingHotKey { get; set; }
|
|
|
|
/// <inheritdoc/>
|
|
protected override bool OnHandlingHotKey (CommandEventArgs args)
|
|
{
|
|
OnHandlingHotKeyCount++;
|
|
|
|
return HandleOnHandlingHotKey;
|
|
}
|
|
|
|
public bool HandleHandlingHotKey { get; set; }
|
|
|
|
public int OnActivatingCount { get; set; }
|
|
public int ActivatingCount { get; set; }
|
|
public bool HandleOnActivating { get; set; }
|
|
public bool HandleActivating { get; set; }
|
|
|
|
|
|
/// <inheritdoc/>
|
|
protected override bool OnActivating (CommandEventArgs args)
|
|
{
|
|
OnActivatingCount++;
|
|
|
|
return HandleOnActivating;
|
|
}
|
|
|
|
public int OnCommandNotBoundCount { get; set; }
|
|
public int CommandNotBoundCount { get; set; }
|
|
|
|
public bool HandleOnCommandNotBound { get; set; }
|
|
|
|
public bool HandleCommandNotBound { get; set; }
|
|
|
|
protected override bool OnCommandNotBound (CommandEventArgs args)
|
|
{
|
|
OnCommandNotBoundCount++;
|
|
return HandleOnCommandNotBound;
|
|
}
|
|
}
|
|
}
|