mirror of
https://github.com/AlecM33/Werewolf.git
synced 2025-12-26 07:47:50 +01:00
lint specs
This commit is contained in:
AlecM33
@@ -1,10 +1,10 @@
|
||||
// TODO: clean up these deep relative paths? jsconfig.json is not working...
|
||||
const Game = require("../../../../server/model/Game");
|
||||
const globals = require("../../../../server/config/globals");
|
||||
const Game = require('../../../../server/model/Game');
|
||||
const globals = require('../../../../server/config/globals');
|
||||
const USER_TYPES = globals.USER_TYPES;
|
||||
const Person = require("../../../../server/model/Person");
|
||||
const Person = require('../../../../server/model/Person');
|
||||
const GameManager = require('../../../../server/modules/GameManager.js');
|
||||
const GameStateCurator = require("../../../../server/modules/GameStateCurator");
|
||||
const GameStateCurator = require('../../../../server/modules/GameStateCurator');
|
||||
const logger = require('../../../../server/modules/Logger.js')(false);
|
||||
|
||||
describe('GameManager', function () {
|
||||
@@ -14,8 +14,8 @@ describe('GameManager', function () {
|
||||
spyOn(logger, 'debug');
|
||||
spyOn(logger, 'error');
|
||||
gameManager = new GameManager(logger, globals.ENVIRONMENT.PRODUCTION).getInstance();
|
||||
let inObj = { emit: () => {} }
|
||||
namespace = { in: () => { return inObj }};
|
||||
const inObj = { emit: () => {} };
|
||||
namespace = { in: () => { return inObj; } };
|
||||
gameManager.namespace = namespace;
|
||||
});
|
||||
|
||||
@@ -24,80 +24,76 @@ describe('GameManager', function () {
|
||||
|
||||
describe('#transferModerator', function () {
|
||||
it('Should transfer successfully from a dedicated moderator to a killed player', () => {
|
||||
let personToTransferTo = new Person("1", "123", "Joe", USER_TYPES.KILLED_PLAYER);
|
||||
const personToTransferTo = new Person('1', '123', 'Joe', USER_TYPES.KILLED_PLAYER);
|
||||
personToTransferTo.out = true;
|
||||
let moderator = new Person("3", "789", "Jack", USER_TYPES.MODERATOR)
|
||||
let game = new Game(
|
||||
"abc",
|
||||
const moderator = new Person('3', '789', 'Jack', USER_TYPES.MODERATOR);
|
||||
const game = new Game(
|
||||
'abc',
|
||||
globals.STATUS.IN_PROGRESS,
|
||||
[ personToTransferTo, new Person("2", "456", "Jane", USER_TYPES.PLAYER)],
|
||||
[personToTransferTo, new Person('2', '456', 'Jane', USER_TYPES.PLAYER)],
|
||||
[],
|
||||
false,
|
||||
moderator
|
||||
);
|
||||
gameManager.transferModeratorPowers(game, personToTransferTo, namespace, logger);
|
||||
|
||||
|
||||
expect(game.moderator).toEqual(personToTransferTo);
|
||||
expect(personToTransferTo.userType).toEqual(USER_TYPES.MODERATOR);
|
||||
expect(moderator.userType).toEqual(USER_TYPES.SPECTATOR);
|
||||
});
|
||||
|
||||
it('Should transfer successfully from a dedicated moderator to a spectator', () => {
|
||||
let personToTransferTo = new Person("1", "123", "Joe", USER_TYPES.SPECTATOR);
|
||||
let moderator = new Person("3", "789", "Jack", USER_TYPES.MODERATOR)
|
||||
let game = new Game(
|
||||
"abc",
|
||||
const personToTransferTo = new Person('1', '123', 'Joe', USER_TYPES.SPECTATOR);
|
||||
const moderator = new Person('3', '789', 'Jack', USER_TYPES.MODERATOR);
|
||||
const game = new Game(
|
||||
'abc',
|
||||
globals.STATUS.IN_PROGRESS,
|
||||
[ new Person("2", "456", "Jane", USER_TYPES.PLAYER)],
|
||||
[new Person('2', '456', 'Jane', USER_TYPES.PLAYER)],
|
||||
[],
|
||||
false,
|
||||
moderator
|
||||
);
|
||||
game.spectators.push(personToTransferTo)
|
||||
game.spectators.push(personToTransferTo);
|
||||
gameManager.transferModeratorPowers(game, personToTransferTo, namespace, logger);
|
||||
|
||||
|
||||
expect(game.moderator).toEqual(personToTransferTo);
|
||||
expect(personToTransferTo.userType).toEqual(USER_TYPES.MODERATOR);
|
||||
expect(moderator.userType).toEqual(USER_TYPES.SPECTATOR);
|
||||
});
|
||||
|
||||
it('Should transfer successfully from a temporary moderator to a killed player', () => {
|
||||
let personToTransferTo = new Person("1", "123", "Joe", USER_TYPES.KILLED_PLAYER);
|
||||
const personToTransferTo = new Person('1', '123', 'Joe', USER_TYPES.KILLED_PLAYER);
|
||||
personToTransferTo.out = true;
|
||||
let tempMod = new Person("3", "789", "Jack", USER_TYPES.TEMPORARY_MODERATOR)
|
||||
let game = new Game(
|
||||
"abc",
|
||||
const tempMod = new Person('3', '789', 'Jack', USER_TYPES.TEMPORARY_MODERATOR);
|
||||
const game = new Game(
|
||||
'abc',
|
||||
globals.STATUS.IN_PROGRESS,
|
||||
[ personToTransferTo, tempMod, new Person("2", "456", "Jane", USER_TYPES.PLAYER)],
|
||||
[personToTransferTo, tempMod, new Person('2', '456', 'Jane', USER_TYPES.PLAYER)],
|
||||
[],
|
||||
false,
|
||||
tempMod
|
||||
);
|
||||
gameManager.transferModeratorPowers(game, personToTransferTo, namespace, logger);
|
||||
|
||||
|
||||
expect(game.moderator).toEqual(personToTransferTo);
|
||||
expect(personToTransferTo.userType).toEqual(USER_TYPES.MODERATOR);
|
||||
expect(tempMod.userType).toEqual(USER_TYPES.PLAYER);
|
||||
});
|
||||
|
||||
it('Should make the temporary moderator a dedicated moderator when they take themselves out of the game', () => {
|
||||
let tempMod = new Person("3", "789", "Jack", USER_TYPES.TEMPORARY_MODERATOR);
|
||||
let personToTransferTo = tempMod;
|
||||
const tempMod = new Person('3', '789', 'Jack', USER_TYPES.TEMPORARY_MODERATOR);
|
||||
const personToTransferTo = tempMod;
|
||||
tempMod.out = true;
|
||||
let game = new Game(
|
||||
"abc",
|
||||
const game = new Game(
|
||||
'abc',
|
||||
globals.STATUS.IN_PROGRESS,
|
||||
[ personToTransferTo, tempMod, new Person("2", "456", "Jane", USER_TYPES.PLAYER)],
|
||||
[personToTransferTo, tempMod, new Person('2', '456', 'Jane', USER_TYPES.PLAYER)],
|
||||
[],
|
||||
false,
|
||||
tempMod
|
||||
);
|
||||
gameManager.transferModeratorPowers(game, personToTransferTo, namespace, logger);
|
||||
|
||||
|
||||
expect(game.moderator).toEqual(personToTransferTo);
|
||||
expect(personToTransferTo.userType).toEqual(USER_TYPES.MODERATOR);
|
||||
expect(tempMod.userType).toEqual(USER_TYPES.MODERATOR);
|
||||
@@ -108,18 +104,17 @@ describe('GameManager', function () {
|
||||
it('Should mark a player as out and broadcast it, and should not transfer moderators if the moderator is a dedicated mod.', () => {
|
||||
spyOn(namespace.in(), 'emit');
|
||||
spyOn(gameManager, 'transferModeratorPowers');
|
||||
let player = new Person("1", "123", "Joe", USER_TYPES.PLAYER);
|
||||
let game = new Game(
|
||||
"abc",
|
||||
const player = new Person('1', '123', 'Joe', USER_TYPES.PLAYER);
|
||||
const game = new Game(
|
||||
'abc',
|
||||
globals.STATUS.IN_PROGRESS,
|
||||
[ player ],
|
||||
[player],
|
||||
[],
|
||||
false,
|
||||
new Person("2", "456", "Jane", USER_TYPES.MODERATOR)
|
||||
new Person('2', '456', 'Jane', USER_TYPES.MODERATOR)
|
||||
);
|
||||
gameManager.killPlayer(game, player, namespace, logger);
|
||||
|
||||
|
||||
expect(player.out).toEqual(true);
|
||||
expect(player.userType).toEqual(USER_TYPES.KILLED_PLAYER);
|
||||
expect(namespace.in().emit).toHaveBeenCalled();
|
||||
@@ -129,18 +124,17 @@ describe('GameManager', function () {
|
||||
it('Should mark a temporary moderator as out but preserve their user type, and call the transfer mod function', () => {
|
||||
spyOn(namespace.in(), 'emit');
|
||||
spyOn(gameManager, 'transferModeratorPowers');
|
||||
let tempMod = new Person("1", "123", "Joe", USER_TYPES.TEMPORARY_MODERATOR);
|
||||
let game = new Game(
|
||||
"abc",
|
||||
const tempMod = new Person('1', '123', 'Joe', USER_TYPES.TEMPORARY_MODERATOR);
|
||||
const game = new Game(
|
||||
'abc',
|
||||
globals.STATUS.IN_PROGRESS,
|
||||
[ tempMod ],
|
||||
[tempMod],
|
||||
[],
|
||||
false,
|
||||
tempMod
|
||||
);
|
||||
gameManager.killPlayer(game, tempMod, namespace, logger);
|
||||
|
||||
|
||||
expect(tempMod.out).toEqual(true);
|
||||
expect(tempMod.userType).toEqual(USER_TYPES.TEMPORARY_MODERATOR);
|
||||
expect(namespace.in().emit).toHaveBeenCalled();
|
||||
@@ -150,68 +144,68 @@ describe('GameManager', function () {
|
||||
|
||||
describe('#handleRequestForGameState', function () {
|
||||
it('should send the game state to a matching person with an active connection to the room', () => {
|
||||
let player = new Person("1", "123", "Joe", USER_TYPES.PLAYER);
|
||||
let socket = { id: "socket1"};
|
||||
const player = new Person('1', '123', 'Joe', USER_TYPES.PLAYER);
|
||||
const socket = { id: 'socket1' };
|
||||
spyOn(GameStateCurator, 'getGameStateFromPerspectiveOfPerson');
|
||||
player.socketId = "socket1";
|
||||
let gameRunner = {
|
||||
player.socketId = 'socket1';
|
||||
const gameRunner = {
|
||||
activeGames: {
|
||||
"abc": new Game(
|
||||
"abc",
|
||||
abc: new Game(
|
||||
'abc',
|
||||
globals.STATUS.IN_PROGRESS,
|
||||
[ player ],
|
||||
[player],
|
||||
[],
|
||||
false,
|
||||
new Person("2", "456", "Jane", USER_TYPES.MODERATOR)
|
||||
new Person('2', '456', 'Jane', USER_TYPES.MODERATOR)
|
||||
)
|
||||
}
|
||||
}
|
||||
};
|
||||
spyOn(namespace.in(), 'emit');
|
||||
gameManager.handleRequestForGameState(
|
||||
namespace,
|
||||
logger,
|
||||
gameRunner,
|
||||
"abc",
|
||||
"123",
|
||||
'abc',
|
||||
'123',
|
||||
(arg) => {},
|
||||
socket
|
||||
);
|
||||
|
||||
expect(GameStateCurator.getGameStateFromPerspectiveOfPerson)
|
||||
.toHaveBeenCalledWith(gameRunner.activeGames["abc"], player, gameRunner, socket, logger);
|
||||
.toHaveBeenCalledWith(gameRunner.activeGames.abc, player, gameRunner, socket, logger);
|
||||
});
|
||||
|
||||
it('should send the game state to a matching person who reset their connection', () => {
|
||||
let player = new Person("1", "123", "Joe", USER_TYPES.PLAYER);
|
||||
let socket = { id: "socket_222222", join: () => {}};
|
||||
const player = new Person('1', '123', 'Joe', USER_TYPES.PLAYER);
|
||||
const socket = { id: 'socket_222222', join: () => {} };
|
||||
spyOn(socket, 'join');
|
||||
spyOn(GameStateCurator, 'getGameStateFromPerspectiveOfPerson');
|
||||
player.socketId = "socket_111111";
|
||||
let gameRunner = {
|
||||
player.socketId = 'socket_111111';
|
||||
const gameRunner = {
|
||||
activeGames: {
|
||||
"abc": new Game(
|
||||
"abc",
|
||||
abc: new Game(
|
||||
'abc',
|
||||
globals.STATUS.IN_PROGRESS,
|
||||
[ player ],
|
||||
[player],
|
||||
[],
|
||||
false,
|
||||
new Person("2", "456", "Jane", USER_TYPES.MODERATOR)
|
||||
new Person('2', '456', 'Jane', USER_TYPES.MODERATOR)
|
||||
)
|
||||
}
|
||||
}
|
||||
};
|
||||
spyOn(namespace.in(), 'emit');
|
||||
gameManager.handleRequestForGameState(
|
||||
namespace,
|
||||
logger,
|
||||
gameRunner,
|
||||
"abc",
|
||||
"123",
|
||||
'abc',
|
||||
'123',
|
||||
(arg) => {},
|
||||
socket
|
||||
);
|
||||
|
||||
expect(GameStateCurator.getGameStateFromPerspectiveOfPerson)
|
||||
.toHaveBeenCalledWith(gameRunner.activeGames["abc"], player, gameRunner, socket, logger);
|
||||
.toHaveBeenCalledWith(gameRunner.activeGames.abc, player, gameRunner, socket, logger);
|
||||
expect(player.socketId).toEqual(socket.id);
|
||||
expect(socket.join).toHaveBeenCalled();
|
||||
});
|
||||
@@ -219,35 +213,34 @@ describe('GameManager', function () {
|
||||
|
||||
describe('#joinGame', function () {
|
||||
it('should mark the game as full when all players have been assigned', () => {
|
||||
let person = new Person("1", "123", "Placeholder", USER_TYPES.KILLED_PLAYER);
|
||||
let moderator = new Person("3", "789", "Jack", USER_TYPES.MODERATOR);
|
||||
const person = new Person('1', '123', 'Placeholder', USER_TYPES.KILLED_PLAYER);
|
||||
const moderator = new Person('3', '789', 'Jack', USER_TYPES.MODERATOR);
|
||||
moderator.assigned = true;
|
||||
let game = new Game(
|
||||
"abc",
|
||||
const game = new Game(
|
||||
'abc',
|
||||
globals.STATUS.IN_PROGRESS,
|
||||
[ person ],
|
||||
[person],
|
||||
[],
|
||||
false,
|
||||
moderator
|
||||
);
|
||||
|
||||
gameManager.joinGame(game, "Jill", "x")
|
||||
|
||||
gameManager.joinGame(game, 'Jill', 'x');
|
||||
|
||||
expect(game.isFull).toEqual(true);
|
||||
expect(game.people[0].name).toEqual("Jill");
|
||||
expect(game.people[0].name).toEqual('Jill');
|
||||
expect(game.people[0].assigned).toEqual(true);
|
||||
});
|
||||
|
||||
it('should create a spectator if the game is already full and broadcast it to the room', () => {
|
||||
let person = new Person("1", "123", "AlreadyJoined", USER_TYPES.KILLED_PLAYER);
|
||||
let moderator = new Person("3", "789", "AlreadyTheModerator", USER_TYPES.MODERATOR);
|
||||
const person = new Person('1', '123', 'AlreadyJoined', USER_TYPES.KILLED_PLAYER);
|
||||
const moderator = new Person('3', '789', 'AlreadyTheModerator', USER_TYPES.MODERATOR);
|
||||
moderator.assigned = true;
|
||||
person.assigned = true;
|
||||
let game = new Game(
|
||||
"abc",
|
||||
const game = new Game(
|
||||
'abc',
|
||||
globals.STATUS.IN_PROGRESS,
|
||||
[ person ],
|
||||
[person],
|
||||
[],
|
||||
false,
|
||||
moderator
|
||||
@@ -256,16 +249,15 @@ describe('GameManager', function () {
|
||||
|
||||
spyOn(gameManager.namespace.in(), 'emit');
|
||||
|
||||
gameManager.joinGame(game, "Jane", "x")
|
||||
|
||||
gameManager.joinGame(game, 'Jane', 'x');
|
||||
|
||||
expect(game.isFull).toEqual(true);
|
||||
expect(game.people[0].name).toEqual("AlreadyJoined");
|
||||
expect(game.moderator.name).toEqual("AlreadyTheModerator");
|
||||
expect(game.people[0].name).toEqual('AlreadyJoined');
|
||||
expect(game.moderator.name).toEqual('AlreadyTheModerator');
|
||||
expect(game.spectators.length).toEqual(1);
|
||||
expect(game.spectators[0].name).toEqual("Jane");
|
||||
expect(game.spectators[0].name).toEqual('Jane');
|
||||
expect(game.spectators[0].userType).toEqual(USER_TYPES.SPECTATOR);
|
||||
expect(gameManager.namespace.in().emit).toHaveBeenCalledWith(globals.EVENTS.NEW_SPECTATOR, jasmine.anything())
|
||||
expect(gameManager.namespace.in().emit).toHaveBeenCalledWith(globals.EVENTS.NEW_SPECTATOR, jasmine.anything());
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user