From 95d78b4e5bf1f9b900e8e80c1e2c94c851a4a2e3 Mon Sep 17 00:00:00 2001
From: Alec Maier <Maier.144@osu.edu>
Date: Mon, 13 Apr 2020 03:12:36 -0400
Subject: [PATCH] Fix bug duplicating custom roles, reset form on submit

---
 static/setup.js | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/static/setup.js b/static/setup.js
index 33be1f0..0a6be1b 100644
--- a/static/setup.js
+++ b/static/setup.js
@@ -172,17 +172,21 @@ function addCustomCardToRoles(e) {
             localStorage.setItem("play-werewolf-custom-roles", JSON.stringify(new Array(newCard)));
         }
     }
-    readInUserCustomRoles();
+    updateCustomRoleModal();
     closeModal();
+    document.getElementById("custom-role-form").reset();
 }
 
-function readInUserCustomRoles() {
+function updateCustomRoleModal() {
     document.getElementById("custom-roles").innerHTML = "";
     cards.forEach((card) => {
-        if (card.custom && !card.saved) {
+        if (card.custom) {
             renderCustomRoleInModal(card);
         }
     });
+}
+
+function readInUserCustomRoles() {
     let existingRoles = localStorage.getItem("play-werewolf-custom-roles");
     if (existingRoles !== null) {
         let rolesArray;
@@ -193,7 +197,8 @@ function readInUserCustomRoles() {
         }
         if (rolesArray) {
             rolesArray.forEach((card) => {
-                renderCustomRoleInModal(card)
+                renderCustomRoleInModal(card);
+                cards.push(card);
             })
         }
     }
@@ -203,7 +208,6 @@ function readInUserCustomRoles() {
 }
 
 function renderCustomRoleInModal(card) {
-    cards.push(card);
     let roleElement = document.createElement("div");
     let editRemoveContainer = document.createElement("div");
     let roleName = document.createElement("p");
@@ -240,8 +244,8 @@ function removeCustomRole(name) {
         }
         localStorage.setItem("play-werewolf-custom-roles", JSON.stringify(rolesArray));
     }
+    updateCustomRoleModal();
     renderAvailableCards();
-    readInUserCustomRoles();
 }