From c6929071724e6ff6c1b259cfafefef9817b1b9e7 Mon Sep 17 00:00:00 2001
From: Maier <maiera3@nationwide.com>
Date: Tue, 14 Jan 2020 14:16:13 -0500
Subject: [PATCH] major rework of server/client interaction - request
 periodically from each client

---
 server.js       | 22 +++++++---------------
 static/game.js  | 28 ++++++++++++++++++++++------
 static/setup.js |  2 +-
 3 files changed, 30 insertions(+), 22 deletions(-)

diff --git a/server.js b/server.js
index bd725d2..513f2c6 100644
--- a/server.js
+++ b/server.js
@@ -116,25 +116,24 @@ io.on('connection', function(socket) {
         const game = activeGames[Object.keys(activeGames).find((key) => key === data.code)];
         if (game && Object.keys(socket.rooms).includes(data.code) === false) {
             socket.join(data.code, function() {
-                io.sockets.in(data.code).emit('state', game);
+                socket.emit('state', game);
             });
         } else {
             if (game) {
-                io.sockets.in(data.code).emit('state', game);
+                socket.emit('state', game);
             }
         }
     });
     socket.on('startGame', function(gameData) {
         let game = activeGames[Object.keys(activeGames).find((key) => key === gameData.code)];
         if (game) {
-            game.state = "started";
+            game.status = "started";
             game.players = gameData.players;
             if (game.time) {
                 let d = new Date();
                 d.setMinutes(d.getMinutes() + parseInt(game.time));
                 game.endTime = d.toJSON();
             }
-            io.sockets.in(gameData.code).emit('state', game);
         }
     });
     socket.on('pauseGame', function(code) {
@@ -142,7 +141,6 @@ io.on('connection', function(socket) {
         if (game) {
             game.pauseTime = (new Date()).toJSON();
             game.paused = true;
-            io.sockets.in(code).emit('state', game);
         }
     });
     socket.on('resumeGame', function(code) {
@@ -153,15 +151,13 @@ io.on('connection', function(socket) {
             let newDate = new Date(game.endTime);
             newDate.setTime(newTime);
             game.endTime = newDate.toJSON();
-            io.sockets.in(code).emit('state', game);
         }
     });
     socket.on("timerExpired", function(code) {
         let game = activeGames[Object.keys(activeGames).find((key) => key === code)];
         if (game) {
             game.winningTeam = "wolf";
-            game.state = "ended";
-            io.sockets.in(code).emit('state', game);
+            game.status = "ended";
         }
     });
     socket.on('killPlayer', function(id, code) {
@@ -176,14 +172,10 @@ io.on('connection', function(socket) {
             const winCheck = teamWon(game);
             if (winCheck === "wolf") {
                 game.winningTeam = "wolf";
-                game.state = "ended";
-                io.sockets.in(code).emit('state', game);
-            } else if (winCheck === "village") {
+                game.status = "ended";
+            } if (winCheck === "village") {
                 game.winningTeam = "village";
-                game.state = "ended";
-                io.sockets.in(code).emit('state', game);
-            } else {
-                io.sockets.in(code).emit('state', game);
+                game.status = "ended";
             }
         }
     });
diff --git a/static/game.js b/static/game.js
index 04585d7..5ad21b3 100644
--- a/static/game.js
+++ b/static/game.js
@@ -5,6 +5,7 @@ const socket = io();
 const finishedArtArray = ["Villager", "Werewolf", "Seer", "Shadow", "Hunter", "Mason", "Minion", "Sorcerer"];
 let clock;
 let currentGame = null;
+let lastGameState = null;
 let cardFlippedOver = false;
 let cardRendered = false;
 let lastKilled = null;
@@ -12,7 +13,9 @@ let lastKilled = null;
 // respond to the game state received from the server
 socket.on('state', function(game) {
     currentGame = game;
-    buildGameBasedOnState();
+    if(detectChanges(game)) {
+        buildGameBasedOnState(game);
+    }
 });
 
 window.onblur = function() { // pause animations if the window is not in focus
@@ -27,8 +30,8 @@ window.onfocus = function() { // play animations when window is focused
     this.document.querySelector("#killed-name").style.animationPlayState = 'running';
 }
 
-function buildGameBasedOnState() {
-    switch(currentGame.state) {
+function buildGameBasedOnState(game) {
+    switch(game.status) {
         case "lobby":
             renderLobby();
             break;
@@ -43,6 +46,19 @@ function buildGameBasedOnState() {
     }
 }
 
+function detectChanges(game) {
+    if (lastGameState === null ||
+        lastGameState.status !== game.status ||
+        lastGameState.paused !== game.paused ||
+        lastGameState.lastKilled !== game.lastKilled ||
+        lastGameState.startTime !== game.startTime ||
+        lastGameState.players.length !== game.players.length) {
+        lastGameState = game;
+        return true;
+    } 
+        return false;
+}
+
 function hideAfterExit(e) {
     e.target.style.display = 'none'
     e.target.classList.remove(e.target.exitClass);
@@ -312,7 +328,7 @@ function renderLobby() {
     }
 }
 
-// request the current state of the game from the server
-window.onload = function() {
+// request game state from server periodically
+setInterval(function () {
     socket.emit('requestState', {code: sessionStorage.getItem("code")});
-};
+}, 200);
diff --git a/static/setup.js b/static/setup.js
index 89d9ca6..02e079a 100644
--- a/static/setup.js
+++ b/static/setup.js
@@ -23,7 +23,7 @@ class Game {
         this.deck = deck;
         this.time = time;
         this.players = [];
-        this.state = "lobby";
+        this.status = "lobby";
         this.endTime = null;
     }
 }