Git_Mirror/Terminal.Gui
1
0
Fork 0
mirror of https://github.com/gui-cs/Terminal.Gui.git synced 2026-01-01 00:46:39 +01:00
Code Issues Packages Projects Releases Wiki Activity

TODOs

Browse Source
This commit is contained in:
Tig
2024-04-11 07:00:46 -06:00
parent f924ea3d79
commit 9f93dea5cb
2 changed files with 13 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
Terminal.Gui/Views/ListView.cs
View File

@@ -94,6 +94,9 @@ public class ListView : View
private int _lastSelectedItem = -1;
private int _selected = -1;
private IListDataSource _source;
// TODO: ListView has been upgraded to use Viewport and ContentSize instead of the
// TODO: bespoke _top and _left. It was a quick & dirty port. There is now duplicate logic
// TODO: that could be removed.
//private int _top, _left;
/// <summary>
@@ -250,10 +253,16 @@ public class ListView : View
get => _source;
set
{
if (_source == value)
{
return;
}
_source = value;
ContentSize = new Size (Viewport.Width, _source.Count);
KeystrokeNavigator.Collection = _source?.ToList ();
ContentSize = new Size (Viewport.Width, _source?.Count ?? 0);
Viewport = Viewport with { Y = 0 };
KeystrokeNavigator.Collection = _source?.ToList ();
_selected = -1;
_lastSelectedItem = -1;
SetNeedsDisplay ();
@@ -317,6 +326,7 @@ public class ListView : View
{
if (_selected < Viewport.Y)
{
// TODO: The Max check here is not needed because, by default, Viewport enforces staying w/in ContentArea (View.ScrollSettings).
Viewport = Viewport with { Y = Math.Max (_selected, 0) };
}
else if (Viewport.Height > 0 && _selected >= Viewport.Y + Viewport.Height)

2
UnitTests/Views/ListViewTests.cs
View File

@@ -670,7 +670,7 @@ Item 6",
private class NewListDataSource : IListDataSource
{
public int Count => throw new NotImplementedException ();
public int Count => 0;
public int Length => throw new NotImplementedException ();
public bool IsMarked (int item) { throw new NotImplementedException (); }