Git_Mirror/Terminal.Gui
1
0
Fork 0
mirror of https://github.com/gui-cs/Terminal.Gui.git synced 2026-01-01 08:50:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

Addressed code review comments

Browse Source
This commit is contained in:
Tig
2024-05-29 10:37:05 -06:00
parent 3575a78e9d
commit be0118e9d4
3 changed files with 11 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
Terminal.Gui/View/Layout/Dim.cs
View File

@@ -6,8 +6,7 @@ namespace Terminal.Gui;
/// <summary>
/// <para>
/// A Dim object describes the dimensions of a <see cref="View"/>. Dim is the type of the
/// <see cref="View.Width"/> and <see cref="View.Height"/> properties of <see cref="View"/>. Dim objects enable
/// automatic management of the dimensions of a view.
/// <see cref="View.Width"/> and <see cref="View.Height"/> properties of <see cref="View"/>.
/// </para>
/// <para>
/// Integer values are implicitly convertible to an absolute <see cref="Dim"/>. These objects are created using

1
Terminal.Gui/Views/Button.cs
View File

@@ -34,7 +34,6 @@ public class Button : View
private bool _isDefault;
/// <summary>Initializes a new instance of <see cref="Button"/>.</summary>
/// <remarks>The width and height of the <see cref="Button"/> is computed based on the text.</remarks>
public Button ()
{
TextAlignment = Alignment.Center;

22
Terminal.Gui/Views/Dialog.cs
View File

@@ -9,7 +9,8 @@ namespace Terminal.Gui;
/// </summary>
/// <remarks>
/// To run the <see cref="Dialog"/> modally, create the <see cref="Dialog"/>, and pass it to
/// <see cref="Application.Run(Toplevel, Func{Exception, bool}, ConsoleDriver)"/>. This will execute the dialog until it terminates via the
/// <see cref="Application.Run(Toplevel, Func{Exception, bool}, ConsoleDriver)"/>. This will execute the dialog until
/// it terminates via the
/// [ESC] or [CTRL-Q] key, or when one of the views or buttons added to the dialog calls
/// <see cref="Application.RequestStop"/>.
/// </remarks>
@@ -41,7 +42,6 @@ public class Dialog : Window
[SerializableConfigurationProperty (Scope = typeof (ThemeScope))]
public static int DefaultMinimumHeight { get; set; } = 25;
// TODO: Reenable once border/borderframe design is settled
/// <summary>
/// Defines the default border styling for <see cref="Dialog"/>. Can be configured via
@@ -55,11 +55,12 @@ public class Dialog : Window
private readonly List<Button> _buttons = new ();
/// <summary>
/// Initializes a new instance of the <see cref="Dialog"/> class.
/// Initializes a new instance of the <see cref="Dialog"/> class with no <see cref="Button"/>s.
/// </summary>
/// <remarks>
/// By default, <see cref="View.X"/>, <see cref="View.Y"/>, <see cref="View.Width"/>, and <see cref="View.Height"/> are set
/// such that the dialog will be centered and no larger than 90% of the container's width and height.
/// By default, <see cref="View.X"/>, <see cref="View.Y"/>, <see cref="View.Width"/>, and <see cref="View.Height"/> are
/// set
/// such that the <see cref="Dialog"/> will be centered in, and no larger than 90% of the screen dimensions.
/// </remarks>
public Dialog ()
{
@@ -67,8 +68,8 @@ public class Dialog : Window
X = Pos.Center ();
Y = Pos.Center ();
Width = Dim.Auto (DimAutoStyle.Content, minimumContentDim: Dim.Percent (DefaultMinimumWidth), Dim.Percent (90));
Height = Dim.Auto (DimAutoStyle.Content, minimumContentDim: Dim.Percent (DefaultMinimumHeight), Dim.Percent (90));
Width = Dim.Auto (DimAutoStyle.Content, Dim.Percent (DefaultMinimumWidth), Dim.Percent (90));
Height = Dim.Auto (DimAutoStyle.Content, Dim.Percent (DefaultMinimumHeight), Dim.Percent (90));
ColorScheme = Colors.ColorSchemes ["Dialog"];
Modal = true;
@@ -85,7 +86,6 @@ public class Dialog : Window
return true;
});
KeyBindings.Add (Key.Esc, Command.QuitToplevel);
}
private bool _canceled;
@@ -113,8 +113,6 @@ public class Dialog : Window
}
#endif
_canceled = value;
return;
}
}
@@ -123,7 +121,7 @@ public class Dialog : Window
public Alignment ButtonAlignment { get; set; }
/// <summary>
/// Gets or sets the alignment modes for the dialog's buttons.
/// Gets or sets the alignment modes for the dialog's buttons.
/// </summary>
public AlignmentModes ButtonAlignmentModes { get; set; }
@@ -158,7 +156,7 @@ public class Dialog : Window
}
// Use a distinct GroupId so users can use Pos.Align for other views in the Dialog
button.X = Pos.Align (ButtonAlignment, ButtonAlignmentModes, groupId: GetHashCode ());
button.X = Pos.Align (ButtonAlignment, ButtonAlignmentModes, GetHashCode ());
button.Y = Pos.AnchorEnd ();
_buttons.Add (button);