Git_Mirror/Terminal.Gui
1
0
Fork 0
mirror of https://github.com/gui-cs/Terminal.Gui.git synced 2025-12-26 15:57:56 +01:00
Code Issues Packages Projects Releases Wiki Activity

Code cleanup/API docs

Browse Source
This commit is contained in:
Tig
2024-09-18 12:57:49 -06:00
parent 176207e6cb
commit e01af59543
4 changed files with 19 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
Terminal.Gui/Application/ApplicationNavigation.cs
View File

@@ -62,11 +62,6 @@ public class ApplicationNavigation
}
}
//if (start.Border is { })
//{
// return IsInHierarchy (start.Border, view);
//}
return false;
}
@@ -85,11 +80,6 @@ public class ApplicationNavigation
_focused = value;
//if (_focused is { } && Application.PositionCursor ())
//{
// Application.Driver?.UpdateCursor ();
//}
FocusedChanged?.Invoke (null, EventArgs.Empty);
}

12
Terminal.Gui/View/Adornment/Border.cs
View File

@@ -317,6 +317,9 @@ public class Border : Adornment
SetHighlight (HighlightStyle);
// Arrange Mode -
// TODO: This code can be refactored to be more readable and maintainable.
// If not resizable, but movable: Drag anywhere is move
// If resizable and movable: Drag on top is move, other 3 sides are size
// If not movable, but resizable: Drag on any side sizes.
@@ -468,6 +471,7 @@ public class Border : Adornment
int minHeight = Thickness.Vertical + Parent!.Margin.Thickness.Bottom;
int minWidth = Thickness.Horizontal + Parent!.Margin.Thickness.Right;
// TODO: This code can be refactored to be more readable and maintainable.
switch (_arranging)
{
case ViewArrangement.Movable:
@@ -989,6 +993,8 @@ public class Border : Adornment
Application.MouseEvent += ApplicationOnMouseEvent;
// TODO: This code can be refactored to be more readable and maintainable.
// Create buttons for resizing and moving
if (Parent!.Arrangement.HasFlag (ViewArrangement.Movable))
{
@@ -1222,6 +1228,7 @@ public class Border : Adornment
if (arrangement == ViewArrangement.Fixed)
{
// Keyboard mode - enable nav
// TODO: Keyboard mode only supports sizing from bottom/right.
_arranging = (ViewArrangement)(Focused?.Data ?? ViewArrangement.Fixed);
}
@@ -1344,6 +1351,11 @@ public class Border : Adornment
Command.Tab,
() =>
{
// BUGBUG: If an arrangable view has only arrangable subviews, it's not possible to activate
// BUGBUG: ArrangeMode with keyboard for the superview.
// BUGBUG: AdvanceFocus should be wise to this and when in ArrangeMode, should move across
// BUGBUG: the view hierachy.
AdvanceFocus (NavigationDirection.Forward, TabBehavior.TabStop);
_arranging = (ViewArrangement)(Focused?.Data ?? ViewArrangement.Fixed);

6
Terminal.Gui/View/View.Drawing.cs
View File

@@ -187,11 +187,15 @@ public partial class View // Drawing APIs
}
/// <summary>
/// Draws the view. Causes the following virtual methods to be called (along with their related events):
/// Draws the view if it needs to be drawn. Causes the following virtual methods to be called (along with their related events):
/// <see cref="OnDrawContent"/>, <see cref="OnDrawContentComplete"/>.
/// </summary>
/// <remarks>
/// <para>
/// The view will only be drawn if it is visible, and has any of <see cref="NeedsDisplay"/>, <see cref="SubViewNeedsDisplay"/>,
/// or <see cref="LayoutNeeded"/> set.
/// </para>
/// <para>
/// Always use <see cref="Viewport"/> (view-relative) when calling <see cref="OnDrawContent(Rectangle)"/>, NOT
/// <see cref="Frame"/> (superview-relative).
/// </para>

2
Terminal.Gui/View/View.Layout.cs
View File

@@ -771,6 +771,8 @@ public partial class View // Layout APIs
SetNeedsLayout ();
// TODO: This ensures overlapped views are drawn correctly. However, this is inefficient.
// TODO: The correct fix is to implement non-rectangular clip regions: https://github.com/gui-cs/Terminal.Gui/issues/3413
if (Arrangement.HasFlag (ViewArrangement.Overlapped))
{
foreach (Toplevel v in Application.TopLevels)