Commit Graph

180 Commits

Author SHA1 Message Date
BDisp
237b57e4b2 Refactoring code. 2022-10-31 12:27:50 +00:00
BDisp
45990d0e87 Fixes 2142. Dim.Combine wasn't calculating well. 2022-10-31 11:54:33 +00:00
Charlie Kindel
52e6d10d84 Fixed tons of little doc typos 2022-10-20 09:37:05 -06:00
Tig
ac6f7756b7 Merge branch 'develop' into view-clear-background 2022-10-20 07:30:09 -07:00
Tig
a108590969 Merge pull request #2098 from pavkam/cleanup_1
Cleanups up and fixes docs in View class.
2022-10-20 07:22:56 -07:00
BDisp
516e7e25de Fixes 2094. View does not clear it's background. 2022-10-19 20:24:03 +01:00
tznind
711d4d739e Updated docs and made MouseEvent fields into properties for futureproofing and consistency 2022-10-19 15:47:57 +01:00
tznind
b20483cc68 Change MouseEvent to a mutable class (previously struct) and added Handled 2022-10-19 13:57:53 +01:00
Alexandru Ciobanu
3e19bf70ed Correct for the comments on the PR and removed two unused imports. 2022-10-19 13:55:34 +01:00
Alexandru Ciobanu
97c0f5349a cleanup and fix docs in View class 2022-10-18 21:11:20 +01:00
BDisp
702ef46727 Fixes #2069. KeyDown and KeyUp events must run before OnKeyDown and OnKeyUp. 2022-09-29 19:10:56 +01:00
BDisp
b6715863a3 Fixes #2071. DrawContentComplete event is never called from the base if it's overridden. 2022-09-28 17:16:48 +01:00
BDisp
c350886b5d Fixes #2047. Tests are failing locally after merging #2046 2022-09-18 00:28:31 +01:00
BDisp
281a849c08 Fixes #2026. Added ClearOnVisibleFalse to flag if the view must be cleared or not. (#2020)
* Fixes #1984. Added ClearOnVisibleFalse to flag if the view must be cleared or not.

* Fixes #2022. ScrollBarView doesn't show the down arrow on vertical if there isn't horizontal.
2022-09-16 09:16:44 -07:00
BDisp
09f005448e Fixes #1800. TextView now uses the same colors as TextField. (#1971)
* Fixes #1800. TextView now uses the same colors as TextField.

* Replacing the textview to default in some scenarios.

* Removing TextView ColorScheme from the Wizard component.

* Changing someText color to be different from the help text color.

* Renamed some color methods as requested.

Co-authored-by: Tig Kindel <tig@users.noreply.github.com>
2022-09-15 06:43:18 -07:00
BDisp
9505987d40 Fixes #1984. Setting Label.Visible to false does not hide the Label (#1985) 2022-09-05 07:25:11 -07:00
Thomas Nind
bfe9878554 Add ToArray to prevent 'Collection has been modified' Exception in older runtimes (#1976) 2022-09-05 07:18:10 -07:00
Thomas Nind
8a90453bb2 Fixes #1962 - Change KeyBindings to allow chaining commands (#1966)
* Change KeyBindings to allow chaining commands

* Added more asserts for repeating the keybinding till at bottom of list

* Added tests for 'no command' and multiple commands return type
2022-08-30 05:58:22 -07:00
BDisp
32fa12e0bd Changes due to the requested changes. 2022-07-04 11:22:27 -04:00
BDisp
6542e86979 Removing duplicate code. 2022-07-04 11:22:27 -04:00
BDisp
e02df8c043 Added some more features and bug fixes. 2022-07-04 11:22:27 -04:00
BDisp
38bed3fd98 Added exceptions for AutoSize. 2022-07-04 11:22:27 -04:00
BDisp
5b35b0a842 Changes GetTextFormatterBoundsSize and GetBoundsTextFormatterSize as public. 2022-07-04 11:22:27 -04:00
BDisp
3160b4c914 Fixes some AutoSize issues with rules. 2022-07-04 11:22:27 -04:00
Charlie Kindel
ab503d1de1 more unit tests and refactoring 2022-06-15 17:32:25 -07:00
Charlie Kindel
1bc2c79938 Progress on refactoring nav 2022-06-15 17:32:25 -07:00
Tig Kindel
2451c19d15 Wizard fixes (#1802)
* Fixes #1791. Added Pos/Dim Function feature to automate layout.

* Added PosFunc/DimFunc class. and some more features.

* Fixes #1793. ScrollBarView is hiding if the host fit the available space.

* Fixes #1791. View not turn off AutoSize if TextFormatter.Size fit the Anchor.

* Done requested changes.

* Addressing feedback

* Added more AutoSize unit tests.

* wip

* Refactored and enhanced API

* Fixed test

Co-authored-by: BDisp <bd.bdisp@gmail.com>
2022-06-14 08:54:33 -07:00
BDisp
8f7bc395c7 Fixes #1791. View not turn off AutoSize if TextFormatter.Size fit the Anchor. (#1798)
* View not turn off AutoSize if TextFormatter.Size fit the Anchor.

* Added a Button unit test with HotKeySpecifier.
2022-06-13 15:39:20 -07:00
BDisp
b33b658f5b Fixes #1769. Supports a minimum view size for non-automatic size views. (#1771)
* Fixes #1769. Supports a minimum view size for non-automatic size views.

* Only sets the minimum view size if it has text for non-autosize views.

* Added Dim unit tests for views with text.
2022-06-08 13:05:34 -07:00
BDisp
7f3c26906b Reverting Clear method to use AddRune as initially. 2022-05-18 16:50:39 +01:00
BDisp
e941169dad Fixes the draw clip bounds issue visible on ScrollView. 2022-05-13 17:37:26 +01:00
BDisp
a82ac45843 Fixes AutoSize, Window Tile and added option to Border for fill or not. 2022-04-30 01:12:21 +01:00
BDisp
a822e1afa9 Adds a popup ContextMenu feature. Implements ContextMenu for TextField. (#1615)
* Implementing ContextMenu feature to being popup by keyboard or mouse.

* Implements ContextMenu into TextField.

* Ensures the context menu's right and bottom frame from being greater than the container.

* Added Host property. Improving scenario and unit tests.

* Only draw the RightTee if it is at the end of the menu.

* Implements cursor visibility on TextField.

* Fixes the sub-menu not showing.

* Avoids draw the menu help and shortcut if there no available space.

* Remove reference for the MenuClosing event.

* UpdateCursor must only run after the ScreenBuffer is initialized to use the cursor visibility.

* Implements Resized event on Toplevel class.

* Prevents writing overlay on the menu.

* Covering more unit tests.

* Changing from Views to Core namespace.

* Implementing MenuClosingEventArgs and MenuAllClosed event.

* Only close the menu if it's open.

* Implementing localization for en-US and pt-PT to the FileDialog.

* Implementing localization for en-US and pt-PT on the TextField context menu.

* Fixes a bug where DeleteSelectedText is updating the Text before operation completion.

* Added a method to get all the supported cultures from the Terminal.Gui.

* Improving context menu and adding more unit tests.
2022-03-06 22:01:51 -08:00
BDisp
4281030361 Changed Button Text property to use override instead of new. (#1622)
* Changed Button Text property to use override instead of new.

* Fixing HotKey behavior.
2022-03-04 18:05:27 -08:00
BDisp
a9a0d176c1 The KeyPress event must only be used by the most focused view in the ProcessHotKey event. (#1614) 2022-02-26 23:59:50 -08:00
BDisp
56c28f6d37 Fixes the CanFocus equal to false from setting HasFocus to true again. (#1612)
* Fixes the CanFocus equal to false from setting HasFocus to true again.

* Unit test also proving setting a toplevel CanFocus to false focus the next toplevel.

* Unit test proving that a view with CanFocus equal to true can be focused on the same toplevel.
2022-02-24 05:49:34 -08:00
BDisp
0168a3c054 Fixes the auto-size text bug. (#1603)
* Fixes the auto-size text bug.

* The superview is responsible to clearing the previous frame.
2022-02-20 08:02:38 -08:00
BDisp
b185722ab6 Standalone update fix (#1596)
* Updating nuget package and fixing nonworking code.

* Adding some more improvements and launch for UseSystemConsole.

* Fixes layout issue.

* Also added a launch for UseSystemConsole for the Example project.

* Fixing unit tests.

* Trying fixing timeouts duplicate keys.
2022-02-18 07:23:46 -08:00
Thomas Nind
ea7981dc59 Adds Key Binding support. Also refactors Autocomplete and Undo/Redo. (#1556)
* Refactored ProcessKey to use public methods for case logic

* Added KeyBinding class

* Refactored key binding to split key->command from command->implementation

This reduces duplication and simplifies the API

* Finishing key bindings implementation in ListView.

* Adding more unit tests to the ListView.

* Added key bindings to the Button and more features.

* Replaces Action for Func<KeyEvent, bool> on CommandImplementations.

* Allowing commands to have any number of arguments.

* Implementing key bindings on Checkbox view.

* Added test for changing HotKey in Button and made ReplaceKeyBinding protected

* Changed `CommandImplementations` to `Func<KeyEvent, bool>` to better understand current command implementations

* Implementing key bindings in ComboBox.

* Renamed Command keys and fixed ComboBox issues:

- Fixed pressing Esc in ListAndCombos scenario without selecting cause an array out of bounds error
- Changed the Esc key in ComboBox to also collapse the list selection
- Added bool return to public virtual method Expand and Collapse (this is a breaking change)

* Implementing key bindings in DateField.

* Organizing some things.

* Implementing key bindings on TimeField.

* No key bindings on FrameView.

* Added keybinding support to TreeView

* Added mouse support and more features.

* Updating NuGet packages.

* Putting text on the same line.

* Changing function command to Func<bool>.

* Added a read only Position, CursorPosition properties and events.

* Keybindings for GraphView

* Added a stream argument to ApplyEdits to only save the edits.

* Implementing key bindings on the HexView.

* Added MenuOpened event and others bug fixes.

* Fixing typo.

* Unifying constructors initializations.

* Implementing keybindings in the Menu.

* Removing unnecessary variable.

* Implementing keybindings in RadioGroup view.

* Changing Home to TopHome and End to BottomEnd.

* Implementing keybindings in the ScrollView.

* Changing the PageLeft and PageRight keybindings.

* Fixing PageLeft and RightPage.

* Removing CleanUp command.

* Key bindings for TabView

* Keybindings for TableView

* Fixed unit tests for PageDown to correctly assign input focus to the TableView

* Fixes the CalculateLeftColumn method avoiding jump two columns on forward moving.

* Fixes #1525. Gives the same backspace behavior as TextView.

* Changes kill-to-start key to work on Linux too.

* Fixes SelectedStart, SelectedText and some cleaning.

* Implementing keybindings in TextField.

* Updated command names and merged as discussed with @BDisp

- Merged LeftItem and LeftChar to Left (same for Right).
- Also renamed Kill to Cut
- Added ScrollLeft / ScrollRight (and renamed ScrollLineUp to just ScrollUp

* Renamed Command.InsertChar to ToggleOverwriteMode and added Enable/Disable

* Removed 'Mode' suffix from toggle overwrite

* Allows navigation to outside a TextView if IsMdiContainer is true.

* Implementing keybindings in Toplevel.

* Fixing null reference exception.

* Changing to keys instances events instead static.

* Transferring the events to the Toplevel.

* Implementing keybindings in TextView.

* Removing static from the QuitKeyChanged and adding unit test.

* Replacing Added with the Initialized event.

* Ignore control characters and other special keys.

* Changing InvokeKeybindings to return Nullable bool and added two more keys to the Toplevel.

* Implementing keybindings in Autocomplete. I had to derive from View.

* Added keybindings menu item to UICatalog

* Added ClearBinding

* Implementing IAutocomplete, abstract Autocomplete and derived TextViewAutocomplete.

* Implementing keybindings in the TextValidateProvider

* Add keybinding to CellActivationKey.

* Fixing some formats.

* Add ObjectActivationKey to the keybindings.

* Made it much easier to implement abstract base `Autocomplete` in other views by moving methods up out of `TextViewAutocomplete` implementation

* Allowing Autocomplete to popup inside or outside the container.

* Fixes the cursor not being showing if the text length is equal to the view width.

* A unit test to prove the 4df5897.

* Removed unused method `GetCursorPosition` from Autocomplete

* Trimmed down implementation specific methods from IAutocomplete

* Fixed xmldoc comment tag

* Format Autocomplete on multiline and fixes wrap settings.

* Adding keys from a to z to avoid the Key.Space on ToString.

* Fixes the vertical position outside the container.

* Adding more key unit tests.

* Changing comment to upper case and proving that doesn't will breaking nothing.

* Replaces Pos.Bottom to Pos.AnchorEnd.

* Fixes popup on resizing.

* Should only using the Pos.Bottom to position outside the view.

* Fixes #1584

* Fixes https://github.com/migueldeicaza/gui.cs/issues/1584#issuecomment-1027987475

* Fixes some bugs with SelectedItem.

* Command must also return a nullable bool.

* Ensures updating the ComboBox text on leaving the control.

* Only with the nullable bool was possible to make the MoveUp and the MoveDown working.

* Added logging of which scenario failed in test

Co-authored-by: BDisp <bd.bdisp@gmail.com>
2022-02-08 10:40:40 -08:00
BDisp
87f6cfc8ed Fixes #1557 - Border and PanelView fixes (#1563)
* Fixes #1557. Ensures the border child not to be null.

* Improves the PanelView and some bug fixes.

* Implementing rounded corners border.

* Fixes some items not showing on page down/up.
2022-02-06 14:43:38 -08:00
BDisp
6d108fd99d Fixed #1534. Label autosize redraw fix on shrink. 2021-12-06 22:25:46 +00:00
BDisp
58e7698f4c Fixes #1475. Selection ending with a white space error. (#1478)
* Fixes #1475. Selection ending with a white space error.

* Prevents the mouse  double click processing twice.

* Removing unnecessary variable.

* Sets ScrollViewBar CanFocus to false to ensure the host always focused.

* Only navigates through TabView if winDialog is not null and ensures TextView being focused.

* Fixes both dynamic menu and status bar broken scenarios.

* Fix a bug where the subviews oldEnabled can be overridden, even the superview Enable property hasn't changed.

* Fixes CanFocus when set to false and HasFocus is true.

* Fixes the broken TextView DesiredCursorVisibility.

* Prevents TextField being focused by mouse if CanFocus is false.

* Fixes the CanFocus on content views.

* Fixes #1470. Not all WindowsConsole.InputRecord are caught in WindowsDriver.

* Changing the input for a Queue object.

* Suppress warnings.

* Fixed yet the visibility cursor and adding more unit tests.

* Suppressing more warnings.
2021-10-25 12:40:18 -07:00
BDisp
2ef4edd08e NetDriver fixes keys modifiers not reseting and enter key on Windows Terminal. (#1484)
* Fixes keys modifiers not reseting and enter key on Windows Terminal.

* Fixes summary warnings.

* Ensures MainIteration processes  input while count greater than zero.

* Adding UseSystemConsole to the launch settings profile.

* Improves the performance with Console.Write by writing faster.
2021-10-25 12:31:49 -07:00
BDisp
9d767a4171 Dynamic menu/statusbar and Enable property fix. (#1489)
* Fixes both dynamic menu and status bar broken scenarios.

* Fix a bug where the subviews oldEnabled can be overridden, even the superview Enable property hasn't changed.
2021-10-25 12:29:27 -07:00
BDisp
d55ae77331 Fixes #1446. Added more features to the Border and Toplevel focus. (#1447)
* Fixes #1446. Added more features to the Border and Toplevel focus.

* Prevents throwing exception on negative effect3DOffset values

* Ensures that a view can be focused.

* Only sets focus if it isn't disposing.

* Fixes ViewToScreen and DrawChildBorder Effect3D.

* Unit test for negative coordinates with the ViewToScreen method.

* Added Tab navigation feature to the Editor scenario.

* ComboBox cursonDownKey nullref fix (#1472)

* added null guard to fix null ref when pressing keyDown inside combobox
Improved an error message when view cannot be found

* Added a unit test to ensure combobox can process all key events
Found and fixed a new nullref

* Found a new bug when source is already present and combobox is added to a top view

* searchSet is auto initialized to new List() now to make the code a little bit safer

* Fixes WindowsDriver HeightAsBuffer set to false. (#1466)

* Bump ReportGenerator from 4.8.12 to 4.8.13 (#1473)

Bumps [ReportGenerator](https://github.com/danielpalme/ReportGenerator) from 4.8.12 to 4.8.13.
- [Release notes](https://github.com/danielpalme/ReportGenerator/releases)
- [Commits](https://github.com/danielpalme/ReportGenerator/compare/v4.8.12...v4.8.13)

---
updated-dependencies:
- dependency-name: ReportGenerator
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fixes #1445. Fixing more the Curses and WSL clipboard. (#1448)

* Fixes #1445. Fixing more the Curses and WSL clipboard.

* Fixing unit tests.

* Changing namespace.

* Fixes WSL2 clipboard unit test.

* Upgrades devcontainer with the MainLoop fix.

* Fixes pasting with no selection and with lines break.

* Prevents the event button click being fired after a button pressed with mouse move.

* Fixes the char [ not being processed.

* Added Application.QuitKey property to allow change the quitting application key. (#1450)

* Added Application.QuitKey property to allow change the quitting application key.

* Fixes QuitKey unit test by reseting his value.

* Locks timeouts until is added.

* Fixes #1467. AlternateForward/BackwardKey bypasses dialog modality (#1468)

* Changed namespace.

* Fixing merge conflicts.

* Fixes mouse click issue.

* Removing windows resizing because buffer resizing is enough.

* Fixes #1477. Mouse click and console bottom on Windows Terminal.

Co-authored-by: Igor Bagdamyan <37334640+En3Tho@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-10-05 09:22:13 -07:00
Igor Bagdamyan
f602d3bd1d ComboBox cursonDownKey nullref fix (#1472)
* added null guard to fix null ref when pressing keyDown inside combobox
Improved an error message when view cannot be found

* Added a unit test to ensure combobox can process all key events
Found and fixed a new nullref

* Found a new bug when source is already present and combobox is added to a top view

* searchSet is auto initialized to new List() now to make the code a little bit safer
2021-09-29 14:14:32 -07:00
BDisp
8bfa2f0425 Border feature (#1436)
* Allowing pass the view to the RootMouseEvent.

* Allowing bring the current window to front on dragging.

* Improving the ConsoleDriver to get the Attribute colors based on the value.

* Added a PanelView to deal with borders.

* Added a Border feature to all views.
2021-08-26 07:55:19 -07:00
BDisp
52f48b2044 Fixes #1384. Added a VisibleChanged event on the View class. (#1385)
* Fixes #1384. Added a VisibleChanged event on the View class.

* Getting the last char.

* Fixes #871. Added Enable property to Responder and added Disabled color for all ColorSchemes.

* Added GetNormalColor method to the View being more readable.

* Fixes the contentBottomRightCorner Enable and Visible.

* Fixes #643. Added AddItemAt and RemoveItem to StatusBar and fixed more bugs.

* Typo fixes.

* Fixes #1387. Allowing the UnitTests project to test internal keywords.

* Fixes #1389. Added a unidirectional feature to the Marquee styles to the ProgressBar.

* Fixes #1394. Added ReflectedType to check for overridden.

* Fixes #1396. Using the Loaded event instead the Ready event.

* Fixes #1402. Only WindowsDriver supports horizontal scroll. (#1403)

* Fixes #1402. Only WindowsDriver supports horizontal scroll.

* Fixes ProcessContinuousButtonPressedAsync on all drivers.

* Fixed internal unit test.

* Fixing warning.

* Fixing Editor scenario error.

* Fixes double and triple click on a touchpad.

* Ensuring reset the counting.

* Allowing touchpad double and triple click with one finger on CursesDriver.

* Allowing touchpad double and triple click with one finger on WindowsDriver.

* Fixes #1414. Fixed multi toplevels and mdi container issues.

* Improving EnsureVisibleBounds and PositionToplevel.

* Added mouseGrabView to the ResetState method.

* Changing namespace.

* Allowing file type on the SaveDialog.

* Fixes SaveDialogs writing the extension twice.
2021-08-11 02:56:30 -07:00
Charlie Kindel
91c3294491 Merge pull request #1366 from BDisp/colorscheme-setter
Fixes #1078. ColorScheme setter now calls SetNeedsDisplay.
2021-07-21 08:58:56 -07:00
BDisp
d24b7ef25c Fixing the potential infinite loops on changing the property. 2021-07-18 16:15:10 +01:00