Commit Graph

4635 Commits

Author SHA1 Message Date
Brandon Thetford
2b25aca129 Remove now-invalid usings. 2024-02-22 19:56:09 -07:00
Brandon Thetford
ac0b655b1a Add explicit casts to a few tests to ensure the correct type is tested. 2024-02-22 19:56:09 -07:00
Brandon Thetford
21fbb4c321 Define casts and equality operators to enable mostly-seamless transition away from Rect 2024-02-22 19:56:09 -07:00
Brandon Thetford
20a49c917b Remove Rectangle type and alias System.Drawing.Rectangle to Rectangle
Also remove a duplicate global using
2024-02-22 19:56:09 -07:00
Brandon Thetford
17d028432e Re-apply Rect->Rectangle name changes in these files 2024-02-22 16:03:06 -07:00
Brandon Thetford
70ca504687 This check is redundant with the rectangle check below 2024-02-22 16:01:59 -07:00
Brandon Thetford
48becffb35 Update this since 6.0.0 is no longer available and prevents build 2024-02-22 15:56:55 -07:00
Brandon Thetford
3d807c3833 Merge branch 'v2_develop' into v2_3256_prepare_for_Rect_removal
* v2_develop:
  Fixes #3039. Fix View.HotKey (#3249)
2024-02-22 15:51:04 -07:00
Tig
16055c53b0 Fixes #3039. Fix View.HotKey (#3249)
* Added View.DefaultCommand etc... Started on dedicated scenario

* Fixed un-shifted hotkeys -> Fixed Key Equals. Fixed WindowsDriver passing wrong key. Etc.

* Fixed Key Bindings and HotKeys

* Fixed Key Bindings and HotKeys

* Label now correctly supports hotkey

* Disabled unix hot keys because they are annoying and get in the way

* Updated nuget. fixed warnings

* Trying to fix ci/ci issue

* Trying to fix ci/ci issue

* Trying to fix ci/ci issue

* Changed TextChangingEventArgs to inherit from CancelEventArgs

* TextChangingEventArgs -> TextEventArgs

* Simplified Text events by having only on args class

* Fixed unit tests fail

* Simplified by removing TitleEventArgs

* POC of Title being primary for hotkey. Label and Button hacked to work

* POC of Title being primary for hotkey. Label and Button hacked to work - all unit tests pass

* Dropped Microsoft.NETFramework.ReferenceAssemblies

* Fixed Dialogs scenario hotkeys

* Fixed build warnings

* Fixed Border Title render bug

* Regiggering default command handling

* Regiggering default command handling

* Checkbox clean up

* Added StateEventArgs POC

* Command.Default -> Command.HotKey

* Command.Default -> Command.HotKey - fixed TableView

* Command.Default -> Command.HotKey - fixed TableView

* Updated reactive example

* Fixed Toplevel.BringOverlappedTopToFront - was reordering SubViews when it shouldn't

* WIP - broke

* Finished impl of StateEventArgs

* Deleted ToggleEventArgs.cs. Added StateEventArgs.cs

* XML doc fix

* Removed old code

* Removed commented out code

* Label.Clicked -> Label.Accept (missed this before)

* Removed Labels as Buttons scenario as it's not really  useful

* Moved SubView tests to own file

* Moved SubView tests to own file

* Simplified Text test

* Added OnAccept test

* Deleted DefaultCommand

* Modernized CheckBox

* New button test

* Cleaned up RadioGroup; added tests

* KeyCode->Key in ListView

* Added ListView unit tests

* ListView now does Accept correctly

* TreeView now does Accept correctly

* Cleaned up some TextField tests

* TextView now handles Accept properly; updated CharMap and Adornments scenarios to test

* Fixed ComboBox to deal with TextView now handles Accept properly; updated CharMap and Adornments scenarios to test

* Removed un-needed using statement
2024-02-22 15:11:26 -07:00
dodexahedron
2ae06f7b72 Merge branch 'v2_develop' into v2_3256_prepare_for_Rect_removal 2024-02-21 17:03:21 -07:00
dodexahedron
55cb3e76b4 V2 Cleanup Batch 1 (Per #3253) (#3255)
* Replace all 342 `== null` with `is null`

* Replace 354 `!= null` with `is { }`

* Wrap these in conditionals since they break tests against Release configuration

The members they depend on do not exist in Release configuration

* Split these up and dispose properly

This test needs to be revisited for several reasons at some point.

* Fix release configuration tests

* Declare interface these already support

* Annotate constructor properly and use throw helper

* Move class to its own file

* Rename these files so they nest in the solution explorer

* Make this a record type and remove now-redundant/illegal members

* Reference passing to avoid some struct copies

* Simplify this

* Carry reference passing through as appropriate

* Turn this into a record struct

* Remove unused internal constructor and its test

It was only used by that test.

* Simplify this constructor

* This should be a property

* Simplify constructor

* Simplify GetHashCode

* Mark this ignored just in case

* Missed a couple of opportunities for reference passing

* record struct already does this by value

* Remove unused class

* Simplify the type initializer and Reset method

* Implement INotifyCollectionChanged and IDictionary by delegating to ColorSchemes

* Fix for reflection-based configuration

* Make CI  build happy by disambiguiating this attribute

* Add PERF, NOTE, QUESTION, and CONCURRENCY tags for the todo explorer

* Make this string comparison faster.

* Add a tag for unclear intent

* This is a constant

* Turn this into a constant via use of a unicode literal

* Remove this method and its test

It is unused
There's no guarantee at all that the parent process is the terminal.
There are good reasons, including that one, why there's no simple way to do it in .net.
It's also of course a windows-only thing, if using WMI.

* With the WMI method gone, we no longer need this

* Make this more efficient

* Add detail to this property's XmlDoc

* Move the general properties up top because order matters

* Make sure any constants defined at higher levels are not clobbered and define a couple more

* Put InternalsVisibleTo in its own group

* Sort dependencies alphabetically and update

* Global usings

* Split to one type per file

* Collection expression

* Fix naming

* Inline to avoid copies

* This is already a value copy (struct)

* Combine to one non-destructive mutation

* Avoid some potential boxing

* Turn on null analysis here

* Remove unnecessary cast and use real type name

* Seal this

* Fix name

* Move nested class to a nested file (no type layout change made)

* Undo naming change that isn't changed globally until next batch
2024-02-21 06:31:54 -07:00
Brandon Thetford
feca713516 Change GetHashCode to be equivalent to System.Drawing.Rectangle 2024-02-20 21:37:24 -07:00
Brandon Thetford
47fad6189d Re-apply backed-out naming change from parent branch 2024-02-20 20:21:35 -07:00
Brandon Thetford
56fc0b23d1 Some more categorization 2024-02-20 20:19:52 -07:00
Brandon Thetford
b65e2fb5f8 Use raw strings for better clarity 2024-02-20 20:19:52 -07:00
Brandon Thetford
f3c1f5c67d Add a category to this 2024-02-20 20:19:52 -07:00
Brandon Thetford
53fbdab54d Make this easier to follow (naming only) 2024-02-20 20:19:52 -07:00
Brandon Thetford
7242905343 Perform proper platform-agnostic normalization 2024-02-20 20:19:52 -07:00
Brandon Thetford
cc447306ab Remove this 2024-02-20 20:19:52 -07:00
Brandon Thetford
c50c4559d0 Collection expressions and constants 2024-02-20 20:19:52 -07:00
Brandon Thetford
e670960ee0 Test against Rectangles, not strings 2024-02-20 20:19:52 -07:00
Brandon Thetford
93f21b8edd Slightly de-couple these as well 2024-02-20 20:19:52 -07:00
Brandon Thetford
8252203c75 These should be testing against the Rectangles, not the strings 2024-02-20 20:19:52 -07:00
Brandon Thetford
f0b2fb1820 Fix these tests the same way as the previous commit 2024-02-20 20:19:52 -07:00
Brandon Thetford
3d0c750bd6 Fix this test
This is not a test of Rectangle, so trust that Rectangle gets it right.
2024-02-20 20:19:52 -07:00
Brandon Thetford
53df3eac2a Change to behavior matching System.Drawing.Rectangle 2024-02-20 20:19:52 -07:00
Brandon Thetford
e38933d3d6 Add baseline test for ToString checking for current behavior. 2024-02-20 20:19:52 -07:00
Brandon Thetford
a638edeeaf Rename Rect to Rectangle in preparation for removal 2024-02-20 20:19:52 -07:00
Brandon Thetford
13bd11d5d0 Undo naming change that isn't changed globally until next batch 2024-02-20 20:19:29 -07:00
Brandon Thetford
afe4e2191e Merge remote-tracking branch 'origin/v2_develop' into v2_cleanup_work_1
* origin/v2_develop:
  Fixes #3242 - Replaces simple null checks (#3248)
2024-02-20 20:16:39 -07:00
Brandon Thetford
b3a49bbebe Move nested class to a nested file (no type layout change made) 2024-02-20 17:20:54 -07:00
Brandon Thetford
3bf091d713 Fix name 2024-02-20 17:20:54 -07:00
Brandon Thetford
8d581f24d7 Seal this 2024-02-20 17:20:54 -07:00
Brandon Thetford
4f8b272240 Remove unnecessary cast and use real type name 2024-02-20 17:20:54 -07:00
Brandon Thetford
39a66bf5c4 Turn on null analysis here 2024-02-20 17:20:54 -07:00
Brandon Thetford
76b247a9b3 Avoid some potential boxing 2024-02-20 17:20:54 -07:00
Brandon Thetford
6865391bd1 Combine to one non-destructive mutation 2024-02-20 17:20:54 -07:00
dodexahedron
deaa7563fc This is already a value copy (struct) 2024-02-20 17:20:54 -07:00
Brandon Thetford
0fb31d19f7 Inline to avoid copies 2024-02-20 17:20:54 -07:00
dodexahedron
1e05e24998 Fix naming 2024-02-20 17:20:54 -07:00
Brandon Thetford
e7fdd4c5a1 Collection expression 2024-02-20 17:20:54 -07:00
Brandon Thetford
b4795c722a Split to one type per file 2024-02-20 17:20:54 -07:00
Brandon Thetford
63eafaa03f Global usings 2024-02-20 17:20:54 -07:00
Brandon Thetford
2ecf55b025 Sort dependencies alphabetically and update 2024-02-20 17:20:54 -07:00
Brandon Thetford
6f7af499da Put InternalsVisibleTo in its own group 2024-02-20 17:20:54 -07:00
Brandon Thetford
71f0db1cb7 Make sure any constants defined at higher levels are not clobbered and define a couple more 2024-02-20 17:20:54 -07:00
Brandon Thetford
242a62987a Move the general properties up top because order matters 2024-02-20 17:20:54 -07:00
Brandon Thetford
f57ec92b15 Add detail to this property's XmlDoc 2024-02-20 17:20:54 -07:00
Brandon Thetford
05d41bc21c Make this more efficient 2024-02-20 17:20:54 -07:00
Brandon Thetford
1360c4747b With the WMI method gone, we no longer need this 2024-02-19 04:31:47 -07:00