Brandon Thetford
53fbdab54d
Make this easier to follow (naming only)
2024-02-20 20:19:52 -07:00
Brandon Thetford
7242905343
Perform proper platform-agnostic normalization
2024-02-20 20:19:52 -07:00
Brandon Thetford
cc447306ab
Remove this
2024-02-20 20:19:52 -07:00
Brandon Thetford
c50c4559d0
Collection expressions and constants
2024-02-20 20:19:52 -07:00
Brandon Thetford
e670960ee0
Test against Rectangles, not strings
2024-02-20 20:19:52 -07:00
Brandon Thetford
93f21b8edd
Slightly de-couple these as well
2024-02-20 20:19:52 -07:00
Brandon Thetford
8252203c75
These should be testing against the Rectangles, not the strings
2024-02-20 20:19:52 -07:00
Brandon Thetford
f0b2fb1820
Fix these tests the same way as the previous commit
2024-02-20 20:19:52 -07:00
Brandon Thetford
3d0c750bd6
Fix this test
...
This is not a test of Rectangle, so trust that Rectangle gets it right.
2024-02-20 20:19:52 -07:00
Brandon Thetford
53df3eac2a
Change to behavior matching System.Drawing.Rectangle
2024-02-20 20:19:52 -07:00
Brandon Thetford
e38933d3d6
Add baseline test for ToString checking for current behavior.
2024-02-20 20:19:52 -07:00
Brandon Thetford
a638edeeaf
Rename Rect to Rectangle in preparation for removal
2024-02-20 20:19:52 -07:00
Brandon Thetford
13bd11d5d0
Undo naming change that isn't changed globally until next batch
2024-02-20 20:19:29 -07:00
Brandon Thetford
afe4e2191e
Merge remote-tracking branch 'origin/v2_develop' into v2_cleanup_work_1
...
* origin/v2_develop:
Fixes #3242 - Replaces simple null checks (#3248 )
2024-02-20 20:16:39 -07:00
Brandon Thetford
b3a49bbebe
Move nested class to a nested file (no type layout change made)
2024-02-20 17:20:54 -07:00
Brandon Thetford
3bf091d713
Fix name
2024-02-20 17:20:54 -07:00
Brandon Thetford
8d581f24d7
Seal this
2024-02-20 17:20:54 -07:00
Brandon Thetford
4f8b272240
Remove unnecessary cast and use real type name
2024-02-20 17:20:54 -07:00
Brandon Thetford
39a66bf5c4
Turn on null analysis here
2024-02-20 17:20:54 -07:00
Brandon Thetford
76b247a9b3
Avoid some potential boxing
2024-02-20 17:20:54 -07:00
Brandon Thetford
6865391bd1
Combine to one non-destructive mutation
2024-02-20 17:20:54 -07:00
dodexahedron
deaa7563fc
This is already a value copy (struct)
2024-02-20 17:20:54 -07:00
Brandon Thetford
0fb31d19f7
Inline to avoid copies
2024-02-20 17:20:54 -07:00
dodexahedron
1e05e24998
Fix naming
2024-02-20 17:20:54 -07:00
Brandon Thetford
e7fdd4c5a1
Collection expression
2024-02-20 17:20:54 -07:00
Brandon Thetford
b4795c722a
Split to one type per file
2024-02-20 17:20:54 -07:00
Brandon Thetford
63eafaa03f
Global usings
2024-02-20 17:20:54 -07:00
Brandon Thetford
2ecf55b025
Sort dependencies alphabetically and update
2024-02-20 17:20:54 -07:00
Brandon Thetford
6f7af499da
Put InternalsVisibleTo in its own group
2024-02-20 17:20:54 -07:00
Brandon Thetford
71f0db1cb7
Make sure any constants defined at higher levels are not clobbered and define a couple more
2024-02-20 17:20:54 -07:00
Brandon Thetford
242a62987a
Move the general properties up top because order matters
2024-02-20 17:20:54 -07:00
Brandon Thetford
f57ec92b15
Add detail to this property's XmlDoc
2024-02-20 17:20:54 -07:00
Brandon Thetford
05d41bc21c
Make this more efficient
2024-02-20 17:20:54 -07:00
Brandon Thetford
1360c4747b
With the WMI method gone, we no longer need this
2024-02-19 04:31:47 -07:00
Brandon Thetford
776044b716
Remove this method and its test
...
It is unused
There's no guarantee at all that the parent process is the terminal.
There are good reasons, including that one, why there's no simple way to do it in .net.
It's also of course a windows-only thing, if using WMI.
2024-02-19 04:31:47 -07:00
Brandon Thetford
b2c05221bd
Turn this into a constant via use of a unicode literal
2024-02-19 04:31:47 -07:00
Brandon Thetford
278af5a55a
This is a constant
2024-02-19 04:31:47 -07:00
Brandon Thetford
fcfc7245f1
Add a tag for unclear intent
2024-02-19 04:31:47 -07:00
Brandon Thetford
1bc3595d0e
Make this string comparison faster.
2024-02-19 04:31:47 -07:00
Brandon Thetford
24aefb9ad9
Add PERF, NOTE, QUESTION, and CONCURRENCY tags for the todo explorer
2024-02-19 04:31:47 -07:00
dodexahedron
34bef2c839
Fixes #3242 - Replaces simple null checks ( #3248 )
...
* Replace all 342 `== null` with `is null`
* Replace 354 `!= null` with `is { }`
* Wrap these in conditionals since they break tests against Release configuration
The members they depend on do not exist in Release configuration
* Split these up and dispose properly
This test needs to be revisited for several reasons at some point.
* Fix release configuration tests
* Declare interface these already support
* Annotate constructor properly and use throw helper
* Move class to its own file
* Rename these files so they nest in the solution explorer
* Make this a record type and remove now-redundant/illegal members
* Reference passing to avoid some struct copies
* Simplify this
* Carry reference passing through as appropriate
* Turn this into a record struct
* Remove unused internal constructor and its test
It was only used by that test.
* Simplify this constructor
* This should be a property
* Simplify constructor
* Simplify GetHashCode
* Mark this ignored just in case
* Missed a couple of opportunities for reference passing
* record struct already does this by value
* Remove unused class
* Simplify the type initializer and Reset method
* Implement INotifyCollectionChanged and IDictionary by delegating to ColorSchemes
* Fix for reflection-based configuration
* Make CI build happy by disambiguiating this attribute
2024-02-16 16:46:25 -07:00
Brandon Thetford
cf2ffef85b
Make CI build happy by disambiguiating this attribute
2024-02-16 16:09:18 -07:00
Brandon Thetford
e7b228a2c8
Fix for reflection-based configuration
2024-02-16 16:05:03 -07:00
Brandon Thetford
3cd0832cb0
Implement INotifyCollectionChanged and IDictionary by delegating to ColorSchemes
2024-02-15 19:49:09 -07:00
Brandon Thetford
e4024a5fc3
Simplify the type initializer and Reset method
2024-02-15 19:06:48 -07:00
Brandon Thetford
c0a838113c
Remove unused class
2024-02-15 19:06:19 -07:00
Brandon Thetford
74c8920f32
record struct already does this by value
2024-02-15 19:05:26 -07:00
Brandon Thetford
37b58afc39
Missed a couple of opportunities for reference passing
2024-02-15 19:05:03 -07:00
Brandon Thetford
d8a9f0f9a0
Mark this ignored just in case
2024-02-15 18:54:56 -07:00
Brandon Thetford
17a565ed74
Simplify GetHashCode
2024-02-15 18:53:25 -07:00
