fix webpack compression exception

Bumps [ws](https://github.com/websockets/ws) and [socket.io-adapter](https://github.com/socketio/socket.io-adapter). These dependencies needed to be updated together.

Updates `ws` from 8.11.0 to 8.17.1
- [Release notes](https://github.com/websockets/ws/releases)
- [Commits](https://github.com/websockets/ws/compare/8.11.0...8.17.1)

Updates `socket.io-adapter` from 2.5.2 to 2.5.5
- [Release notes](https://github.com/socketio/socket.io-adapter/releases)
- [Changelog](https://github.com/socketio/socket.io-adapter/blob/2.5.5/CHANGELOG.md)
- [Commits](https://github.com/socketio/socket.io-adapter/compare/2.5.2...2.5.5)

---
updated-dependencies:
- dependency-name: ws
  dependency-type: indirect
- dependency-name: socket.io-adapter
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

.github/workflows/node.js.yml

@@ -16,7 +16,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [14.x]
+        node-version: [20.x]
         # See supported Node.js release schedule at https://nodejs.org/en/about/releases/
 
     steps:

Dockerfile

@@ -1,6 +1,6 @@
 # Use the official lightweight Node.js 14 image.
 # https://hub.docker.com/_/node
-FROM node:14-slim
+FROM node:20-slim
 
 # Create and change to the app directory.
 WORKDIR /usr/src/app

Dockerfile.dev

@@ -1,4 +1,4 @@
-FROM node:14-slim
+FROM node:20-slim
 
 WORKDIR /usr/src/app
 

client/src/modules/page_handlers/gameHandler.js

@@ -18,7 +18,7 @@ import { InProgress } from '../game_state/states/InProgress.js';
 import { Ended } from '../game_state/states/Ended.js';
 
 export const gameHandler = (socket, window, gameDOM) => {
-    window.onunload = () => {
+    window.onpagehide = () => {
         socket.close();
     };
     document.body.innerHTML = gameDOM + document.body.innerHTML;
@@ -60,8 +60,11 @@ export const gameHandler = (socket, window, gameDOM) => {
                     toast(err, 'error', true, false);
                 });
 
-                socket.on('disconnect', () => {
+                socket.on('disconnect', (reason) => {
                     toast('Disconnected. Attempting reconnect...', 'error', true, false);
+                    if (reason === 'io client disconnect') { // see https://socket.io/docs/v4/client-api/#event-disconnect
+                        socket.connect();
+                    }
                 });
                 setClientSocketHandlers(stateBucket, socket);
                 resolve();

client/webpack/webpack-prod.config.js

@@ -15,7 +15,7 @@ module.exports = {
         path: path.resolve(__dirname, '../dist'),
         filename: "[name]-bundle.js"
     },
-    plugins: [new CompressionPlugin({ deleteOriginalAssets: true, exclude: [/521-bundle.js$/]})],
+    plugins: [new CompressionPlugin({ deleteOriginalAssets: true, exclude: [/\d+-bundle.js$/]})],
     mode: "production",
     node: false,
     module: {

package.json

@@ -21,24 +21,24 @@
   },
   "main": "index.js",
   "engines": {
-    "node": ">= 14.0.0"
+    "node": ">= 20.0.0"
   },
   "author": "",
   "license": "ISC",
   "dependencies": {
     "babel-loader": "^8.2.3",
-    "body-parser": "^1.20.1",
+    "body-parser": "^1.20.3",
     "compression-webpack-plugin": "^10.0.0",
     "cors": "^2.8.5",
-    "express": "^4.18.2",
+    "express": "^4.21.1",
     "express-force-https": "^1.0.0",
     "express-rate-limit": "^6.0.1",
     "open": "^7.0.3",
     "rate-limiter-flexible": "^2.3.6",
     "redis": "^4.5.1",
     "regenerator-runtime": "^0.13.9",
-    "socket.io": "^4.6.1",
+    "socket.io": "^4.8.1",
-    "socket.io-client": "^4.5.4"
+    "socket.io-client": "^4.7.5"
   },
   "devDependencies": {
     "@babel/core": "^7.18.13",
@@ -59,7 +59,7 @@
     "karma": "^6.3.16",
     "karma-chrome-launcher": "^3.1.0",
     "karma-jasmine": "^4.0.1",
-    "webpack": "^5.76.0",
+    "webpack": "^5.94.0",
     "webpack-cli": "^4.9.1",
     "webpack-remove-debug": "^0.1.0"
   },

server/modules/singletons/GameManager.js

@@ -191,7 +191,7 @@ class GameManager {
             && game.people.filter(person => person.userType === USER_TYPES.SPECTATOR).length === PRIMITIVES.MAX_SPECTATORS
         ) {
             return Promise.reject({ status: 400, reason: 'There are too many people already spectating.' });
-        } else if (joinAsSpectator || this.isGameStartable(game)) {
+        } else if (joinAsSpectator || this.isGameStartable(game) || game.status === STATUS.IN_PROGRESS) {
             return await addSpectator(game, name, this.logger, this.namespace, this.eventManager, this.instanceId, this.refreshGame);
         }
         let moderator, newPlayer;