- Started MouseEventEventArgs -> MouseEvent transition - for OnMouseEvent. Partially fixes#3029.
- Refactored Appliation.OnMouseEvent and View.OnMouseEvent to match design guidelines.
- Re-impleented highlight, enabling extensibility (see Border).
- Beefed up unit tests
* Added View.DefaultCommand etc... Started on dedicated scenario
* Fixed un-shifted hotkeys -> Fixed Key Equals. Fixed WindowsDriver passing wrong key. Etc.
* Fixed Key Bindings and HotKeys
* Fixed Key Bindings and HotKeys
* Label now correctly supports hotkey
* Disabled unix hot keys because they are annoying and get in the way
* Updated nuget. fixed warnings
* Trying to fix ci/ci issue
* Trying to fix ci/ci issue
* Trying to fix ci/ci issue
* Changed TextChangingEventArgs to inherit from CancelEventArgs
* TextChangingEventArgs -> TextEventArgs
* Simplified Text events by having only on args class
* Fixed unit tests fail
* Simplified by removing TitleEventArgs
* POC of Title being primary for hotkey. Label and Button hacked to work
* POC of Title being primary for hotkey. Label and Button hacked to work - all unit tests pass
* Dropped Microsoft.NETFramework.ReferenceAssemblies
* Fixed Dialogs scenario hotkeys
* Fixed build warnings
* Fixed Border Title render bug
* Regiggering default command handling
* Regiggering default command handling
* Checkbox clean up
* Added StateEventArgs POC
* Command.Default -> Command.HotKey
* Command.Default -> Command.HotKey - fixed TableView
* Command.Default -> Command.HotKey - fixed TableView
* Updated reactive example
* Fixed Toplevel.BringOverlappedTopToFront - was reordering SubViews when it shouldn't
* WIP - broke
* Finished impl of StateEventArgs
* Deleted ToggleEventArgs.cs. Added StateEventArgs.cs
* XML doc fix
* Removed old code
* Removed commented out code
* Label.Clicked -> Label.Accept (missed this before)
* Removed Labels as Buttons scenario as it's not really useful
* Moved SubView tests to own file
* Moved SubView tests to own file
* Simplified Text test
* Added OnAccept test
* Deleted DefaultCommand
* Modernized CheckBox
* New button test
* Cleaned up RadioGroup; added tests
* KeyCode->Key in ListView
* Added ListView unit tests
* ListView now does Accept correctly
* TreeView now does Accept correctly
* Cleaned up some TextField tests
* TextView now handles Accept properly; updated CharMap and Adornments scenarios to test
* Fixed ComboBox to deal with TextView now handles Accept properly; updated CharMap and Adornments scenarios to test
* Removed un-needed using statement
* Removed resharper settings from editorconfig
* Remove constructors with frame parameters from Button class.
* Remove constructors with frame parameters from CheckBox class.
* Cleanup code.
* Remove constructors with frame parameters from ComboBox class.
* @BDisp
Remove constructors with frame parameters from FrameView class.
* Remove constructors with frame parameters from Label class.
* Remove constructors with frame parameters from ListView class.
* Remove constructors with frame parameters from ScrollBarView class.
* Remove constructors with frame parameters from ScrollView class.
* Remove namespace braces.
* Cleanup code.
* Cleanup code.
* Cleanup code.
* Remove constructors with frame parameters from TextField class.
* Remove constructors with frame parameters from TimeField class.
* Fixes#3182. OnResizeNeeded returns int.MaxValue and int.MaxValue when Application.Top is null, should return Size.Empty.
* Remove constructors with frame parameters from Toplevel class.
* Remove constructors with frame parameters from Window class.
* Fix merge errors.
* Revert "Fixes #3182. OnResizeNeeded returns int.MaxValue and int.MaxValue when Application.Top is null, should return Size.Empty."
This reverts commit cf9c24b846.
* Revert unit test.
* Fixes#2882. TabView: 'Frame.DrawFrame(Rect, bool)' is obsolete: 'This method is obsolete in v2. Use use LineCanvas or Frame (#2980)
* Fixes#2882. TabView: 'Frame.DrawFrame(Rect, bool)' is obsolete: 'This method is obsolete in v2. Use use LineCanvas or Frame
* Trying fix this unit test that sometimes fail.
* Fixes#2983. View need a alternative DrawFrame for the v2.
* Use new DrawFrame method.
* Change _lines field to Lines property.
* Add TabWindow unit test.
* Add DrawIncompleteFrame method and unit tests.
* Add more unit tests to LineCanvas.
* Fix newline conflict errors.
* Revert "Change _lines field to Lines property."
This reverts commit ab6c5f3094.
* Add DrawIncompleteFrame method and unit tests.
* Add more unit tests to LineCanvas.
* Fix newline conflict errors.
* Force render immediately instead of join.
* I will never rely on zero-location-based unit test again.
* Fix TestTreeViewColor unit test fail.
* Using location of 3 to avoid be divisible by 2 and so avoiding bugs.
* Revert "Using location of 3 to avoid be divisible by 2 and so avoiding bugs."
This reverts commit dd3df135d8.
* Revert "I will never rely on zero-location-based unit test again."
This reverts commit 62adf6f285.
* Revert "Fix newline conflict errors."
This reverts commit 4acf72612d.
* Revert "Add more unit tests to LineCanvas."
This reverts commit 66bc6f514e.
* Revert "Add DrawIncompleteFrame method and unit tests."
This reverts commit 680ba264e1.
* Resolving merge conflicts.
* Revert "Use new DrawFrame method."
This reverts commit 69a7f17f19.
* Revert "Fixes #2983. View need a alternative DrawFrame for the v2."
This reverts commit dade9fd767.
* Reverting this changes to start a new one.
* Add horizontal and vertical support for combining glyphs.
* Fix text and auto size behavior.
* Add TabWidth property.
* Add unit test for WordWrap.
* Fixes#3017. View TextDirection returns incorrect size on a vertical direction instance with AutoSize as false.
* Using Frame to force read from the get method.
* Fix some issues with AutoSize and ForceValidatePosDim.
* Fixing broken unit tests.
* Restoring code I've broken.
* Removing forgotten code.
* Only LayoutStyle.Computed can change the Frame.
* DateField and TimeField depends on LayoutStyle.Computed.
* Fix unit tests related with LayoutStyle.
* Implements tabs, left and right arrows as View.
* Draws a minimum full border.
* Adds missing XML parameter.
* Adds assert tests for Frame.
* Removes duplicates InlineData.
* Adds more unit tests for minimum full border without Left and Right thickness.
* Trying to fix the TestTreeViewColor unit test fail.
* Prevents a user to set TextDirection to -1.
* Prevents any invalid TextDirection value.
* Removes (TextDirection)(-1).
* Removes unnecessary TextDirection initialization.
* Removes LayoutStyle.
* Fixing unit tests with border.
* Trying to fix TestTreeViewColor again.
* Revert "Trying to fix TestTreeViewColor again."
This reverts commit c2efa8e42e.
* Trying to fix TestTreeViewColor again.
* Fix merge errors.
* Fix merge errors.
* Restoring unit test.
* Restores the right XML comment.
* Fix Disposing unit tests that sometimes throws because some instances aren't cleared on others unit tests classes.
* Fix Disposing unit tests that sometimes throws because some instances aren't cleared on others unit tests classes.
* Only call OnResizeNeeded if it's LayoutStyle.Computed.
* Fix merge errors.
* Fix merge errors.
* Fix unit tests fail.
* Reformat.
* Again.
* Rename to OnDrawAdornments.
* Fix failing unit tests.
* Reduces indentation and cleanup code.
* Cleanup code.
* Fix bug done when cleanup.
* Replace FrameHandledMouseEvent to AdornmentHandledMouseEvent.
* Removes Tab constructor parameters.
---------
Co-authored-by: Tig <tig@users.noreply.github.com>
* Fix merge errors.
* Remove constructors with parameters from Button.
* Remove parenthesis on objects initializers from Button.
* Remove constructors with parameters from CheckBox.
* Remove parenthesis on objects initializers from CheckBox.
* Remove constructors with parameters from ComboBox.
* Remove constructors with parameters from FrameView.
* Remove parenthesis on objects initializers from FrameView.
* Initial commit
* Renamed Direction enum for clarity in refactoring unit tests
* Moved nav tests to NavigationTests
* Moved view tests around
* Cleaning up TextFormatter and View.AutoSize code
* Fixed latent TextFormatter bug with \n
* removed Application dependency on some autosize unit tests
* Fixed Label tests to deal with auotsize overriding height/width
* Fixed more label tests. WIP
* Fixed all places where AutoSize = happend after setting Dims
* Started adding new primitive View.Text tests
* Code comments
* WIP: Enforce that it makes no sense to set Width/Height if AutoSize = true. Update Unit tests to match.
* WIP: Enforce that it makes no sense to set Width/Height if AutoSize = true. Update Unit tests to match.
* Remove frame set from the View constructor and prevent SetRelativeLayout running if not yet initialized.
* Changes needed for unit tests pass on remove parameters constructors from the Label class.
* Remove constructors with parameters from Label.
* Remove parenthesis on objects initializers from Label.
* Prefix private fields with underscore.
* Renamed to MaxLength.
* Remove constructors with parameters from ListView.
* MakeWrapper not needed anymore.
* Remove parenthesis on objects initializers from ListView.
* WIP: Enforce that it makes no sense to set Width/Height if AutoSize = true. Update Unit tests to match.
* Massive code cleanup - use parameterless constructors and ensure AutoSize is set properly. Code reformat.
* Massive code cleanup - use parameterless constructors and ensure AutoSize is set properly. Code reformat.
* Fixed messagebox
* Remove constructors with parameters from ScrollBarView and ScrollView.
* Remove parenthesis on objects initializers from ScrollBarView and ScrollView.
* Cleanup code.
* Fix merge errors.
* Add empty dotsettings for solution and projects.
* Set ReSharper language analysis level for projects to C#12
* Make ReSharper consider itself the boss for style
* Add rule to enforce property backing fields above the property
* Disable auto-detection of naming rules so ReSharper doesn't change them by itself
* Don't let someone's VS settings override the indent settings
* Explicitly set tab width to 4 spaces and force spaces.
* Rules to keep various multi-line constructs aligned within themselves
* Curly brace rules (Using K&R style, per current project spec)
* Blank line rules
Mostly to add breaks in various situations, and also to enforce max of 1 blank line.
* Increase auto-wrap to 160 from default of 120
* Line break at end of all files, to make Unixy systems happy
* Keep attributes on their own lines except for methods and records that are themselves single-line
* Increase attribute auto-wrap to 60 from default of 38
* Wrap/chop rules for long method signatures and record declarations
Chop if either already multi-line or if over 8 parameters.
Chop AFTER the left paren and BEFORE the first parameter.
* Chop rules for generics
For generics with multi-line type parameters or multiple type parameter constraints, chop in a way that has consistent alignment.
* Always enforce enum members on their own lines
* One-line functions completely on one line
They're usually expression-bodied anyway, here, so this is almost irrelevant
* Keep control flow statements on their own lines
* Follow same chop rules for method invocation as method declaration
* Chop long or multi-line method chains or patterns
* Wrap rules for binary operators
Operator at beginning of new lines
Auto-chop if long or already multi-line
* Spaces between keywords and their opening parentheses
* Add file layout rules for organization of reorderable items like fields, properties, etc.
Ugly XML, so load it up in the UI to look at it
It's MOSTLY the ReSharper defaults, but with more aggressive sorting, generally by access modifier and name, within each grouping.
* Deconstructors use per-member types
* Use keywords for built-in types and increase severity of inspection for violations
Also apply to IntPtr and similar, which should now be nint and similar
* Apply syntax style on completion.
* Use var when evident for built-in and simple types, but not elsewhere
* Increase severity for some minor redundancy and clarity inspections
* Enforce braces always required for blocks, and treat as error
* Warn if a local function is not statement-bodied
* Increase various inspection severities
IF Condition => Severity:
Attributes not wrapped property => Suggestion
Constructors expression-bodied => Error
default doesn't have type when it isn't clear => suggestion
Namespaces not file-scoped => error
Methods not statement-bodied => hint
Null check pattern not the object property pattern => Error
* Adjust preference order of null check patterns to make object pattern highest
* XmlDoc rules to keep tags and contents aligned and wrapped
* Add a few custom profiles for code cleanup and make the full profile default
* Remove parts for languages not used in this solution
* copied in v2_develop changes
* Merged v2_develop
* Added Begin/Init unit tests. Removed Application dependencey from AutoSizeFalse tests
* TextFormatter.Lines -> GetLines ()
* Let ReSharper know we intend to localize things
* TextFormatter code cleanup
* copied in v2_develop changes
* Merged v2_develop
* Spaces aren't wanted here either.
* Fix merge errors.
* Fixes ContentBottomRightCorner related with https://github.com/gui-cs/Terminal.Gui/issues/3211#issue-2098878820
* Remove constructors with parameters from ContextMenu.
* Remove commented code.
* Remove constructors with parameters from OpenDialog.
* Remove constructors with parameters from SaveDialog.
* Remove constructors with parameters from TextField.
* Remove constructors with parameters from TimeField.
* Fix unit test.
* Remove unnecessary SetInitialProperties method.
* Remove unnecessary SetInitialProperties method.
* Remove parenthesis on objects initializers from Toplevel and Window.
* Remove constructors with parameters from RadioGroup.
* Remove constructors with parameters from TextView.
* Remove constructors with parameters from MenuBar.
* TEMPORARY: Turn everything that was set to error down to warning or lower
* Fixes#3219. MenuBar is opened by call OpenMenu even it's disabled.
* Remove constructors with parameters from Menu.
* Remove constructors with parameters from View.
* Change constructor to internal because is mainly useful for testing.
* ReSharper Cleanup Code.
* Added format only r# config
* Fixes#3224. TextFormatter.Lines should return a single string.Empty list even with Width or Height equal to zero.
* Remove constructors with parameters from Dialog.
* Remove constructors with parameters from TextValidateField.
* Fixes https://github.com/gui-cs/Terminal.Gui/issues/3224#issuecomment-1924096038
* Fixes#3225. Press CursorDown on TabView doesn't move to the next view.
* Fixes#3229. TextFormatter should have a FillRemaining property.
* Testing formatting merge in bdisp
* Testing formatting merge
* Testing formatting merge bdisp
* Testing formatting merge 2
* xmldoc format
* R# Full Code Cleanup
* R# Full Code Cleanup2
* R# Full Code Cleanup2
* Merged! But broke tests
* Refixing...
* Refixed DrawTests
* Refixed ViewTests
* Refixed Text Tests
* Refixed more unit tests
* Refixed scenarios
* Refixed rest of scenarios
* Refixed ViewsTests
* Refixed rest of tests. All unit tests pass again!
* Fixed warnings
* Updated R# version. Added new code cleanup settings
* Applied latest code cleanup to solution
* Another code cleanup pass
* Tweaked r# settings. .editorconfig now matches.
* r# else on separate line
* r# - update
* r# - full solution
* test commit
* test commit
* test commit
* Removed extra profiles
* Full cleanup following cleaning up profiles
* Null checking pattern rules/inspections
* Tabs and extra whitespace are evil
* Attributes on their own lines
* Code layout rules to put fields first and to put backing fields with their properties
* Merged v2_develop
* Full cleanup following dodexahedron's PR
---------
Co-authored-by: BDisp <bd.bdisp@gmail.com>
Co-authored-by: Brandon Thetford <github@snapsinazfs.com>
* Removed resharper settings from editorconfig
* Moved ColorScheme to ColorScheme.cs
* Moved ColorScheme to ColorScheme.cs
* Potential fix. PlatformColor was not being set by FakeDriver correctly.
* Made ColorScheme effectively readonly
* Removed Color.Base etc... Updated API docs.
* Adds basic MainLoop unit tests
* Remove WinChange action from Curses
* Remove WinChange action from Curses
* Remove ProcessInput action from Windows MainLoop
* Simplified MainLoop/ConsoleDriver by making MainLoop internal and moving impt fns to Application
* Modernized Terminal resize events
* Modernized Terminal resize events
* Removed un used property
* for _isWindowsTerminal devenv->wininit; not sure what changed
* Modernized mouse/keyboard events (Action->EventHandler)
* Updated OnMouseEvent API docs
* Using WT_SESSION to detect WT
* removes hacky GetParentProcess
* Updates to fix#2634 (clear last line)
* removes hacky GetParentProcess2
* Addressed mac resize issue
* Addressed mac resize issue
* Removes ConsoleDriver.PrepareToRun, has Init return MainLoop
* Removes unneeded Attribute methods
* Removed GetProcesssName
* Removed GetProcesssName
* Refactored KeyEvent and KeyEventEventArgs into a single class
* Revert "Refactored KeyEvent and KeyEventEventArgs into a single class"
This reverts commit 88a00658db.
* Fixed key repeat issue; reverted stupidity on 1049/1047 confusion
* Updated CSI API Docs
* merge
* Remove NStack and replace ustring to string.
* Add unit test and improving some code.
* Adjust code and fix all unit tests errors.
* Add XML Document and move the Rune folder into the Text folder.
* Improve unit tests with byte array on DecodeRune and DecodeLastRune.
* Fix unit test.
* 😂Code review
* Reduce unit tests code.
* Change StringExtensions.Make to StringExtensions.ToString and added some more unit tests.
* Fix merge errors.
* Remove GetTextWidth and calls replaced with StringExtensions.GetColumns.
* Hack to use UseSystemConsole passed in the command line arguments.
* Revert "Hack to use UseSystemConsole passed in the command line arguments."
This reverts commit b74d11c786.
* Remove Application.UseSystemConsole from the config file.
* Fix errors related by removing UseSystemConsole from the config file.
* Fixes#2633. DecodeEscSeq throw an exception if cki is null.
* Fix an exception if SelectedItem is -1.
* Set SelectedItem to 0 and remove unnecessary ToString.
* Using a unique ToString method for Rune and other for byte.
* Fix a bug where a wider rune is added with only a width of 1.
* Force the SelectedGlyph is the one that was typed after jumpList is executed.
* Added more InlineData to RuneTests.
* Reducing significantly the code by using Theory attribute in the TextFormatterTests.
* Override PositionCursor to handle the CharMap cursor position.
* Fix merge errors.
* Minor tweaks to API docs
---------
Co-authored-by: Tig Kindel <tig@users.noreply.github.com>
* Fixes#2482. Refactor Redraw - Non-virtual with the right set of virtual OnXXX methods.
* Change documentation comments.
* Fixes#2575 - TableView to use interface instead of System.Data.DataTable (#2576)
* WIP: Add ITableDataSource
* WIP: Refactor TableView
* WIP: Port CSVEditor
* WIP: Port TableEditor
* WIP: Port MultiColouredTable scenario
* Fix bug of adding duplicate column styles
* Update tests to use DataTableSource
* Tidy up
* Add EnumerableTableDataSource<T>
* Add test for EnumerableTableDataSource
* Add test for EnumerableTableDataSource
* Add code example to xmldoc
* Add ProcessTable scenario
* Rename ITableDataSource to ITableSource and update docs
* Rename EnumerableTableDataSource to EnumerableTableSource
* Fixed Frame != Bounds; changed UICat Scenarios list to use tableview!
* Fix scroll resetting in ProcessTable scenario
* Fix unit tests by setting Frame to same as Bounds
* Document why we have to measure our data for use with TableView
---------
Co-authored-by: Tig Kindel <tig@users.noreply.github.com>
* Fixes#2582 - Refactors FileDialog for cleaner data model (#2583)
* WIP: Add ITableDataSource
* WIP: Refactor TableView
* WIP: Port CSVEditor
* WIP: Port TableEditor
* WIP: Port MultiColouredTable scenario
* Fix bug of adding duplicate column styles
* Update tests to use DataTableSource
* Tidy up
* Add EnumerableTableDataSource<T>
* Add test for EnumerableTableDataSource
* Add test for EnumerableTableDataSource
* Add code example to xmldoc
* Add ProcessTable scenario
* Rename ITableDataSource to ITableSource and update docs
* Rename EnumerableTableDataSource to EnumerableTableSource
* Fixed Frame != Bounds; changed UICat Scenarios list to use tableview!
* Fix scroll resetting in ProcessTable scenario
* Fix unit tests by setting Frame to same as Bounds
* Document why we have to measure our data for use with TableView
* WIP: Simplify FileDialogs use of TableView
* WIP start migrating sorter
* WIP new filedialog table source mostly working
* WIP remove sorter class
* Refactor GetOrderByValue to be adjacent to GetColumnValue
* Fix collection navigator back so it ignores icon
* Fix unit tests
* Tidy up
* Fix UseColors
* Add test for UseColors
---------
Co-authored-by: Tig Kindel <tig@users.noreply.github.com>
* Fixes#2196. TextView: Setting Text places cursor at beginning, unlike TextField (#2572)
* Fixes#2196. TextView: Setting Text places cursor at beginning, unlike TextField
* Change all private members to have the _prefix.
* Renamed local member to prevLayoutStyle.
* Helper function for SetNeedsDisplay.
* Fixes#2569. Borders scenarios needed to be refactored. (#2570)
* Fixes#2569. Borders scenarios needed to be refactored.
* Fix border title with width equal to 4 and thickness top grater than 1.
* Improves border manipulation on borders scenarios.
* Prevents null value on the margin, border and padding thickness on the border scenarios.
* Remove NStack using dependence and fix prior commit.
* Refactoring the Frames scenario.
* Deleted borders scenarios.
* I did not realize that it was changed to SetSubViewNeedsDisplay.
* Re-layout; fixed colorpicker; fixed radio group
* Remove Thickness.IsEmpty as requested.
* Change the Frames scenario as requested.
---------
Co-authored-by: Tig Kindel <tig@users.noreply.github.com>
* Builds CollectionNavigator support into UI Catalog for TableView (#2584)
* Builds collectionnav support into UI cat for TableView
* Fixes keyboard mapping
* MultiSelect = false for TableView
* MultiSelect = false doesn't unbind ctrl-a
* Fixes#2581 Refactor CollectionNavigator so it supports TableView (#2586)
* Refactor CollectionNavigator to a base and a collection implementation
* Refactor CollectionNavigatorBase to look for first match smartly
* Add TableCollectionNavigator
* Make TableCollectionNavigator a core part of TableView
* Fix bad merge
* Added tests for tableview collection navigator
* Add FileDialogCollectionNavigator which ignores . and directory separator prefixes on file names
* whitespace fixes
---------
Co-authored-by: Tig <tig@users.noreply.github.com>
* Resolving merge conflicts.
* Fix merge errors.
* Fix merge errors.
* Add Command.Accept and snap to the selected glyph when ShowHorizontalScrollIndicator change to true.
* Reformat.
* Reformat again.
---------
Co-authored-by: Thomas Nind <31306100+tznind@users.noreply.github.com>
Co-authored-by: Tig Kindel <tig@users.noreply.github.com>
