Tig
7fd4223fd0
Merge pull request #3269 from dodexahedron/v2_3256_remove_size
...
Stage 5 of #3256 - Remove Size
2024-02-26 08:22:24 -07:00
Tig
4b6dfc0124
Merge pull request #3270 from dodexahedron/v2_3256_final_cleanup
...
Final stage of #3256 - Cleanup, annotation, and performance
2024-02-26 08:22:09 -07:00
Tig
aa9e4cf06d
Merge pull request #3268 from dodexahedron/v2_3256_remove_point
...
Stage 4 of #3256 - Remove Point
2024-02-26 08:21:55 -07:00
Tig
a598794578
Merge branch 'v2_develop' into v2_3256_final_cleanup
2024-02-26 08:10:43 -07:00
Tig
3ac11987da
Merge branch 'v2_develop' into v2_3256_remove_size
2024-02-26 08:08:22 -07:00
Tig
83fa2d2bc1
Merge branch 'v2_develop' into v2_3256_remove_point
2024-02-26 08:08:06 -07:00
Tig
0e34edf977
Merge pull request #3267 from dodexahedron/v2_3256_cleanup_2
...
Stage 3 of #3256 - Miscellaneous cleanup before more removals
2024-02-26 08:07:45 -07:00
Brandon Thetford
b47a8c8634
More commentary
2024-02-25 21:32:03 -07:00
Brandon Thetford
736eea1469
Fix this test for release builds
2024-02-25 20:52:15 -07:00
Brandon Thetford
13b6d754ff
A couple more Rectangles simplified
2024-02-25 20:49:56 -07:00
Brandon Thetford
1ebc99b226
Fix this test for Release builds
2024-02-25 20:49:14 -07:00
Brandon Thetford
fb364e90bb
Let ReSharper know we're a library so it analyzes async better.
2024-02-25 20:39:20 -07:00
Brandon Thetford
799d82986d
Add some commentary
2024-02-25 20:39:20 -07:00
Brandon Thetford
7b799a1a3c
A collection expression and null coalescing assignment
2024-02-25 20:33:35 -07:00
Brandon Thetford
85698529dc
string.Empty
2024-02-25 20:32:49 -07:00
Brandon Thetford
489da798bb
Can make that static to avoid a callvirt
2024-02-25 20:32:34 -07:00
Brandon Thetford
99e0a5a83a
Condense another switch and annotate nullability
2024-02-25 20:25:14 -07:00
Brandon Thetford
4b462809e5
Condense down to a check for Z and then a single switch return. (performance)
2024-02-25 20:23:17 -07:00
Brandon Thetford
4e1ba721be
Only call this once
2024-02-25 20:09:53 -07:00
Brandon Thetford
e3cc13a833
Remove dead code
2024-02-25 20:08:04 -07:00
Brandon Thetford
5ca5b541d7
Only call that method once
2024-02-25 20:07:55 -07:00
Brandon Thetford
be02dcefc9
string interpolation
2024-02-25 20:07:38 -07:00
Brandon Thetford
af0912e05b
Use collection expressions (performance)
2024-02-25 20:07:26 -07:00
Brandon Thetford
9fdbea768d
Pull these out into statics so we only pay the price once
2024-02-25 20:06:39 -07:00
Brandon Thetford
cbaca4cc71
More .Empty opportunities and commentary
2024-02-25 20:06:00 -07:00
Brandon Thetford
6e8e3aeea5
Condense this down to a switch expression
2024-02-25 20:05:22 -07:00
Brandon Thetford
bfedfee9ee
Simplify construction of new Rectangle, Size, Point, and *F instances
...
Use *.Empty when possible.
Use `with` in a few cases.
Also add some TODO commentary
2024-02-25 20:05:00 -07:00
Brandon Thetford
bbd5177de8
Add aliases for Size and SizeF for UICatalog
...
Still needed in this csproj because of ambiguous naming from ImageSharp
2024-02-25 16:48:28 -07:00
Brandon Thetford
942e586f3c
Switch to namespace import, now that the types are no longer ambiguous
2024-02-25 16:47:28 -07:00
Brandon Thetford
9303af9c44
Remove Size and SizeF
2024-02-25 16:47:03 -07:00
Brandon Thetford
c66951baa0
Remove RectangleF, Point, and PointF
2024-02-25 16:39:15 -07:00
Brandon Thetford
fde275c016
Add type aliases for RectangleF, Point, and PointF
2024-02-25 16:38:59 -07:00
Brandon Thetford
e3f5b8f83c
Move this to its own file (it's still a nested class though)
2024-02-23 16:17:04 -07:00
Brandon Thetford
be8a758046
Seal this
2024-02-23 16:17:04 -07:00
Brandon Thetford
d69534823f
Move this to its own file and inherit from EventArgs
2024-02-23 16:17:04 -07:00
Brandon Thetford
64488be380
Expand nullability context and mark a couple things nullable
2024-02-23 16:17:04 -07:00
Brandon Thetford
069ff05da2
Invert another statement to reduce nesting even more
2024-02-23 16:17:04 -07:00
Brandon Thetford
ecb6ff9952
Invert this for readability and less nesting
2024-02-23 16:17:04 -07:00
Brandon Thetford
27fe9eeb7d
Use proper null check pattern
2024-02-23 16:17:04 -07:00
Brandon Thetford
cb067ece0a
Fix comment
2024-02-23 16:17:04 -07:00
Brandon Thetford
8e0a193cab
In-line this, which is only used once
...
The zero checks are redundant. If the point is not inside the rectangle, it isn't inside the rectangle, period.
2024-02-23 16:17:04 -07:00
Brandon Thetford
e9deb280c4
Mark these nullable
2024-02-23 16:17:04 -07:00
Brandon Thetford
0c76b97ef2
Enable null analysis here
2024-02-23 16:17:04 -07:00
Brandon Thetford
6559512a41
Make this static to force us to avoid capturing things from the outer scope.
2024-02-23 16:17:04 -07:00
Brandon Thetford
282c434fda
Invert the if for even less nesting
2024-02-23 16:17:04 -07:00
Brandon Thetford
3f3264229f
Make the logic positive
...
This is a fun trick. Saying `is true` covers the null check because the left operand must be something that evaluates to a boolean with a value of `true`.
2024-02-23 16:17:04 -07:00
Brandon Thetford
693d8d1f03
Nullable
2024-02-23 16:17:04 -07:00
Brandon Thetford
4843488bc0
Move local function to end of method
2024-02-23 16:17:04 -07:00
Brandon Thetford
3b2bd3b323
Combine to pattern
2024-02-23 16:17:04 -07:00
Brandon Thetford
8e3538218c
Fix XmlDoc
...
This also fixed it complaining there was no noun after "the"
2024-02-23 16:17:04 -07:00
