* Initial plan
* Refactor tests to use modern ApplicationImpl.Coordinator architecture instead of legacy Application.RunIteration
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Changes before error encountered
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Replace Application.RunIteration implementation to use modern ApplicationImpl.Coordinator architecture
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Simplify Application.RunIteration to directly delegate to ApplicationImpl.Coordinator without legacy infrastructure
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Update multitasking.md documentation to use Application.AddTimeout/RemoveTimeout instead of deprecated Application.MainLoop methods
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Refactor contribution guidelines and documentation
- Consolidated all contribution-related instructions into `CONTRIBUTING.md` as the single source of truth.
- Updated `copilot-instructions.md` and `AGENTS.md` to reference `CONTRIBUTING.md`.
- Enhanced build, test, and CI/CD workflow documentation.
- Updated repository structure documentation in `README.md` and `CONTRIBUTING.md`.
- Reinforced coding conventions and streamlined testing requirements.
- Documented GitHub Actions workflows and provided local CI replication steps.
- Refined API documentation requirements and PR guidelines.
- Simplified `.sln` file and removed redundant content.
- Updated links to point to the latest documentation resources.
* Revamp bug report template for clarity and detail
Updated the bug report template to improve structure, readability, and comprehensiveness:
- Specified "Terminal.Gui" in the `about` section.
- Replaced bold headings with Markdown heading syntax.
- Enhanced "To Reproduce" with placeholders for code and behavior details.
- Added an "Environment" section to collect OS, terminal, PowerShell, .NET, and `Terminal.Gui` version details.
- Expanded "Screenshots" to include GIFs and terminal output instructions.
- Removed outdated "Desktop" and "Smartphone" sections, consolidating relevant details.
- Improved "Additional Context" with prompts for consistency, prior behavior, and error messages.
- Streamlined "For Maintainers" instructions for setting project and milestone.
These changes aim to make bug reports more actionable and easier to reproduce.
* Remove [Obsolete] attribute and pragma warnings from Application.RunIteration - method now uses modern architecture internally
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Refactor Application.Run.cs for clarity and cleanup
Removed debug assertions and unused/commented-out code to simplify logic and improve maintainability. Renamed `forceDraw` to `forceRedraw` in `LayoutAndDraw` for better clarity. Removed the internal `OnNotifyStopRunState` method and its associated logic, indicating a refactor of the stop notification mechanism.
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Tig <tig@users.noreply.github.com>
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Initial plan
* Remove legacy drivers and reorganize v2 architecture
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Extract Windows key helper utilities and fix build
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Fix all test references to legacy drivers
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Update documentation to reflect new driver architecture
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Remove V2.cd diagram file
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Fix test failures: support legacy drivers and update exception handling
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* updated driver names
* Move V2 tests from ConsoleDrivers/V2 to proper locations
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Rename ApplicationV2 to ModernApplicationImpl to remove v2 terminology
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Remove V2 terminology from test drivers and FakeDriver classes
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Merge ModernApplicationImpl into ApplicationImpl and move to App folder
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Create modern FakeDriver with component factory architecture in Terminal.Gui project
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Refactor: Move non-platform-dependent code from /Drivers to /App
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Code cleanup and org
* Unit test reorg
* Refactor MainLoop architecture: rename classes and enhance documentation for clarity
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Add comprehensive FakeDriver tests (WIP - some tests need fixes)
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Fixed FakeDriver build failures
* Fix all FakeDriver test failures - Application.Top creation and clipboard behaviors
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Fixed FakeDriver build failures2
* Remove hanging legacy FakeDriver tests that use Console.MockKeyPresses
Co-authored-by: tig <585482+tig@users.noreply.github.com>
* Fixed some tests
* Fixed more tests
* Fixed more tests
* Fix bad copilot (#4277)
* Update Terminal.Gui/Drivers/FakeDriver/FakeConsoleOutput.cs
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Refactor Application Init and Update Tests
Refactored `Application.Init` to improve initialization logic:
- Added fallback to `ForceDriver` when `driverName` is null.
- Changed repeated `Init` calls to throw `InvalidOperationException`.
- Updated `_driverName` assignment logic for robustness.
Enhanced `IConsoleDriver` with detailed remarks on implementations.
Revised test cases to align with updated `Application.Init` behavior:
- Replaced `FakeDriver` with `null` and `driverName: "fake"`.
- Skipped or commented out tests incompatible with new logic.
- Improved formatting and removed redundant setup code.
Improved code style and consistency across the codebase:
- Standardized parameter formatting and spacing.
- Removed outdated comments and unused code.
General cleanup to enhance readability and maintainability.
* Warp fix copilot (#4278)
* More fixes (#4279)
* Fixes/works around test failures and temporarily disable failing test
Updated `FakeDriver` to set `RunningUnitTests` to `true` and initialize dimensions using `FakeConsole`. Modified `TestRespondersDisposedAttribute` to set `ConsoleDriver.RunningUnitTests` in the `Before` method, ensuring proper behavior during unit tests.
Temporarily disabled the `Button_CanFocus_False_Raises_Accepted_Correctly` test in `ViewCommandTests` by adding a `Skip` parameter to the `[Fact]` attribute, referencing issue #4270.
* Allow all tests to run despite failures in UnitTests
Modified the `dotnet test` command in the `Run UnitTestsParallelizable` step to set `xunit.stopOnFail` to `false`. This ensures that the test runner does not stop execution on the first failure, allowing all tests to execute regardless of individual test outcomes.
* Refactor ApplicationScreenTests for cleaner setup/teardown
Refactored `ClearContents_Called_When_Top_Frame_Changes` test:
- Added `[AutoInitShutdown]` attribute for automatic lifecycle management.
- Replaced manual `Application.Init` and `Application.Top` setup with `Application.Begin` and `RunState`.
- Simplified event handling by defining `ClearedContents` handler inline.
- Removed explicit cleanup logic, relying on `Application.End` for teardown.
Updated `using` directives to include `UnitTests` namespace.
* Attempt to fix intermittent local test failures.
Update ApplicationImpl initialization parameter
Changed the second parameter of the `impl.Init` method in the
`FakeApplicationFactory` class from `"dotnet"` to `"fake"`.
* Code cleanup to cause Action to re-run.
* Stop tests on first failure in UnitTestsParallelizable
Updated the `dotnet test` command in `unit-tests.yml` to set the `xunit.stopOnFail` parameter to `true`. This change ensures that test execution halts immediately upon encountering a failure, allowing quicker identification and resolution of issues. Note that this may prevent the full test suite from running in the event of a failure.
* Allow all tests to run despite failures in CI
Updated `unit-tests.yml` to set `xunit.stopOnFail` to `false`
in both `Run UnitTests` and `Run UnitTestsParallelizable`
steps. This ensures that the test runner does not stop
execution on the first test failure, allowing all tests
to complete even if some fail.
* Enhance RuneExtensions docs and update user dictionary
Updated the `<remarks>` section in `RuneExtensions.GetColumns` to include details about the `wcwidth` implementation and improved readability with `<para>` tags. Added `wcwidth` to the user dictionary in `Terminal.sln.DotSettings` to avoid spelling errors.
* Improve XML doc formatting in RuneExtensions.cs
Updated the remarks section of the `GetColumns` method in the
`RuneExtensions` class to enhance readability by reformatting
and properly indenting `<para>` tags. The content remains
unchanged, describing the method's implementation via `wcwidth`
and its role as a Terminal.Gui extension for `System.Text.Rune`.
* Refactor drivers and improve clipboard handling
Replaced legacy drivers (`CursesDriver`, `NetDriver`) with
`UnixDriver` and `DotNetDriver` across the codebase, including
comments, method names, and test cases. Updated documentation
and remarks to reflect the new driver names and platforms.
Revamped clipboard handling with new platform-specific
implementations: `UnixClipboard` for Unix, `MacOSXClipboard`
for macOS, and `WSLClipboard` for Linux under WSL. Removed
the old `CursesClipboard` and consolidated clipboard logic.
Updated test cases to align with the new drivers and clipboard
implementations. Improved naming consistency and cleaned up
redundant code. Updated the README and documentation to
reflect these changes.
* Remove `PlatformColor` from `Attribute` struct
This commit removes the `PlatformColor` property from the `Attribute` struct, simplifying the codebase by eliminating platform-specific color handling. The following changes were made:
- Removed `PlatformColor` from the `Attribute` struct, including its initialization, usage, and related comments.
- Updated constructors to no longer initialize or use `PlatformColor`.
- Modified `Equals` and `GetHashCode` methods to exclude `PlatformColor`.
- Updated `UnixComponentFactory` documentation to remove references to "v2unix."
- Renamed `v2TestDriver` to `testDriver` in the `With` class for clarity.
- Removed `PlatformColor` references in `DriverAssert` and related error messages.
- Deleted test cases in `AttributeTests` that relied on `PlatformColor`.
- Cleaned up comments and TODOs related to `PlatformColor` and `UnixDriver`.
These changes reflect a shift away from platform-dependent color management, improving code clarity and reducing complexity.
Remove `PlatformColor` and simplify `Attribute` logic
The `PlatformColor` property has been removed from the `Attribute` struct, along with its associated logic, simplifying the codebase and eliminating platform-specific dependencies. Constructors, equality checks, and hash code generation in `Attribute` have been updated accordingly.
The `CurrentAttribute` property in `ConsoleDriver` and `OutputBuffer` has been simplified, removing dependencies on `Application.Driver`. The `MakeColor` method logic has been removed or simplified in related classes.
Tests in `AttributeTests` have been refactored to reflect these changes, focusing on `Foreground`, `Background`, and `Style`. Unix-specific logic tied to `PlatformColor` has been eliminated.
Additional updates include renaming parameters in the `With` class for clarity, simplifying `DriverAssert` output, and performing minor code cleanups to improve readability and maintainability.
* Refactor Terminal.Gui driver architecture for v2
Updated documentation to reflect the new modular driver architecture in Terminal.Gui v2.
- Revised `namespace-drivers.md` to include new components (`IConsoleInput`, `IConsoleOutput`, `IInputProcessor`, `IOutputBuffer`, `IWindowSizeMonitor`) and terminal size monitoring.
- Replaced "Key Components" with "Architecture Overview" and added details on the **Component Factory** pattern.
- Documented the four driver implementations (`DotNetDriver`, `WindowsDriver`, `UnixDriver`, `FakeDriver`) and their platform-specific optimizations.
- Added a "Threading Model" section to explain the multi-threaded design for responsive input handling.
- Updated examples to demonstrate driver capabilities and explicit driver selection.
In `drivers.md`:
- Expanded the "Overview" to emphasize the modular, component-based architecture.
- Reorganized "Drivers" into "Available Drivers" and added details on `FakeDriver` for unit testing.
- Added sections on "Initialization Flow," "Shutdown Flow," and platform-specific driver details.
- Provided examples for accessing driver components and creating custom drivers.
In `index.md`:
- Updated "Cross Platform" feature to reflect new driver names and clarified compatibility with SSH and monochrome terminals.
* Moved files around
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: tig <585482+tig@users.noreply.github.com>
Co-authored-by: Tig <tig@users.noreply.github.com>
Co-authored-by: Thomas Nind <31306100+tznind@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* touching publish.yml
* ColorScheme->Scheme
* ColorScheme->Scheme 2
* Prototype of GetAttributeForRole
* Badly broke CM
* Further Badly broke CM
* Refactored CM big-time. View still broken
* All unit test pass again. Tons added. CM is still WIP, but Schemes is not mostly refactored and working.
* Actually:
All unit test pass again.
Tons added.
CM is still WIP, but Schemes is not mostly refactored and working.
* Bug fixes.
DeepMemberWiseClone cleanup
* Further cleanup of Scope<T>, ConfigProperty, etc.
* Made ConfigManager thread safe.
* WIP: Broken
* WIP: new deep clone impl
* WIP: new deep clone impl is done. Now fixing CM
* WIP:
- config.md
- Working on AOT clean up
- Core CM is broken; but known.
* WIP
* Merged.
Removed CM from Application.Init
* WIP
* More WIP; Less broke
* All CM unit tests pass... Not sure if it actually works though
* All unit tests pass... Themes are broken though in UI Cat
* CM Ready for review?
* Fixed failures due to TextStyles PR
* Working on Scheme/Attribute
* Working on Scheme/Attribute 2
* Working on Scheme/Attribute 3
* Working on Scheme/Attribute 4
* Working on Scheme/Attribute 5
* Working on Scheme/Attribute 6
* Added test to show how awful memory usage is
* Improved schema. Updated config.json
* Nade Scope<T> concurrentdictionary and added test to prove
* Made Themes ConcrurrentDictionary. Added bunches of tests
* Code cleanup
* Code cleanup 2
* Code cleanup 3
* Tweaking Scheme
* ClearJsonErrors
* ClearJsonErrors2
* Updated Attribute API
* It all (mostly) works!
* Skip odd unit test
* Messed with Themes
* Theme tweaks
* Code reorg. New .md stuff
* Fixed Enabled. Added mock driver
* Fixed a bunch of View.Enabled related issues
* Scheme -> Get/SetScheme()
* Cleanup
* Cleanup2
* Broke something
* Fixed everything
* Made CM.Enable better
* Text Style Scenario
* Added comments
* Fixed UI Catalog Theme Changing
* Fixed more dynamic CM update stuff
* Warning cleanup
* New Default Theme
* fixed unit test
* Refactoring Scheme and Attribute to fix inheritance
* more unit tests
* ConfigProperty is not updating schemes correctly
* All unit tests pass.
Code cleanup
* All unit tests pass.
Code cleanup2
* Fixed unit tests
* Upgraded TextField and TextView
* Fixed TextView !Enabled bug
* More updates to TextView. More unit tests for SchemeManager
* Upgraded CharMap
* API docs
* Fixe HexView API
* upgrade HexView
* Fixed shortcut KeyView
* Fixed more bugs. Added new themes
* updated themes
* upgraded Border
* Fixed themes memory usage...mostly
* Fixed themes memory usage...mostly2
* Fixed themes memory usage...2
* Fixed themes memory usage...3
* Added new colors
* Fixed GetHardCodedConfig bug
* Added Themes Scenario - WIP
* Added Themes Scenario
* Tweaked Themes Scenario
* Code cleanup
* Fixed json schmea
* updated deepdives
* updated deepdives
* Tweaked Themes Scenario
* Made Schemes a concurrent dict
* Test cleanup
* Thread safe ConfigProperty tests
* trying to make things more thread safe
* more trying to make things more thread safe
* Fixing bugs in shadowview
* Fixing bugs in shadowview 2
* Refactored GetViewsUnderMouse to GetViewsUnderLocation etc...
* Fixed dupe unit tests?
* Added better description of layout and coordiantes to deep dive
* Added better description of layout and coordiantes to deep dive
* Modified tests that call v2.AddTimeout; they were returning true which means restart the timer!
This was causing mac/linux unit test failures.
I think
* Fixed auto scheme.
Broke TextView/TextField selection
* Realized Attribute.IsExplicitlySet is stupid; just use nullable
* Fixed Attribute. Simplified. MOre theme testing
* Updated themes again
* GetViewsUnderMouse to GetViewsUnderLocation broke TransparentMouse.
* Fixing mouseunder bugs
* rewriting...
* All working again.
Shadows are now slick as snot.
GetViewsUnderLocation is rewritten to actually work and be readable.
Tons more low-level unit tests.
Margin is now actually ViewportSettings.Transparent.
* Code cleanup
* Code cleanup
* Code cleanup of color apis
* Fixed Hover/Highlight
* Update Examples/UICatalog/Scenarios/AllViewsTester.cs
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update Examples/UICatalog/Scenarios/CharacterMap/CharacterMap.cs
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update Examples/UICatalog/Scenarios/Clipping.cs
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Fixed race condition?
* reverted
* Simplified Attribute API by removing events from SetAttributeForRole
* Removed recursion from GetViewsAtLocation
* Removed unneeded code
* Code clean up.
Fixed Scheme bug.
* reverted temporary disable
* Adjusted scheme algo
* Upgraded TextValidateField
* Fixed TextValidate bugs
* Tweaks
* Frameview rounded border by default
* API doc cleanup
* Readme fix
* Addressed tznind feeback
* Fixed more unit test issues by protecting Application statics from being set if Application.Initialized is not true
* Fixed more unit test issues by protecting Application statics from being set if Application.Initialized is not true 2
* cleanup
---------
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Comment/warning clean up
* Moved Text and Drawing out
* Moved Layout out
* Removed extra lines
* Removed Mouse out
* Reorgainzed View
* API docs
* removed border.cs
* TopLevel.Resized -> TerminalResized
* Mdi -> Overlapped
* Removed confusing and un-needed WillPresent
* privates -> _
* Tweaked RunLoop API
* tweaked version # for v1.0.0-beta.10
* tweaked version # for v1.0.0-beta.11
* Updated readme and revision history for 1.0
* tweaked rel notes
* Regenerated docs for v1.0.0.0
* updating build docs
* updating docs
* updated readme
* updated readme
* more docs
* more docs
* Refactored for clarity
* tweaks
* updated info on versioning
* merged with main. updated relnotes
* updated api docs
* updated README to point to new docs
* merged from future v1.0.0 branch
* regen apidocs
* add code coverage badge generation to publish
* add code coverage badge generation to publish
* tweaked badge
